{"id":19155,"url":"https://patchwork.libcamera.org/api/patches/19155/?format=json","web_url":"https://patchwork.libcamera.org/patch/19155/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231019140133.32090-8-jacopo.mondi@ideasonboard.com>","date":"2023-10-19T14:01:28","name":"[libcamera-devel,v6,07/12] libcamera: transform: Add operations with Orientation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"138aa2f3373a822c0db3fb409fd820237752ff1d","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19155/mbox/","series":[{"id":4053,"url":"https://patchwork.libcamera.org/api/series/4053/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4053","date":"2023-10-19T14:01:21","name":"libcamera: Replace CameraConfiguration::transform","version":6,"mbox":"https://patchwork.libcamera.org/series/4053/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19155/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19155/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 962AEC32B8\n\tfor ;\n\tThu, 19 Oct 2023 14:01:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15A6662986;\n\tThu, 19 Oct 2023 16:01:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 955BA6298B\n\tfor ;\n\tThu, 19 Oct 2023 16:01:52 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FFB41211;\n\tThu, 19 Oct 2023 16:01:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697724117;\n\tbh=EpRqUS3MNglBuApYSlDj9tKTV7Wf+jE0I46bfdvTYrI=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Hkubu3r8D6+tEyux9t2nzP9UBfuv0/Fcni0B9o5nSHWT04ED4MCb7lIMuyYCq9NkB\n\t13UZpaYvVG851MdPzKG5Y1iuR07Df3pJlyzB/AnydOklEbHgoiyaNFcXFR/Xu5YW4h\n\tFtioFnJXRSGTXizthmyssZSjrZancshbZkNAJxo1KMmlSAJanpkZD9ocb3VeS7a4QW\n\tlZEtKVJSE+F87JSzfupx7yRct401QlCUO5TqisM9pZimnPnFp/f0mWRW57yFpWZL3e\n\tOIQEBtzSzxlXHoqNdlgpCkgxwTpbnAIw9fheYiliahQwGnSElejpKWRG+U/2ZYle1L\n\t6LDb+78D/CzCg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697724104;\n\tbh=EpRqUS3MNglBuApYSlDj9tKTV7Wf+jE0I46bfdvTYrI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SR50dmByY1KrmeO1OLONOWYMi2bgsY8e6vzfCAfCG6FLf4ZAxAUcrkJ5cKFro5n8V\n\t9X4c3qETKzjKsthHzWDQoBXoweSm3UrncJjOspD4T9pRg1hBMBOCYhOz4Ce+anOIY5\n\tvdHuQrVUi6KvdkwyeD2YGrV4wzbGOln2XHXe1dLg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"SR50dmBy\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 19 Oct 2023 16:01:28 +0200","Message-ID":"<20231019140133.32090-8-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.42.0","In-Reply-To":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>","References":"<20231019140133.32090-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v6 07/12] libcamera: transform: Add\n\toperations with Orientation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add two operations that allows to combine Transform with Orientation.\n\n- Transform operator/(const Orientation &o1, const Orientation &o2)\n allows to easily get back the Transform that needs to be applied to\n Orientation2 to get Orientation1\n\n- Orientation operator*(const Orientation &o, const Transform &t)\n allows to apply a Transform to an Orientation and obtain the\n combination of the two\n\nThese two operations allow applications to use Transforms to\nmanipulate the Orientation inside the CameraConfiguration, if they\nwish.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: David Plowman \n---\n include/libcamera/transform.h | 3 +++\n src/libcamera/transform.cpp | 33 +++++++++++++++++++++++++++++++++\n 2 files changed, 36 insertions(+)","diff":"diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h\nindex 14f1db0e8572..847a1f94713c 100644\n--- a/include/libcamera/transform.h\n+++ b/include/libcamera/transform.h\n@@ -74,6 +74,9 @@ Transform transformFromRotation(int angle, bool *success = nullptr);\n Transform transformFromOrientation(const Orientation &orientation);\n Orientation transformToOrientation(const Transform &transform);\n \n+Transform operator/(const Orientation &o1, const Orientation &o2);\n+Orientation operator*(const Orientation &o1, const Transform &t);\n+\n const char *transformToString(Transform t);\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp\nindex 38735c525aa3..85bc2d28b0cd 100644\n--- a/src/libcamera/transform.cpp\n+++ b/src/libcamera/transform.cpp\n@@ -362,6 +362,39 @@ Orientation transformToOrientation(const Transform &transform)\n \treturn Orientation::Rotate0;\n }\n \n+/**\n+ * \\brief Return the Transform that applied to \\a o2 gives \\a o1\n+ * \\param o1 The Orientation to obtain\n+ * \\param o2 The base Orientation\n+ *\n+ * This operation can be used to easily compute the Transform to apply to a\n+ * base orientation \\a o2 to get the desired orientation \\a o1.\n+ *\n+ * \\return A Transform that applied to \\a o2 gives \\a o1\n+ */\n+Transform operator/(const Orientation &o1, const Orientation &o2)\n+{\n+\tTransform t1 = transformFromOrientation(o1);\n+\tTransform t2 = transformFromOrientation(o2);\n+\n+\treturn -t2 * t1;\n+}\n+\n+/**\n+ * \\brief Apply the Transform \\a t on the orientation \\a o\n+ * \\param o The orientation\n+ * \\param t The transform to apply on \\a o\n+ * \\return The Orientation resulting from applying \\a t on \\a o\n+ */\n+Orientation operator*(const Orientation &o, const Transform &t)\n+{\n+\t/*\n+\t * Apply a Transform corresponding to the orientation first and\n+\t * then apply \\a t to it.\n+\t */\n+\treturn transformToOrientation(transformFromOrientation(o) * t);\n+}\n+\n /**\n * \\brief Return a character string describing the transform\n * \\param[in] t The transform to be described.\n","prefixes":["libcamera-devel","v6","07/12"]}