{"id":19144,"url":"https://patchwork.libcamera.org/api/patches/19144/?format=json","web_url":"https://patchwork.libcamera.org/patch/19144/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231013074841.16972-21-naush@raspberrypi.com>","date":"2023-10-13T07:48:41","name":"[libcamera-devel,v2,20/20] ipa: rpi: agc: When AGC channels are changed, start with the 1st channel","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"654f6d37863de811f31df5475aea27d8a9c23db8","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19144/mbox/","series":[{"id":4049,"url":"https://patchwork.libcamera.org/api/series/4049/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4049","date":"2023-10-13T07:48:21","name":"Raspberry Pi: Preliminary PiSP support","version":2,"mbox":"https://patchwork.libcamera.org/series/4049/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19144/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19144/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD859C32C3\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Oct 2023 07:49:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C4B1629A7;\n\tFri, 13 Oct 2023 09:49:11 +0200 (CEST)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68A5062980\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Oct 2023 09:49:01 +0200 (CEST)","by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-405361bba99so18181555e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Oct 2023 00:49:01 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm16-20020a7bca50000000b003fee6e170f9sm1791890wml.45.2023.10.13.00.49.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Oct 2023 00:49:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697183351;\n\tbh=qWYFKgKt+M35FD/oyMfU26xNozgblvrSu93pmLzVqfc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=J+OaEyyYpY75XnIFSBRSUXomQAgXZHIRDL4D+1hmXvAIto55j7qQSYZ8Y2Kpgotny\n\tX08rOUOMelHVxCOW7/2kbDguqN1aZcWNidTtPbNsEES9ytZ7OTYG0AaEf0VZGiCcHc\n\tJ9mv2Yj+wrLwP4pXMkrEHirzQbkOiTUK38LW6lpus4gHyaY5KJZYrjoP3fh2hxqIAF\n\t76ZcmOhFBBDq04uZlc1HnfSLLSfbAuekf1BcFajYmYhH2k0O+55HQgOrUj37iOH4W0\n\tn2OvRsBbn62lMMCf8gVNAQRZnRy2ZS+SDxVmFjCrPgwBvLjsBf+uxr1a3f+t3U0XIb\n\tQtE7UOYrwZALw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1697183341; x=1697788141;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=I5J8mlsHtCYzdntwDAWvg8yYk6A3l+isJ5W7v+jGlFs=;\n\tb=lafyLJGSEmAZhmW7OVVTHtnKJlzbdpbH4ouS43Wtee3dTsUC+x214Nz8rV5x0/GtKp\n\tMte1MrcsOR5C5LgbapsYe0Y+gYHZUN7wdd2e4G7iZf4qVtyqXHVsMGF5fn9kGx4fWZIu\n\td2JHyCrK0wRHSO6RAljGmQzLe3FN9IYDk+4faw5SUsLnBk5MpFQ73jwi7NYNYHbSx9ip\n\tqJtdjuEffdv4aO5EBPyl3j/6Ao+yXLHeMeR2LCr0Q3GBZYODKLNTGh0LoXvJrSRQNrGx\n\tFeUgH7uKObJaSeInJ0SsR5qPol3rsAePlqJfd+J4jvbdE+B3D9EW9noNz9tMvbmOL6tX\n\tpCtg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"lafyLJGS\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1697183341; x=1697788141;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=I5J8mlsHtCYzdntwDAWvg8yYk6A3l+isJ5W7v+jGlFs=;\n\tb=bAX7fWiQjGUy5yLm18palzoVlJeuYIGZL0o5Rst8LPQWxXOisiDAjJ0arJqkuWv9dL\n\tH9o/1/luN3En8u/NmZ1A2EV5Y5ikgwa4CVxrT2J3rc5sD2BEngpwR5W6Ic9Egvy7m5A7\n\tsvgtwiyM6uup6+itigBhW9S4Fxo6NvZJQZz1Dy/NNllOkj7nTQiPG6Fqu0b9HovVnB09\n\tIX4RpYPr9/XnN9ptE1KOYp4cJgWQxh4/8mtfKhDKzKgkkQVVluTpnPFvxM5ckv+2ztq2\n\t/JOH1L4pHJZh3W7vblflwpJF0RRHjW19AzUCC/uYlhggJqkpldxPq7qM7cnxk0UX7Lkn\n\tjbuA==","X-Gm-Message-State":"AOJu0Yz2RAdWmC209CWMbYbNR8xg8J3yXr1W280xCPB6GCxdNpJ0Rpvl\n\tZgnlMaWu1zS5iWTO27QG8ZWSO3QAACcUeRUD+SlQ3w==","X-Google-Smtp-Source":"AGHT+IGnf1n1iZGT/joIzUzLMuJ5mBYxbTT0SMShTOoCDDdtskdP7YvV7UV7fh56ysZvPakjqR4RXg==","X-Received":"by 2002:a05:600c:214f:b0:405:3251:47a1 with SMTP id\n\tv15-20020a05600c214f00b00405325147a1mr22927731wml.40.1697183340867; \n\tFri, 13 Oct 2023 00:49:00 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 13 Oct 2023 08:48:41 +0100","Message-Id":"<20231013074841.16972-21-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20231013074841.16972-1-naush@raspberrypi.com>","References":"<20231013074841.16972-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 20/20] ipa: rpi: agc: When AGC channels\n\tare changed, start with the 1st channel","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Whenever the AGC active channels are changed, start with the first\nchannel listed. This allows applications to rely on a particular channel\nbeing generated first. For example, multi-exposure HDR always wants the\nshort channel first.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/ipa/rpi/controller/rpi/agc.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/ipa/rpi/controller/rpi/agc.cpp b/src/ipa/rpi/controller/rpi/agc.cpp\nindex 758da0719b9b..32eb36242268 100644\n--- a/src/ipa/rpi/controller/rpi/agc.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc.cpp\n@@ -203,6 +203,7 @@ void Agc::setActiveChannels(const std::vector<unsigned int> &activeChannels)\n \n \tLOG(RPiAgc, Debug) << \"setActiveChannels \" << activeChannels;\n \tactiveChannels_ = activeChannels;\n+\tindex_ = 0;\n }\n \n void Agc::switchMode(CameraMode const &cameraMode,\n","prefixes":["libcamera-devel","v2","20/20"]}