{"id":19132,"url":"https://patchwork.libcamera.org/api/patches/19132/?format=json","web_url":"https://patchwork.libcamera.org/patch/19132/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231013074841.16972-9-naush@raspberrypi.com>","date":"2023-10-13T07:48:29","name":"[libcamera-devel,v2,08/20] ipa: rpi: Add PiSP definitions to the Controller hardware description","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c8d83bababd090a70368fe420b13d3297c0d7e60","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19132/mbox/","series":[{"id":4049,"url":"https://patchwork.libcamera.org/api/series/4049/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4049","date":"2023-10-13T07:48:21","name":"Raspberry Pi: Preliminary PiSP support","version":2,"mbox":"https://patchwork.libcamera.org/series/4049/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19132/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19132/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE35CC32BB\n\tfor ;\n\tFri, 13 Oct 2023 07:48:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A5156299C;\n\tFri, 13 Oct 2023 09:48:59 +0200 (CEST)","from mail-ed1-x532.google.com (mail-ed1-x532.google.com\n\t[IPv6:2a00:1450:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E03B962988\n\tfor ;\n\tFri, 13 Oct 2023 09:48:52 +0200 (CEST)","by mail-ed1-x532.google.com with SMTP id\n\t4fb4d7f45d1cf-5230a22cfd1so3186277a12.1\n\tfor ;\n\tFri, 13 Oct 2023 00:48:52 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm16-20020a7bca50000000b003fee6e170f9sm1791890wml.45.2023.10.13.00.48.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 13 Oct 2023 00:48:51 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697183339;\n\tbh=grKRcMsPLPTDt0zCnVGMPYfcCnn0WLFzYyoDqxEwl0Q=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=j40VU/MqpL/vR4a/fmDWchTTvLrloA19H8zaUhzs0thK4cUA+3dMFyULQD3x74lgt\n\tiVxNptZfPyvpTbFJdye2dUBFLztAD9xR0oH/Plj0pXfL2nNfV5vBGhBXlp3llZF8RZ\n\tv8kiShAn562Oqgj4flp3r/kUzRfjnEjJ6f7s+0NDxtpmdieQaUYgvHyUOHY1Y0+yu/\n\tS58Uhc9LWARF/J/sea5ynJ61B/Mfbj4hOc01CGx15V39UsWYD972/01aIKJsHDI1EW\n\tqjiHj2bVRkOqKUCVpwUS3Nfei9CVfTHtEoP8NXAA02Y6XijlTEQVQXmLYFhqf90ilm\n\tc++IbF3WfyEfA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1697183332; x=1697788132;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=dszJkstXMUB4hIMHgiMs+n0waKBu2LYR6hRex+ii310=;\n\tb=e73sxPBgX8BRiNDvmJ9usYadvktbNvSzZtKbPnq3viRPUGz5w93gliFkQXUKtJISRe\n\teiKE322XsESeOO42405lEZ4+4enw477al9n/w/PiCkD/BGpeBGIgTcTf7e2AcOooJ77m\n\tjvL8IdQOirKaZ/ZqAsg0Bs6P9IJ2o30aPGO8XplT+QcEvnYLsan9V/O83nS7J4vqFs+J\n\teU5KmgRuyti6UINr4wiN1S/0SIUjycYzISt27iHdVYAMDGs306ofyXLFc7I4m5ng0bUe\n\tfXa2oKaCbK/LIWRb+CdnAzgM1hU4+CVxRVfgc+J0vaECTTkfd/GdscvEKv9oLsl6j0ud\n\tcHNw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"e73sxPBg\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1697183332; x=1697788132;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=dszJkstXMUB4hIMHgiMs+n0waKBu2LYR6hRex+ii310=;\n\tb=LWEyRzlhUyt+TGQZnc2N+qA5wzfpGGDXqlj7Sm2pa15yT2FGRrgEloahKOTJY+850Y\n\t6Q4ej0EYwSRfSKvkgpnpnPvJNZFJN/YJ6YLSblr1GL9uVSS2Blioh/QxI1JIrPwo/W1J\n\tHolSxL1yf4xHEaKW4hCgyvjZyoXRt8DEGOApyPzSNFsq0EilZJZ1EDuPHyCbE9ggZII8\n\tEoDG2lV0JSSzzMaPX36RINNBHlDtwZrUfkyEDV7wednBie6xliPShMCrSfcnoFRpb6Oz\n\tgAmtY6+uAlcyB8QB9XMzCXqTIf7NCPGUYCYCaUN76GdSI6R+T6mH023wQJZ/EI4U8AGd\n\t+K3w==","X-Gm-Message-State":"AOJu0Yyc+klYSaW2KSubZE/2Xd8pybyNl5GbPEapqtDwS0Tp0I0i586y\n\tIcgJ1Ow0mChaaHJoHwpfLsFJZkqtPW2woUFMpU2JTA==","X-Google-Smtp-Source":"AGHT+IHM10BjP+s0fmXFfQ511pbuhEK/O/6snajg0IuZcvVEpq+qozB4AuETjMtescT6TGMa5ibX7A==","X-Received":"by 2002:aa7:ccd3:0:b0:538:a47:89d3 with SMTP id\n\ty19-20020aa7ccd3000000b005380a4789d3mr21114841edt.21.1697183332205; \n\tFri, 13 Oct 2023 00:48:52 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 13 Oct 2023 08:48:29 +0100","Message-Id":"<20231013074841.16972-9-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20231013074841.16972-1-naush@raspberrypi.com>","References":"<20231013074841.16972-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 08/20] ipa: rpi: Add PiSP definitions\n\tto the Controller hardware description","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add an entry to Controller::HardwareConfig describing the PiSP hardware\nfor the IPA and controller algorithms to use.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \nReviewed-by: Jacopo Mondi \n---\n src/ipa/rpi/controller/controller.cpp | 15 +++++++++++++++\n src/ipa/rpi/controller/controller.h | 1 +\n 2 files changed, 16 insertions(+)","diff":"diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\nindex 4b6f82b41916..e62becd87e85 100644\n--- a/src/ipa/rpi/controller/controller.cpp\n+++ b/src/ipa/rpi/controller/controller.cpp\n@@ -31,6 +31,7 @@ static const std::map HardwareConfigMap\n \t\t\t.agcRegions = { 15 , 1 },\n \t\t\t.agcZoneWeights = { 15 , 1 },\n \t\t\t.awbRegions = { 16, 12 },\n+\t\t\t.cacRegions = { 0, 0 },\n \t\t\t.focusRegions = { 4, 3 },\n \t\t\t.numHistogramBins = 128,\n \t\t\t.numGammaPoints = 33,\n@@ -38,6 +39,20 @@ static const std::map HardwareConfigMap\n \t\t\t.statsInline = false,\n \t\t}\n \t},\n+\t{\n+\t\t\"pisp\",\n+\t\t{\n+\t\t\t.agcRegions = { 0, 0 },\n+\t\t\t.agcZoneWeights = { 15, 15 },\n+\t\t\t.awbRegions = { 32, 32 },\n+\t\t\t.cacRegions = { 8, 8 },\n+\t\t\t.focusRegions = { 8, 8 },\n+\t\t\t.numHistogramBins = 1024,\n+\t\t\t.numGammaPoints = 64,\n+\t\t\t.pipelineWidth = 16,\n+\t\t\t.statsInline = true,\n+\t\t}\n+\t},\n };\n \n Controller::Controller()\ndiff --git a/src/ipa/rpi/controller/controller.h b/src/ipa/rpi/controller/controller.h\nindex a8bc61880ab4..6e5f595284fd 100644\n--- a/src/ipa/rpi/controller/controller.h\n+++ b/src/ipa/rpi/controller/controller.h\n@@ -41,6 +41,7 @@ public:\n \t\tlibcamera::Size agcRegions;\n \t\tlibcamera::Size agcZoneWeights;\n \t\tlibcamera::Size awbRegions;\n+\t\tlibcamera::Size cacRegions;\n \t\tlibcamera::Size focusRegions;\n \t\tunsigned int numHistogramBins;\n \t\tunsigned int numGammaPoints;\n","prefixes":["libcamera-devel","v2","08/20"]}