[{"id":27962,"web_url":"https://patchwork.libcamera.org/comment/27962/","msgid":"","date":"2023-10-12T10:57:37","subject":"Re: [libcamera-devel] [PATCH 20/20] ipa: rpi: agc: When AGC\n\tchannels are changed, start with the 1st channel","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Fri, Oct 06, 2023 at 02:20:00PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Whenever the AGC active channels are changed, start with the first\n> channel listed. This allows applications to rely on a particular channel\n> being generated first. For example, multi-exposure HDR always wants the\n> short channel first.\n\nThe user won't be able to cycle through channels directly, but the HDR\nalgorithm will, right ? So this doesn't need to be documented anywhere\nperhaps...\n\n>\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rpi/controller/rpi/agc.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/rpi/controller/rpi/agc.cpp b/src/ipa/rpi/controller/rpi/agc.cpp\n> index 758da0719b9b..32eb36242268 100644\n> --- a/src/ipa/rpi/controller/rpi/agc.cpp\n> +++ b/src/ipa/rpi/controller/rpi/agc.cpp\n> @@ -203,6 +203,7 @@ void Agc::setActiveChannels(const std::vector &activeChannels)\n>\n> \tLOG(RPiAgc, Debug) << \"setActiveChannels \" << activeChannels;\n> \tactiveChannels_ = activeChannels;\n> +\tindex_ = 0;\n> }\n>\n> void Agc::switchMode(CameraMode const &cameraMode,\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 605CABD808\n\tfor ;\n\tThu, 12 Oct 2023 10:57:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B70FA62980;\n\tThu, 12 Oct 2023 12:57:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE6AF6296D\n\tfor ;\n\tThu, 12 Oct 2023 12:57:40 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 918177FC;\n\tThu, 12 Oct 2023 12:57:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697108261;\n\tbh=ZQ0zPJyiQRg1Ry3/yt3etBKU/Ihi7hWG6d4SiNDKig0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YIiLhvmIwPY1yE76tAHvFJcdK4DZ/+nKQsFgDB8p8qQGCFnxj90brSS4UMj4Er8QT\n\t1lHwDsyx4PvODzdMoObA6p5IAtCMKMmD/OR0hAgaKcAZkv2VRd4uya6Xxq93rFAVzG\n\tFKdprKvFipbnysa97E0nKS3D5SV/+4J8aFeEzM9S2yI7McKmzJyw2DvD4dbIEX0gHT\n\t/ew8l+w/RghZ2sDGNZLZqnbhZOhXT7U2pqZmFreVNuS7oh6yD8c4iu7Orf6eYbQsUN\n\tuQpYkuD6OVCjOrPTU24G4raOMC3zAjneQogcJpZwfSzBRUez5zTPKzGdW9C813vHjR\n\t2XoC3VLP04E5Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697108257;\n\tbh=ZQ0zPJyiQRg1Ry3/yt3etBKU/Ihi7hWG6d4SiNDKig0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=D+4h3rGJlmvL3rnEwUQNfjTGkWcNsXkQkbwusXrcZFGkFrjRUZq7AesEY4oAkD5rW\n\teY3IurvLUiw9+H48mM9wVm8BpwZQxwH72HKLn8q9aY03vd/6EPyQQA7C8TiXTeKPCN\n\tUWGE7Adlfi1oIWEIKEqHaWLv6ciJKtlvsOTpHV+w="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"D+4h3rGJ\"; dkim-atps=neutral","Date":"Thu, 12 Oct 2023 12:57:37 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20231006132000.23504-1-naush@raspberrypi.com>\n\t<20231006132000.23504-21-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231006132000.23504-21-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 20/20] ipa: rpi: agc: When AGC\n\tchannels are changed, start with the 1st channel","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27967,"web_url":"https://patchwork.libcamera.org/comment/27967/","msgid":"","date":"2023-10-12T13:11:21","subject":"Re: [libcamera-devel] [PATCH 20/20] ipa: rpi: agc: When AGC\n\tchannels are changed, start with the 1st channel","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Jacopo,\n\nThank you for the review.\n\nOn Thu, 12 Oct 2023 at 11:57, Jacopo Mondi\n wrote:\n>\n> Hi Naush\n>\n> On Fri, Oct 06, 2023 at 02:20:00PM +0100, Naushir Patuck via libcamera-devel wrote:\n> > Whenever the AGC active channels are changed, start with the first\n> > channel listed. This allows applications to rely on a particular channel\n> > being generated first. For example, multi-exposure HDR always wants the\n> > short channel first.\n>\n> The user won't be able to cycle through channels directly, but the HDR\n> algorithm will, right ?\n\nCorrect!\n\n> So this doesn't need to be documented anywhere\n> perhaps...\n\nWe do have a job of updating our IPA/tuning guide and this will have\nto be noted there.\n\nRegards,\nNaush\n\n>\n> >\n> > Signed-off-by: Naushir Patuck \n> > Reviewed-by: David Plowman \n>\n> Reviewed-by: Jacopo Mondi \n>\n> Thanks\n> j\n>\n> > ---\n> > src/ipa/rpi/controller/rpi/agc.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/ipa/rpi/controller/rpi/agc.cpp b/src/ipa/rpi/controller/rpi/agc.cpp\n> > index 758da0719b9b..32eb36242268 100644\n> > --- a/src/ipa/rpi/controller/rpi/agc.cpp\n> > +++ b/src/ipa/rpi/controller/rpi/agc.cpp\n> > @@ -203,6 +203,7 @@ void Agc::setActiveChannels(const std::vector &activeChannels)\n> >\n> > LOG(RPiAgc, Debug) << \"setActiveChannels \" << activeChannels;\n> > activeChannels_ = activeChannels;\n> > + index_ = 0;\n> > }\n> >\n> > void Agc::switchMode(CameraMode const &cameraMode,\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70D1CC3272\n\tfor ;\n\tThu, 12 Oct 2023 13:11:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBF9A6297E;\n\tThu, 12 Oct 2023 15:11:49 +0200 (CEST)","from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com\n\t[IPv6:2607:f8b0:4864:20::b36])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C80E6296D\n\tfor ;\n\tThu, 12 Oct 2023 15:11:49 +0200 (CEST)","by mail-yb1-xb36.google.com with SMTP id\n\t3f1490d57ef6-d9a3d737d66so964663276.2\n\tfor ;\n\tThu, 12 Oct 2023 06:11:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697116309;\n\tbh=Pn1lv+fkfLbAJMyH2vYe4pwy7p8rXTgKAjZO9uv1F3o=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jwMdGkTB8Fk7QNOP7QZwkOcV+WBN0u70FhXjE3Ib3caTEFEaxcCt2KIqdNeXsat9g\n\tRtIc5ksIwtYrkCzXYjNmS6a3/7JfYXlhJZhhbhPPZKqExxrkL88Ha9f0Gx0h/xwnH9\n\tyHkxdq00Q0hAZUxwhAbgxQZf5ZqmksmlSbB2WkpPPZbEN/Lb1iBgsSiJcqgDoQ8sn/\n\tLaEKom45LhBJNK2jLVKvyuCOTPmfPC3A0K4EN4c0FcpXOLrSmOADjI5FaXQKw3Nmld\n\tsaZZlakYvxm+ZKtW6suwippqZecy59sb3t/9FNHsMkycaza3exMrIQGXiqhY8Zb+7e\n\tN8kjnv9BskwYA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1697116308; x=1697721108;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=jUT5uSDQHpljD9RYYnh4VEHOjx1RMGZJKz/1wwmGxCI=;\n\tb=IEJME4fY1tpw7QKxboapgGmpf6qZuUw1gLWTzImvTXUaIQ5vqSDl3fjH0x38DEQ/a4\n\t4zaitbHswZ2vX1p3kV7El9fvQ5pP3Ju3otE6dvMOjCKpK7oMHjv+amky0wU+jiQcgDDY\n\tX5wTBnmdnp9PVh4hOIzL8B2EJlDDvJ9n70IBTyzoSkaFOOy4aMsbdNUP0Ck7fQOjHHr1\n\tye1VZbBeym+beQGf0XJtjv3FM0BuLd9Mzlakj93knZkfND++EivDMK9An5qnzAMkWr5+\n\t6A6BTobw3uJqCVWSi/7+A3T3MNmf4D16wlMHnOKHEx4X+x52T/TRTU+hb6F+wYGUKp+r\n\ty83w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"IEJME4fY\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1697116308; x=1697721108;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=jUT5uSDQHpljD9RYYnh4VEHOjx1RMGZJKz/1wwmGxCI=;\n\tb=mUpDnYDH+HeysCDQT2G/G95sc+FX/Q7VsPPtdApfr8H9i9DJzPbRQybqvmwDXWs4Bu\n\tYHLeWbR5GdtrYkXNBuHBQpz2Y5ilj2SOprga5z1tEbd0iQi3E34iEnxmJasOtEfAjUxh\n\thZ8GXjlucIRCSXIwVHgwFtjenl9clchLzB0+L0AibckzqZyLFThF8uUKA0aG/k9FXzst\n\tXQEr43UV4kDNvS/atk1sSWlj+ec/0LDLsSKvGLVEEsd/zkGCe/tuNkW5GzPXnxxuT2pW\n\tnGoSbMUuhCAYUvbn5+Byhjb/VVk2FEHzayVmW+ipzlGZgY3pYaOCTyiZtRoFII5uRkLF\n\tSu3Q==","X-Gm-Message-State":"AOJu0Yx9PWh+yK+sqnG3bE2D8Wdo+gjmRzAysfUK5boeE2J0n1Chhu0w\n\tIokP50gh0LC4C8RfQNTRV9vhkiupwwK6A/klIF2GZw==","X-Google-Smtp-Source":"AGHT+IGPNqv4EwprYWHr26141HXaW9J4ssEyVSFiZCekzXks2n2RaAS/Ui6vyteGAXVjIMwjTy/ppRZ5MYri01sV+2E=","X-Received":"by 2002:a25:5f11:0:b0:d9a:c391:503 with SMTP id\n\tt17-20020a255f11000000b00d9ac3910503mr1848527ybb.3.1697116307758;\n\tThu, 12 Oct 2023 06:11:47 -0700 (PDT)","MIME-Version":"1.0","References":"<20231006132000.23504-1-naush@raspberrypi.com>\n\t<20231006132000.23504-21-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Thu, 12 Oct 2023 14:11:21 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 20/20] ipa: rpi: agc: When AGC\n\tchannels are changed, start with the 1st channel","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]