{"id":19122,"url":"https://patchwork.libcamera.org/api/patches/19122/?format=json","web_url":"https://patchwork.libcamera.org/patch/19122/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231006132000.23504-21-naush@raspberrypi.com>","date":"2023-10-06T13:20:00","name":"[libcamera-devel,20/20] ipa: rpi: agc: When AGC channels are changed, start with the 1st channel","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"654f6d37863de811f31df5475aea27d8a9c23db8","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19122/mbox/","series":[{"id":4047,"url":"https://patchwork.libcamera.org/api/series/4047/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4047","date":"2023-10-06T13:19:40","name":"Raspberry Pi: Preliminary PiSP support","version":1,"mbox":"https://patchwork.libcamera.org/series/4047/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19122/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19122/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02E54C32B9\n\tfor ;\n\tFri, 6 Oct 2023 13:20:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACF356296F;\n\tFri, 6 Oct 2023 15:20:25 +0200 (CEST)","from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com\n\t[IPv6:2a00:1450:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2484F62973\n\tfor ;\n\tFri, 6 Oct 2023 15:20:22 +0200 (CEST)","by mail-wr1-x42f.google.com with SMTP id\n\tffacd0b85a97d-31c5cac3ae2so1847429f8f.3\n\tfor ;\n\tFri, 06 Oct 2023 06:20:22 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm8-20020a056000180800b00321773bb933sm1639478wrh.77.2023.10.06.06.20.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Oct 2023 06:20:20 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696598425;\n\tbh=Uzn4lVqtWjaQ8Sb+MKfJXTauUyz0RMz4BqtMjjUX6gM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=E0iYA+UCNG2136+oodcOeSYQsF0o5PMKI3ofiaMv4uPwUtWq/IgIfnJqzXMSYsSXD\n\thYiraZbzNuJGU5kzyAe7W6SBLvrfvC9JpWtI+VagX0Cq7ahrpTg3Ka1M6tdZhle7tx\n\tuNYLHeYOAnUEithQMq8RlIzPuoGQ2QwtYcGsCkwnTsFoET/neNMB+ezXzCZ3lwRR3t\n\tqWmRmEKYLoxzINsYhQMJDzkTl3qNhz0MRQ/DA6LgptOeqJRHZD7wuRo/70urd6YwTP\n\tvLSlC0WcsDG8Wg1TBQksxpCw2nfOEVPUSOuX0CoqKkJ0ypLIhVZaycygREwBZZy/Fe\n\tFfwHWJM2hOMJw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1696598421; x=1697203221;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=yNBJCUYXo4LXGeLxzlT54YfPdDc3yVuc6878WBeD0Qg=;\n\tb=aXyMqC8J/zprDNboWHe/ciNCqDlkePwYoyVNTKnnfHZWIGYmpto5T85es4+Cl/xyns\n\tqG4Ggc3ndjwOsQezfyuLRCS5lgQ6OOtceo6ccptoZulWgNlJXduv5F+fAiPtCcHOXioV\n\tPFfksuLJ+ts0lndAL8Z3eoqWukZH6oLX1MqsAI5caziCp5Jyr97HEWv6EiOnkGpZGpZ7\n\tMpb0DIuE8vKm73VsmDvsi6K+76gRgcuiocDzk0aUBxMQf2Vk5EI+rVXVvydNcCe1F1bc\n\tpC9xST22M2EwrHbd4dKepBVqVcAMZHUN4j8qU7XFafgdc8FHKmKBoI0ZCvv+JYxg3YW9\n\t4uIw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"aXyMqC8J\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1696598421; x=1697203221;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=yNBJCUYXo4LXGeLxzlT54YfPdDc3yVuc6878WBeD0Qg=;\n\tb=k+WG7P1hGpAbq4B6pR3r9dRtg6iDyxa1Wt+zPV5fdSmYdtGZRsRMuf/+Y4zhZCDmd8\n\tJtJvL1VLAwss1bCozkQeDWRc7c2JbC/GoVHUgi8Hnmi7WyvZ36Q+7p7OFVcIRo3feaMf\n\t+3dPWOC9Ge2svBB0OnXugHiVDRadfqje+xGA7TUQmDSpdq6BrvBp2zQSObwAWhI1z2da\n\tjj/28KkyKerJM24Viy7amIVWPdiQTX0dMSwnCkT5pyfg9vz3PzbIuiRNuoWHZ7U49FIA\n\tpOBmpXgpIAVDB7PJ7pHQHzPqY90H0AdY0EFeOwU2E/G56Qkgv02dFox/fIjvNc6aH1JO\n\tSe6A==","X-Gm-Message-State":"AOJu0Yy2FhxNUG3rGffnmOKoh1lctT2Ux9RUrm5GDcFOgizd/KzrR+fR\n\tLO5WNtGasN1+l7wVVNfJ+OKePPs3ImVDh+4As7y4Sw==","X-Google-Smtp-Source":"AGHT+IFWQRFoPZfSp8ts4n3vBTyMEci6mfCzM0Xvt07F4BAVxC31jWyFItfxmXrEAtA1Hu5YJ3UWsg==","X-Received":"by 2002:adf:f4c6:0:b0:320:5ad:2b9c with SMTP id\n\th6-20020adff4c6000000b0032005ad2b9cmr7330590wrp.2.1696598421523; \n\tFri, 06 Oct 2023 06:20:21 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Oct 2023 14:20:00 +0100","Message-Id":"<20231006132000.23504-21-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20231006132000.23504-1-naush@raspberrypi.com>","References":"<20231006132000.23504-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 20/20] ipa: rpi: agc: When AGC channels\n\tare changed, start with the 1st channel","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Whenever the AGC active channels are changed, start with the first\nchannel listed. This allows applications to rely on a particular channel\nbeing generated first. For example, multi-exposure HDR always wants the\nshort channel first.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n src/ipa/rpi/controller/rpi/agc.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/ipa/rpi/controller/rpi/agc.cpp b/src/ipa/rpi/controller/rpi/agc.cpp\nindex 758da0719b9b..32eb36242268 100644\n--- a/src/ipa/rpi/controller/rpi/agc.cpp\n+++ b/src/ipa/rpi/controller/rpi/agc.cpp\n@@ -203,6 +203,7 @@ void Agc::setActiveChannels(const std::vector &activeChannels)\n \n \tLOG(RPiAgc, Debug) << \"setActiveChannels \" << activeChannels;\n \tactiveChannels_ = activeChannels;\n+\tindex_ = 0;\n }\n \n void Agc::switchMode(CameraMode const &cameraMode,\n","prefixes":["libcamera-devel","20/20"]}