[{"id":27957,"web_url":"https://patchwork.libcamera.org/comment/27957/","msgid":"","date":"2023-10-12T10:09:38","subject":"Re: [libcamera-devel] [PATCH 15/20] pipeline: rpi: Make color space\n\tmembers in RPiCameraConfiguration public","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Fri, Oct 06, 2023 at 02:19:55PM +0100, Naushir Patuck via libcamera-devel wrote:\n> This allows them to be accessed by the pipeline handlers when needed.\n>\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> index 0c4a59b7f590..267eef1102f1 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> @@ -273,9 +273,6 @@ public:\n> \tstd::vector rawStreams_;\n> \tstd::vector outStreams_;\n>\n> -private:\n> -\tconst CameraData *data_;\n> -\n> \t/*\n> \t * Store the colour spaces that all our streams will have. RGB format streams\n> \t * will have the same colorspace as YUV streams, with YCbCr field cleared and\n> @@ -283,6 +280,9 @@ private:\n> \t */\n> \tstd::optional yuvColorSpace_;\n> \tstd::optional rgbColorSpace_;\n> +\n> +private:\n> +\tconst CameraData *data_;\n> };\n>\n> } /* namespace RPi */\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D778DC3272\n\tfor ;\n\tThu, 12 Oct 2023 10:09:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B3D462980;\n\tThu, 12 Oct 2023 12:09:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7BED6296D\n\tfor ;\n\tThu, 12 Oct 2023 12:09:41 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CC2D7FC;\n\tThu, 12 Oct 2023 12:09:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697105384;\n\tbh=NKX6Qdz9Mv6Jkk+w1bqdWWk8jKXpGw6S2bggalo6Pck=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RnLGLdZ1VorkJ2B2EYCteOD74xri8dWEt7cE9epL0aKInijsrmxqTlPf2zEl7XB1b\n\tMGToO9ujvSGSx3SrFpFvFPOKSTrqi4IDtKcojwm/Pu/KmgjruV/hvBRTJFWRCFcqB7\n\tanX+puRMFR7HCiewtCv3UPkbL1Bqi2+hwTgkihoG+myeRa7zMw1Vrg3qLob1SqSAFL\n\tAur+HsLhBfdRqLPJdKJgHQdDbMLFFnDbsEzQm3PLIL1Qd+68HbIkEmowSikt9wJN8x\n\teejoz0QxovN3+HwEYQAhLkpd2L7CqbwDw4BLj1CnY1UsNj/kl03AowkUrNG7IRPA46\n\tlegUlYdLKSJtQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697105378;\n\tbh=NKX6Qdz9Mv6Jkk+w1bqdWWk8jKXpGw6S2bggalo6Pck=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ubdczb33tA5+G/FurHnw6SlEbiHo0LUXDbdawXNb7xMSB24ikqd7h+cd8VtczQWfW\n\t6SpQZ5MEqAtXnXRQyIM4B/GLQCd3pzN9DUF87FlBO/1WMpMkOp3sZ6blEkFCtzJpGC\n\tCn+kL6LZijuj/4+u0kGGUUvmoL3RPl7GrpwK2uyI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Ubdczb33\"; dkim-atps=neutral","Date":"Thu, 12 Oct 2023 12:09:38 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20231006132000.23504-1-naush@raspberrypi.com>\n\t<20231006132000.23504-16-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231006132000.23504-16-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 15/20] pipeline: rpi: Make color space\n\tmembers in RPiCameraConfiguration public","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]