[{"id":27947,"web_url":"https://patchwork.libcamera.org/comment/27947/","msgid":"","date":"2023-10-12T08:30:27","subject":"Re: [libcamera-devel] [PATCH 08/20] ipa: rpi: Add PiSP definitions\n\tto the Controller hardware description","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Fri, Oct 06, 2023 at 02:19:48PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Add an entry to Controller::HardwareConfig describing the PiSP hardware\n> for the IPA and controller algorithms to use.\n>\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rpi/controller/controller.cpp | 15 +++++++++++++++\n> src/ipa/rpi/controller/controller.h | 1 +\n> 2 files changed, 16 insertions(+)\n>\n> diff --git a/src/ipa/rpi/controller/controller.cpp b/src/ipa/rpi/controller/controller.cpp\n> index 4b6f82b41916..e62becd87e85 100644\n> --- a/src/ipa/rpi/controller/controller.cpp\n> +++ b/src/ipa/rpi/controller/controller.cpp\n> @@ -31,6 +31,7 @@ static const std::map HardwareConfigMap\n> \t\t\t.agcRegions = { 15 , 1 },\n> \t\t\t.agcZoneWeights = { 15 , 1 },\n> \t\t\t.awbRegions = { 16, 12 },\n> +\t\t\t.cacRegions = { 0, 0 },\n> \t\t\t.focusRegions = { 4, 3 },\n> \t\t\t.numHistogramBins = 128,\n> \t\t\t.numGammaPoints = 33,\n> @@ -38,6 +39,20 @@ static const std::map HardwareConfigMap\n> \t\t\t.statsInline = false,\n> \t\t}\n> \t},\n> +\t{\n> +\t\t\"pisp\",\n> +\t\t{\n> +\t\t\t.agcRegions = { 0, 0 },\n> +\t\t\t.agcZoneWeights = { 15, 15 },\n> +\t\t\t.awbRegions = { 32, 32 },\n> +\t\t\t.cacRegions = { 8, 8 },\n> +\t\t\t.focusRegions = { 8, 8 },\n> +\t\t\t.numHistogramBins = 1024,\n> +\t\t\t.numGammaPoints = 64,\n> +\t\t\t.pipelineWidth = 16,\n> +\t\t\t.statsInline = true,\n> +\t\t}\n> +\t},\n> };\n>\n> Controller::Controller()\n> diff --git a/src/ipa/rpi/controller/controller.h b/src/ipa/rpi/controller/controller.h\n> index a8bc61880ab4..6e5f595284fd 100644\n> --- a/src/ipa/rpi/controller/controller.h\n> +++ b/src/ipa/rpi/controller/controller.h\n> @@ -41,6 +41,7 @@ public:\n> \t\tlibcamera::Size agcRegions;\n> \t\tlibcamera::Size agcZoneWeights;\n> \t\tlibcamera::Size awbRegions;\n> +\t\tlibcamera::Size cacRegions;\n> \t\tlibcamera::Size focusRegions;\n> \t\tunsigned int numHistogramBins;\n> \t\tunsigned int numGammaPoints;\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A458EBD808\n\tfor ;\n\tThu, 12 Oct 2023 08:30:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3435D62980;\n\tThu, 12 Oct 2023 10:30:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85F256297B\n\tfor ;\n\tThu, 12 Oct 2023 10:30:30 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80278583;\n\tThu, 12 Oct 2023 10:30:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697099431;\n\tbh=vKdH0zDRC25Jr2QNcA/yGwVijxXwAS6aGggQIsA9haA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=atolgLd5zewnuhZiWB1eDvxnPobnrp0hyP/z0IdbWmsrGPndbpMctgeNy2irtYAGI\n\tyDRRltGyU8ZKBxbGpIbERvimkjJTidzhgUUYD31IEvOn+MN4CuA1wFJtUluJzPkdoF\n\tcuwKdXRmT75AgrgkoJydly2mARUaoifNDOXaBZV8ncYz24OAGpdh+EOB81IPxtdalz\n\tX7ARYB5r1XP63rrkMbfm3s39qVSRfxYDWMVgum+VqyGitR4PdBMNbcgZRHWdVd88kO\n\tGfKJbA7dkOZ8FWJcL/gHxPiR1y36hB2UdqGls/oHEq+bTq/mAGVU9bKTUrQhP1YnRw\n\tSImRRZkiIzqHg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697099427;\n\tbh=vKdH0zDRC25Jr2QNcA/yGwVijxXwAS6aGggQIsA9haA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RlmiJtnHglHpxoUGf6ANxe3WX8mkzj/HTOXfji8StDBjqnwLn4eFgaj5jyzmyIycr\n\tP8/otCMP6/V7s/EW69p2gYOeEZCmH0JmZL/Y/7tKtZjy77CgWR9X0KCWa1/UWGVgEj\n\tNsPWFi4rR1QRTn/VBhx4sNmu6zgAhDzh4E7qgFeY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"RlmiJtnH\"; dkim-atps=neutral","Date":"Thu, 12 Oct 2023 10:30:27 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20231006132000.23504-1-naush@raspberrypi.com>\n\t<20231006132000.23504-9-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231006132000.23504-9-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 08/20] ipa: rpi: Add PiSP definitions\n\tto the Controller hardware description","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]