[{"id":27943,"web_url":"https://patchwork.libcamera.org/comment/27943/","msgid":"","date":"2023-10-12T08:22:17","subject":"Re: [libcamera-devel] [PATCH 06/20] ipa: rpi: Add try_lock() to\n\tRPiController::Metadata","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Fri, Oct 06, 2023 at 02:19:46PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Add the missing try_lock() member function to RPiController::Metadata.\n> This will allow RPiController::Metadata to be used as a template\n> parameter in std::scoped_lock.\n>\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rpi/controller/metadata.h | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/rpi/controller/metadata.h b/src/ipa/rpi/controller/metadata.h\n> index bf8a2393457a..a232dcb12456 100644\n> --- a/src/ipa/rpi/controller/metadata.h\n> +++ b/src/ipa/rpi/controller/metadata.h\n> @@ -116,6 +116,7 @@ public:\n> \t * e.g. std::lock_guard lock(metadata)\n> \t */\n> \tvoid lock() LIBCAMERA_TSA_ACQUIRE() { mutex_.lock(); }\n> +\tauto try_lock() LIBCAMERA_TSA_ACQUIRE() { return mutex_.try_lock(); }\n> \tvoid unlock() LIBCAMERA_TSA_RELEASE() { mutex_.unlock(); }\n>\n> private:\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4C2EBD808\n\tfor ;\n\tThu, 12 Oct 2023 08:22:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E02A6297B;\n\tThu, 12 Oct 2023 10:22:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BED806297B\n\tfor ;\n\tThu, 12 Oct 2023 10:22:20 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B4719583;\n\tThu, 12 Oct 2023 10:22:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1697098942;\n\tbh=leovlXqBAuAa+y94WVR9MP1GCJbSpMrcFcdtH02lRF8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jI2VpWv8Y1pl6kwm7EAT3LnS/HYq6DllVsVbCFIpWQGWAbiyMLDoHwE7VWwetoKsG\n\tzWW4Qx/ad8onTTMOPRewLf+2fLMASel8bv2hEt7HvYriQeBb4KgTWF9GjEQbTaRKps\n\t3W8G5qblft6mwezcRHvBUo9yGKav6gc8QBLR63aVjuzdMUSXU1uz16HrE/9GMAl2y6\n\tlZyGqJThWq30MDI2UdSqXarzQYQLC7szG0xCBOIieozip6CIPGzL9e/QzDqvZ4ht8h\n\tMqb1TCzZCT9TisjOkOdlgJkJZ9fVdn4C5cYTi/IMFGVQkRPxO1MBEQU6/frDR7r4+J\n\t5FMLcsBYEFIzg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1697098937;\n\tbh=leovlXqBAuAa+y94WVR9MP1GCJbSpMrcFcdtH02lRF8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HpNrvWgvYPt58SSxJxO8x7WAOYVA0KAz1MIr/tGVUs6KcX/Nw/3/lLj1PeAm/VRpP\n\teyOuvOYXsTYy4ByKpofF0l4PRvMg/wtXbr0+au80kUWrLR/yIgFAiETGXvkSIsb9os\n\tVrbWo9ihBrXljQ5p6Cw4cH/WhwpNxyhLFQr0NLFw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HpNrvWgv\"; dkim-atps=neutral","Date":"Thu, 12 Oct 2023 10:22:17 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20231006132000.23504-1-naush@raspberrypi.com>\n\t<20231006132000.23504-7-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20231006132000.23504-7-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 06/20] ipa: rpi: Add try_lock() to\n\tRPiController::Metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]