{"id":19104,"url":"https://patchwork.libcamera.org/api/patches/19104/?format=json","web_url":"https://patchwork.libcamera.org/patch/19104/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20231006132000.23504-3-naush@raspberrypi.com>","date":"2023-10-06T13:19:42","name":"[libcamera-devel,02/20] pipeline: rpi: Add Recurrent and Needs32bitConv flags to RPi::Stream","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"96b1a1629687ab8ecc0b5f5881a75d81d2e40c42","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19104/mbox/","series":[{"id":4047,"url":"https://patchwork.libcamera.org/api/series/4047/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4047","date":"2023-10-06T13:19:40","name":"Raspberry Pi: Preliminary PiSP support","version":1,"mbox":"https://patchwork.libcamera.org/series/4047/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19104/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19104/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAEB7C32B6\n\tfor ;\n\tFri, 6 Oct 2023 13:20:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17D406296C;\n\tFri, 6 Oct 2023 15:20:01 +0200 (CEST)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B90A62961\n\tfor ;\n\tFri, 6 Oct 2023 15:19:59 +0200 (CEST)","by mail-wr1-x434.google.com with SMTP id\n\tffacd0b85a97d-3232be274a0so2013791f8f.1\n\tfor ;\n\tFri, 06 Oct 2023 06:19:59 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tm8-20020a056000180800b00321773bb933sm1639478wrh.77.2023.10.06.06.19.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 06 Oct 2023 06:19:57 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696598401;\n\tbh=suH0PJIgEqPYNksTKJuL5bMOo1kXPdifvQWKd+ecGoc=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wpcx6pdMx5nPshIIujyFT6asBu7xFyZH3oIBFJD7MTxQ+P2XyBmCuolmcSaWOOO9Y\n\trjfaaY66KI3Q0+EAqzcUNLnHh8bweRt0tBtFQomOME4yXnaOm0/EW8OWYL/CMxHQbd\n\tknA1tqFGj9pH25eJEu4v5oE/JvpWaZhRgwVikxB2UIdFmSm7Yt9j5L6YI1fbM3v8I7\n\tYum6E9SXjcmcUYc4JQKWQYywMEwX5aciHYseu4ua9zvhKOvr5P5n2WkGTccbEn1loX\n\tKRQy2l0tOoHLOexxgRaPRovoHIpCqCbjlQoOU38X1irJ5x4WDNDSdj+6N9YbbEOwGe\n\tJEcSPgdQPxIYQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1696598398; x=1697203198;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=iaJ6H3b9VuzhIwenAA8wBuE39LFc+MtAJZU0c3sCiBo=;\n\tb=q5Q7tNiucHlsce62xH2qVPHbXlVKL94Z1WgPn1u3y6p1DD3DCYQWiY7MQkTGkqT+4J\n\tICQfcEPeMBS1kuKBrQgDznHCXExb1JKb8yPzVcJu72hxtfZK4i3lcOc0/kZHHUu9lplZ\n\tKUMszuhSiKhLAw7rjgJdXEB8aZoC+aS0muvX0ezK+KzaQaSR418u9pB1dRT2ZAtc9DwY\n\tILm64aXcsdA60Bfge+qv+QZoWzjr+HM+uvrwdtiW0gcogRx77u9f1ogEY/5jMwMLc0uc\n\tS8+Lb+t2AUT4LIwhziaz4ryq32P8yi9bV3gKcc38Rf6MtiKQMVzWfoZoc9C+woQfaUQ7\n\tF5nA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"q5Q7tNiu\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1696598398; x=1697203198;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=iaJ6H3b9VuzhIwenAA8wBuE39LFc+MtAJZU0c3sCiBo=;\n\tb=d7b806zpYz5u9QeJazSEuat/XmyLSF3ptBxhiVc0/WyfRUhEqUB2sIK8D4t3WishIG\n\tnOL7GnvKZRJRWih0L8FM5EBLE/zobBLPF05w4mG6DCj6vTTnQU1Rc3SBB2LpbosIZn/D\n\tbIDfnP5l+aFoIJeBkGrnmDa0E5DN/60/3DkQC+QRY45vg3juvqrbchfmzz3kI05Pn1yA\n\tmEYlGCYLBJ0Xe+hNHu/HuQlGyqB3dC0TTC0AqCw6xP4SZgUonfbLVo0Y/2AFxYKHRWbr\n\tDBBMqJUlnfb132xHqB4NVK0LRJY9RBtdd5tcRNA2uIm7UXhZ5+1MhyJIILL6+oiPPNWb\n\tTRmw==","X-Gm-Message-State":"AOJu0Yw81epG8UDOq2aFhPxMSzwlZP/NpWan9XRk/JjjkcMBmpwSbGm3\n\tM3IocWWswQKsOrJHOaJzE0dEQidZ4psROPbgoI3gWA==","X-Google-Smtp-Source":"AGHT+IEi9hBaD5Zd1EsPHXtCYiL6nXHGvk8uF5GWJI5PmNzBxcg0MtwnDTbqa+fBNzsG3LlvUddFbg==","X-Received":"by 2002:adf:cd09:0:b0:323:1e69:7b4 with SMTP id\n\tw9-20020adfcd09000000b003231e6907b4mr3864736wrm.31.1696598398301; \n\tFri, 06 Oct 2023 06:19:58 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 6 Oct 2023 14:19:42 +0100","Message-Id":"<20231006132000.23504-3-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20231006132000.23504-1-naush@raspberrypi.com>","References":"<20231006132000.23504-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 02/20] pipeline: rpi: Add Recurrent and\n\tNeeds32bitConv flags to RPi::Stream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a new \"Recurrent\" stream flag. This flag indicates the stream buffer\nhandling/management happend from the pipeline handler exclusively. This\nis used for TDN/Stitch and Config streams.\n\nAdd a new Needs32bitConv stream flag to indicate that this stream needs\na software postprocessing conversion run on it before returning out to\nthe application.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: David Plowman \n---\n src/libcamera/pipeline/rpi/common/rpi_stream.cpp | 4 ++--\n src/libcamera/pipeline/rpi/common/rpi_stream.h | 11 +++++++++++\n 2 files changed, 13 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\nindex 83c2205f7ca0..fd6f2efc6e27 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n@@ -155,7 +155,7 @@ int Stream::queueBuffer(FrameBuffer *buffer)\n \n void Stream::returnBuffer(FrameBuffer *buffer)\n {\n-\tif (!(flags_ & StreamFlag::External)) {\n+\tif (!(flags_ & StreamFlag::External) && !(flags_ & StreamFlag::Recurrent)) {\n \t\t/* For internal buffers, simply requeue back to the device. */\n \t\tqueueToDevice(buffer);\n \t\treturn;\n@@ -217,7 +217,7 @@ int Stream::queueAllBuffers()\n {\n \tint ret;\n \n-\tif (flags_ & StreamFlag::External)\n+\tif ((flags_ & StreamFlag::External) || (flags_ & StreamFlag::Recurrent))\n \t\treturn 0;\n \n \twhile (!availableBuffers_.empty()) {\ndiff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.h b/src/libcamera/pipeline/rpi/common/rpi_stream.h\nindex 861e9c8e7dab..c5e35d134926 100644\n--- a/src/libcamera/pipeline/rpi/common/rpi_stream.h\n+++ b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n@@ -70,6 +70,17 @@ public:\n \t\t * to the pipeline handler when requested.\n \t\t */\n \t\tRequiresMmap\t= (1 << 2),\n+\t\t/*\n+\t\t * Indicates a stream that needs buffers recycled every frame internally\n+\t\t * in the pipeline handler, e.g. stitch, TDN, config. All buffer\n+\t\t * management will be handled by the pipeline handler.\n+\t\t */\n+\t\tRecurrent\t= (1 << 3),\n+\t\t/*\n+\t\t * Indicates that the output stream needs a software format conversion\n+\t\t * to be applied after ISP processing.\n+\t\t */\n+\t\tNeeds32bitConv\t= (1 << 4),\n \t};\n \n \tusing StreamFlags = Flags;\n","prefixes":["libcamera-devel","02/20"]}