[{"id":27911,"web_url":"https://patchwork.libcamera.org/comment/27911/","msgid":"<877co82gg6.fsf@baylibre.com>","date":"2023-09-30T08:50:01","subject":"Re: [libcamera-devel] [PATCH v3 2/5] libcamera: converter: drop\n\tunnecessary #include directive","submitter":{"id":153,"url":"https://patchwork.libcamera.org/api/people/153/","name":"Mattijs Korpershoek","email":"mkorpershoek@baylibre.com"},"content":"On jeu., sept. 28, 2023 at 21:55, Andrey Konovalov wrote:\n\n> libcamera/internal/media_device.h includes linux/media.h already.\n>\n> Signed-off-by: Andrey Konovalov \n> Suggested-by: Jacopo Mondi \n\nReviewed-by: Mattijs Korpershoek \n\n> ---\n> src/libcamera/converter.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\n> index 15701363..aca4fbc7 100644\n> --- a/src/libcamera/converter.cpp\n> +++ b/src/libcamera/converter.cpp\n> @@ -13,8 +13,6 @@\n> \n> #include \"libcamera/internal/media_device.h\"\n> \n> -#include \"linux/media.h\"\n> -\n> /**\n> * \\file internal/converter.h\n> * \\brief Abstract converter\n> -- \n> 2.34.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAFAABD808\n\tfor ;\n\tSat, 30 Sep 2023 08:50:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6037F6295F;\n\tSat, 30 Sep 2023 10:50:05 +0200 (CEST)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E8B26295E\n\tfor ;\n\tSat, 30 Sep 2023 10:50:04 +0200 (CEST)","by mail-wr1-x436.google.com with SMTP id\n\tffacd0b85a97d-3226cc3e324so13635644f8f.3\n\tfor ;\n\tSat, 30 Sep 2023 01:50:04 -0700 (PDT)","from localhost\n\t(2a01cb06b0237dd3c01dd287ba46c248.ipv6.abo.wanadoo.fr.\n\t[2a01:cb06:b023:7dd3:c01d:d287:ba46:c248])\n\tby smtp.gmail.com with ESMTPSA id\n\ty5-20020adfee05000000b003250aec5e97sm3797757wrn.4.2023.09.30.01.50.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 30 Sep 2023 01:50:03 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696063805;\n\tbh=y6dg4Zz4Nq5NBCam8VPWVG9Nvf0Ygad8nMMfVQUcT3g=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=mObtb8T5OP1K1sw11JUlHf7t0V3GQ4jDnPwxkHplkkCF1NkIjIHJWRObw6tCLu1Nc\n\tX/XaHie4MjHr/JifSd0b4J51QhOkzlDGH0gu8LbNIDJJ0B15+c+zP5Q16sCDHYDV40\n\tIhHtqBRTKv//Q1+oYg//sVug6pVpxLfLDWZUf4zfxhchpxVz9sqH8zgqo/KEP9jyrr\n\tdM2TOkZVvQzm9GPqP6DbA2p0YwZHOgJLTrfOPXkC1uQplKr1OOhDtNc5mj/N2K6Ldl\n\tKxjumvUCig8eeFsKlcEeqnWGCmy7vOY0d1OsNGxYHjxC97N6+b/zbhEEmnxswMKbKN\n\tz5YylTS9FjTMg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1696063804;\n\tx=1696668604; darn=lists.libcamera.org; \n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=0SnxKo3DeQMkgHrM0LO+LqWDqETOCi+fApKjXSJsBUQ=;\n\tb=bpbq7Dvo8Uf4HsGCgNoiuvaGi+vFGj/m/RXyAErquu3TLZiQsYWu2PQ137jfqAugVi\n\tuTYk/MZOZuQTzQ7f4m9H/y/3O4K2FpAeGhTB42XQBG20Bmp4bjMrZvBBRcuIq0JPihzV\n\tW5HYHoMr75qWk2wxNij22VELauhvX9ksx7sKBg+qf0kceMsgyLSTCHYWb7nrQUlmkT/N\n\tq3mZX9f+nCOFwH69Defl54gzJNW03MUT0KqqvqThvuhyeq9u9dMj8FlojIdtK0fvyVfv\n\t5zWHKKqjFPROUoCK1T8BGy1x8lPOGThcUVp5Eh689TT+uCEQ2B3STUb7/msFqpqKvAsa\n\t4QKA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20230601.gappssmtp.com\n\theader.i=@baylibre-com.20230601.gappssmtp.com header.b=\"bpbq7Dvo\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1696063804; x=1696668604;\n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; \n\tbh=0SnxKo3DeQMkgHrM0LO+LqWDqETOCi+fApKjXSJsBUQ=;\n\tb=X1BoNjLtTkS+pNPWyMVcyNgmi4zrpAitqxmumLLFawe+oQpudQH1dIYfGMS9wU2D3K\n\tgvNOn3m6gg+eglrS18y2HepkbACHhPifMgEUMTqWK8S+PDwBMsBmlrNpOPKJ5wvYeXRG\n\tSe07ZU6K8e2+dzUOYXCpeNqA1Ou4ENPmcsid30pw6BtREAcr7cme5270avY3pk4tjWV6\n\tDa8Zq9lT4NcpcOKStl2QQxdpLzDJJo0ADKaOVhnJFfxS8f1rQlBqOtV2VRWKSYx3A7vv\n\tG7+eMPd96Cl2h9oROcZp6cXbWBa7iltzpyndQWK5T67qsI/dNmkMDQO50TCDfjulGTLx\n\tSUDg==","X-Gm-Message-State":"AOJu0YyNaRULSBw1O0ig3TSGwJJXa6fHUefnQsSNx47LPvoiLu5RQ32i\n\tpTe6jTaPIXv4xU20kZ0hEvvJZ8kXg6I0jdWAk18=","X-Google-Smtp-Source":"AGHT+IE53tecU+QnSFsqrxOmjmAuv2YGREhBaUR+lmdVl1j6KWW1R80Ep6pmjpfkCsfEvvyPNpiOig==","X-Received":"by 2002:a5d:4951:0:b0:31f:fb02:4dcd with SMTP id\n\tr17-20020a5d4951000000b0031ffb024dcdmr5929251wrs.4.1696063803669; \n\tSat, 30 Sep 2023 01:50:03 -0700 (PDT)","To":"Andrey Konovalov ,\n\tlibcamera-devel@lists.libcamera.org","In-Reply-To":"<20230928185537.20178-3-andrey.konovalov@linaro.org>","References":"<20230928185537.20178-1-andrey.konovalov@linaro.org>\n\t<20230928185537.20178-3-andrey.konovalov@linaro.org>","Date":"Sat, 30 Sep 2023 10:50:01 +0200","Message-ID":"<877co82gg6.fsf@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH v3 2/5] libcamera: converter: drop\n\tunnecessary #include directive","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mattijs Korpershoek via libcamera-devel\n\t","Reply-To":"Mattijs Korpershoek ","Cc":"jacopo.mondi@ideasonboard.com, bryan.odonoghue@linaro.org,\n\tsrinivas.kandagatla@linaro.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27914,"web_url":"https://patchwork.libcamera.org/comment/27914/","msgid":"<20230930091625.GB22488@pendragon.ideasonboard.com>","date":"2023-09-30T09:16:25","subject":"Re: [libcamera-devel] [PATCH v3 2/5] libcamera: converter: drop\n\tunnecessary #include directive","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Andrey,\n\nThank you for the patch.\n\nOn Thu, Sep 28, 2023 at 09:55:34PM +0300, Andrey Konovalov via libcamera-devel wrote:\n> libcamera/internal/media_device.h includes linux/media.h already.\n> \n> Signed-off-by: Andrey Konovalov \n> Suggested-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/converter.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\n> index 15701363..aca4fbc7 100644\n> --- a/src/libcamera/converter.cpp\n> +++ b/src/libcamera/converter.cpp\n> @@ -13,8 +13,6 @@\n> \n> #include \"libcamera/internal/media_device.h\"\n> \n> -#include \"linux/media.h\"\n> -\n> /**\n> * \\file internal/converter.h\n> * \\brief Abstract converter","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63445C0F2A\n\tfor ;\n\tSat, 30 Sep 2023 09:16:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D734062960;\n\tSat, 30 Sep 2023 11:16:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D33786295E\n\tfor ;\n\tSat, 30 Sep 2023 11:16:14 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(lfbn-idf1-1-343-200.w86-195.abo.wanadoo.fr [86.195.61.200])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3CE27DD9;\n\tSat, 30 Sep 2023 11:14:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696065376;\n\tbh=DPqxXDt+Z8FqV/z4qMZKW89zzZMXh5iT8FVed4kFxns=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wU2rP1kCgkL963YGa05m3raG5/KL9UrEBRnhO3eTkynn1F8C/6nhJqVzXgLB+GtDS\n\tw9eoqtKzAl23H3cOx3I7lWRJoo4fLBoiyX7bQCjFg+xsl6tpVy6jq4hbgkUlFhjvJj\n\tq4r72Oo8ca5FHzlg6ZGlUgQtK09JS8XoP9N43hkXCEteqTYUOwxz6I6lb4WRQjTpKa\n\tl0N/CVTuw+4w5C44WZnKgyIQf+myFaQksC5wf9OYkiZQPvRex3oYsTPa9JqqEC1h1x\n\tyzAD2UwjQeQjmt5edwUENey3MGeeR24CXB2Oc6dbL6g0aKWmrj4L/NbO0u/ghgWRC9\n\tW9DKSx1sT9rmA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1696065271;\n\tbh=DPqxXDt+Z8FqV/z4qMZKW89zzZMXh5iT8FVed4kFxns=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VFF7iQPWHpm7lxJp7Fk/SzMOnLcIi9hiaChgWc/KOE+G2ewXWLPHO64GDzOh+iFEb\n\tZlBBgASr7xqDI/6o0daDXH6KfLU4j1es644VZmDSsrg1V0cctsK7leNeFBQ+YCLFN4\n\te/PP57AoCc4346I9vLDixRX8N98Uw1b7+1oa0se0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VFF7iQPW\"; dkim-atps=neutral","Date":"Sat, 30 Sep 2023 12:16:25 +0300","To":"Andrey Konovalov ","Message-ID":"<20230930091625.GB22488@pendragon.ideasonboard.com>","References":"<20230928185537.20178-1-andrey.konovalov@linaro.org>\n\t<20230928185537.20178-3-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230928185537.20178-3-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v3 2/5] libcamera: converter: drop\n\tunnecessary #include directive","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"jacopo.mondi@ideasonboard.com, bryan.odonoghue@linaro.org,\n\tlibcamera-devel@lists.libcamera.org, srinivas.kandagatla@linaro.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]