{"id":19091,"url":"https://patchwork.libcamera.org/api/patches/19091/?format=json","web_url":"https://patchwork.libcamera.org/patch/19091/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230928094124.21801-1-david.plowman@raspberrypi.com>","date":"2023-09-28T09:41:24","name":"[libcamera-devel] ipa: rpi: Avoid skipping IPAs on the first frame after the drop frames","commit_ref":"ff41de7ba1f92ab445473177f9c9107baf2debda","pull_url":null,"state":"accepted","archived":false,"hash":"77de6dc1d55fa69a1a9ab59313e8bb66ea7ad4bc","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19091/mbox/","series":[{"id":4041,"url":"https://patchwork.libcamera.org/api/series/4041/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4041","date":"2023-09-28T09:41:24","name":"[libcamera-devel] ipa: rpi: Avoid skipping IPAs on the first frame after the drop frames","version":1,"mbox":"https://patchwork.libcamera.org/series/4041/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19091/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19091/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D431CC326B\n\tfor ;\n\tThu, 28 Sep 2023 09:41:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D29561DE1;\n\tThu, 28 Sep 2023 11:41:30 +0200 (CEST)","from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E76DA61DE1\n\tfor ;\n\tThu, 28 Sep 2023 11:41:28 +0200 (CEST)","by mail-wr1-x436.google.com with SMTP id\n\tffacd0b85a97d-3231dff4343so5823131f8f.0\n\tfor ;\n\tThu, 28 Sep 2023 02:41:28 -0700 (PDT)","from pi5-davidp.pitowers.org\n\t([2a00:1098:3142:14:183e:6cc8:a436:a27c])\n\tby smtp.gmail.com with ESMTPSA id\n\tn26-20020a7bcbda000000b004063977eccesm6864278wmi.42.2023.09.28.02.41.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 28 Sep 2023 02:41:27 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695894090;\n\tbh=ADAxlc/a/9qc6lB+ocH8xK/AHpm0LeGhVTFc/xuDQ0c=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=S9gIiH7dXitCHGo5Lpg48lIX46ql2pfVvGkNnKXsXhGszXpv+xlWZqoMqdp457GCb\n\toQ5hEtaI7vMDXb3UXBqg/HE8OhaxQmqAuD1dzvQL8K0gXtCHDgU+5czv2v9Hl4TdbE\n\tKzy+TvqipC/VHCLIyA6At1Vlzjt0ikMd7oSGE3RMqVJgbowOE0uoWGoMLt2ajAltmM\n\tOb4QkZrRUCk2xVXL7LbMItGmrSsub3NwUQf0xSomqEF6rcpvZXQddek5zs62IsmWe0\n\tyf0hzqNT6Q7eg78HluTrdI6l0PIc93FwpLzmn/V7URABAFiGS2V4ROjnpnqEUGgLLl\n\toz7nrLVm+KcUQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695894088; x=1696498888;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Dt+wapjxDUScAB7vMyDlS4OAlDoGDeUp3/NHY4ZOmoU=;\n\tb=SGviwS+JJWyzNY6sE1ZYwHO/2lR18b09HZ4wbjY2V0GbOg7c63amtXRmoiIrFqF/z8\n\txnpLg/qgO1dvTCVlYJjLDuZ8ljTybNkrdt/5EqH9GkMaHlOCHIQQRC47H7iVy/rZxytv\n\tKuB+0Mn/AaR3IXWHmyvEDNU1tDWps37704QitX03jgkrs4QeVi+kEMeN5tcb7/bdmijC\n\toL4ky6pVDasMn6ss5kjW4+mOyORMiRz1apwuRlZzPeAajkvhRdCieXK0SnNVcE5/D7OL\n\tavW1mREfcGTZZMERhUKDWUY8zga0AqcWCT4Tcd0Kht+utebU9fIoU3/h2zjFdxspGDzV\n\tg6UA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"SGviwS+J\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695894088; x=1696498888;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=Dt+wapjxDUScAB7vMyDlS4OAlDoGDeUp3/NHY4ZOmoU=;\n\tb=PKDxrDCJAK65VQYIEpazCKnlhZOuaeTOtT2nRZCJ77WafzEqLM7eoJFNH0woazshXV\n\tkPerYohVoYK4SksGtA6nZqQNf2waxIthUP8ZzfPMzBipuOoC+LuhPyvT0abqqFCIfKOv\n\tkkkFag6meYXGEaHMlTV6o6yq2IZ/4aIZXq3QbWqfZI+kWmq8nWDXWYAHSYy9qGGw4HJ3\n\t+59DKnIpS37xrCRBSWsSj36tzLME3isc6RMAjLd/HdZjOuIFcMRrcLget38/3kYHctlR\n\tZj+gUR0SeSqLkyhnM8P5+dnX/d/FuBpT8/3jffh/VFj/o1nibkfGuAFXtV9zbu9ecZgO\n\tsekQ==","X-Gm-Message-State":"AOJu0YxHbhHpcQEQxIYUgmTVckt/EF6yzg7+40LgGTibOFLE8gCSOcie\n\tpnQ+luOF9ZoqCHbmP2eI0lFjZlpHB1cHGZV7MEE=","X-Google-Smtp-Source":"AGHT+IHGiMrUFYwM2ID/h4DZ8nAbthodTdikyRdFMxsQHetfDQk0W7Ky40OiN/L9NfVdB1YshqAIVg==","X-Received":"by 2002:a5d:604c:0:b0:317:dadc:4a63 with SMTP id\n\tj12-20020a5d604c000000b00317dadc4a63mr781580wrt.8.1695894088033; \n\tThu, 28 Sep 2023 02:41:28 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 28 Sep 2023 10:41:24 +0100","Message-Id":"<20230928094124.21801-1-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.39.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: rpi: Avoid skipping IPAs on the\n\tfirst frame after the drop frames","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We avoid skipping the IPAs while frameCount_ is less then\ndropFrameCount_, indicating that these frames will not be sent to the\napplication. This means that when these numbers are equal then this is\nthe first frame the application will get, so again, we must avoid\nskipping the IPAs. Consequently the test here must avoid the case of\nequality.\n\nSigned-off-by: David Plowman \n---\n src/ipa/rpi/common/ipa_base.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\nindex 551adadf..5df1998c 100644\n--- a/src/ipa/rpi/common/ipa_base.cpp\n+++ b/src/ipa/rpi/common/ipa_base.cpp\n@@ -409,7 +409,7 @@ void IpaBase::prepareIsp(const PrepareParams ¶ms)\n \n \t/* Allow a 10% margin on the comparison below. */\n \tDuration delta = (frameTimestamp - lastRunTimestamp_) * 1.0ns;\n-\tif (lastRunTimestamp_ && frameCount_ >= dropFrameCount_ &&\n+\tif (lastRunTimestamp_ && frameCount_ > dropFrameCount_ &&\n \t delta < controllerMinFrameDuration * 0.9) {\n \t\t/*\n \t\t * Ensure we merge the previous frame's metadata with the current\n","prefixes":["libcamera-devel"]}