[{"id":27900,"web_url":"https://patchwork.libcamera.org/comment/27900/","msgid":"<CAHW6GYKgAuU3rEQk0RiCgJeyP4Q6+LvwwNvoYp05QO-TAywntw@mail.gmail.com>","date":"2023-09-28T09:19:21","subject":"Re: [libcamera-devel] [PATCH] py: Add constructor for\n\tSensorConfiguration","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Sorry, please ignore this patch. It's assuming the Python bindings\nhave been updated for the SensorConfiguration, but on master they\nhaven't been yet! Anyway, that patch needs submitting first so I'll do\nthat, and roll this fix in directly.\n\nThanks\nDavid\n\nOn Wed, 27 Sept 2023 at 17:34, David Plowman\n<david.plowman@raspberrypi.com> wrote:\n>\n> The SensorConfiguration is optional within the CameraConfiguration, so\n> Python applications need a constructor to create a SensorConfiguration\n> object that can be put there.\n>\n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> ---\n>  src/py/libcamera/py_main.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp\n> index c36e6e6c..8df04520 100644\n> --- a/src/py/libcamera/py_main.cpp\n> +++ b/src/py/libcamera/py_main.cpp\n> @@ -283,6 +283,7 @@ PYBIND11_MODULE(_libcamera, m)\n>                 });\n>\n>         pySensorConfiguration\n> +               .def(py::init<>())\n>                 .def_readwrite(\"bit_depth\", &SensorConfiguration::bitDepth)\n>                 .def_readwrite(\"output_size\", &SensorConfiguration::outputSize);\n>\n> --\n> 2.39.2\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6EB5BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 28 Sep 2023 09:19:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3774962963;\n\tThu, 28 Sep 2023 11:19:36 +0200 (CEST)","from mail-qt1-x836.google.com (mail-qt1-x836.google.com\n\t[IPv6:2607:f8b0:4864:20::836])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8238761DE1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Sep 2023 11:19:34 +0200 (CEST)","by mail-qt1-x836.google.com with SMTP id\n\td75a77b69052e-4194c3cf04aso36672601cf.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 28 Sep 2023 02:19:34 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695892776;\n\tbh=j9zCzYTBLOzWzsvu/pe2zReurZfJ7m8adHhyZspF7j0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=O4mKoYZZI8PgQFH4pxD9/i1ONCv3pxr/VaZmfWsKHocJlDFHG7eLBsZRMhnOzjEs1\n\tRw1D6vUV2Axdf6GxdcxvOHH9m3Q0K1EGjmJiAWQEHDETvOqHV1b2o+zqyg9z4d1gRd\n\tIujEKWSW9C5oYXMvuHlVx/AAne7Wk8gk1bqX1gwSxKw6125Ygrk2PrZ9HQBlFxsxSd\n\tDuuKJY9WwuPRfQ++8QjObJfsOpagwLMdmPBods8onscMrZyTnfRwO2PXmIpoxJq7oi\n\tdRRz7iC2KpZCdWQiGLJBY0B4YVa4fXDX2tOJtg9tPY71g1g2qMnfIt+u6L59RYpBWU\n\tamEMPOhUo/y4w==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695892773; x=1696497573;\n\tdarn=lists.libcamera.org; \n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=chFf502UEqAx57LHL34kcN8bRzT/yNM+43ujhwBlVIA=;\n\tb=WqfKcCucpAU8iZhsdUTJuncpnqSzjnecWYc/VhEJ2y0Jv+7roMCbd2Mp0zvd3pUuMd\n\t0auyZrSVxzryN+ucO1x6rBZ266sI8AblEnZxoD03tKPeVzQWEH6qD5f+38mzi2ODuyQv\n\tlRX5JEId3mlY9Z7obcluGdMFHWYD6YLemDo27Cnzst6Pq/XbH4WFrA+2yDYiSCr0tMsH\n\tlmFdpRmq0XZTy7MZkBfzjHETP240eCvGgvqDSAchxHWNmOGrqcZ8q8vFl4UC50eRSMU6\n\tK8m//9bnujmvhZOVyOWJfHKU+1AYS2HrnmNag+s+ipGsuE3akPCqsUzNxihDv1JQRycQ\n\t0NsA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"WqfKcCuc\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695892773; x=1696497573;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=chFf502UEqAx57LHL34kcN8bRzT/yNM+43ujhwBlVIA=;\n\tb=TeOQ9Twc2IIWUmkPjSAEnA7pxIJJ3CdULs4tM9NMFE9R5OiC2IP+JZ6H8vwp13/odS\n\tqFxt6nAlwe/jTwN+7T4U1CCXYBJAGlTuizJL3acIsJ1QKgfFcpsVAM8FvEHYkvgmUIYx\n\tSsFYO1QGAKML/h/V5FhPGSpwCJfUpG4riwbgD/EmISuZVDmHRS1F1lteYSu/BasFMTiP\n\t3v0Ue/yDb9ErLnonGS6dfpC9z/tG2LCWAgDJlgL9TlmSw4lxjtuVzsLsm0I64T6ZB3lw\n\tdcZVbeIA64xxCrhtnghsLu4JMSLoDthsq76jhgWx6T5PcKK7R+2LCy9qHPngJxedNgdc\n\t2DlA==","X-Gm-Message-State":"AOJu0YzCR1NRXmOnU2BOvvkR5WCg9laUBhh6nn9bJhPfixta0xyO7MX0\n\t/3P4ZCjCMGIgqWDtUjJQXbBt/tX6oGQ2ohZTa+P8gZs4OTk2MkOz","X-Google-Smtp-Source":"AGHT+IG2aP9LpHT5cAp0a2dwJKYFpaxyxzRzysvBg4Amo+Gj4OSGtokfQML8fB7HrsnKxOUU8oKgT2KHEPev2kFa1A8=","X-Received":"by 2002:a05:6214:488d:b0:64f:51fe:859c with SMTP id\n\tpc13-20020a056214488d00b0064f51fe859cmr688638qvb.43.1695892772927;\n\tThu, 28 Sep 2023 02:19:32 -0700 (PDT)","MIME-Version":"1.0","References":"<20230927163422.15924-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20230927163422.15924-1-david.plowman@raspberrypi.com>","Date":"Thu, 28 Sep 2023 10:19:21 +0100","Message-ID":"<CAHW6GYKgAuU3rEQk0RiCgJeyP4Q6+LvwwNvoYp05QO-TAywntw@mail.gmail.com>","To":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] py: Add constructor for\n\tSensorConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"David Plowman <david.plowman@raspberrypi.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]