[{"id":2570,"web_url":"https://patchwork.libcamera.org/comment/2570/","msgid":"<20190903104604.GD4779@pendragon.ideasonboard.com>","date":"2019-09-03T10:46:04","subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator: fix\n\tudev media graph loading dependency","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Sep 02, 2019 at 12:17:13AM -0400, Paul Elder wrote:\n> When a MediaDevice is enumerated and populated by the\n> DeviceEnumeratorUdev, there is a possibility that the member device\n> nodes of the media graph would not be ready (either not created, or\n> without proper permissions set by udev yet) The MediaDevice is still\n\ns/)/)./\n\n> passed up to the pipeline handler, where an attempt to access the device\n> nodes will fail in EPERM. This whole issue is especially likely to\n> happen when libcamera is run at system init time.\n> \n> To fix this, we first split DeviceEnumerator::addDevice() into three\n> methods:\n> - createDevice() to simply create the MediaDevice\n> - populateMediaDevice() to populate the MediaDevice\n> - addDevice() to pass the MediaDevice up to the pipeline handler\n> \n> DeviceEnumeratorSysfs calls these methods in succession, similar to what\n> it did before when they were all together as addDevice().\n> \n> DeviceEnumeratorUdev additionally keeps a map of MediaDevices to a list\n> of pending device nodes (plus some other auxillary maps), and a simple\n> list of orphan device nodes. If a v4l device node is ready and there\n> does not exist any MediaDevice node for it, then it goes to the orphan\n> list, otherwise it is initialized and removed from the pending list of\n> the corresponding MediaDevice in the dependency map. When a MediaDevice\n> is populated via DeviceEnumeratorUdev::populateMediaDevice(), it first\n> checks the orphan list to see if the device nodes it needs are there,\n> otherwise it tries to initialize the device nodes and if it fails, then\n> it adds the device nodes it wants to its list in the dependency map.\n> \n> This allows MediaDevice instances to be created and initialized properly\n> with udev when v4l device nodes in the media graph may not be ready when\n> the MediaDevice is populated.\n> \n> Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>\n> \n> ---\n> Changes in v2:\n> - add documentation\n> - better name for the maps\n> - other minor changes\n> \n> todos:\n> - do we need a better name for populateMediaDevice() ?\n> \n> ---\n>  src/libcamera/device_enumerator.cpp           |  52 +++----\n>  src/libcamera/device_enumerator_sysfs.cpp     |  34 ++++-\n>  src/libcamera/device_enumerator_udev.cpp      | 140 +++++++++++++++++-\n>  src/libcamera/include/device_enumerator.h     |   3 +-\n>  .../include/device_enumerator_sysfs.h         |   5 +-\n>  .../include/device_enumerator_udev.h          |  16 ++\n>  6 files changed, 218 insertions(+), 32 deletions(-)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 60c918f..0290832 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -195,16 +195,19 @@ DeviceEnumerator::~DeviceEnumerator()\n>   */\n>  \n>  /**\n> - * \\brief Add a media device to the enumerator\n> - * \\param[in] deviceNode path to the media device to add\n> + * \\brief Create a media device instance\n> + * \\param[in] deviceNode path to the media device to create\n>   *\n> - * Create a media device for the \\a deviceNode, open it, populate its media graph,\n> - * and look up device nodes associated with all entities. Store the media device\n> - * in the internal list for later matching with pipeline handlers.\n> + * Create a media device for the \\a deviceNode, open it, and populate its\n> + * media graph. populateMediaDevice() should be called after this to look\n> + * up device nodes associated with all entities and to initialize them.\n> + * addDevice() shall be called with the media device returned from this\n> + * method, after populateMediaDevice() and after all devices nodes in the\n> + * media graph have been confirmed to be initialized.\n\nI wouldn't mention populateMediaDevice() here as those methods are only\nimplemented in the derived classes. How about\n\n * Create a media device for the \\a deviceNode, open it, and populate its\n * media graph. The device enumerator shall then populate the media device by\n * associating device nodes with entities using MediaEntity::setDeviceNode().\n * This process is specific to each device enumerator, and the device enumerator\n * shall ensure that device nodes are ready to be used (for instance, if\n * applicable, by waiting for device nodes to be created and access permissions\n * to be set by the system). Once done, it shall add the media device to the\n * system with addDevice().\n\n>   *\n> - * \\return 0 on success or a negative error code otherwise\n> + * \\return Created media device instance on success, or nullptr otherwise\n>   */\n> -int DeviceEnumerator::addDevice(const std::string &deviceNode)\n> +std::shared_ptr<MediaDevice> DeviceEnumerator::createDevice(const std::string &deviceNode)\n>  {\n>  \tstd::shared_ptr<MediaDevice> media = std::make_shared<MediaDevice>(deviceNode);\n>  \n> @@ -213,34 +216,31 @@ int DeviceEnumerator::addDevice(const std::string &deviceNode)\n>  \t\tLOG(DeviceEnumerator, Info)\n>  \t\t\t<< \"Unable to populate media device \" << deviceNode\n>  \t\t\t<< \" (\" << strerror(-ret) << \"), skipping\";\n> -\t\treturn ret;\n> +\t\treturn nullptr;\n>  \t}\n>  \n>  \tLOG(DeviceEnumerator, Debug)\n>  \t\t<< \"New media device \\\"\" << media->driver()\n>  \t\t<< \"\\\" created from \" << deviceNode;\n>  \n> -\t/* Associate entities to device node paths. */\n> -\tfor (MediaEntity *entity : media->entities()) {\n> -\t\tif (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)\n> -\t\t\tcontinue;\n> -\n> -\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(),\n> -\t\t\t\t\t\t\t  entity->deviceMinor());\n> -\t\tif (deviceNode.empty())\n> -\t\t\treturn -EINVAL;\n> -\n> -\t\tret = entity->setDeviceNode(deviceNode);\n> -\t\tif (ret)\n> -\t\t\treturn ret;\n> -\t}\n> +\treturn media;\n> +}\n>  \n> +/**\n> + * \\brief Add a media device to the enumerator\n> + * \\param[in] media media device instance to add\n> + *\n> + * Store the media device in the internal list for later matching with\n> + * pipeline handlers. \\a media shall be created with createDevice() first.\n> + * This method shall be called after all members of the members of the\n> + * media graph have been confirmed to be initialized.\n\nDid you mean \"all members of the entities of the media graph\" ?\n\n> + */\n> +void DeviceEnumerator::addDevice(std::shared_ptr<MediaDevice> media)\n> +{\n\nYou can pass a const reference to the shared pointer instead of a copy.\n\n>  \tLOG(DeviceEnumerator, Debug)\n> -\t\t<< \"Added device \" << deviceNode << \": \" << media->driver();\n> -\n> -\tdevices_.push_back(std::move(media));\n> +\t\t<< \"Added device \" << media->deviceNode() << \": \" << media->driver();\n>  \n> -\treturn 0;\n> +\tdevices_.push_back(media);\n>  }\n>  \n>  /**\n> diff --git a/src/libcamera/device_enumerator_sysfs.cpp b/src/libcamera/device_enumerator_sysfs.cpp\n> index f3054d5..98299d7 100644\n> --- a/src/libcamera/device_enumerator_sysfs.cpp\n> +++ b/src/libcamera/device_enumerator_sysfs.cpp\n> @@ -32,6 +32,7 @@ int DeviceEnumeratorSysfs::enumerate()\n>  {\n>  \tstruct dirent *ent;\n>  \tDIR *dir;\n> +\tint ret = 0;\n>  \n>  \tstatic const char * const sysfs_dirs[] = {\n>  \t\t\"/sys/subsystem/media/devices\",\n> @@ -71,11 +72,42 @@ int DeviceEnumeratorSysfs::enumerate()\n>  \t\t\tcontinue;\n>  \t\t}\n>  \n> -\t\taddDevice(devnode);\n> +\t\tstd::shared_ptr<MediaDevice> media = createDevice(devnode);\n> +\t\tif (!media) {\n> +\t\t\tret = -ENODEV;\n> +\t\t\tbreak;\n> +\t\t}\n> +\n> +\t\tif (populateMediaDevice(media) < 0) {\n> +\t\t\tret = -ENODEV;\n> +\t\t\tbreak;\n> +\t\t}\n> +\n> +\t\taddDevice(media);\n>  \t}\n>  \n>  \tclosedir(dir);\n>  \n> +\treturn ret;\n> +}\n> +\n> +int DeviceEnumeratorSysfs::populateMediaDevice(std::shared_ptr<MediaDevice> media)\n\nYou can pass a const reference to the shared pointer instead of a copy\n(same for the udev enumerator).\n\n> +{\n> +\t/* Associate entities to device node paths. */\n> +\tfor (MediaEntity *entity : media->entities()) {\n> +\t\tif (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)\n> +\t\t\tcontinue;\n> +\n> +\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(),\n> +\t\t\t\t\t\t\t  entity->deviceMinor());\n> +\t\tif (deviceNode.empty())\n> +\t\t\treturn -EINVAL;\n> +\n> +\t\tint ret = entity->setDeviceNode(deviceNode);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n> +\n>  \treturn 0;\n>  }\n>  \n> diff --git a/src/libcamera/device_enumerator_udev.cpp b/src/libcamera/device_enumerator_udev.cpp\n> index 86f6ca1..c89f152 100644\n> --- a/src/libcamera/device_enumerator_udev.cpp\n> +++ b/src/libcamera/device_enumerator_udev.cpp\n> @@ -7,6 +7,10 @@\n>  \n>  #include \"device_enumerator_udev.h\"\n>  \n> +#include <algorithm>\n> +#include <list>\n> +#include <map>\n> +\n>  #include <fcntl.h>\n>  #include <libudev.h>\n>  #include <string.h>\n> @@ -17,6 +21,7 @@\n>  #include <libcamera/event_notifier.h>\n>  \n>  #include \"log.h\"\n> +#include \"media_device.h\"\n>  \n>  namespace libcamera {\n>  \n> @@ -57,9 +62,40 @@ int DeviceEnumeratorUdev::init()\n>  \tif (ret < 0)\n>  \t\treturn ret;\n>  \n> +\tret = udev_monitor_filter_add_match_subsystem_devtype(monitor_, \"video4linux\",\n> +\t\t\t\t\t\t\t      nullptr);\n> +\tif (ret < 0)\n> +\t\treturn ret;\n> +\n>  \treturn 0;\n>  }\n>  \n> +int DeviceEnumeratorUdev::addUdevDevice(struct udev_device *dev)\n> +{\n> +\tconst char *subsystem = udev_device_get_subsystem(dev);\n> +\tif (!subsystem)\n> +\t\treturn -ENODEV;\n> +\n> +\tif (!strcmp(subsystem, \"media\")) {\n> +\t\tstd::shared_ptr<MediaDevice> media =\n> +\t\t\tcreateDevice(udev_device_get_devnode(dev));\n> +\t\tif (!media)\n> +\t\t\treturn -ENODEV;\n> +\n> +\t\tint ret = populateMediaDevice(media);\n> +\t\tif (ret == 0)\n> +\t\t\taddDevice(media);\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tif (!strcmp(subsystem, \"video4linux\")) {\n> +\t\taddV4L2Device(udev_device_get_devnum(dev));\n> +\t\treturn 0;\n> +\t}\n> +\n> +\treturn -ENODEV;\n> +}\n> +\n>  int DeviceEnumeratorUdev::enumerate()\n>  {\n>  \tstruct udev_enumerate *udev_enum = nullptr;\n> @@ -74,6 +110,14 @@ int DeviceEnumeratorUdev::enumerate()\n>  \tif (ret < 0)\n>  \t\tgoto done;\n>  \n> +\tret = udev_enumerate_add_match_subsystem(udev_enum, \"video4linux\");\n> +\tif (ret < 0)\n> +\t\tgoto done;\n> +\n> +\tret = udev_enumerate_add_match_is_initialized(udev_enum);\n> +\tif (ret < 0)\n> +\t\tgoto done;\n> +\n>  \tret = udev_enumerate_scan_devices(udev_enum);\n>  \tif (ret < 0)\n>  \t\tgoto done;\n> @@ -102,10 +146,16 @@ int DeviceEnumeratorUdev::enumerate()\n>  \t\t\tgoto done;\n>  \t\t}\n>  \n> -\t\taddDevice(devnode);\n> +\t\tif (addUdevDevice(dev) < 0) {\n> +\t\t\tudev_device_unref(dev);\n> +\t\t\tret = -ENODEV;\n> +\t\t\tgoto done;\n> +\t\t}\n>  \n>  \t\tudev_device_unref(dev);\n> +\t\tcontinue;\n\nThis line isn't needed anymore.\n\nHow about\n\n\tret = addUdevDevice(dev);\n\tudev_device_unref(dev);\n\tif (ret < 0)\n\t\tbreak;\n\nto simplify the code and propagate the error ?\n\n>  \t}\n> +\n>  done:\n>  \tudev_enumerate_unref(udev_enum);\n>  \tif (ret < 0)\n> @@ -122,6 +172,48 @@ done:\n>  \treturn 0;\n>  }\n>  \n> +int DeviceEnumeratorUdev::populateMediaDevice(std::shared_ptr<MediaDevice> media)\n> +{\n> +\tunsigned int pendingNodes = 0;\n> +\tint ret;\n> +\n> +\t/* Associate entities to device node paths. */\n> +\tfor (MediaEntity *entity : media->entities()) {\n> +\t\tif (entity->deviceMajor() == 0 && entity->deviceMinor() == 0)\n> +\t\t\tcontinue;\n> +\n> +\t\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(),\n> +\t\t\t\t\t\t\t  entity->deviceMinor());\n> +\t\tdev_t devnum = makedev(entity->deviceMajor(),\n> +\t\t\t\t       entity->deviceMinor());\n> +\n> +\t\t/* Take device from orphan list first, if it is in the list. */\n> +\t\tif (std::find(orphans_.begin(), orphans_.end(), devnum) != orphans_.end()) {\n> +\t\t\tif (deviceNode.empty())\n> +\t\t\t\treturn -EINVAL;\n> +\n> +\t\t\tret = entity->setDeviceNode(deviceNode);\n> +\t\t\tif (ret)\n> +\t\t\t\treturn ret;\n> +\n> +\t\t\torphans_.remove(devnum);\n> +\t\t\tcontinue;\n> +\t\t}\n> +\n> +\t\tif (::access(deviceNode.c_str(), R_OK | W_OK) < 0) {\n> +\t\t\tdeps_[media].push_back(devnum);\n> +\t\t\tdevnumToDevice_[devnum] = media;\n> +\t\t\tdevnumToEntity_[devnum] = entity;\n> +\t\t\tpendingNodes++;\n> +\t\t\tcontinue;\n> +\t\t}\n> +\n> +\t\tentity->setDeviceNode(deviceNode);\n\nWhat exactly would go wrong if you removed the access() check and the\nentity->setDeviceNode() ? I agree that a device node may be ready here,\nbut if it's not in the orphans list it will get there later, and will be\nadded to the media device at that time. Trying to add it early here just\nin case is an optimisation that I believe makes more harm than good, as\nit opens the door to more race conditions. For instance, maybe udev\nfirst sets permissions and then renames the device node, and we could\nrun just between those two operations.\n\nFurthermore, when DeviceEnumeratorUdev::addV4L2Device() is later called,\nthe device will not be in devnumToEntity_, so it will be added to\norphans_, even though it will already be in use by the media device. I\ndon't think that's right.\n\nAs there's no hurry to make media devices available, I would simplify\nthe code and stay on the safe side.\n\n> +\t}\n> +\n> +\treturn pendingNodes;\n> +}\n> +\n>  std::string DeviceEnumeratorUdev::lookupDeviceNode(int major, int minor)\n>  {\n>  \tstruct udev_device *device;\n> @@ -143,6 +235,46 @@ std::string DeviceEnumeratorUdev::lookupDeviceNode(int major, int minor)\n>  \treturn deviceNode;\n>  }\n>  \n> +/**\n> + * \\brief Add a V4L2 device to the media device that needs it\n\ns/that needs it/that it belongs to/ ?\n\n> + * \\param[in] devnum major:minor number of V4L2 device to add, as a dev_t\n> + *\n> + * Add V4L2 device identified by \\a devnum to the MediaDevice that needs it,\n\nSame here.\n\n> + * if such a MediaDevice has been created. Otherwise add the V4L2 device to\n> + * the orphan list. If the V4L2 device is added to a MediaDevice, and it is\n> + * the last V4L2 device that the MediaDevice needs, then the MediaDevice\n> + * will be sent up to the pipeline handler.\n\nThere's one intermediate step, so I would say something along the lines\nof \"then the MediaDevice is added to the DeviceEnumerator, where it is\navailable for pipeline handlers.\"\n\n> + *\n> + * \\return 0 on success or a negative error code otherwise\n> + */\n> +int DeviceEnumeratorUdev::addV4L2Device(dev_t devnum)\n> +{\n> +\tMediaEntity *entity = devnumToEntity_[devnum];\n> +\tif (!entity) {\n> +\t\torphans_.push_back(devnum);\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tstd::string deviceNode = lookupDeviceNode(entity->deviceMajor(),\n> +\t\t\t\t\t\t  entity->deviceMinor());\n> +\tif (deviceNode.empty())\n> +\t\treturn -EINVAL;\n> +\n> +\tint ret = entity->setDeviceNode(deviceNode);\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> +\tstd::shared_ptr<MediaDevice> media = devnumToDevice_[devnum];\n\nI'm really tempted to use normal pointer internally, and create the\nshared pointer in addDevice(). If you do so, the above line could be\nreplaced with\n\n\tMediaDevice *media = entity->device();\n\nand the devnumToDevice_ map could be removed, which I think would\nsimplify the code. You didn't seem to like this when I proposed it in\nthe review of v1, do you think it's a bad idea ? Or would you prefer\nfixing it on top ? (I may submit a patch to do so :-))\n\n> +\tdeps_[media].remove(devnum);\n> +\tdevnumToDevice_.erase(devnum);\n> +\tdevnumToEntity_.erase(devnum);\n> +\n> +\tif (deps_[media].empty())\n> +\t\taddDevice(media);\n\nYou should also deps_.erase(media).\n\n> +\n> +\treturn 0;\n> +}\n> +\n>  void DeviceEnumeratorUdev::udevNotify(EventNotifier *notifier)\n>  {\n>  \tstruct udev_device *dev = udev_monitor_receive_device(monitor_);\n> @@ -153,9 +285,11 @@ void DeviceEnumeratorUdev::udevNotify(EventNotifier *notifier)\n>  \t\t<< action << \" device \" << udev_device_get_devnode(dev);\n>  \n>  \tif (action == \"add\") {\n> -\t\taddDevice(deviceNode);\n> +\t\taddUdevDevice(dev);\n>  \t} else if (action == \"remove\") {\n> -\t\tremoveDevice(deviceNode);\n> +\t\tconst char *subsystem = udev_device_get_subsystem(dev);\n> +\t\tif (subsystem && !strcmp(subsystem, \"media\"))\n> +\t\t\tremoveDevice(deviceNode);\n\nWe could create a removeUdevDevice() method for symmetry, but I don't\nthink that's required yet.\n\n>  \t}\n>  \n>  \tudev_device_unref(dev);\n> diff --git a/src/libcamera/include/device_enumerator.h b/src/libcamera/include/device_enumerator.h\n> index 02aec3b..b7d1b0a 100644\n> --- a/src/libcamera/include/device_enumerator.h\n> +++ b/src/libcamera/include/device_enumerator.h\n> @@ -44,7 +44,8 @@ public:\n>  \tstd::shared_ptr<MediaDevice> search(const DeviceMatch &dm);\n>  \n>  protected:\n> -\tint addDevice(const std::string &deviceNode);\n> +\tstd::shared_ptr<MediaDevice> createDevice(const std::string &deviceNode);\n> +\tvoid addDevice(std::shared_ptr<MediaDevice> media);\n>  \tvoid removeDevice(const std::string &deviceNode);\n>  \n>  private:\n> diff --git a/src/libcamera/include/device_enumerator_sysfs.h b/src/libcamera/include/device_enumerator_sysfs.h\n> index 8d3adc9..cc33f75 100644\n> --- a/src/libcamera/include/device_enumerator_sysfs.h\n> +++ b/src/libcamera/include/device_enumerator_sysfs.h\n> @@ -9,6 +9,8 @@\n>  \n>  #include <string>\n\nYou should #include <memory> for std::shared_ptr.\n\n>  \n> +#include \"media_device.h\"\n> +\n\nYou can just forward-declare class MediaDevice.\n\n>  #include \"device_enumerator.h\"\n>  \n>  namespace libcamera {\n> @@ -20,7 +22,8 @@ public:\n>  \tint enumerate();\n>  \n>  private:\n> -\tstd::string lookupDeviceNode(int major, int minor);\n> +\tint populateMediaDevice(std::shared_ptr<MediaDevice> media);\n> +\tstd::string lookupDeviceNode(int major, int minor) final;\n>  };\n>  \n>  } /* namespace libcamera */\n> diff --git a/src/libcamera/include/device_enumerator_udev.h b/src/libcamera/include/device_enumerator_udev.h\n> index 80f9372..3f8af52 100644\n> --- a/src/libcamera/include/device_enumerator_udev.h\n> +++ b/src/libcamera/include/device_enumerator_udev.h\n> @@ -7,8 +7,13 @@\n>  #ifndef __LIBCAMERA_DEVICE_ENUMERATOR_UDEV_H__\n>  #define __LIBCAMERA_DEVICE_ENUMERATOR_UDEV_H__\n>  \n> +#include <list>\n> +#include <map>\n>  #include <string>\n\nYou need #include <memory> here too.\n\n>  \n> +#include <libudev.h>\n\nYou can just forward-declare struct udev_device.\n\n> +#include <sys/types.h>\n> +\n\nYou can mix the C++ and C headers.\n\n>  #include \"device_enumerator.h\"\n>  \n>  struct udev;\n> @@ -17,6 +22,8 @@ struct udev_monitor;\n>  namespace libcamera {\n>  \n>  class EventNotifier;\n> +class MediaDevice;\n> +class MediaEntity;\n>  \n>  class DeviceEnumeratorUdev : public DeviceEnumerator\n>  {\n> @@ -32,8 +39,17 @@ private:\n>  \tstruct udev_monitor *monitor_;\n>  \tEventNotifier *notifier_;\n>  \n> +\tstd::map<std::shared_ptr<MediaDevice>, std::list<dev_t>> deps_;\n> +\tstd::map<dev_t, std::shared_ptr<MediaDevice>> devnumToDevice_;\n> +\tstd::map<dev_t, MediaEntity *> devnumToEntity_;\n> +\n> +\tstd::list<dev_t> orphans_;\n> +\n> +\tint addUdevDevice(struct udev_device *dev);\n> +\tint populateMediaDevice(std::shared_ptr<MediaDevice> media);\n>  \tstd::string lookupDeviceNode(int major, int minor) final;\n>  \n> +\tint addV4L2Device(dev_t devnum);\n>  \tvoid udevNotify(EventNotifier *notifier);\n>  };\n>","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 995FA60BCF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  3 Sep 2019 12:46:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(231.125-247-81.adsl-dyn.isp.belgacom.be [81.247.125.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00C65542;\n\tTue,  3 Sep 2019 12:46:10 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567507571;\n\tbh=SHxaQI9rdaVY7g+LCH3icflDeBGN92WDO7fOwHLEm3k=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Zw02xkyP3eJg2znsWQJh0iBAjEMGCvT0dJtm84DWzFtx/KTuhhq9yZFIPpaMvlxsb\n\tOGVosJ3kO4fHXVWZJduaR8qwbssa4wGizy54z+HCh0rkItOE84YEuIKa5TEsvDOCdY\n\ta10OzZoPhOs7WnX/KEbi3Sj6gmFO9UrAHd0ko0NI=","Date":"Tue, 3 Sep 2019 13:46:04 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190903104604.GD4779@pendragon.ideasonboard.com>","References":"<20190902041713.11229-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190902041713.11229-1-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2] libcamera: device_enumerator: fix\n\tudev media graph loading dependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 03 Sep 2019 10:46:11 -0000"}}]