[{"id":27877,"web_url":"https://patchwork.libcamera.org/comment/27877/","msgid":"<20230925121644.GC375@pendragon.ideasonboard.com>","date":"2023-09-25T12:16:44","subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Fix typo in YV444\n\tV4L2PixelFormat listing","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Sep 25, 2023 at 12:01:05PM +0100, Naushir Patuck via libcamera-devel wrote:\n> This format was defined with the V4L2_PIX_FMT_YUV444M fourcc instead of\n> the correct V4L2_PIX_FMT_YVU444M fourcc.\n> \n> Fixes: 3b9fe4ae996b (\"libcamera: formats: Add YUV444 and YVU444 pixel formats\")\n> Signed-off-by: Naushir Patuck \n\nOops.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_pixelformat.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index a7ae69bb317d..5551c62eb39b 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -123,7 +123,7 @@ const std::map vpf2pf{\n> \t\t{ formats::YVU422, \"Planar YVU 4:2:2 (N-C)\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV444M),\n> \t\t{ formats::YUV444, \"Planar YUV 4:4:4 (N-C)\" } },\n> -\t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV444M),\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_YVU444M),\n> \t\t{ formats::YVU444, \"Planar YVU 4:4:4 (N-C)\" } },\n> \n> \t/* Greyscale formats. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8EC5EBD808\n\tfor ;\n\tMon, 25 Sep 2023 12:16:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E90CB62944;\n\tMon, 25 Sep 2023 14:16:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD101628FA\n\tfor ;\n\tMon, 25 Sep 2023 14:16:33 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8CB01DB7;\n\tMon, 25 Sep 2023 14:14:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695644195;\n\tbh=lCy1gmIRuJUaeAIQfIURIjNQEz2boh+8f7ufhIsf43Y=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tRv9bJewdTYa54W8a9VrBJ9fWgEuzVoz7AQBhfN/WGs0ENU/jT/gnT1cjovA/BoYM\n\tLYFJxWCcBTzhZZzPmE5b6DmzKmySmP4UvzEcjYbeONLFyfXfmOoXHnUZj3tXHhbs27\n\tPGcYzW3wOkKaE8C7U2duR+Jhzu4PVr+vJSMVAX5+s9iPKy1KB/L6GkQPrG6dGk4ivs\n\tLnWDVWPXhtKm35KSELy94PKxgCMaABakk+pxvftZmNkDemAcmq7Pcpib6l0YEPyXi3\n\t2soxdM1QDyCdMGpcMaJh6gDABHdprXMVwKDkR7oQl28FFBpOMuuGFp7/Oa5GEkfkp9\n\tNb9RqPH6yZR+A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695644093;\n\tbh=lCy1gmIRuJUaeAIQfIURIjNQEz2boh+8f7ufhIsf43Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=V4Yy8wwSq0qXGy1eqF3S/rt1JYxTHlebAfu//txwLF3UiE+klBeVIULx7a8PiN3RW\n\tIQduBqMUa7fyokzIvJ84yoUbMW9jUGNnl0PhQ2lOS6OuDPm9LKpXjOaOrUomZT4zQb\n\tsfoz8SFT0qhKpeNV1GpOkRl8rj7uDL4EcmdJR1e0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"V4Yy8wwS\"; dkim-atps=neutral","Date":"Mon, 25 Sep 2023 15:16:44 +0300","To":"Naushir Patuck ","Message-ID":"<20230925121644.GC375@pendragon.ideasonboard.com>","References":"<20230925110105.13783-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230925110105.13783-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Fix typo in YV444\n\tV4L2PixelFormat listing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27880,"web_url":"https://patchwork.libcamera.org/comment/27880/","msgid":"<169564968738.2915094.1824872457908270217@ping.linuxembedded.co.uk>","date":"2023-09-25T13:48:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Fix typo in YV444\n\tV4L2PixelFormat listing","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-09-25 13:16:44)\n> Hi Naush,\n> \n> Thank you for the patch.\n> \n> On Mon, Sep 25, 2023 at 12:01:05PM +0100, Naushir Patuck via libcamera-devel wrote:\n> > This format was defined with the V4L2_PIX_FMT_YUV444M fourcc instead of\n> > the correct V4L2_PIX_FMT_YVU444M fourcc.\n> > \n> > Fixes: 3b9fe4ae996b (\"libcamera: formats: Add YUV444 and YVU444 pixel formats\")\n> > Signed-off-by: Naushir Patuck \n> \n> Oops.\n\nYikes indeed.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > src/libcamera/v4l2_pixelformat.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> > index a7ae69bb317d..5551c62eb39b 100644\n> > --- a/src/libcamera/v4l2_pixelformat.cpp\n> > +++ b/src/libcamera/v4l2_pixelformat.cpp\n> > @@ -123,7 +123,7 @@ const std::map vpf2pf{\n> > { formats::YVU422, \"Planar YVU 4:2:2 (N-C)\" } },\n> > { V4L2PixelFormat(V4L2_PIX_FMT_YUV444M),\n> > { formats::YUV444, \"Planar YUV 4:4:4 (N-C)\" } },\n> > - { V4L2PixelFormat(V4L2_PIX_FMT_YUV444M),\n> > + { V4L2PixelFormat(V4L2_PIX_FMT_YVU444M),\n> > { formats::YVU444, \"Planar YVU 4:4:4 (N-C)\" } },\n> > \n> > /* Greyscale formats. */\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1364BD808\n\tfor ;\n\tMon, 25 Sep 2023 13:48:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17EA162944;\n\tMon, 25 Sep 2023 15:48:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 76EEB628FA\n\tfor ;\n\tMon, 25 Sep 2023 15:48:09 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 523711B70;\n\tMon, 25 Sep 2023 15:46:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695649691;\n\tbh=E7HuyEJN+NBTB+wprNZHPsi5UzZ3067lAnu4Bes+w8U=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WObWcPW/illvimU5JA15wKL7/fAizXvwDdlkl05ql8ihOc1233r3eSmWJtT2CKFSL\n\tREufBfoZ6Q69ClH2iqD/i7zF1kTwiWCe4hUJJp/ud4BP/SSm/GaLJUcVf+T69Tl3/v\n\tFwucOY8OV+QFmzE1HNV/AIvDxKzt4w3CduIm3HfmojSMSVMtIuY82Lnu2U1Au/LGSz\n\t9FFrJWOPdiB+Kcda8raFfAg7Tbu4LRUccBmB9MwNMnMYheqsd9fSj1bXhq1dBMTTwy\n\tp9jRNTOBP8RMva2Jl+waPex/yHMztE95THyIrENWaOiwZANlQxpVmCjWENjw3ebvsb\n\tWAygAHy0+kDOQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695649589;\n\tbh=E7HuyEJN+NBTB+wprNZHPsi5UzZ3067lAnu4Bes+w8U=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=MijoeycALKT8fxm4z/i/YJVOUB/3wDwA/Vq/rKzFOA2w3GIRnvEWE56qPraKze7gd\n\tpfMSEOp/DspceXJiX9Vl7OiG6qRVLalHEb98LVFDfyl4f2mTskJZHIIMq+BiwORe59\n\t2waZ48htTef2FrV5VCue8mmmoQO/s9HN3zmmGCmQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"MijoeycA\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230925121644.GC375@pendragon.ideasonboard.com>","References":"<20230925110105.13783-1-naush@raspberrypi.com>\n\t<20230925121644.GC375@pendragon.ideasonboard.com>","To":"Laurent Pinchart ,\n\tLaurent Pinchart via libcamera-devel\n\t, \n\tNaushir Patuck ","Date":"Mon, 25 Sep 2023 14:48:07 +0100","Message-ID":"<169564968738.2915094.1824872457908270217@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Fix typo in YV444\n\tV4L2PixelFormat listing","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]