[{"id":27903,"web_url":"https://patchwork.libcamera.org/comment/27903/","msgid":"","date":"2023-09-28T14:21:02","subject":"Re: [libcamera-devel] [PATCH v2 1/1] libcamera: controls: Add\n\tcontrols for HDR","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Oops, there's a typo:\n\nOn Mon, 25 Sept 2023 at 10:21, David Plowman\n wrote:\n>\n> We add an HdrMode control (to enable and disable HDR processing)\n> and an HdrChannel, which indicates what kind of HDR frame (short, long\n> or otherwise) has just arrived.\n>\n> Currently the HdrMode supports the following values:\n>\n> * Off - no HDR processing at all.\n> * MultiExposure - frames at multiple different exposures are combined\n> to create HDR images.\n> * SingleExposure - multiple frames all at the same exposure are\n> combined to create HDR images.\n> * Night - multiple frames will be combined to create \"night mode\"\n> images.\n>\n> Signed-off-by: David Plowman \n> Reviewed-by: Naushir Patuck \n> ---\n> src/libcamera/control_ids.yaml | 55 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 55 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index f2e542f4..0b4e2462 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -774,6 +774,61 @@ controls:\n> Continuous AF is paused. No further state changes or lens movements\n> will occur until the AfPauseResume control is sent.\n>\n> + - HdrMode:\n> + type: int32_t\n> + description: |\n> + Control to set the mode to be used for High Dynamic Range (HDR)\n> + imaging.\n> +\n> + enum:\n> + - name: HdrModeOff\n> + value: 0\n> + description: |\n> + HDR is not enabled.\n> + - name: HdrModeMultiExposure\n> + value: 1\n> + description: |\n> + Multiple exposures will be used to create HDR images.\n> + - name: HdrModeSingleExposure\n> + value: 2\n> + description: |\n> + Multiple frames all at a single exposure will be used to create HDR\n> + images.\n> + - name: HdrModeNight\n> + value: 3\n> + description: |\n> + Multiple frames will be combined to produce \"night mode\" images.\n> +\n> + - HdrChannel:\n> + type: int32_t\n> + description: |\n> + This value is reported back to the application so that it can discover\n> + whether this capture corresponds to the short or long exposure image (or\n> + any other image used by the HDR procedure).\n> +\n> + enum:\n> + - name: HdrChannelNone\n> + value: 0\n> + description: |\n> + This image does not correspond to any of the captures used to create\n> + an HDR image.\n> + - name: HdrChannelShort\n> + value: 1\n> + description: |\n> + This is a short exposure image.\n> + - name: HdrChannelMedium\n> + value: 2\n> + description: |\n> + This is a medium exposure image.\n> + - name: HdrChannelLong\n> + value: 3\n> + description: |\n> + This is a long exposure image.\n> + - name: HdrChannel Night\n\ns/HdrChannel Night/HdrChannelNight/\n\nThanks!\nDavid\n\n> + value: 4\n> + description: |\n> + This frame has been used to produce a \"night mode\" image.\n> +\n> # ----------------------------------------------------------------------------\n> # Draft controls section\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0769BD808\n\tfor ;\n\tThu, 28 Sep 2023 14:21:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E52BA62963;\n\tThu, 28 Sep 2023 16:21:16 +0200 (CEST)","from mail-qt1-x830.google.com (mail-qt1-x830.google.com\n\t[IPv6:2607:f8b0:4864:20::830])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8048661DE3\n\tfor ;\n\tThu, 28 Sep 2023 16:21:15 +0200 (CEST)","by mail-qt1-x830.google.com with SMTP id\n\td75a77b69052e-4181f8d82b9so44920701cf.0\n\tfor ;\n\tThu, 28 Sep 2023 07:21:15 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695910876;\n\tbh=R3Gs7UuM6d5KK4KssQWCrWl5EmOgIODwmnHSbkfz+24=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=TpwJyL1WW5g+LGJ71FPNcazT3HF4Mzd6mGbEfgI4+HoZJg5OhJdcGXHFjO2MWrMP6\n\tiyGs3oTai0aYL6j1eHmxwOT54On//sHEkgWrBiTmTnE/56NC83Kw/o4FltdFGvMdJi\n\tt2qViiIjSyG5+RCmesdOVFWNyDOYxJxkoVqQFZmyz14GhX1U82LbuwdNPWxgFogn2v\n\taJAjf4mCeGmKtRyhKYY/n4FOkYnwKfShWXCTX6e6g8aB757+J5tqv4pxjtaNPs5/vC\n\tBeQSuoW4Z5Z5pQ49Luq21CGy/luLJ7HJthpk3yEjEJGGruMJ4+/cZUD8KiUAYSufdP\n\tedu40JDsW6MJA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695910874; x=1696515674;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ecW4OtW2QQjjikqLPtPRaxtZ46K4IGoAZADTRuysiTY=;\n\tb=OaSgpok9qW5TgB8Uu8vgzEf51W9lj+oew7Q7yRgnU1/Q05sZPNWzdv6+cl2AzfCm39\n\tgtGWMNn8XS7DZXVgvpR8YCwquRsshSDOJ5/JqCtB+K8ppQOMDOr8ZFyZ4yfGRbOoSlqK\n\t/QVtGj9wCBqKGZa2Njq/0TvPVFeZH/PCS6HKS2uuI9RTx4zEFaO3EcD2YZG4GKcjGfqn\n\t+oaKFaDX1rw6EgWuTjhOxvXCVv7D/06uIypzAOCyv2arPJVK1UpBw5JonFIJxgHbdStu\n\tR0Uh8ewqepkUpDXhD8wxBnQE8uG1auox0gKKomrkW4qXG8nuSdXZTX8odPI/AWsWMN4c\n\t8IRQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"OaSgpok9\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695910874; x=1696515674;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ecW4OtW2QQjjikqLPtPRaxtZ46K4IGoAZADTRuysiTY=;\n\tb=t+L2qFmauDNm1iJvdeAIhOU2GlXE0pqNO0VI0ukYrs6/0AERdwKqn9PCLKZEowezDd\n\ttfkPzqIXtbT+rOVYOGj4S6WL/RVqKLGnxJFUqDrv+PL85gO86WdubPsx9h02ru7S1Kc+\n\t9ysBGAU7Fg3VQIGwSetM24aglT29nvSwf/Ybjgw0HkJALSttthDBpT67kd7OBKsdmH7p\n\tegwz+FA7tKrIVcgL+lMedJL094wUVuo+0lzxHqALZiVNjmf5Jb54Zlt1seUL8k9XXFng\n\tsHOxEvms3Kr/Mojjkf21KL88CZBxUBCO9B8h48NHzFeY2pTv4FZDJwqYAXO2pFNXJRmS\n\tA+wA==","X-Gm-Message-State":"AOJu0YxkwT2YoB3xnn5N3rqdVKFPjVio8Cudl4o1xsY9+yi6+31gBO/l\n\t4qpUtuZFkIORQM7KjKf2f1P3KQ8slPHOF6HGXLCGRJ+K07i68aRBi8M=","X-Google-Smtp-Source":"AGHT+IGQ3YZ1BKTh35r4+aR+yK61JT03V5ZHA/XmHx9vMLJ5H6bzqHL0io1hpmip3ojR8EfKcbll3W+iFHlSf6kB6Kk=","X-Received":"by 2002:ac8:5c15:0:b0:410:9af1:f9b2 with SMTP id\n\ti21-20020ac85c15000000b004109af1f9b2mr1540226qti.3.1695910873969;\n\tThu, 28 Sep 2023 07:21:13 -0700 (PDT)","MIME-Version":"1.0","References":"<20230925092136.51550-1-david.plowman@raspberrypi.com>\n\t<20230925092136.51550-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20230925092136.51550-2-david.plowman@raspberrypi.com>","Date":"Thu, 28 Sep 2023 15:21:02 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 1/1] libcamera: controls: Add\n\tcontrols for HDR","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]