[{"id":27862,"web_url":"https://patchwork.libcamera.org/comment/27862/","msgid":"<20230924155359.GC13101@pendragon.ideasonboard.com>","date":"2023-09-24T15:53:59","subject":"Re: [libcamera-devel] [PATCH v3 2/4] android: Import\n\tGraphicBufferAllocator header from vndk v33","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Mattijs,\n\nThank you for the patch.\n\nOn Sat, Sep 23, 2023 at 06:23:32PM +0200, Mattijs Korpershoek via libcamera-devel wrote:\n> The GraphicBufferAllocator class (from libui) provides a more modern interface\n> to Android buffer allocation.\n> \n> Moreover, the gralloc.h API has been deprecated since Android P (9).\n> \n> Import the GraphicBufferAllocator.h from the VNDK.\n> \n> These have been imported from:\n> URL: https://android.googlesource.com/platform/prebuilts/vndk/v33/\n> rev: 390028a9da88 (\"Update VNDK snapshot v33 to build 9948968. am: 3042508aee am: 7092391a46\")\n\nSame comments as for patch 1/4.\n\n> No changes have been made to the files, besides adding the SPDX comment.\n> \n> Note: because GraphicBufferAllocator has lots of Android-specific dependencies,\n> a future patch is needed to stub/simplify this include.\n\nI fear we'll soon reach a point where it won't be possible anymore to\ncompile-test this code without a full VNDK. We'll see.\n\n> Signed-off-by: Mattijs Korpershoek \n> ---\n> .../libs/ui/include/ui/GraphicBufferAllocator.h | 111 +++++++++++++++++++++\n> 1 file changed, 111 insertions(+)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F35DC326B\n\tfor ;\n\tSun, 24 Sep 2023 15:53:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 888C562945;\n\tSun, 24 Sep 2023 17:53:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 801F062931\n\tfor ;\n\tSun, 24 Sep 2023 17:53:48 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B209A475;\n\tSun, 24 Sep 2023 17:52:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695570829;\n\tbh=jlTVzc3amPjd2THC1TRurUW6hhnnjwmBBAgb57XBoNM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2do2QRytz/l2tWyx1UdIQXUNiVWmxZ2hMhvaTU3Ni13yJsvXE0dyXAa1k/hkOAApD\n\th9NqQ3G6eROCAC2SCEOiqNi2CP7pL4XPA7pxRFH2Wuk9kKfeY9pPF2hK5iIkwCjr1W\n\toQzBvR1tQhp0YItUvO2VWbnpaRJ/pO2HXl05tp10QIozcYNnXfLZyHGYaXsw/il18x\n\tkVt9N8x8MFJWd9DkBLCMzvA21jDtQ1DWsC0eOHhAhFJ1YQKvu02LXAB4ax1Ji0FE3r\n\tKYnTzUqya2NTfPaeCEciTBR6YZQjGNPVqgWioz2avsgq+u2aQg53S0A/TecSFKZjtC\n\t6qEGH/mWlKwCA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695570728;\n\tbh=jlTVzc3amPjd2THC1TRurUW6hhnnjwmBBAgb57XBoNM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BZs/+FFnAXr7LEB42s+CzeUhjuQ5Zexg7LTjR77TMqTZ1fyeqbBTSLIPvrepbGP49\n\tAY51zzuwzEzyJSEWLZhtmSqAxf45dQNZR3ofvaV6IokzUoKiS5Qnypza4cw1wxXROW\n\t1UG4dEG9B0AZAwO3ddK5rLQhBL1c4WJpmSNFMxxY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BZs/+FFn\"; dkim-atps=neutral","Date":"Sun, 24 Sep 2023 18:53:59 +0300","To":"Mattijs Korpershoek ","Message-ID":"<20230924155359.GC13101@pendragon.ideasonboard.com>","References":"<20230923-gralloc-api-v4-v3-0-9a9e039284ba@baylibre.com>\n\t<20230923-gralloc-api-v4-v3-2-9a9e039284ba@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230923-gralloc-api-v4-v3-2-9a9e039284ba@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] android: Import\n\tGraphicBufferAllocator header from vndk v33","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tGuillaume La Roque ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27905,"web_url":"https://patchwork.libcamera.org/comment/27905/","msgid":"<87r0mg2j0r.fsf@baylibre.com>","date":"2023-09-30T07:54:28","subject":"Re: [libcamera-devel] [PATCH v3 2/4] android: Import\n\tGraphicBufferAllocator header from vndk v33","submitter":{"id":153,"url":"https://patchwork.libcamera.org/api/people/153/","name":"Mattijs Korpershoek","email":"mkorpershoek@baylibre.com"},"content":"Hi Laurent,\n\nThank you for your review.\n\nOn dim., sept. 24, 2023 at 18:53, Laurent Pinchart wrote:\n\n> Hi Mattijs,\n>\n> Thank you for the patch.\n>\n> On Sat, Sep 23, 2023 at 06:23:32PM +0200, Mattijs Korpershoek via libcamera-devel wrote:\n>> The GraphicBufferAllocator class (from libui) provides a more modern interface\n>> to Android buffer allocation.\n>> \n>> Moreover, the gralloc.h API has been deprecated since Android P (9).\n>> \n>> Import the GraphicBufferAllocator.h from the VNDK.\n>> \n>> These have been imported from:\n>> URL: https://android.googlesource.com/platform/prebuilts/vndk/v33/\n>> rev: 390028a9da88 (\"Update VNDK snapshot v33 to build 9948968. am: 3042508aee am: 7092391a46\")\n>\n> Same comments as for patch 1/4.\n\nACK.\n\n>\n>> No changes have been made to the files, besides adding the SPDX comment.\n>> \n>> Note: because GraphicBufferAllocator has lots of Android-specific dependencies,\n>> a future patch is needed to stub/simplify this include.\n>\n> I fear we'll soon reach a point where it won't be possible anymore to\n> compile-test this code without a full VNDK. We'll see.\n\nThat's possible indeed. I think it would be really nice to enable\nNDK/VNDK based builds as standalone but doing that and documenting it is\na bit out of scope for this series, imho.\n\nI will investigate building with NDK/VNDK again in the coming month.\n\n>\n>> Signed-off-by: Mattijs Korpershoek \n>> ---\n>> .../libs/ui/include/ui/GraphicBufferAllocator.h | 111 +++++++++++++++++++++\n>> 1 file changed, 111 insertions(+)\n>\n> -- \n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD178BD808\n\tfor ;\n\tSat, 30 Sep 2023 07:54:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 35EA562963;\n\tSat, 30 Sep 2023 09:54:35 +0200 (CEST)","from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6025C6295E\n\tfor ;\n\tSat, 30 Sep 2023 09:54:33 +0200 (CEST)","by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-405524e6768so127992595e9.2\n\tfor ;\n\tSat, 30 Sep 2023 00:54:33 -0700 (PDT)","from localhost ([89.207.171.79]) by smtp.gmail.com with ESMTPSA id\n\tm24-20020a7bca58000000b004063977eccesm2850623wml.42.2023.09.30.00.54.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 30 Sep 2023 00:54:32 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696060475;\n\tbh=DSWf9okdg1VVX5qbaObQY54XAWo4S+L/Vk9568K5KbM=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=FWDqx+3NVgL4Pr8NIvNDrCYK+WxccItEp6KlWs17lYutnmvizwkNu5kyyrt+gPRx3\n\tQWHUQhrEgUpXvB3T0mkMxV/rUuPgSkQwq9qxg8xOhwhjGb9cUO7pU5pM61GsM3vne8\n\tQJs5GFJb8EBC7/qDiWEDH0zSZTdVZW7efISZ+b8vG7nytK7wmoxKVv4l2tOrG2RzJr\n\tivvb08PfwyJ+IhFVnaRvDeUUlK0PA/Zy9BnyPHnT9SdkrYSBspHPwb/34q99WuqUaW\n\ta9qL6bsiOCc6W896kvDpv48cTgChfaI/F2I/sFZrYhdw/h402pr3k+d7eJjHwwgG02\n\tIavtOBuX/bPEQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1696060473;\n\tx=1696665273; darn=lists.libcamera.org; \n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=AHrpQMawQbINrIYClM3FuVHnaKH+P/jZKcyKVsY1XEE=;\n\tb=zu7U4VGpcbLx5vd5Mx0+etFR1ufoVpJsLvpxu2NSKRNwwEy96rNm+Irob+VOIZ3pMa\n\tQUjfPCmPk/Aq7PVNqUX3cDax9fj1R2RNOqfVBgd8ia7XRIvdt0Bsg1ovHqKMyTrsIS5n\n\t2yJzSP1yeEJLv8jXPhTnh9qJldXUJoEtnrs3j83uV0u34lKIWleXK6dAz1dPfxl6ef51\n\tpQKWZlPqif4dTFJZtbnhqbnCjY1sZC32mzZ32GfussEEc4e8bLoK3woIOimkkdYsup6B\n\tslznFHk24Vqf4t5/kKLnGsnihpuaqC+qX3oKo+JjRUprGvZCNTfFJ4beziNlsr4S/pld\n\towog=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20230601.gappssmtp.com\n\theader.i=@baylibre-com.20230601.gappssmtp.com header.b=\"zu7U4VGp\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1696060473; x=1696665273;\n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; \n\tbh=AHrpQMawQbINrIYClM3FuVHnaKH+P/jZKcyKVsY1XEE=;\n\tb=h/VNHqmf9f6PmqqFPHv+n3DtdmSLb75iU9YxbkTkZSmJnHjWUYw81aAxwYm0ZLhvTV\n\tGf8Nkt3HjiBrzOQjwcANm3eIbGQ15xwuXnqY9Cg25y2ppT1P8zbAeROFaieLP/gNzzbs\n\tq8qB0/PonAkmRi1npw/+Xt9uDnH7NbTr7LBsLqr5V8OQWyj5AhDLdfs75iUaAILmuX4h\n\tahgzSJzylkTcXRnxEQdx3yzwSoTOja16q+H3FMFiiubO/L7QxDo7UWfwWqbby8N9NWls\n\tX0T4AxUoV7llKnI7QdtsvAjA6ByQ7+2BpTSTny0WhrYF+Gqo0+sWtobYADfjK3QRgzPx\n\tdkCg==","X-Gm-Message-State":"AOJu0YxqhfguXj1HZ9duYZQVF21nLWVvcVcU+L2D8N1y2lTRU42VARFb\n\tqRT3vSDkQldylP3FgJj1JWdpuA==","X-Google-Smtp-Source":"AGHT+IHoFZRtVT+GcPh54j4RwRSm+1CvgNNEo9842C/I/t4UEPD4/Kk5UI1W2BJqwmv+qm3ey/+N6A==","X-Received":"by 2002:a05:600c:2315:b0:403:b6bc:d90d with SMTP id\n\t21-20020a05600c231500b00403b6bcd90dmr6089548wmo.20.1696060472870; \n\tSat, 30 Sep 2023 00:54:32 -0700 (PDT)","To":"Laurent Pinchart ","In-Reply-To":"<20230924155359.GC13101@pendragon.ideasonboard.com>","References":"<20230923-gralloc-api-v4-v3-0-9a9e039284ba@baylibre.com>\n\t<20230923-gralloc-api-v4-v3-2-9a9e039284ba@baylibre.com>\n\t<20230924155359.GC13101@pendragon.ideasonboard.com>","Date":"Sat, 30 Sep 2023 09:54:28 +0200","Message-ID":"<87r0mg2j0r.fsf@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] android: Import\n\tGraphicBufferAllocator header from vndk v33","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mattijs Korpershoek via libcamera-devel\n\t","Reply-To":"Mattijs Korpershoek ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tGuillaume La Roque ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27918,"web_url":"https://patchwork.libcamera.org/comment/27918/","msgid":"<20230930130726.GC31829@pendragon.ideasonboard.com>","date":"2023-09-30T13:07:26","subject":"Re: [libcamera-devel] [PATCH v3 2/4] android: Import\n\tGraphicBufferAllocator header from vndk v33","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Mattijs,\n\nOn Sat, Sep 30, 2023 at 09:54:28AM +0200, Mattijs Korpershoek wrote:\n> On dim., sept. 24, 2023 at 18:53, Laurent Pinchart wrote:\n> > On Sat, Sep 23, 2023 at 06:23:32PM +0200, Mattijs Korpershoek via libcamera-devel wrote:\n> >> The GraphicBufferAllocator class (from libui) provides a more modern interface\n> >> to Android buffer allocation.\n> >> \n> >> Moreover, the gralloc.h API has been deprecated since Android P (9).\n> >> \n> >> Import the GraphicBufferAllocator.h from the VNDK.\n> >> \n> >> These have been imported from:\n> >> URL: https://android.googlesource.com/platform/prebuilts/vndk/v33/\n> >> rev: 390028a9da88 (\"Update VNDK snapshot v33 to build 9948968. am: 3042508aee am: 7092391a46\")\n> >\n> > Same comments as for patch 1/4.\n> \n> ACK.\n> \n> >> No changes have been made to the files, besides adding the SPDX comment.\n> >> \n> >> Note: because GraphicBufferAllocator has lots of Android-specific dependencies,\n> >> a future patch is needed to stub/simplify this include.\n> >\n> > I fear we'll soon reach a point where it won't be possible anymore to\n> > compile-test this code without a full VNDK. We'll see.\n> \n> That's possible indeed. I think it would be really nice to enable\n> NDK/VNDK based builds as standalone but doing that and documenting it is\n> a bit out of scope for this series, imho.\n> \n> I will investigate building with NDK/VNDK again in the coming month.\n\nThat's very appreciated, thank you. Jacopo will appreciate it too :-)\n\n> >> Signed-off-by: Mattijs Korpershoek \n> >> ---\n> >> .../libs/ui/include/ui/GraphicBufferAllocator.h | 111 +++++++++++++++++++++\n> >> 1 file changed, 111 insertions(+)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5CD59BD808\n\tfor ;\n\tSat, 30 Sep 2023 13:07:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 027B362963;\n\tSat, 30 Sep 2023 15:07:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC83F61DE1\n\tfor ;\n\tSat, 30 Sep 2023 15:07:15 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(lfbn-idf1-1-343-200.w86-195.abo.wanadoo.fr [86.195.61.200])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6CF68DD9;\n\tSat, 30 Sep 2023 15:05:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696079237;\n\tbh=Fms1ofzNOSB3WOgA7t8fpIrfooAH3RiBTF6uMOORrT0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=hIl2JFR8/sfSxl8t9pEFuQd4RqfW6PYxO9d/cJ06iJ5pQ6evIt4wY6hOx49GMoRIz\n\tUWcLYW+nPtQe3KLUnJCOgVgocTgfnLQDmLuIT0nyFSRlkKIbNvKBgY06NDCJcTSZXV\n\tUntte0vBeBDFfIyydo/4xpHpu8wIFuKFa+i4qxsHBc8wVdFmQpVIBd4WxASnyqmDmI\n\t2z2KUWIARUsaStN8CFz1LifG4XpljTPYrfeUVEQhk0YRHVq1ULEec55ofMWVkqg1Qj\n\tuUOFUIPT6CuTUwFOf/00MQh/wGTHD+rIQlQks/rE/tRA49Qid4+Eq1F6xK0wSWk2Z6\n\tAGIIJCRfu018A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1696079132;\n\tbh=Fms1ofzNOSB3WOgA7t8fpIrfooAH3RiBTF6uMOORrT0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C32wvm4j3+59nkveIrsqOGXgRWGENQ5QCBS5tSE0Fi31aft9N3shctO45ZeVf3Po6\n\tc0SgPKn6+4pAjz1RFT9qAst3E74QfvEKKhOqOu00PKh4ERBjRjEuPhg+MLTHxC6L8u\n\ttoCkIUZM8fBRgSCd8/GFgj4djM+ZVpFUcyVgTMm4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"C32wvm4j\"; dkim-atps=neutral","Date":"Sat, 30 Sep 2023 16:07:26 +0300","To":"Mattijs Korpershoek ","Message-ID":"<20230930130726.GC31829@pendragon.ideasonboard.com>","References":"<20230923-gralloc-api-v4-v3-0-9a9e039284ba@baylibre.com>\n\t<20230923-gralloc-api-v4-v3-2-9a9e039284ba@baylibre.com>\n\t<20230924155359.GC13101@pendragon.ideasonboard.com>\n\t<87r0mg2j0r.fsf@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<87r0mg2j0r.fsf@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH v3 2/4] android: Import\n\tGraphicBufferAllocator header from vndk v33","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tGuillaume La Roque ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]