[{"id":27861,"web_url":"https://patchwork.libcamera.org/comment/27861/","msgid":"<20230924155115.GB13101@pendragon.ideasonboard.com>","date":"2023-09-24T15:51:15","subject":"Re: [libcamera-devel] [PATCH v3 1/4] android: Import libutils/libui\n\theaders from vndk v33","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Mattijs,\n\nThank you for the patch.\n\nOn Sat, Sep 23, 2023 at 06:23:31PM +0200, Mattijs Korpershoek via libcamera-devel wrote:\n> In order to switch to the more modern GraphicBufferAllocator class, we need\n> additional compile-time dependencies.\n> \n> Import all the needed headers from the Android Vendor Native Development\n> Kit (vndk) and add them to the android_includes.\n> \n> These have been imported from:\n> URL: https://android.googlesource.com/platform/prebuilts/vndk/v33/\n\nThis doesn't look like the upstream for those files, it's a prebuild\nrepository for binaries, with header files that are regularly imported\nfrom upstream. for frameworks/native the upstream seems to be\nhttps://android.googlesource.com/platform/frameworks/native/, while for\nsystem/core it seems to be\nhttps://android.googlesource.com/platform/system/core/.\n\nIf we import files from those repositories, I think we should update the\nheaders already included in libcamera to the same version. Mixing two\nversions seems dangerous.\n\n> rev: 390028a9da88 (\"Update VNDK snapshot v33 to build 9948968. am: 3042508aee am: 7092391a46\")\n\nWould it make sense to go for a tagged release instead of the latest\ncommit in the main branch ?\n\n> No changes have been made to the files, besides adding the SPDX comment.\n> \n> Signed-off-by: Mattijs Korpershoek \n> ---\n> .../native/libs/ui/include/ui/PixelFormat.h | 75 +++++++\n> include/android/meson.build | 2 +\n> .../system/core/libutils/include/utils/Compat.h | 94 +++++++++\n> .../system/core/libutils/include/utils/Errors.h | 78 ++++++++\n> .../system/core/libutils/include/utils/Mutex.h | 219 +++++++++++++++++++++\n> .../system/core/libutils/include/utils/Singleton.h | 102 ++++++++++\n> .../system/core/libutils/include/utils/Timers.h | 103 ++++++++++\n> 7 files changed, 673 insertions(+)\n\n[snip]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7F2A7C326B\n\tfor ;\n\tSun, 24 Sep 2023 15:51:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBEDC62931;\n\tSun, 24 Sep 2023 17:51:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 41F6A62916\n\tfor ;\n\tSun, 24 Sep 2023 17:51:04 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FF7B475;\n\tSun, 24 Sep 2023 17:49:24 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695570665;\n\tbh=YVa5hyPhqj57aqnw7fPe3TJgxYMb7vDZxo/6StGa9Jg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=NiETVqQLYgzCYiC/JlpYxfW3CapkH4Et+4Je74+8V5MVPbYbSg0ri567eBg5KSbAP\n\tnjXgqX6gkBRIgR4+tHovGFxy6aEeslCo1w/7IWMBSGytAUINAPC2KuK5G988YajIdj\n\tSLkLxPCi+lPh2URHsE9D/D+S3eY+jy+7cHiWoOoQlw6gp6mcJLZg1FJH7pmFmmmI+K\n\t5oaZs1icb3ip8bpdlOHMjENDvodnY14KOdcOa1GyTj/9gwH+VKOF2TN7MG3CCtTDP7\n\tobnAXKcgJkvRABRbgq/IkjgvBvPbOe+uCDt/fT0F752vAf/Ox41TX0F8AW7VsStym7\n\tPSiSvbeYiJfrA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695570564;\n\tbh=YVa5hyPhqj57aqnw7fPe3TJgxYMb7vDZxo/6StGa9Jg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uslLUDwSB8mqqzBfeJT8Qzq1QAPdXlnCbbdUDRwJxP4R6MPxJPxAGeJS2e39at3tm\n\tvblCtOZPV9Yp7arMD/B2MTPBvcFmKnTtnHEkGQCv/5PFcqlzgclFp8y3CBoJN1PAYs\n\thPEKnD6eLXx6oPpAzi+NMfG+/oMWpz6bnjlVGgVE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uslLUDwS\"; dkim-atps=neutral","Date":"Sun, 24 Sep 2023 18:51:15 +0300","To":"Mattijs Korpershoek ","Message-ID":"<20230924155115.GB13101@pendragon.ideasonboard.com>","References":"<20230923-gralloc-api-v4-v3-0-9a9e039284ba@baylibre.com>\n\t<20230923-gralloc-api-v4-v3-1-9a9e039284ba@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230923-gralloc-api-v4-v3-1-9a9e039284ba@baylibre.com>","Subject":"Re: [libcamera-devel] [PATCH v3 1/4] android: Import libutils/libui\n\theaders from vndk v33","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tGuillaume La Roque ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27904,"web_url":"https://patchwork.libcamera.org/comment/27904/","msgid":"<87ttrc2j59.fsf@baylibre.com>","date":"2023-09-30T07:51:46","subject":"Re: [libcamera-devel] [PATCH v3 1/4] android: Import libutils/libui\n\theaders from vndk v33","submitter":{"id":153,"url":"https://patchwork.libcamera.org/api/people/153/","name":"Mattijs Korpershoek","email":"mkorpershoek@baylibre.com"},"content":"Hi Laurent,\n\nThank you for your review.\n\nOn dim., sept. 24, 2023 at 18:51, Laurent Pinchart wrote:\n\n> Hi Mattijs,\n>\n> Thank you for the patch.\n>\n> On Sat, Sep 23, 2023 at 06:23:31PM +0200, Mattijs Korpershoek via libcamera-devel wrote:\n>> In order to switch to the more modern GraphicBufferAllocator class, we need\n>> additional compile-time dependencies.\n>> \n>> Import all the needed headers from the Android Vendor Native Development\n>> Kit (vndk) and add them to the android_includes.\n>> \n>> These have been imported from:\n>> URL: https://android.googlesource.com/platform/prebuilts/vndk/v33/\n>\n> This doesn't look like the upstream for those files, it's a prebuild\n> repository for binaries, with header files that are regularly imported\n> from upstream. for frameworks/native the upstream seems to be\n> https://android.googlesource.com/platform/frameworks/native/, while for\n> system/core it seems to be\n> https://android.googlesource.com/platform/system/core/.\n\nThat's correct, and intentional. The vndk is known to provide stable\nheaders. However the VND and the NDK might be different versions.\n\n>\n> If we import files from those repositories, I think we should update the\n> headers already included in libcamera to the same version. Mixing two\n> versions seems dangerous.\n\nIndeed\n\n>\n>> rev: 390028a9da88 (\"Update VNDK snapshot v33 to build 9948968. am: 3042508aee am: 7092391a46\")\n>\n> Would it make sense to go for a tagged release instead of the latest\n> commit in the main branch ?\n\nYes it makes sense. I will either pick a tag from source or a release\nversion of the NDK.\nI will add a first commit to update all existing headers to that known version.\n\nThen I will add these headers here.\n\n>\n>> No changes have been made to the files, besides adding the SPDX comment.\n>> \n>> Signed-off-by: Mattijs Korpershoek \n>> ---\n>> .../native/libs/ui/include/ui/PixelFormat.h | 75 +++++++\n>> include/android/meson.build | 2 +\n>> .../system/core/libutils/include/utils/Compat.h | 94 +++++++++\n>> .../system/core/libutils/include/utils/Errors.h | 78 ++++++++\n>> .../system/core/libutils/include/utils/Mutex.h | 219 +++++++++++++++++++++\n>> .../system/core/libutils/include/utils/Singleton.h | 102 ++++++++++\n>> .../system/core/libutils/include/utils/Timers.h | 103 ++++++++++\n>> 7 files changed, 673 insertions(+)\n>\n> [snip]\n>\n> -- \n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 34697BD808\n\tfor ;\n\tSat, 30 Sep 2023 07:51:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75D0762963;\n\tSat, 30 Sep 2023 09:51:55 +0200 (CEST)","from mail-wm1-x329.google.com (mail-wm1-x329.google.com\n\t[IPv6:2a00:1450:4864:20::329])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C18E6295E\n\tfor ;\n\tSat, 30 Sep 2023 09:51:53 +0200 (CEST)","by mail-wm1-x329.google.com with SMTP id\n\t5b1f17b1804b1-4066692ad35so2362415e9.1\n\tfor ;\n\tSat, 30 Sep 2023 00:51:52 -0700 (PDT)","from localhost ([89.207.171.79]) by smtp.gmail.com with ESMTPSA id\n\tt9-20020a7bc3c9000000b003feae747ff2sm2828616wmj.35.2023.09.30.00.51.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 30 Sep 2023 00:51:52 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1696060315;\n\tbh=2uN/MWtk98BBDJIjiR+QNPYrAm/eAF4WKZj7UUHeukU=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cq/lFk9SNvxfekZILtfW8cUESKnBlu60F8qSiGNDqZOY/k0iY9c/G0R9To/95X2Cv\n\txnvTF5I9HWdz9VWU3o02Mri2vxjusj5BYQ9Cm1rvaqwqOW6DcJpM4CudA7HpqEHKEQ\n\t95R9clplBSiWH6ODo0ASizYvMshd4QOpUvWBSGY+DL6oM7TKBIs6GAdpiS2Fru4SA3\n\tqmTMSXgJd1dPD4HSIVQxfqWwunRVEEXXuWtzcv5zObm5CWYGQ6+/MyAW5sGCb5ox/p\n\t0WPaIsPXI1Rjrj7HzCsRyANSCMHXxbsyfIG+DbGlz2n/GqJZE4TYK5VE8S9S8mUocW\n\tmVoYgWajQF4HA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1696060312;\n\tx=1696665112; darn=lists.libcamera.org; \n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=T1hY8W5ODWwU+MHmqk8pNv4ccjbufoqHkGKE0VNi4dI=;\n\tb=Huy/FK+ccum9U0fjG+6E1FbxLpk+LUGDTAYfy+FtmknRB5lLM6t2Yx8mgPQEY3kR7J\n\tktn88gw39IEhZMdzTrQKTWIi+4IaGtdK6/u8YEibyRLRZVRLVf68g+7oJQpNS3cCJ4Q0\n\tU5ZJDl7SaVbQFYxXaNHC92o13RJUKBX/68Nc1JOqmpMpyecdY7OFtkH/uDU9TmXf0Gbh\n\tLoS+utz10ByFLZ5S1mYTjiAUw8ZqvjHEA2BiB3Te4BidSnd9Dl3erWJzfZ5ZkxpK2q9u\n\tmXWtSgLB1DV3Tg4MRju9CbZpeieCFhyrEZthYw7lLg3+GIq1uI0AQ2T6thHXg3QTWgkc\n\trbgA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20230601.gappssmtp.com\n\theader.i=@baylibre-com.20230601.gappssmtp.com header.b=\"Huy/FK+c\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1696060312; x=1696665112;\n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; \n\tbh=T1hY8W5ODWwU+MHmqk8pNv4ccjbufoqHkGKE0VNi4dI=;\n\tb=NikOV1UeXLa4qlieR5iQLi7mnrSj9BvnpzxzG1n4CZhZfWZMqiuqRoduCF3yhwRwxp\n\tjn8ZjeoJ4rGantwvlChjMFakgQzfQUXQwfZ1P7UMm3ce6RLsg7kKfZhNaBAV+/s3BuDr\n\tokidfCWMyyb8KvTBAJ3npMqmE2cMjeJmtDr0QqD4Xqgdfx+sHCbz2vlFQKTqRyaHJLQM\n\tkxIPpimpEvKkWJo8cf4DwPAISsBDeYsWEA2rDvO0auFCBFt03LCtCWYB0EPdWbvyQehZ\n\tzj+ahiBPTqm0YNK+h3iP0G3n7O9fdZOCLFlfTpMQt+yYuVXWtUeDWrxyjIOzzC71Tpq/\n\tEyOA==","X-Gm-Message-State":"AOJu0YxYKqc8dLvSAGHxPakpcPuqJllSqK7BFVHncCD2PImKAJkAG86u\n\tC5Y110ZmQrhiFS7fsomQ9RL0Ww==","X-Google-Smtp-Source":"AGHT+IHfkRsUrfKDcZQ+iqK5HO3xV+IJn0ds5j0n/xc4EFLjxlXKkPGDl73YqeW30XFH/Sk+IY8iVw==","X-Received":"by 2002:a7b:ce89:0:b0:406:44e6:c00d with SMTP id\n\tq9-20020a7bce89000000b0040644e6c00dmr5808801wmj.2.1696060312526; \n\tSat, 30 Sep 2023 00:51:52 -0700 (PDT)","To":"Laurent Pinchart ","In-Reply-To":"<20230924155115.GB13101@pendragon.ideasonboard.com>","References":"<20230923-gralloc-api-v4-v3-0-9a9e039284ba@baylibre.com>\n\t<20230923-gralloc-api-v4-v3-1-9a9e039284ba@baylibre.com>\n\t<20230924155115.GB13101@pendragon.ideasonboard.com>","Date":"Sat, 30 Sep 2023 09:51:46 +0200","Message-ID":"<87ttrc2j59.fsf@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH v3 1/4] android: Import libutils/libui\n\theaders from vndk v33","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mattijs Korpershoek via libcamera-devel\n\t","Reply-To":"Mattijs Korpershoek ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org,\n\tGuillaume La Roque ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]