[{"id":27895,"web_url":"https://patchwork.libcamera.org/comment/27895/","msgid":"<20230926225151.GA15901@pendragon.ideasonboard.com>","date":"2023-09-26T22:51:51","subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Thu, Sep 21, 2023 at 06:55:48PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> From: Naushir Patuck \n> \n> Switch to XRGB8888 as a default Viewfinder role output format, and\n> YUV420 as a default output format for everything else.\n\nThe commit message should explain *why* those formats are better.\n\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Jacopo Mondi \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> index c560e48c12fb..f8e8e13dc837 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> @@ -268,7 +268,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> \n> \t\tif (fmts.find(out.dev->toV4L2PixelFormat(cfgPixFmt)) == fmts.end()) {\n> \t\t\t/* If we cannot find a native format, use a default one. */\n> -\t\t\tcfgPixFmt = formats::NV12;\n> +\t\t\tcfgPixFmt = formats::YUV420;\n> \t\t\tstatus = Adjusted;\n> \t\t}\n> \n> @@ -431,7 +431,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span \n> \t\tcase StreamRole::StillCapture:\n> \t\t\tfmts = data->ispFormats();\n> -\t\t\tpixelFormat = formats::NV12;\n> +\t\t\tpixelFormat = formats::YUV420;\n> \t\t\t/*\n> \t\t\t * Still image codecs usually expect the sYCC color space.\n> \t\t\t * Even RGB codecs will be fine as the RGB we get with the\n> @@ -465,7 +465,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span \n> \t\tcase StreamRole::Viewfinder:\n> \t\t\tfmts = data->ispFormats();\n> -\t\t\tpixelFormat = formats::ARGB8888;\n> +\t\t\tpixelFormat = formats::XRGB8888;\n> \t\t\tcolorSpace = ColorSpace::Sycc;\n> \t\t\tsize = { 800, 600 };\n> \t\t\tbufferCount = 4;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C031DC326B\n\tfor ;\n\tTue, 26 Sep 2023 22:51:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0489D62944;\n\tWed, 27 Sep 2023 00:51:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5EB0F628FA\n\tfor ;\n\tWed, 27 Sep 2023 00:51:41 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DEC7113C5;\n\tWed, 27 Sep 2023 00:49:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695768703;\n\tbh=e/Z+USxvoenKiMV9dt5iKEyToyI/55gtBugPlN7kXGA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=YJD6zCHaaipBld1h3oqn02AQz4VkMLlCOJwXUBv85K4uF6+4cWPSyHQ8aOr0XHROZ\n\thE20V0DH4UTLb3AOkGiSEXa1LN/3Jq2s8R4H2h584YLgrEKf+acNTkS7wLs/7Dbhet\n\tMH+/G1k4lQkC+xpGS4BPTkvDZE+m/EDiO6WMaRK/XsJ9RfHjxmzxQXBkHSQ+/OOShv\n\tlF5V3dsfiA34lHhd9l9c80sy3d6cATNcJ6klet0UOhuiJNQyM45OH+VehKisOc0Jc9\n\tTKuiIBcjnr6yV/fIwOX13Jyyt1v+rDHUw9qYCiz4S1mNrT8ZbzYfNlqy92tpqLWoXj\n\tKelPWqq6Nz0KA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695768600;\n\tbh=e/Z+USxvoenKiMV9dt5iKEyToyI/55gtBugPlN7kXGA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M/6j3jwe5UUfnu1QhPApv5cN7MqjhWdna4QxumaY0/+DuetfFwZdtRdPmd7O/6g2M\n\tIqtqmFtIwV5z8Q8IzK6IE3dUBRLrU6uzx9Tf5RfXliSNBZm4QTaWrsnpOj2xYCLnsD\n\tvJaWwyn3+fE0s+hjB02XU2o81BFFqYwRWyY/ClNI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"M/6j3jwe\"; dkim-atps=neutral","Date":"Wed, 27 Sep 2023 01:51:51 +0300","To":"Jacopo Mondi ","Message-ID":"<20230926225151.GA15901@pendragon.ideasonboard.com>","References":"<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>\n\t<20230921165550.50956-12-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230921165550.50956-12-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27896,"web_url":"https://patchwork.libcamera.org/comment/27896/","msgid":"","date":"2023-09-27T07:30:05","subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Tue, 26 Sept 2023 at 23:51, Laurent Pinchart via libcamera-devel\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Thu, Sep 21, 2023 at 06:55:48PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> > From: Naushir Patuck \n> >\n> > Switch to XRGB8888 as a default Viewfinder role output format, and\n> > YUV420 as a default output format for everything else.\n>\n> The commit message should explain *why* those formats are better.\n\nRGB24/32 formats are typically better supported by display pipelines\nthan YUV420. Happy to add this line to the commit message, or can\nthis be done while applying?\n\nRegards,\nNaush\n\n>\n> > Signed-off-by: Naushir Patuck \n> > Reviewed-by: Jacopo Mondi \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > index c560e48c12fb..f8e8e13dc837 100644\n> > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > @@ -268,7 +268,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> >\n> > if (fmts.find(out.dev->toV4L2PixelFormat(cfgPixFmt)) == fmts.end()) {\n> > /* If we cannot find a native format, use a default one. */\n> > - cfgPixFmt = formats::NV12;\n> > + cfgPixFmt = formats::YUV420;\n> > status = Adjusted;\n> > }\n> >\n> > @@ -431,7 +431,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span >\n> > case StreamRole::StillCapture:\n> > fmts = data->ispFormats();\n> > - pixelFormat = formats::NV12;\n> > + pixelFormat = formats::YUV420;\n> > /*\n> > * Still image codecs usually expect the sYCC color space.\n> > * Even RGB codecs will be fine as the RGB we get with the\n> > @@ -465,7 +465,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span >\n> > case StreamRole::Viewfinder:\n> > fmts = data->ispFormats();\n> > - pixelFormat = formats::ARGB8888;\n> > + pixelFormat = formats::XRGB8888;\n> > colorSpace = ColorSpace::Sycc;\n> > size = { 800, 600 };\n> > bufferCount = 4;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F08BBD808\n\tfor ;\n\tWed, 27 Sep 2023 07:30:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55AB562944;\n\tWed, 27 Sep 2023 09:30:44 +0200 (CEST)","from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com\n\t[IPv6:2607:f8b0:4864:20::112c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9908A60374\n\tfor ;\n\tWed, 27 Sep 2023 09:30:42 +0200 (CEST)","by mail-yw1-x112c.google.com with SMTP id\n\t00721157ae682-5a1f00b75aaso19707767b3.2\n\tfor ;\n\tWed, 27 Sep 2023 00:30:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695799844;\n\tbh=1GA6ZhBg9lRATrL+ssFiF16OJhB+dX32VieLZaSKfWo=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=KmlfX7H8l7VWZhxwL68aP/Au2bKiYbZ5n3cmN3o3aU4cd9JEkWq0qNUmghYfBV/Rs\n\t5/56M0i5xgFHSdqxij8E4rDf/WObljeFyDcBQdvWIn5xYQYNkqJZfDLx/wVUqZPkyN\n\t0ghuro6fRlasbwpwXEJ3QsjkVqu0d1ZyXmeWrsFcheQDtjZlUOBNnScJqSM/37Qjjq\n\tYsYj+FDlSuAROnh2MahLgL62AH5+MPolfy7Y97PMxbhUAvcKFtgt/QeY4P129XjCkW\n\t0jRqpjEGnjPWd8RpU/Vk9W3bPdSnM9p19AJYGgHiqjZBjD3przXnZa6ONtpieIqPDa\n\tb3upeHeNNcs0Q==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695799841; x=1696404641;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=YELsJOoTDlnbmrCAWZ0mJoVv1wugruPa5CZoQlXYjlQ=;\n\tb=rmSbjhh7UdD3S4vtSWAXu93GpzwZ5/HP5+2HEX+zgEmN7uL/vEG0QUp6FHlNH8buLG\n\t75pQ8q/MJvnJDbdmu5u4aDfyLv5xxtcJnDkB/VhG7PylOI72JPyOTYknUXldPLEZj991\n\tzpFyVlh2yDELLYhORJ6TPYp4dPgqWsAUv8w9688J5daaOhktCuXaqEHKaJ6/dbjVznBw\n\taVMuNbsHtnxxxZ9WjrY1ZgpDhvPAh75oFdRe6mMaB/rgEeGgQB8wxnZZBeKnlZaxOw2g\n\t9LB5z76A9Fb3FEabmGdXQmnUlqr9o4kBeuXr95/rsDUNkfjaTNKLHQCSftXi8PgXXZwl\n\tHGHw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"rmSbjhh7\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695799841; x=1696404641;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=YELsJOoTDlnbmrCAWZ0mJoVv1wugruPa5CZoQlXYjlQ=;\n\tb=HrlSe3e3c0nXfsxClQlmEA7AicDR7hMQJ63KAwu1PvJz/5iOhnwfu/OyTkLqWXLv3a\n\tJIsA4jkudZfYY5GXRLdxwjXY/SmZdIU/Z9evV0yi5U6SyjqqWdE/xs02ILio6RGq0lrT\n\trwT61N82HemGm75BBQ5lHnnOPVuxz3p2cvivUSwCa/BaZeNW1H76KsN4Wm1838tG1zHj\n\ta7dnleDRrnaOZNFqcqxdZ/gNlBQPRunAn7TZglxrW3Me8ahbTVkRkgc4uTtn9Aaf2FpG\n\tm6AxXdgMaohUhVrS3o0O8P+Jl5F9SGspKLNhSG55hjahS7aYi94K8UBCCltgnbeeHrY1\n\tknfw==","X-Gm-Message-State":"AOJu0YyizTjVcqjjPQHBRrgkd710MUh83T+6gqJ5gfvWks0NPxQ4lokl\n\t9TBNC5lh/KKqIKsnTQeVPZAAYn8S8UMTkqej+KtGoVaSNBHYcGR+Szg=","X-Google-Smtp-Source":"AGHT+IE524O0BFapdjjkhRGXAqSV0lYZjUuKmKbCYKd6eRoNQLgiVDBrH2JC0Eqa7Ja2YIiiDpUOT7lqzT/pKKVH+Go=","X-Received":"by 2002:a0d:c602:0:b0:589:eec9:a7e8 with SMTP id\n\ti2-20020a0dc602000000b00589eec9a7e8mr1657672ywd.38.1695799841339;\n\tWed, 27 Sep 2023 00:30:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>\n\t<20230921165550.50956-12-jacopo.mondi@ideasonboard.com>\n\t<20230926225151.GA15901@pendragon.ideasonboard.com>","In-Reply-To":"<20230926225151.GA15901@pendragon.ideasonboard.com>","Date":"Wed, 27 Sep 2023 08:30:05 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27897,"web_url":"https://patchwork.libcamera.org/comment/27897/","msgid":"<20230927074835.GN5854@pendragon.ideasonboard.com>","date":"2023-09-27T07:48:35","subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Sep 27, 2023 at 08:30:05AM +0100, Naushir Patuck wrote:\n> On Tue, 26 Sept 2023 at 23:51, Laurent Pinchart via libcamera-devel wrote:\n> > On Thu, Sep 21, 2023 at 06:55:48PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> > > From: Naushir Patuck \n> > >\n> > > Switch to XRGB8888 as a default Viewfinder role output format, and\n> > > YUV420 as a default output format for everything else.\n> >\n> > The commit message should explain *why* those formats are better.\n> \n> RGB24/32 formats are typically better supported by display pipelines\n> than YUV420.\n\nThis patch switches from YUV 4:2:0 semi-planar to planar, and from ARGB\nto XRGB, so I'm not sure how that's related :-)\n\n> Happy to add this line to the commit message, or can\n> this be done while applying?\n\nIf you reply with an updated commit message, I can handle it when\napplying.\n\n> > > Signed-off-by: Naushir Patuck \n> > > Reviewed-by: Jacopo Mondi \n> > > Signed-off-by: Jacopo Mondi \n> > > ---\n> > > src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 6 +++---\n> > > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > index c560e48c12fb..f8e8e13dc837 100644\n> > > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > @@ -268,7 +268,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> > >\n> > > if (fmts.find(out.dev->toV4L2PixelFormat(cfgPixFmt)) == fmts.end()) {\n> > > /* If we cannot find a native format, use a default one. */\n> > > - cfgPixFmt = formats::NV12;\n> > > + cfgPixFmt = formats::YUV420;\n> > > status = Adjusted;\n> > > }\n> > >\n> > > @@ -431,7 +431,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span > >\n> > > case StreamRole::StillCapture:\n> > > fmts = data->ispFormats();\n> > > - pixelFormat = formats::NV12;\n> > > + pixelFormat = formats::YUV420;\n> > > /*\n> > > * Still image codecs usually expect the sYCC color space.\n> > > * Even RGB codecs will be fine as the RGB we get with the\n> > > @@ -465,7 +465,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span > >\n> > > case StreamRole::Viewfinder:\n> > > fmts = data->ispFormats();\n> > > - pixelFormat = formats::ARGB8888;\n> > > + pixelFormat = formats::XRGB8888;\n> > > colorSpace = ColorSpace::Sycc;\n> > > size = { 800, 600 };\n> > > bufferCount = 4;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC57DC326B\n\tfor ;\n\tWed, 27 Sep 2023 07:48:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2AC6062931;\n\tWed, 27 Sep 2023 09:48:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 369AA60374\n\tfor ;\n\tWed, 27 Sep 2023 09:48:27 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8590FEF0;\n\tWed, 27 Sep 2023 09:46:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695800909;\n\tbh=x9Vt2aOxTCA+hNjGh5+pwYqjjKUN73A2ckzaV13J090=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MjbLzhgMUeLwb7eP6U6oeookxAbeW0mCnqNZg1PL/+bMB/y4ZAoblVoCPIb/T9xhs\n\tviq7QHrzFK71/4BvVXpbSYbxRmZW7Bq6rkP0NBiUtTR+ubVCmBW533zDLeBJK82aHK\n\tzztHJ9fW2EuTw2L8mcoJXQiyJEBqQFaGB55rICYPjQKhfPCtilWZjRppnfi7qCMTZz\n\t0I2o8hW7c+mbt4Zoih97RlEqjidPQCkPlBJ4RiAn1F76WTBx4nR4pObt4TBi2Nudy6\n\ttO5z9l1403uJDrzfUIe+J1ZgpdScht0/m8k2VsO0zXekfV3KlRqDZtCAoXS6UGXI3r\n\tm5eBBkdfqagkA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695800805;\n\tbh=x9Vt2aOxTCA+hNjGh5+pwYqjjKUN73A2ckzaV13J090=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sbDvn3lA/FR4M8YT47DApgDoMitpqZtn9r4751sRgtOSAoI79/IRchHIqh4Sk2Z8Y\n\tdPcjHr43fbm/o6FwRRlwIHa7iHTeENd1VSzp11Vjoyu9BJudqdpr4tCdHwmoUtKDhl\n\tTE3qUzn7xOC+tHDEM0VHnz4iLNJBxCZ1A8Z+04hY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"sbDvn3lA\"; dkim-atps=neutral","Date":"Wed, 27 Sep 2023 10:48:35 +0300","To":"Naushir Patuck ","Message-ID":"<20230927074835.GN5854@pendragon.ideasonboard.com>","References":"<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>\n\t<20230921165550.50956-12-jacopo.mondi@ideasonboard.com>\n\t<20230926225151.GA15901@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27898,"web_url":"https://patchwork.libcamera.org/comment/27898/","msgid":"","date":"2023-09-27T08:59:36","subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Wed, 27 Sept 2023 at 08:48, Laurent Pinchart\n wrote:\n>\n> On Wed, Sep 27, 2023 at 08:30:05AM +0100, Naushir Patuck wrote:\n> > On Tue, 26 Sept 2023 at 23:51, Laurent Pinchart via libcamera-devel wrote:\n> > > On Thu, Sep 21, 2023 at 06:55:48PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> > > > From: Naushir Patuck \n> > > >\n> > > > Switch to XRGB8888 as a default Viewfinder role output format, and\n> > > > YUV420 as a default output format for everything else.\n> > >\n> > > The commit message should explain *why* those formats are better.\n> >\n> > RGB24/32 formats are typically better supported by display pipelines\n> > than YUV420.\n>\n> This patch switches from YUV 4:2:0 semi-planar to planar, and from ARGB\n> to XRGB, so I'm not sure how that's related :-)\n\nSorry, I phrased that completely wrong! Here's a (hopefully) clearer\ncommit message:\n\nSwitch to XRGB8888 as a default Viewfinder role output format, this is\na more correct description of the ISP hardware output, and what is\naccepted by the Raspberry Pi hardware.\n\nSwitch to YUV420 as a default output format for everything else, as\nthis format is best supported by encoding (e.g. H.264, JPEG) sinks on\nthe Raspberry Pi platform.\n\n>\n> > Happy to add this line to the commit message, or can\n> > this be done while applying?\n>\n> If you reply with an updated commit message, I can handle it when\n> applying.\n>\n> > > > Signed-off-by: Naushir Patuck \n> > > > Reviewed-by: Jacopo Mondi \n> > > > Signed-off-by: Jacopo Mondi \n> > > > ---\n> > > > src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 6 +++---\n> > > > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > > >\n> > > > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > > index c560e48c12fb..f8e8e13dc837 100644\n> > > > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > > @@ -268,7 +268,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> > > >\n> > > > if (fmts.find(out.dev->toV4L2PixelFormat(cfgPixFmt)) == fmts.end()) {\n> > > > /* If we cannot find a native format, use a default one. */\n> > > > - cfgPixFmt = formats::NV12;\n> > > > + cfgPixFmt = formats::YUV420;\n> > > > status = Adjusted;\n> > > > }\n> > > >\n> > > > @@ -431,7 +431,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span > > >\n> > > > case StreamRole::StillCapture:\n> > > > fmts = data->ispFormats();\n> > > > - pixelFormat = formats::NV12;\n> > > > + pixelFormat = formats::YUV420;\n> > > > /*\n> > > > * Still image codecs usually expect the sYCC color space.\n> > > > * Even RGB codecs will be fine as the RGB we get with the\n> > > > @@ -465,7 +465,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span > > >\n> > > > case StreamRole::Viewfinder:\n> > > > fmts = data->ispFormats();\n> > > > - pixelFormat = formats::ARGB8888;\n> > > > + pixelFormat = formats::XRGB8888;\n> > > > colorSpace = ColorSpace::Sycc;\n> > > > size = { 800, 600 };\n> > > > bufferCount = 4;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84AA2BD808\n\tfor ;\n\tWed, 27 Sep 2023 09:00:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D385762944;\n\tWed, 27 Sep 2023 11:00:15 +0200 (CEST)","from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com\n\t[IPv6:2607:f8b0:4864:20::112d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA8C460374\n\tfor ;\n\tWed, 27 Sep 2023 11:00:13 +0200 (CEST)","by mail-yw1-x112d.google.com with SMTP id\n\t00721157ae682-59f57ad6126so91316327b3.3\n\tfor ;\n\tWed, 27 Sep 2023 02:00:13 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695805215;\n\tbh=cIgfF0QrmTMSv2dVF1+KXIIa0PclwBN/t7W+DcpBQe8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vMqNE8qEd4ZX2G9nanCepTsJOwYGK7kjRUahlDiThVcFV7Zd0uiYChNaVIEbQzYjq\n\tdCjhQnHMXwVpAzn+RCk++3eyH/0/1Sw4XbFie3dMhVdUN4UQU3PNj7rXq2xmNe7+9D\n\tW+rqYNo/p0faO5PVdYnaxsLj8EeBIVwXX+R9KFMT58toIkr6WrxH9qBK1EL51gF+gY\n\t2qKeAwh0JM+PEQO6zql4kVELYzifO+cuLmunY1clmpWq4RQpWoWzAnx3L2IJzesweL\n\thwaueuHmLUQaxoVRIUAL2O8aELPsK+A37y6rzpDzgO73+k77rAN+Kbed1GHmzH5u1p\n\tWz5qKC35o71ow==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695805212; x=1696410012;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=JzfG1FlzPyQaDaAH2Gj6+7G5TNFIIImuQMBDfnxRKwg=;\n\tb=iyh+K1ywTwgf8Dgtlk+Ttr/RFe8a6rACvFajvCOVDA8KK0aAj5FI7at19q1XLIai92\n\tjPuY00RCYgXdE0XUf0SuOQyTQsEtTDYC2BFOhGCTE/5P3slyS1NiY0KP3g91p2k0Cx63\n\tm8r6dlBmXtIzK7o9w8oYakXvZGFrp4AWLgEc/I/1bmgN8C33fgBYfVgAkfLIXTXfve/2\n\tnTYd/PA4wBuHAH7s51zF3nscfQ79O1/7AEsuO78XtUgeAXQCglEuV1FferQ0+5ab00lP\n\teQXfIFdfWVcEpyxc/4lkIZVIVx7v/PqGvDmGyZ2Qc5mzifdZTBQFZjX1oA3+xgWbS/sD\n\t6K+w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"iyh+K1yw\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695805212; x=1696410012;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=JzfG1FlzPyQaDaAH2Gj6+7G5TNFIIImuQMBDfnxRKwg=;\n\tb=wkejf+M6tBjoTaHpKObF2VfT1vabhViZtIef6SmGPGmnPMPtQ8JlKkgwihmJCHa5yh\n\tK0AJznMMKMxXAXf9Irol6t7duAFMtyGpPTgQtr3gIegTnTicxI6/HNU2ALofnslEJb4J\n\tgxGubwzIea0ihYgI4gX6z5EF4goutrz9TlUL1sx6SXtdVu8ajaxMKIEC6YjMnDlY3qnM\n\tUgOVGeknMSf1R9/JPElV2UbmtAqpl504jWJpADw2ToJdRjeII5Aebxdi1IvdMTdFQSVQ\n\tUh0XW2RQOg/8EreoB5dgn9cvhU//119QwksT3PHnNKU/SBTO5LqLQPKRrBCSIAwAJ60L\n\t1jIw==","X-Gm-Message-State":"AOJu0YzLZGcTQBKpteG4j52oUA2BRmG8WzD+Jwt/FUOZ3b7YCRYabnd1\n\tBJR9qngncCcvSkAG3xLpWZt4huHYAABcG9ISE5wiIrsstadQ/Cy2uro=","X-Google-Smtp-Source":"AGHT+IH7cixcnpy+iWr6kN3TLURCe1e+rtFtZUCFwre1Yjz9r8h9cN0q3IFCiv1ZVYvgMFDTgFUNQff+VW5gYzouC6s=","X-Received":"by 2002:a0d:e212:0:b0:59b:ec10:9165 with SMTP id\n\tl18-20020a0de212000000b0059bec109165mr1576580ywe.24.1695805212410;\n\tWed, 27 Sep 2023 02:00:12 -0700 (PDT)","MIME-Version":"1.0","References":"<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>\n\t<20230921165550.50956-12-jacopo.mondi@ideasonboard.com>\n\t<20230926225151.GA15901@pendragon.ideasonboard.com>\n\t\n\t<20230927074835.GN5854@pendragon.ideasonboard.com>","In-Reply-To":"<20230927074835.GN5854@pendragon.ideasonboard.com>","Date":"Wed, 27 Sep 2023 09:59:36 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27899,"web_url":"https://patchwork.libcamera.org/comment/27899/","msgid":"<20230927120223.GV5854@pendragon.ideasonboard.com>","date":"2023-09-27T12:02:23","subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nOn Wed, Sep 27, 2023 at 09:59:36AM +0100, Naushir Patuck wrote:\n> On Wed, 27 Sept 2023 at 08:48, Laurent Pinchart wrote:\n> > On Wed, Sep 27, 2023 at 08:30:05AM +0100, Naushir Patuck wrote:\n> > > On Tue, 26 Sept 2023 at 23:51, Laurent Pinchart via libcamera-devel wrote:\n> > > > On Thu, Sep 21, 2023 at 06:55:48PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> > > > > From: Naushir Patuck \n> > > > >\n> > > > > Switch to XRGB8888 as a default Viewfinder role output format, and\n> > > > > YUV420 as a default output format for everything else.\n> > > >\n> > > > The commit message should explain *why* those formats are better.\n> > >\n> > > RGB24/32 formats are typically better supported by display pipelines\n> > > than YUV420.\n> >\n> > This patch switches from YUV 4:2:0 semi-planar to planar, and from ARGB\n> > to XRGB, so I'm not sure how that's related :-)\n> \n> Sorry, I phrased that completely wrong! Here's a (hopefully) clearer\n> commit message:\n> \n> Switch to XRGB8888 as a default Viewfinder role output format, this is\n> a more correct description of the ISP hardware output, and what is\n> accepted by the Raspberry Pi hardware.\n> \n> Switch to YUV420 as a default output format for everything else, as\n> this format is best supported by encoding (e.g. H.264, JPEG) sinks on\n> the Raspberry Pi platform.\n\nThank you. I've updated the commit message and pushed the series.\n\n> > > Happy to add this line to the commit message, or can\n> > > this be done while applying?\n> >\n> > If you reply with an updated commit message, I can handle it when\n> > applying.\n> >\n> > > > > Signed-off-by: Naushir Patuck \n> > > > > Reviewed-by: Jacopo Mondi \n> > > > > Signed-off-by: Jacopo Mondi \n> > > > > ---\n> > > > > src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 6 +++---\n> > > > > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > > > >\n> > > > > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > > > index c560e48c12fb..f8e8e13dc837 100644\n> > > > > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > > > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > > > @@ -268,7 +268,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> > > > >\n> > > > > if (fmts.find(out.dev->toV4L2PixelFormat(cfgPixFmt)) == fmts.end()) {\n> > > > > /* If we cannot find a native format, use a default one. */\n> > > > > - cfgPixFmt = formats::NV12;\n> > > > > + cfgPixFmt = formats::YUV420;\n> > > > > status = Adjusted;\n> > > > > }\n> > > > >\n> > > > > @@ -431,7 +431,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span > > > >\n> > > > > case StreamRole::StillCapture:\n> > > > > fmts = data->ispFormats();\n> > > > > - pixelFormat = formats::NV12;\n> > > > > + pixelFormat = formats::YUV420;\n> > > > > /*\n> > > > > * Still image codecs usually expect the sYCC color space.\n> > > > > * Even RGB codecs will be fine as the RGB we get with the\n> > > > > @@ -465,7 +465,7 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span > > > >\n> > > > > case StreamRole::Viewfinder:\n> > > > > fmts = data->ispFormats();\n> > > > > - pixelFormat = formats::ARGB8888;\n> > > > > + pixelFormat = formats::XRGB8888;\n> > > > > colorSpace = ColorSpace::Sycc;\n> > > > > size = { 800, 600 };\n> > > > > bufferCount = 4;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2C4BC326B\n\tfor ;\n\tWed, 27 Sep 2023 12:02:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2EB0E62931;\n\tWed, 27 Sep 2023 14:02:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8493561DE5\n\tfor ;\n\tWed, 27 Sep 2023 14:02:14 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [95.214.66.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C58DF18BF;\n\tWed, 27 Sep 2023 14:00:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695816136;\n\tbh=FJ+ZUUwC46FSSlsirCdvLGulF20N7IRYQz5tbju+w7w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zQqJbcR4+rygy6IjH8ruHQqoqgQ/K3i920BhF7sBvG9oYI1UNkSWqyBd2S1HPbXDG\n\tX0f7/txIpHUDHYLVK8ekjpFpj22lezcwSKBeo0c0zuaz60LInA11U4br9XS/eKiSma\n\tH0kmHDro4uN8BgbVFOW4DsrcvvfZgFGNERYxi1yhcKMtRp35b6oYMXkbDn7wJEmYGH\n\tvw6YggE1EEjEpfj09QPQfzGrd33O6IW2QEeyyoJiRTBsHAzeORqsRKdmuJlR+tZgG4\n\t/89tZbcaeLoR4g2HLl1Erc5yKPoMt0uiaemRKJSlxfcr0xEpchJHWXyyKms3aOcH+b\n\t7qBLfWgl1jLvQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695816033;\n\tbh=FJ+ZUUwC46FSSlsirCdvLGulF20N7IRYQz5tbju+w7w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XhPWmKOnaLv1gbRb9ovjFO7Tr1rA6kOt90jNsQ9y25Xz4cBhaDUUz1QvYFBukN4Jp\n\tRaPuOkrx9Y3Qt4DWnosTkOfBW3etievAqmAvlXjrPUlXElTsSrn0QDlwQKRhFmcQ96\n\tg0JLQtPG1lN/lVSSVuzu7b+E4WULfT8+tKmxPJNs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"XhPWmKOn\"; dkim-atps=neutral","Date":"Wed, 27 Sep 2023 15:02:23 +0300","To":"Naushir Patuck ","Message-ID":"<20230927120223.GV5854@pendragon.ideasonboard.com>","References":"<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>\n\t<20230921165550.50956-12-jacopo.mondi@ideasonboard.com>\n\t<20230926225151.GA15901@pendragon.ideasonboard.com>\n\t\n\t<20230927074835.GN5854@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v5 11/13] libcamera: rpi: Change\n\tdefault stream formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]