[{"id":27893,"web_url":"https://patchwork.libcamera.org/comment/27893/","msgid":"<20230926222850.GK5854@pendragon.ideasonboard.com>","date":"2023-09-26T22:28:50","subject":"Re: [libcamera-devel] [PATCH v5 06/13] libcamera: rpi: Fix wrong\n\tcomment indentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Sep 21, 2023 at 06:55:43PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> The closing line of a comment block was aligned with spaces and not\n> tabs. Fix it.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> index 81b2b7d2f4d1..3e7c487fb0bf 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> @@ -273,7 +273,7 @@ private:\n> \t * Store the colour spaces that all our streams will have. RGB format streams\n> \t * will have the same colorspace as YUV streams, with YCbCr field cleared and\n> \t * range set to full.\n> - */\n> +\t */\n> \tstd::optional yuvColorSpace_;\n> \tstd::optional rgbColorSpace_;\n> };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED37CC326B\n\tfor ;\n\tTue, 26 Sep 2023 22:28:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99C6A62931;\n\tWed, 27 Sep 2023 00:28:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74E9F628FA\n\tfor ;\n\tWed, 27 Sep 2023 00:28:40 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 551E513C5;\n\tWed, 27 Sep 2023 00:26:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695767322;\n\tbh=2IA8WltqX/IwnyXFEonALWKQcmutgWcbBy1VvcSHyI8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RX+wlTZWR5RoGW2eQ6dlsaCJUzslp0SKn7lEkSuOUjghxOlorEOle0kSb2fkPY+Bv\n\tqrp0caXqfKk64e20gulBH263hEuwKZTJESDnQpPLuq669tMxsF5bbyG8J3k0vgU0UM\n\tNTUCC/3vsGd10pCOsJ/LDTw+Rmm2HgiNK18dkvgN8cpUogm8Sy3fif3pAT3eQdYVhj\n\tbH7V8f1IsSFw3+WJ2AFjw8z8ttCs/xjD/TxhkMWeH/QhYfS31SSPkeekjtpv3NVQEg\n\tXnlPk/6PlUwMagi4HkprNof38g7rwRy1XhRxumY4QIAhu+SOqydk7FfwUTOyrAQQ/2\n\tSDbe2ssTTovvA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695767219;\n\tbh=2IA8WltqX/IwnyXFEonALWKQcmutgWcbBy1VvcSHyI8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=f8DJjocklZebC18dvgQTr3ca3Rfgor4OfgNTTTgmrtCxPDjOwneWMyaauzSPOB7FZ\n\tXd/QFneBPy9+OZ0JKHlNRAgmjdLfzS/Gc5Wg3cD+9Yw2MSXAwyavPcdAvZ9dPLxqRl\n\tUCC0K61vogDLGLRrZDfro4IT7Qi/m7VkSx3k9L+U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f8DJjock\"; dkim-atps=neutral","Date":"Wed, 27 Sep 2023 01:28:50 +0300","To":"Jacopo Mondi ","Message-ID":"<20230926222850.GK5854@pendragon.ideasonboard.com>","References":"<20230921165550.50956-1-jacopo.mondi@ideasonboard.com>\n\t<20230921165550.50956-7-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230921165550.50956-7-jacopo.mondi@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v5 06/13] libcamera: rpi: Fix wrong\n\tcomment indentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]