[{"id":27821,"web_url":"https://patchwork.libcamera.org/comment/27821/","msgid":"","date":"2023-09-21T07:47:23","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: converter: a few\n\tfixes to ConverterFactoryBase documentation","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Andrey\n\nOn Wed, Sep 20, 2023 at 06:19:18PM +0300, Andrey Konovalov via libcamera-devel wrote:\n> Signed-off-by: Andrey Konovalov \n> ---\n> src/libcamera/converter.cpp | 17 ++++++++++-------\n> 1 file changed, 10 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\n> index fa0f1ec8..466f8421 100644\n> --- a/src/libcamera/converter.cpp\n> +++ b/src/libcamera/converter.cpp\n> @@ -199,16 +199,18 @@ ConverterFactoryBase::ConverterFactoryBase(const std::string name, std::initiali\n>\n> /**\n> * \\fn ConverterFactoryBase::compatibles()\n> - * \\return The names compatibles\n> + * \\return The compatibles\n\nWhile I agree the \"name compatibles\" might not be super precise, just\n\"the compatibles\" doesn't sound any better to me.\n\nThe 'compatibles' are passed in as constructor parameters and are\ndocumented as\n\n * \\param[in] compatibles Name aliases of the converter class\n\nI would re-use part of this in\n\n\\return The list of compatible name aliases of the converter\n\n> */\n>\n> /**\n> - * \\brief Create an instance of the converter corresponding to a named factory\n> - * \\param[in] media Name of the factory\n> + * \\brief Create an instance of the converter corresponding to the media device\n\nThe only thing 'media' is used for is to match on its 'driver()' name,\nso the previous documentation wasn't -that- off..\n\n> + * \\param[in] media the media device to create the converter for\n ^ The\n> *\n> * \\return A unique pointer to a new instance of the converter subclass\n> - * corresponding to the named factory or one of its alias. Otherwise a null\n> - * pointer if no such factory exists\n> + * corresponding to the media device. The converter is created by the factory\n> + * the name or the alias of which equals to the media device driver name.\n\ns/the name/name ?\n\nI have troubles parsing this one, but I'm not a native speaker, so it\nmight be me\n\nDid you mean:\n\n * \\return A unique pointer to a new instance of the converter\n * subclass corresponding to the media device. The converter is\n * created by matching the factory name or any of its compatible\n * aliases with the media device driver name.\n\n> + * If the media device driver name doesn't match anything a null pointer is\n> + * returned.\n> */\n> std::unique_ptr ConverterFactoryBase::create(MediaDevice *media)\n> {\n> @@ -236,10 +238,11 @@ std::unique_ptr ConverterFactoryBase::create(MediaDevice *media)\n> }\n>\n> /**\n> - * \\brief Add a converter class to the registry\n> + * \\brief Add a converter factory to the registry\n> * \\param[in] factory Factory to use to construct the converter class\n> *\n> - * The caller is responsible to guarantee the uniqueness of the converter name.\n> + * The caller is responsible to guarantee the uniqueness of the converter\n> + * factory name.\n\nThese are ok\n\n> */\n> void ConverterFactoryBase::registerType(ConverterFactoryBase *factory)\n> {\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2260DC326B\n\tfor ;\n\tThu, 21 Sep 2023 07:47:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4831862944;\n\tThu, 21 Sep 2023 09:47:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C95961DE7\n\tfor ;\n\tThu, 21 Sep 2023 09:47:27 +0200 (CEST)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A60ECBB2;\n\tThu, 21 Sep 2023 09:45:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695282448;\n\tbh=laltPvNErr7VPvvcMtH2SsjleIUdFdO9/X0XEyd7jTc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WbWTlkWpG49rsAdHiadLG96dcwOwSWDPCTcZFyL4zXeeIB7WmZll3QhJ+zgItVN4W\n\twxPORI3dWj5c4mRcc1M5qIX9TXpF9jbXjinkKjtFGVHTpNYqOD4wDwCmioZu6JBwG7\n\tIPKAwhffVBV/Gk/umqxSmHO64VYdc4h8MmbhX4NXadn8zXZlxoT5IDh2Oj4R3TgqQA\n\t6dx0UHYfLwOOjHXObuKzCx0+wcgq8TEtS68fpIjB05QCuOvEpIE9QIhXu6ReO/aBh4\n\tTt6811Sn+aJOPCxxttZaXatax+oxvm0+tJdhDWtmqQftf1iPH26w6JJEeC70ZIyCST\n\tZGulfXL/pbAlQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695282349;\n\tbh=laltPvNErr7VPvvcMtH2SsjleIUdFdO9/X0XEyd7jTc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mQBs4C61YmWWrmBkqwP3l9qR3T/bWEHC2wOmyU20D2GJOKxA/oUkVE2PrcWL22Q2X\n\t3N4+pVrs4nb1kYwXImS0TPGvV2rpN4HAz5hTUCkDMMMyhQ57rw0GcGN0IusUygJOJc\n\tOhdo/d6lO2CDjEnioKgGg9AcwbfKDknS5J1qaEOk="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"mQBs4C61\"; dkim-atps=neutral","Date":"Thu, 21 Sep 2023 09:47:23 +0200","To":"Andrey Konovalov ","Message-ID":"","References":"<20230920151921.31273-1-andrey.konovalov@linaro.org>\n\t<20230920151921.31273-2-andrey.konovalov@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230920151921.31273-2-andrey.konovalov@linaro.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: converter: a few\n\tfixes to ConverterFactoryBase documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"jacopo.mondi@ideasonboard.com, bryan.odonoghue@linaro.org,\n\tlibcamera-devel@lists.libcamera.org, srinivas.kandagatla@linaro.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27823,"web_url":"https://patchwork.libcamera.org/comment/27823/","msgid":"","date":"2023-09-21T09:05:00","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: converter: a few\n\tfixes to ConverterFactoryBase documentation","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hello again, sorry missed it, you also need a (possibly short) commit\nmessage\n\nThanks\n j\n\nOn Thu, Sep 21, 2023 at 09:47:23AM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Hi Andrey\n>\n> On Wed, Sep 20, 2023 at 06:19:18PM +0300, Andrey Konovalov via libcamera-devel wrote:\n> > Signed-off-by: Andrey Konovalov \n> > ---\n> > src/libcamera/converter.cpp | 17 ++++++++++-------\n> > 1 file changed, 10 insertions(+), 7 deletions(-)\n> >\n> > diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\n> > index fa0f1ec8..466f8421 100644\n> > --- a/src/libcamera/converter.cpp\n> > +++ b/src/libcamera/converter.cpp\n> > @@ -199,16 +199,18 @@ ConverterFactoryBase::ConverterFactoryBase(const std::string name, std::initiali\n> >\n> > /**\n> > * \\fn ConverterFactoryBase::compatibles()\n> > - * \\return The names compatibles\n> > + * \\return The compatibles\n>\n> While I agree the \"name compatibles\" might not be super precise, just\n> \"the compatibles\" doesn't sound any better to me.\n>\n> The 'compatibles' are passed in as constructor parameters and are\n> documented as\n>\n> * \\param[in] compatibles Name aliases of the converter class\n>\n> I would re-use part of this in\n>\n> \\return The list of compatible name aliases of the converter\n>\n> > */\n> >\n> > /**\n> > - * \\brief Create an instance of the converter corresponding to a named factory\n> > - * \\param[in] media Name of the factory\n> > + * \\brief Create an instance of the converter corresponding to the media device\n>\n> The only thing 'media' is used for is to match on its 'driver()' name,\n> so the previous documentation wasn't -that- off..\n>\n> > + * \\param[in] media the media device to create the converter for\n> ^ The\n> > *\n> > * \\return A unique pointer to a new instance of the converter subclass\n> > - * corresponding to the named factory or one of its alias. Otherwise a null\n> > - * pointer if no such factory exists\n> > + * corresponding to the media device. The converter is created by the factory\n> > + * the name or the alias of which equals to the media device driver name.\n>\n> s/the name/name ?\n>\n> I have troubles parsing this one, but I'm not a native speaker, so it\n> might be me\n>\n> Did you mean:\n>\n> * \\return A unique pointer to a new instance of the converter\n> * subclass corresponding to the media device. The converter is\n> * created by matching the factory name or any of its compatible\n> * aliases with the media device driver name.\n>\n> > + * If the media device driver name doesn't match anything a null pointer is\n> > + * returned.\n> > */\n> > std::unique_ptr ConverterFactoryBase::create(MediaDevice *media)\n> > {\n> > @@ -236,10 +238,11 @@ std::unique_ptr ConverterFactoryBase::create(MediaDevice *media)\n> > }\n> >\n> > /**\n> > - * \\brief Add a converter class to the registry\n> > + * \\brief Add a converter factory to the registry\n> > * \\param[in] factory Factory to use to construct the converter class\n> > *\n> > - * The caller is responsible to guarantee the uniqueness of the converter name.\n> > + * The caller is responsible to guarantee the uniqueness of the converter\n> > + * factory name.\n>\n> These are ok\n>\n> > */\n> > void ConverterFactoryBase::registerType(ConverterFactoryBase *factory)\n> > {\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B50C2C326B\n\tfor ;\n\tThu, 21 Sep 2023 09:05:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BC5A62944;\n\tThu, 21 Sep 2023 11:05:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9D33961DE7\n\tfor ;\n\tThu, 21 Sep 2023 11:05:03 +0200 (CEST)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0460F1102;\n\tThu, 21 Sep 2023 11:03:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695287105;\n\tbh=5cGN9pDcD9wPerNd+68/d6uDh0QfjP0DKN8OTrAZKJk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0A4eFP6/XnHV9EtM9UZKjGzGFotjynR+bHFiTAslvA00eKdkTnDdLim3R9zhYhKsb\n\tLj/UXs2TPln9eNA8/xViNk3PG4p2MmgLgPmATvBozoEEbHVUcSaYjPMXQCcR3czWoS\n\t91hN6hBY9Ibj8sSMfeopdHdGfujbN17oDyByLnjUybyn6pZ1bBcILaMP6WdkBLRmTI\n\teIlZhKykYQR/dkrJclFUNrlmfEF26q0NA+I5RiLkcu9846CNMttO2McE9lNlfnwFzY\n\tAYF1NOYvBqhlXQf5Kf1w7eZBXRbhXN/N7GRq5QTAwqBVzxYaaFNsvav58O5qVaEyMW\n\tdfKY4PSeDYLVA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695287006;\n\tbh=5cGN9pDcD9wPerNd+68/d6uDh0QfjP0DKN8OTrAZKJk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EhVUqNHWW3IXyJd16F17nLW01TM5IelOATxzIteR+JQYlcwTXAJvrFCCuvSq+JsIW\n\tqHG34QBK+ApgzwjySsrbMUotdFUqFQe97TRxQnocQsbEnN7X7d0XsrDo4bheuRum6E\n\tdQDj9aWgSR9voUYPO1VJUxGwEOoLgh8CF3/sGrqU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EhVUqNHW\"; dkim-atps=neutral","Date":"Thu, 21 Sep 2023 11:05:00 +0200","To":"Jacopo Mondi ","Message-ID":"","References":"<20230920151921.31273-1-andrey.konovalov@linaro.org>\n\t<20230920151921.31273-2-andrey.konovalov@linaro.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: converter: a few\n\tfixes to ConverterFactoryBase documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"bryan.odonoghue@linaro.org, srinivas.kandagatla@linaro.org,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27838,"web_url":"https://patchwork.libcamera.org/comment/27838/","msgid":"<469b58f5-d0b8-1117-9816-69a74ae01f4b@linaro.org>","date":"2023-09-21T17:34:22","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: converter: a few\n\tfixes to ConverterFactoryBase documentation","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Jacopo,\n\nThank you for the detailed review!\n\nOn 21.09.2023 10:47, Jacopo Mondi wrote:\n> Hi Andrey\n> \n> On Wed, Sep 20, 2023 at 06:19:18PM +0300, Andrey Konovalov via libcamera-devel wrote:\n>> Signed-off-by: Andrey Konovalov \n>> ---\n>> src/libcamera/converter.cpp | 17 ++++++++++-------\n>> 1 file changed, 10 insertions(+), 7 deletions(-)\n>>\n>> diff --git a/src/libcamera/converter.cpp b/src/libcamera/converter.cpp\n>> index fa0f1ec8..466f8421 100644\n>> --- a/src/libcamera/converter.cpp\n>> +++ b/src/libcamera/converter.cpp\n>> @@ -199,16 +199,18 @@ ConverterFactoryBase::ConverterFactoryBase(const std::string name, std::initiali\n>>\n>> /**\n>> * \\fn ConverterFactoryBase::compatibles()\n>> - * \\return The names compatibles\n>> + * \\return The compatibles\n> \n> While I agree the \"name compatibles\" might not be super precise, just\n> \"the compatibles\" doesn't sound any better to me.\n> \n> The 'compatibles' are passed in as constructor parameters and are\n> documented as\n> \n> * \\param[in] compatibles Name aliases of the converter class\n> \n> I would re-use part of this in\n> \n> \\return The list of compatible name aliases of the converter\n\nYes, this is much better.\n\n>> */\n>>\n>> /**\n>> - * \\brief Create an instance of the converter corresponding to a named factory\n>> - * \\param[in] media Name of the factory\n>> + * \\brief Create an instance of the converter corresponding to the media device\n> \n> The only thing 'media' is used for is to match on its 'driver()' name,\n> so the previous documentation wasn't -that- off..\n\nIndeed, the only place where the factory needs the \"the whole\" MediaDevice is when\nit creates an instance of converter (as 'MediaDevice *' needs to be passed to the\nConverter constructor).\nBut still describing an argument of 'MediaDevice *' type as \"Name of the factory\"\nlooks rather confusing to me.\n\n>> + * \\param[in] media the media device to create the converter for\n> ^ The\n\nRight. Will fix that.\n\n>> *\n>> * \\return A unique pointer to a new instance of the converter subclass\n>> - * corresponding to the named factory or one of its alias. Otherwise a null\n>> - * pointer if no such factory exists\n>> + * corresponding to the media device. The converter is created by the factory\n>> + * the name or the alias of which equals to the media device driver name.\n> \n> s/the name/name ?\n\nNo, I meant \"the name of which\"...\n\n> I have troubles parsing this one, but I'm not a native speaker, so it\n> might be me\n\n... but this indeed is hard to get, and this part should be rephrased.\n\n> Did you mean:\n> \n> * \\return A unique pointer to a new instance of the converter\n> * subclass corresponding to the media device. The converter is\n> * created by matching the factory name or any of its compatible\n> * aliases with the media device driver name.\n\nYes, this sounds much more clear.\n\n>> + * If the media device driver name doesn't match anything a null pointer is\n>> + * returned.\n>> */\n>> std::unique_ptr ConverterFactoryBase::create(MediaDevice *media)\n>> {\n>> @@ -236,10 +238,11 @@ std::unique_ptr ConverterFactoryBase::create(MediaDevice *media)\n>> }\n>>\n>> /**\n>> - * \\brief Add a converter class to the registry\n>> + * \\brief Add a converter factory to the registry\n>> * \\param[in] factory Factory to use to construct the converter class\n>> *\n>> - * The caller is responsible to guarantee the uniqueness of the converter name.\n>> + * The caller is responsible to guarantee the uniqueness of the converter\n>> + * factory name.\n> \n> These are ok\n\nThanks,\nAndrey\n\n>> */\n>> void ConverterFactoryBase::registerType(ConverterFactoryBase *factory)\n>> {\n>> --\n>> 2.34.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83F21C326B\n\tfor ;\n\tThu, 21 Sep 2023 17:34:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E402162944;\n\tThu, 21 Sep 2023 19:34:25 +0200 (CEST)","from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com\n\t[IPv6:2a00:1450:4864:20::62f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95AC3628D8\n\tfor ;\n\tThu, 21 Sep 2023 19:34:24 +0200 (CEST)","by mail-ej1-x62f.google.com with SMTP id\n\ta640c23a62f3a-9ae22bf33a0so531569966b.0\n\tfor ;\n\tThu, 21 Sep 2023 10:34:24 -0700 (PDT)","from [192.168.118.20] ([87.116.161.81])\n\tby smtp.gmail.com with ESMTPSA id\n\tva1-20020a17090711c100b00992ea405a79sm1348623ejb.166.2023.09.21.10.34.23\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 21 Sep 2023 10:34:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695317665;\n\tbh=twUg4dLukpYJ/iz55YgJLIIbGiq0MQVjkBEEmrnLWkc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qKtvFUdJghLll/Q9h4Gh4iUk1idEQSPSYL8eiLrGDp4F8pssi4ainP4lREwH75nga\n\tVih6POtgr6gO7gx/zleX+SVfPiNPPD+efolp1wZeZ2b0LgDwV6coBmeX4nkGeoFmhV\n\tJOcAQLv/gVk8BEvDs4T2YxQWt7y01F8CFBnDpZHKu0z8ob/OMyIOUuTFvQV0ywws4W\n\tE49R9f8YkF+jFx4WTUmxPWxOwh1hqwz7ugVI7rFjLaq4QvtMoKbCLLgxl6uk9b9ZYq\n\trvuCj+r37LZ9pqM8I7jSt6l0HRSIuUOGdTc/xNL5odVwvqJSpX6dNiVeIy4dAj0BWd\n\tYsjtrZ8Qe4oVw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1695317664; x=1695922464;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:references:cc:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=eXQRGz+6nPi9qiCbu5yV/oeLZPdibrIjUBAITm0DMiI=;\n\tb=QSUGHbj+oBEYHehYHCE1vBK3j3i8TxiLNxLV1SAfjl8FSp93pnljo4WWWnqIfLhi+Y\n\tPX07363XR+uw0PsXSp5Z10dbkVgSrBkyMJnE8yOaI426Msmq4kWDWImguDBir3o+ykwq\n\tNztErhrirSiKpE8A5oG7+FqMKIzz9FsHzxqAj+fz97IXFPXBLJXccadqeaolNILxRQo2\n\tflPeSbb7hlDKlPwOeaMgwxMUTxgW+yFdS+29bQovKTNHrf+Cs2i1wzDEMoTxvclSTOZU\n\tmIZmBrT2FceGRz0j2c7exflGfhyQO7QxVf+fg8UlUN6/Yx62jHr7EOvw0eDm3cOiojv5\n\ta81g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"QSUGHbj+\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695317664; x=1695922464;\n\th=content-transfer-encoding:in-reply-to:from:references:cc:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=eXQRGz+6nPi9qiCbu5yV/oeLZPdibrIjUBAITm0DMiI=;\n\tb=oMkrz5OY5inN28Ba9FEjijRItdW+gE/08Z+RRsCWSaFw4/cgcYbFoinGC9/puSoAxa\n\tnGwiMp5RwZv4qhMLkjsYVVO5jMbF028v0E0auq6832TUU3t64TLPAC/TaOAM3texDQTg\n\tril2s6ux7om/bsqW2I9TRlEEAlXAzarnmjBb+P3fU6aS8hZ8TqujrSy/V/SEQtPBThZV\n\tMab03emoPTbuGQby2Hxz2A+2dLQYkCkfhdZ5beR+Mzz09lYW2LuKUFfVq7niDkwYD/y/\n\teNCOgP7iLMSBKdGMuKUaOhsckWRkVdFveR5DCiz8dalIlhcGG9MTEMWeWl8deC9b/hV9\n\tIU1Q==","X-Gm-Message-State":"AOJu0Yx1GCN+6MCLqUQ/9GUT+z9qXCF6fSWIL0W7RRBzApoiqqk9RfsA\n\txNu5fDwGzqNrxR5eoXonUoOzxQ==","X-Google-Smtp-Source":"AGHT+IHpiv4Y9IDxQW8fV0IxcO9dJoNXvI60KCu5xJZq1qOqgPXjrICSGumANTNwsjQuJip74AOaGw==","X-Received":"by 2002:a17:906:6a1b:b0:9ae:5879:78dd with SMTP id\n\tqw27-20020a1709066a1b00b009ae587978ddmr552493ejc.1.1695317664015; \n\tThu, 21 Sep 2023 10:34:24 -0700 (PDT)","Message-ID":"<469b58f5-d0b8-1117-9816-69a74ae01f4b@linaro.org>","Date":"Thu, 21 Sep 2023 20:34:22 +0300","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.15.1","Content-Language":"en-US","To":"Jacopo Mondi ","References":"<20230920151921.31273-1-andrey.konovalov@linaro.org>\n\t<20230920151921.31273-2-andrey.konovalov@linaro.org>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: converter: a few\n\tfixes to ConverterFactoryBase documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Andrey Konovalov via libcamera-devel\n\t","Reply-To":"Andrey Konovalov ","Cc":"bryan.odonoghue@linaro.org, libcamera-devel@lists.libcamera.org,\n\tsrinivas.kandagatla@linaro.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]