{"id":1906,"url":"https://patchwork.libcamera.org/api/patches/1906/?format=json","web_url":"https://patchwork.libcamera.org/patch/1906/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190831210220.29819-6-niklas.soderlund@ragnatech.se>","date":"2019-08-31T21:02:19","name":"[libcamera-devel,5/6] libcamera: pipeline: rkisp1: Add plumbing for IPA meta data","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"62a560f87143590200449fd432a22b318c2860d0","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":{"id":16,"url":"https://patchwork.libcamera.org/api/users/16/?format=json","username":"neg","first_name":"Niklas","last_name":"Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/patch/1906/mbox/","series":[{"id":476,"url":"https://patchwork.libcamera.org/api/series/476/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=476","date":"2019-08-31T21:02:14","name":"libcamera: ipa: Add IPA meta data","version":1,"mbox":"https://patchwork.libcamera.org/series/476/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1906/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1906/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B4E160E2A\n\tfor ;\n\tSat, 31 Aug 2019 23:03:02 +0200 (CEST)","from bismarck.berto.se (unknown [84.172.84.18])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid b6e87e3a-cc32-11e9-903a-005056917f90;\n\tSat, 31 Aug 2019 23:03:00 +0200 (CEST)"],"X-Halon-ID":"b6e87e3a-cc32-11e9-903a-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 31 Aug 2019 23:02:19 +0200","Message-Id":"<20190831210220.29819-6-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.22.1","In-Reply-To":"<20190831210220.29819-1-niklas.soderlund@ragnatech.se>","References":"<20190831210220.29819-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 5/6] libcamera: pipeline: rkisp1: Add\n\tplumbing for IPA meta data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 31 Aug 2019 21:03:03 -0000"},"content":"Connect the pipeline handler to the IPA meta data signal. Add a check\nfor that IPA meta data is available to the conditions for completing a\nrequest to the application.\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 19 +++++++++++++++++--\n 1 file changed, 17 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex ab7c595f1e3bd39f..501edc20bb43514f 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -51,6 +51,7 @@ public:\n private:\n \tvoid updateSensor(V4L2ControlList controls);\n \tvoid queueRequestHardware(const void *cookie);\n+\tvoid metaDataReady(const void *cookie, IPAMetaData metaData);\n };\n \n class RkISP1RequestData : public RequestData\n@@ -143,6 +144,8 @@ int RkISP1CameraData::initIPA()\n \t\t\t\t &RkISP1CameraData::updateSensor);\n \tipa_->queueRequest.connect(this,\n \t\t\t\t &RkISP1CameraData::queueRequestHardware);\n+\tipa_->metaDataReady.connect(this,\n+\t\t\t\t &RkISP1CameraData::metaDataReady);\n \treturn 0;\n }\n \n@@ -175,6 +178,17 @@ void RkISP1CameraData::queueRequestHardware(const void *cookie)\n \t\tLOG(RkISP1, Error) << \"Failed to queue video\";\n }\n \n+void RkISP1CameraData::metaDataReady(const void *cookie, IPAMetaData metaData)\n+{\n+\tRequest *request = reinterpret_cast(const_cast(cookie));\n+\tPipelineHandlerRkISP1 *pipe =\n+\t\tstatic_cast(pipe_);\n+\n+\tpipe->processMetaData(request, metaData);\n+\n+\tpipe->tryCompleteRequest(request);\n+}\n+\n RkISP1CameraConfiguration::RkISP1CameraConfiguration(Camera *camera,\n \t\t\t\t\t\t RkISP1CameraData *data)\n \t: CameraConfiguration()\n@@ -709,6 +723,9 @@ void PipelineHandlerRkISP1::tryCompleteRequest(Request *request)\n \tif (request->hasPendingBuffers())\n \t\treturn;\n \n+\tif (!request->metaData().ready)\n+\t\treturn;\n+\n \tdelete reqData;\n \trequest->data = nullptr;\n \n@@ -734,8 +751,6 @@ void PipelineHandlerRkISP1::statReady(Buffer *buffer)\n \n \tdata->ipa_->updateStatistics(request, *buffer);\n \n-\t/* TODO: Fetch libcamera status controls from IPA */\n-\n \treqData->stat = nullptr;\n \n \tstatBuffers_.push(buffer);\n","prefixes":["libcamera-devel","5/6"]}