[{"id":27811,"web_url":"https://patchwork.libcamera.org/comment/27811/","msgid":"<169502952102.2427060.7429292724959371865@ping.linuxembedded.co.uk>","date":"2023-09-18T09:32:01","subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Reset the frame\n\tlengths queue during configure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2023-09-18 10:10:45)\n> The IPA stores a list of the last 10 frame lengths applied to the\n> sensor for determining the timeout to use. This list gets reset on\n> start(), but there is a path through the code that accesses this list\n> in configure() which happens earlier, causing a logical error.\n> \n> Fix this by constructing the list with 10 initial values of 0s.\n> \n> Bug: https://github.com/raspberrypi/libcamera/issues/64\n> Signed-off-by: Naushir Patuck \n\nAre there any other members of IpaBase which also need to be initialised\n? (Not specifically for this patch, just a question of ... if we missed\nthis - do we need to check for others here?, but that's a separate patch\nif there are)\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index f7e7ad5ee499..f0ce6c75dc03 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -100,8 +100,8 @@ LOG_DEFINE_CATEGORY(IPARPI)\n> namespace ipa::RPi {\n> \n> IpaBase::IpaBase()\n> - : controller_(), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0),\n> - firstStart_(true), flickerState_({ 0, 0s })\n> + : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), frameCount_(0),\n> + mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })\n> {\n> }\n> \n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E04E1C326B\n\tfor ;\n\tMon, 18 Sep 2023 09:32:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E02C6293B;\n\tMon, 18 Sep 2023 11:32:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B90361DEC\n\tfor ;\n\tMon, 18 Sep 2023 11:32:04 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5EAC31DD2;\n\tMon, 18 Sep 2023 11:30:29 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695029525;\n\tbh=1Vrn4aOdDUb0t/B/GTBFIh+BfTVkIzKOJnepq6O8vys=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=qA+j29oTKAFG4JtOG6k8gJaVBfo2V7IXh7yNRM1QWWv2aZnQgMSwGlr2OBa/XSL4L\n\t7LSslk7gUkghDMbO6iIBtyuDyWnemC6nWSnaTcb1kpUrRFN0w78YCDFxTzPlGQWUrq\n\tfg6C+Bfg0KNzt7QTfppY5YsTdtrpKTrwRgTpi0dV+xUV3lZp9Hbbgb5oW0J3r0dyD4\n\tshHzgRGDlt7x7wDfDnsVty86JvjYgaejCQYotbYLt/7AWm6t58QmMB8P2xenVbeByC\n\tA5d+VRxBs84VAnwj9yRwRdKogypncKwKizQ4sxkAuSr+AMXp0rqzWTgHy0+CNho71b\n\tIyuTTLqv0LHUQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695029429;\n\tbh=1Vrn4aOdDUb0t/B/GTBFIh+BfTVkIzKOJnepq6O8vys=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VcoUwQSQTm2CV/QGomkOhDpSeJtyGmPubqba0TmYsbAp3wvP+7csxkxjCQ4GTy7AN\n\tzgHtoPp4WK2n5OcQL8DNcmDbytWa4s6RMFjv9T8hXnt9ijvrixQU70AKXUAk48PtPs\n\tDulXAA3HTmgcbQPdxEpeCAdExt/LIYw/7ASSzOgY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VcoUwQSQ\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230918091045.16992-1-naush@raspberrypi.com>","References":"<20230918091045.16992-1-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 18 Sep 2023 10:32:01 +0100","Message-ID":"<169502952102.2427060.7429292724959371865@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Reset the frame\n\tlengths queue during configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27883,"web_url":"https://patchwork.libcamera.org/comment/27883/","msgid":"<169565382992.3049594.5761810119285268256@ping.linuxembedded.co.uk>","date":"2023-09-25T14:57:09","subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Reset the frame\n\tlengths queue during configure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kieran Bingham (2023-09-18 10:32:01)\n> Quoting Naushir Patuck (2023-09-18 10:10:45)\n> > The IPA stores a list of the last 10 frame lengths applied to the\n> > sensor for determining the timeout to use. This list gets reset on\n> > start(), but there is a path through the code that accesses this list\n> > in configure() which happens earlier, causing a logical error.\n> > \n> > Fix this by constructing the list with 10 initial values of 0s.\n> > \n> > Bug: https://github.com/raspberrypi/libcamera/issues/64\n> > Signed-off-by: Naushir Patuck \n> \n> Are there any other members of IpaBase which also need to be initialised\n> ? (Not specifically for this patch, just a question of ... if we missed\n> this - do we need to check for others here?, but that's a separate patch\n> if there are)\n> \n> Reviewed-by: Kieran Bingham \n\nHopefully this is an easy one unless anyone spots anything different.\nCould I get one more tag so I can collect this patch please?\n\n--\nKieran\n\n\n> \n> > ---\n> > src/ipa/rpi/common/ipa_base.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> > index f7e7ad5ee499..f0ce6c75dc03 100644\n> > --- a/src/ipa/rpi/common/ipa_base.cpp\n> > +++ b/src/ipa/rpi/common/ipa_base.cpp\n> > @@ -100,8 +100,8 @@ LOG_DEFINE_CATEGORY(IPARPI)\n> > namespace ipa::RPi {\n> > \n> > IpaBase::IpaBase()\n> > - : controller_(), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0),\n> > - firstStart_(true), flickerState_({ 0, 0s })\n> > + : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), frameCount_(0),\n> > + mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })\n> > {\n> > }\n> > \n> > -- \n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A5DAC326B\n\tfor ;\n\tMon, 25 Sep 2023 14:57:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77EA562945;\n\tMon, 25 Sep 2023 16:57:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4356A62931\n\tfor ;\n\tMon, 25 Sep 2023 16:57:12 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0EFD618BF;\n\tMon, 25 Sep 2023 16:55:32 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695653833;\n\tbh=fexdS3+ljyco96wxC1x6ye3hRkN9nf6BkRU07q4afEE=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0O7G3XXrAV4oNMc8FoDdG+d9y2+nOdBIHnNs1jjtt3E1JuqxUOulOi/U6JNHvFxfY\n\twEKRXdT04qsE+VMHnGSwPCCjfrx6gsKlD3sO2tzvC7kLiJ2eQVrE+1b8XGlXNjFzzs\n\tQa7vevAGlz+JEck574XHKT9oLGYoOgbAlXd2+NODIvqvAqDEY+mTKw0HrmNfL4Tt1m\n\t9t0C9uKe2DIc91/ZJ/Z4BbPJFpT3vDwzeHiyyUvnGevPtZOU4RXjA43GKnUtWzUm/b\n\t7bhNomos2sNuZirUzds4lOQsLostsQpfUkwAbORxlkiYXHPrXfDUd9FrT9ibhdbmjy\n\t1oSkeVUFE8usg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1695653732;\n\tbh=fexdS3+ljyco96wxC1x6ye3hRkN9nf6BkRU07q4afEE=;\n\th=In-Reply-To:References:Subject:From:To:Cc:Date:From;\n\tb=o3CZIXASkLebSRRpwHN1oITPtsLcEmc/kungJk8DLoL+uQFxTr7XJr+KvjGFpbS0f\n\tJM+eB4p4AArtj0yychumf1KxPZ4eIqnhssiAvNYfKP/xxGtiDvyTJktZJ+JHj61abv\n\t4+8fWS1XRVGSyv21Md0k26iQtG8j/E4RXsYpv4IA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"o3CZIXAS\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<169502952102.2427060.7429292724959371865@ping.linuxembedded.co.uk>","References":"<20230918091045.16992-1-naush@raspberrypi.com>\n\t<169502952102.2427060.7429292724959371865@ping.linuxembedded.co.uk>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 25 Sep 2023 15:57:09 +0100","Message-ID":"<169565382992.3049594.5761810119285268256@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Reset the frame\n\tlengths queue during configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Ben Benson ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27884,"web_url":"https://patchwork.libcamera.org/comment/27884/","msgid":"","date":"2023-09-25T15:03:45","subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Reset the frame\n\tlengths queue during configure","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this patch.\n\nOn Mon, 18 Sept 2023 at 10:10, Naushir Patuck via libcamera-devel\n wrote:\n>\n> The IPA stores a list of the last 10 frame lengths applied to the\n> sensor for determining the timeout to use. This list gets reset on\n> start(), but there is a path through the code that accesses this list\n> in configure() which happens earlier, causing a logical error.\n>\n> Fix this by constructing the list with 10 initial values of 0s.\n>\n> Bug: https://github.com/raspberrypi/libcamera/issues/64\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> ---\n> src/ipa/rpi/common/ipa_base.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp\n> index f7e7ad5ee499..f0ce6c75dc03 100644\n> --- a/src/ipa/rpi/common/ipa_base.cpp\n> +++ b/src/ipa/rpi/common/ipa_base.cpp\n> @@ -100,8 +100,8 @@ LOG_DEFINE_CATEGORY(IPARPI)\n> namespace ipa::RPi {\n>\n> IpaBase::IpaBase()\n> - : controller_(), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0),\n> - firstStart_(true), flickerState_({ 0, 0s })\n> + : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), frameCount_(0),\n> + mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })\n> {\n> }\n>\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58F97BD808\n\tfor ;\n\tMon, 25 Sep 2023 15:03:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF94362944;\n\tMon, 25 Sep 2023 17:03:58 +0200 (CEST)","from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com\n\t[IPv6:2607:f8b0:4864:20::f35])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66EAB628FA\n\tfor ;\n\tMon, 25 Sep 2023 17:03:57 +0200 (CEST)","by mail-qv1-xf35.google.com with SMTP id\n\t6a1803df08f44-65b0383f618so16844846d6.1\n\tfor ;\n\tMon, 25 Sep 2023 08:03:57 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695654238;\n\tbh=FjjnlAuOPADDeceObfx3tTPs9u7xmKHmdXcyFElfHq8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=QzmYJA5GPKkqW1l9t6vWFjj9tbzf3+JdFqSkwWE1auKhHKOBVVZgVQDVdIcT1DLjl\n\tAcvoen090gZWgOdtNr6pf+cjYj41hRI3usSW6knh5MiHHpVfyoTxeSvDvlUQSnIGKY\n\tf+8QJ3D98JrZwnkow/fES2PLaDq5wHIaoQmUu+DCMdgV5DAK/GCzFP4JPHxIu1jA1a\n\tXUElBZUghOXQ5sG5mjSCfAQVnfU4Im2wbcfNfmKDXOzqBOmmuDjabyVx5oFrvr9ao1\n\tC7X7YSLV1Rg6iPMygFxpsqxoK8ThxshcssHqhMmNwW7ZtELmKtH+Cvs/OHs/zPFo1f\n\tAJGy+E0Ji6PXA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695654236; x=1696259036;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=n0YohL+2b7WHiVpvl78GXzpPb6Oh4BNoBF1pPsocUGY=;\n\tb=JP60opAqX14F78DPZoMRb/WapVRMCHaTbR476xXee5AjMv+Ofkr3dYCr7/m2Dnui8n\n\tFkR2TCxVJglwknf/TF3T52MuJ7UAKE0erKNY7yMLTxYbNRYWkYQCHVGUNZZ4+9EJ2wh4\n\tOsrHTXU8CWiWJ9bIXPS5FJqUhHQu6VimmOHCP7fW1uY3itwLI8b/KeP/crfdvgMS5WBL\n\ti1kIgE0Vy0f1itkUt3rgnwINRo3aprxgcMQ7qJe908Ga5rx7izEtWXjOF4mGDvPtQXgY\n\tIU9qu2xMDo4Xlk8NEyUS5iaG2bmLTKsXkzUQDITZho7WJbCc6KSOuP3EZOLymm1pSb+f\n\taASQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"JP60opAq\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695654236; x=1696259036;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=n0YohL+2b7WHiVpvl78GXzpPb6Oh4BNoBF1pPsocUGY=;\n\tb=ri8qM8oteaQBelrnmCBn5ezVWZsDr7l0ocsWBDpjS9F5tcwFV4lcUvZWSka5oZlWdm\n\tvgXEijZyvCNQFTPYN6zLQaPkizWeT88euEWYNIB/W2FSHw4r7pLbdg1wE1ZzR/naYnS3\n\tfwtC2Ma+97p2aLySSr2M8C220MwWlMtlztGoxNpVZvBSmWuLrKE/a0k+MIcL6JXe3clC\n\tn6JTMmJ+PDWb5fCdzDvZp9L86Wg2YmFG/ZkMxR8YgKWLeK8PCfLRmNc17+5ZiwCcN2o1\n\tImIFHfF7oAdrXC8bwAbTYzVz8ve2dw+/ELC0ofXj484qTJL8jGzPbtnds/gNp3NZrdBB\n\tEqAw==","X-Gm-Message-State":"AOJu0YyDCa/XnbQ4ub9HO3JC8b40hKmrMdgRAWtlvIkxAaXyZhRgbfG5\n\tc2KRKcgC10y3rQnjz+dcvaZ8jaAaaPSy3q/46Gzz/g==","X-Google-Smtp-Source":"AGHT+IGp6704wRrqO373Z1N4N4WmOTg6zvIcDvJG9ogdIAdLgHDWE5xSpQtcJ9jVEiZj/CLygxo4mOD4jJSF67XyKTs=","X-Received":"by 2002:a05:6214:f6b:b0:635:f899:660b with SMTP id\n\tiy11-20020a0562140f6b00b00635f899660bmr10542149qvb.36.1695654236045;\n\tMon, 25 Sep 2023 08:03:56 -0700 (PDT)","MIME-Version":"1.0","References":"<20230918091045.16992-1-naush@raspberrypi.com>","In-Reply-To":"<20230918091045.16992-1-naush@raspberrypi.com>","Date":"Mon, 25 Sep 2023 16:03:45 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Reset the frame\n\tlengths queue during configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]