[{"id":27786,"web_url":"https://patchwork.libcamera.org/comment/27786/","msgid":"<169478414121.133283.16985883975752594614@ping.linuxembedded.co.uk>","date":"2023-09-15T13:22:21","subject":"Re: [libcamera-devel] [PATCH v3 06/12] libcamera: rpi: Fix wrong\n\tcomment indentation","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2023-09-15 14:06:44)\n> The closing line of a comment block was aligned with spaces and not\n> tabs. Fix it.\n> \n> Signed-off-by: Jacopo Mondi \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> index 81b2b7d2f4d1..3e7c487fb0bf 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n> @@ -273,7 +273,7 @@ private:\n> * Store the colour spaces that all our streams will have. RGB format streams\n> * will have the same colorspace as YUV streams, with YCbCr field cleared and\n> * range set to full.\n> - */\n> + */\n> std::optional yuvColorSpace_;\n> std::optional rgbColorSpace_;\n> };\n> -- \n> 2.42.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A67B1BD160\n\tfor ;\n\tFri, 15 Sep 2023 13:22:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F1EA62918;\n\tFri, 15 Sep 2023 15:22:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C35EE628EC\n\tfor ;\n\tFri, 15 Sep 2023 15:22:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 521FF9A8;\n\tFri, 15 Sep 2023 15:20:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694784146;\n\tbh=98vzjMtpiUV9hBrsfAPyD/c8awj6fs22APaHAK+jhIA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=slULSVE7XXrg9DeKwmMOPc8CCxJIn805I6lwoe/r3rkoD2VJH5RaGTqc0WQKIdvsq\n\t37MuCXiKOCuIN589cVdYmu6NV97XKFRzucBdOurMVKDBRP5OISfl3SKyr3Ie5PAYIv\n\tcIjLpMpq2sQ+I6pDRsU6HAe/0c3U+B2LS9Eni8ROrNKwLlr2T/7Oow7yFgUjwTvIyV\n\tFUqf3bVCwvWvPjPrlScCTFE9c1z9Qg306kfS2Wk/1etdX885qxnnjCW/KbR6hfPdhV\n\tItlg8TVLpqbX8brHQFQ02ptU0RuF6Mn4uYE1xABD6iqmK1jJBOk5bmOhz2+8YFpDnv\n\tMAiRDvSF2Qd/Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1694784050;\n\tbh=98vzjMtpiUV9hBrsfAPyD/c8awj6fs22APaHAK+jhIA=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=r3CEc4a50sYKt/qoKNLevrCYQr2XbXg+U7rEWIg0/vZBeh8BdWcqpSBYqinp4FJi7\n\t5wG/Lwsu0tw/qtbAGqtbHZmpWGxjnYMpYGqdz2iyYwnmCwrYbG3egdxap37MAzMzES\n\t8X7ewdG0JHEVgB7b9HrVZfICMrtLpHZWhXSzqUng="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"r3CEc4a5\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230915130650.35691-7-jacopo.mondi@ideasonboard.com>","References":"<20230915130650.35691-1-jacopo.mondi@ideasonboard.com>\n\t<20230915130650.35691-7-jacopo.mondi@ideasonboard.com>","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 15 Sep 2023 14:22:21 +0100","Message-ID":"<169478414121.133283.16985883975752594614@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 06/12] libcamera: rpi: Fix wrong\n\tcomment indentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]