{"id":19010,"url":"https://patchwork.libcamera.org/api/patches/19010/?format=json","web_url":"https://patchwork.libcamera.org/patch/19010/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230915-libyuv-convert-v1-4-1e5bcf68adac@baylibre.com>","date":"2023-09-15T07:57:28","name":"[libcamera-devel,RFC,4/7] android: camera_device: support when no Direct stream is found","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"5ddccdfd9b57cf1eedf20aa3b20b202fd70dabb2","submitter":{"id":153,"url":"https://patchwork.libcamera.org/api/people/153/?format=json","name":"Mattijs Korpershoek","email":"mkorpershoek@baylibre.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19010/mbox/","series":[{"id":4023,"url":"https://patchwork.libcamera.org/api/series/4023/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4023","date":"2023-09-15T07:57:24","name":"android: add YUYV->NV12 conversion via libyuv","version":1,"mbox":"https://patchwork.libcamera.org/series/4023/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19010/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19010/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A111C32B0\n\tfor ;\n\tFri, 15 Sep 2023 07:57:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C57D6291D;\n\tFri, 15 Sep 2023 09:57:33 +0200 (CEST)","from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7200262911\n\tfor ;\n\tFri, 15 Sep 2023 09:57:30 +0200 (CEST)","by mail-wr1-x430.google.com with SMTP id\n\tffacd0b85a97d-307d58b3efbso1673981f8f.0\n\tfor ;\n\tFri, 15 Sep 2023 00:57:30 -0700 (PDT)","from [192.168.1.20] ([2a01:cb19:8704:be00:4f55:bd9d:611a:6c8e])\n\tby smtp.gmail.com with ESMTPSA id\n\tm2-20020a056000174200b0031fe9a47a87sm2506942wrf.112.2023.09.15.00.57.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 15 Sep 2023 00:57:29 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694764653;\n\tbh=4ps3su9sccE3KcyunR2qOZ3yin2JQeACKjKB208QI34=;\n\th=Date:References:In-Reply-To:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=JlDE/qfRL5o7hNr9tKXJZIGgHWljhAqwp4hyYXBmweREhdF8GNnCech20T11Hpi5o\n\tY62sIUPk5Szso39sFXx4ZsghNuGip2UpXCaCalxDEJcBSJFC1LRR9ELxy5f1Ogu7gG\n\tHTvBKgqA3WE0VLMCa5WbsefDQ32G1ChO14BlCHA4loUzKsW1+sj4ybK4glzsc58QbX\n\t7Ou6GGRRRUps8OyUD3ZDvVFfMIGmwmaq9a3kn9szdudw0aMfDR/q6BqZIxj3o7GZkO\n\tJEMV40yZWJ8PAzynL8VLw6AECvPie/SIXDXad5Qhj3f/dZM5MwPNp21l0RkLmOd2RJ\n\tUJZAZNej5rrTQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1694764650;\n\tx=1695369450; darn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=q8b8Y5ZxAxJoxZYo1iZ+1EV95/CTGwBGZwZrmCm9cTk=;\n\tb=CFwB92r3B0RJ5ySxaKY5kCtE8Z+gv3AuaY0jq4T2ySHhBNvi1hVezkULPCTU3bX2AD\n\t75nADo/Wv5gfOLxBJpEHtk+D+njeuA/KZmkR2/M15vXoXTdHvRs3JzAWnD9h24wIxju0\n\ti7uk3NaxjATA++CcQ4C1KnEbb5NGx4CkY34IBnowjSWvAgnKEJky9AaA+mbjqWfFCRM/\n\tQD52+wkM4m/UVUNEAPex0nLZf/yZxAnEwa1gysU8nxFdNOjGjcWHcnzOAjHYoApaFI03\n\tpB7cQ9CXMsOl5wewFiJijynogighXmDEgONtroqOf50zvyPu3BrbQEnQKk556IquFJ4X\n\tAg9Q=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20230601.gappssmtp.com\n\theader.i=@baylibre-com.20230601.gappssmtp.com header.b=\"CFwB92r3\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1694764650; x=1695369450;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=q8b8Y5ZxAxJoxZYo1iZ+1EV95/CTGwBGZwZrmCm9cTk=;\n\tb=bB1ZaddDfmQGENdWWsE6GVhOfl3f4gp/NrjxqzL26WsRLxPyaShMoeUszUvlXzRRLW\n\tyyA4xCIUYeWtcMOrMgEU09RwDqY7aQTIs9aniH3FhqmZBkgjzl4r6o9R1VsLHifbuIBv\n\tNyf0P04psaHlWeMjUcIVRNPhzPrd1zZtwBaKRM/VSF5BMnTQfQ4KObJq/ElDeKhFLc/g\n\trSDtmAgPu871q6MXgS64xF8PNV+XqnbVq/pkWD47UV7m9sy00WX3tW3b0MFSH+kTm78T\n\t59KpnG3DmJD99kZ+VEK36lvx4tj9GzB24WImbXy4Pc2fNHlTGUKRO3xN+x85+dJLUWpN\n\t+a9g==","X-Gm-Message-State":"AOJu0Yy7jFnixZAY/sU4VlLm+iJdsgPpfjaY2V00wCusK4Fc78xYt7B1\n\tVyvZ2c848qnoT1J7EKROATrBJGffzVatv98vASk=","X-Google-Smtp-Source":"AGHT+IEnFidxUslLAIz8lykDzfVgh4ciiXc6ftDajrKB5KwNJ3dXqWnAWJ8gydLMoEZ1ztxJ6IGWcw==","X-Received":"by 2002:a5d:534c:0:b0:314:1f1e:3a85 with SMTP id\n\tt12-20020a5d534c000000b003141f1e3a85mr638608wrv.61.1694764650073; \n\tFri, 15 Sep 2023 00:57:30 -0700 (PDT)","Date":"Fri, 15 Sep 2023 09:57:28 +0200","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20230915-libyuv-convert-v1-4-1e5bcf68adac@baylibre.com>","References":"<20230915-libyuv-convert-v1-0-1e5bcf68adac@baylibre.com>","In-Reply-To":"<20230915-libyuv-convert-v1-0-1e5bcf68adac@baylibre.com>","To":"libcamera-devel@lists.libcamera.org","X-Mailer":"b4 0.12.4-dev-6aa5d","Subject":"[libcamera-devel] [PATCH RFC 4/7] android: camera_device: support\n\twhen no Direct stream is found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mattijs Korpershoek via libcamera-devel\n\t","Reply-To":"Mattijs Korpershoek ","Cc":"Guillaume La Roque ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"As the comment states, it's possible that the first element in\nstreamConfig.streams is a Internal stream.\nIn that case sourceStream stays a nullptr and all the Mapped streams are\nmapped towards a nullptr.\n\nMake sure that the Mapped streams are mapped to an Internal stream in case\nthat's the first element.\n\nSigned-off-by: Mattijs Korpershoek \n---\n src/android/camera_device.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1f7ce4402b63..d34bae715a47 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -724,7 +724,8 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\t\t * be used when constructing the subsequent mapped\n \t\t\t * streams.\n \t\t\t */\n-\t\t\tif (stream.type == CameraStream::Type::Direct)\n+\t\t\tif (stream.type == CameraStream::Type::Direct ||\n+\t\t\t stream.type == CameraStream::Type::Internal)\n \t\t\t\tsourceStream = &streams_.back();\n \t\t}\n \t}\n","prefixes":["libcamera-devel","RFC","4/7"]}