{"id":19003,"url":"https://patchwork.libcamera.org/api/patches/19003/?format=json","web_url":"https://patchwork.libcamera.org/patch/19003/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230913152146.636483-2-chenghaoyang@google.com>","date":"2023-09-13T15:20:50","name":"[libcamera-devel,v1,1/1] Android adapter: CameraDevice fixes shared internal buffer","commit_ref":"dbe4e0e9457c349ea6a797b62d5f55e15c67f642","pull_url":null,"state":"accepted","archived":false,"hash":"82216ff6311ede02d9d948772331a7deb92fc7f6","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/?format=json","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19003/mbox/","series":[{"id":4020,"url":"https://patchwork.libcamera.org/api/series/4020/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4020","date":"2023-09-13T15:20:49","name":"Android adaptor: CameraDevice fix","version":1,"mbox":"https://patchwork.libcamera.org/series/4020/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19003/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19003/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47AC4C3260\n\tfor ;\n\tWed, 13 Sep 2023 15:21:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0923628F5;\n\tWed, 13 Sep 2023 17:21:58 +0200 (CEST)","from mail-pf1-x436.google.com (mail-pf1-x436.google.com\n\t[IPv6:2607:f8b0:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BE00628E9\n\tfor ;\n\tWed, 13 Sep 2023 17:21:55 +0200 (CEST)","by mail-pf1-x436.google.com with SMTP id\n\td2e1a72fcca58-68fb7fb537dso3439186b3a.2\n\tfor ;\n\tWed, 13 Sep 2023 08:21:55 -0700 (PDT)","from chenghaoyang-low.c.googlers.com.com\n\t(198.180.199.104.bc.googleusercontent.com. [104.199.180.198])\n\tby smtp.gmail.com with ESMTPSA id\n\tb26-20020aa7871a000000b006887be16675sm4922463pfo.205.2023.09.13.08.21.51\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 13 Sep 2023 08:21:52 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694618518;\n\tbh=7wyAeWN9DiM76aMmjbmuweH7TQ5Qd+vPLgiFqkRgYNk=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=qHHR0RM8EGkj24w3X8vHzeSNlS3eT15QHf1xVzN5rpQsXS9XZ7W3Zz4uVvZQu4aCl\n\tLf1WSiHljh6xYabpOIOea5+rCPeRJaNHUy6VbPyeesfbs+l41FmxTQHeKmhDibykBy\n\tVyBzkuQ3AtDOg11693ifEWQBbi9FwtY1+yIf8rns1tPPtqHr8q0phhcG2ujBiRu46B\n\t/15WpPtcvTGjXsuqVfL0yL6a+khi1mB467vjuH5x4AVSjVNg1a0o82wKNuAnFu6tlc\n\tYW+qRWOVt6scCyrl58UltgjIOYUGg412cmM+2kVJvhvF0mrisqs5i3A30+xY/mI0yk\n\tYkro6S7AtSeMw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1694618513; x=1695223313;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=jk7pfldNzCJwQleRpZrxfVkyNI5YMWShVSWjUWvQM1I=;\n\tb=QKiPaU0+KPzgKPjkFeMEg+6n+c2iKl8Dh+CoDZEBXBSZSVjKExJNVXp5chPHj/uAdR\n\tJx8Bf/0p6Ij2N2c89nMq5WoEuvLbPxk0OIKg3/x4DxMdzMeP2tzrWmTF5PxLGnD5aInR\n\tg0NhRsem8SQZ2xrOSrmpRYj32KgGPNVwAF4wo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"QKiPaU0+\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1694618513; x=1695223313;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=jk7pfldNzCJwQleRpZrxfVkyNI5YMWShVSWjUWvQM1I=;\n\tb=DqFqUqjjb8dKzJOMqgr+Dktlo/ia4UKwM9Ft5oCHDFghpR5ohLLLzMvSW/G1pXL4Mu\n\txyrIupaHv79QY8TM63ZaNZnqvhE62IYfYZsxV6CLwH+9Tp3HrfatgPEH5nMBSd583cXB\n\t/hQIsVW9pwBN/dElg8w2i9TgMZSabXBe95FIpVx8fmr6Ui/7UoXSbLlda0i0vi3a3cO7\n\tobRLSOoNJSH/XhkVIpR3rGnlb3OYHeLkzbH4UECNsw7xDLAs9+59skrUG7vQqHi9pL16\n\tW/Xjz/R0Bz50tWePjPXxBnGuTCsv47fOqHF3FAITM5yCNVAsZ1KwYcxSTVF2W/Nm/VaE\n\tTW0Q==","X-Gm-Message-State":"AOJu0YzNBLo38UJvsBhDVaAAO1uHmdZ7sX3dUaBZHArEs4CEEFM4RHxK\n\twlpJvVt2/YYTWZM/VDt3SyRu5BIp+FjW6OjtCOw=","X-Google-Smtp-Source":"AGHT+IFrs9j38fPlKkxVwCZOAeTsCMBRyc2VaZxFescPIVfCVgPlDhcICkbDOFKHsOHtXR7mpfIDdA==","X-Received":"by 2002:a05:6a00:2d8f:b0:68f:dd50:aef8 with SMTP id\n\tfb15-20020a056a002d8f00b0068fdd50aef8mr3378920pfb.4.1694618513042; \n\tWed, 13 Sep 2023 08:21:53 -0700 (PDT)","X-Google-Original-From":"Harvey Yang ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 13 Sep 2023 15:20:50 +0000","Message-ID":"<20230913152146.636483-2-chenghaoyang@google.com>","X-Mailer":"git-send-email 2.42.0.283.g2d96d420d3-goog","In-Reply-To":"<20230913152146.636483-1-chenghaoyang@google.com>","References":"<20230913152146.636483-1-chenghaoyang@google.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v1 1/1] Android adapter: CameraDevice\n\tfixes shared internal buffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Harvey Yang via libcamera-devel ","Reply-To":"Harvey Yang ","Cc":"Harvey Yang ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Harvey Yang \n\nIn CameraDevice::processCaptureRequest, we might need to add an internal\nbuffer for Mapped streams. This patch fixes a case that more than one\nMapped streams depend on a stream that is not requested in one capture\nrequest.\n\nChange-Id: I37a1bcc9c4c2db666a90d74c39883ff18ed11bd5\nSigned-off-by: Harvey Yang \n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 1f7ce440..25cedd44 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1077,7 +1077,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t\tdescriptor->request_->addBuffer(sourceStream->stream(),\n \t\t\t\t\t\tframeBuffer, nullptr);\n \n-\t\trequestedStreams.erase(sourceStream);\n+\t\trequestedStreams.insert(sourceStream);\n \t}\n \n \t/*\n","prefixes":["libcamera-devel","v1","1/1"]}