[{"id":2607,"web_url":"https://patchwork.libcamera.org/comment/2607/","msgid":"<20190904191923.GK5433@pendragon.ideasonboard.com>","date":"2019-09-04T19:19:23","subject":"Re: [libcamera-devel] [PATCH v2 10/14] libcamera: ipa: meson: Allow\n\taccess to internal libcamera headers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Aug 30, 2019 at 01:26:49AM +0200, Niklas Söderlund wrote:\n> Allow IPA implementations to use internal libcamera headers so they can\n> utilize helpers not exposed to applications.\n> \n> Signed-off-by: Niklas Söderlund \n> Reviewed-by: Kieran Bingham \n\nFor open-source IPAs that are shipped with libcamera this is fine, but\nthird-party IPAs, open-source or closed-source, won't have access to\ninternal headers.\n\nFor the open-source IPAs this isn't a blocker, but should still be\naddressed sooner than later. For the closed-source IPAs, I notice you\ninclude v4l2_controls.h in ipa_interface.h, and that's a problem as it\nrequires linking against libcamera. I would like to discuss how to solve\nthis issue. In the meantime,\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index 2b9863bce3eabe80..dca7a9461385b68d 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -9,7 +9,7 @@ foreach t : ipa_dummy_sources\n> ipa = shared_module(t[0],\n> t[1],\n> name_prefix : '',\n> - include_directories : libcamera_includes,\n> + include_directories : includes,\n> install : true,\n> install_dir : ipa_install_dir)\n> endforeach","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A34C60BB2\n\tfor ;\n\tWed, 4 Sep 2019 21:19:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C3336440;\n\tWed, 4 Sep 2019 21:19:29 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567624770;\n\tbh=QxrwhBwnuz8tk2mgJaoQea2pKWmtwIB5p3QjagBCIMk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uhMzJJ7sOZg+Pa4/LxDWMa/gZgitthLnzf2p4XCH79DnfcyWhWD8ePOnsf2BIrONS\n\tvdeDwVBD91VH7+w15/ZozWQA8CkYLrrn7gnW5cOfaTDieHHr+GmXvrXqsVjxFJ9Ba5\n\tOI3ttOGaJ0SZqGI648lSOqmLZpVinMpNCvmvma5M=","Date":"Wed, 4 Sep 2019 22:19:23 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190904191923.GK5433@pendragon.ideasonboard.com>","References":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>\n\t<20190829232653.13214-11-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190829232653.13214-11-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 10/14] libcamera: ipa: meson: Allow\n\taccess to internal libcamera headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 19:19:30 -0000"}}]