{"id":18975,"url":"https://patchwork.libcamera.org/api/patches/18975/?format=json","web_url":"https://patchwork.libcamera.org/patch/18975/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230901150215.11585-13-jacopo.mondi@ideasonboard.com>","date":"2023-09-01T15:02:15","name":"[libcamera-devel,v5,12/12] py: cam: Add option to set stream orientation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"037395cc045ccadcbc2588dae4e0f2314e2af9ee","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18975/mbox/","series":[{"id":4010,"url":"https://patchwork.libcamera.org/api/series/4010/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4010","date":"2023-09-01T15:02:03","name":"libcamera: Replace CameraConfiguration::transform","version":5,"mbox":"https://patchwork.libcamera.org/series/4010/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18975/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18975/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9957DC32B7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  1 Sep 2023 15:03:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0EE12628F3;\n\tFri,  1 Sep 2023 17:03:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC88E628F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  1 Sep 2023 17:02:55 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A51A61288;\n\tFri,  1 Sep 2023 17:01:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1693580580;\n\tbh=OsMSzhJr2Feh6IYM0vX5jRQDQ74eSJ0ryvRr2HrJTyA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=jdhLiOZ/pg5ODiVEMKPx6ZhQbg9CkW4xwa6D8151rDIe3XC62CztnCXyhcTIfyWtR\n\txrn21kjkClitEkYCEHXfsTaR2nWkhE5zCXMvMEsNbhaInDZp6kEkg10AHCM0g0G6Pm\n\tp6XywOQ3HY0ETbTkIQraCcpmN0lCpuqCaD2tsvohhjurIphU6qRyzcCibVnU6iFYTI\n\tlSK/rQUpQy6vSOEbRyBqGc3y/P7P6rN9nBCvuWkqj+lBgeQmYeTczWdwZVvLkpWCWs\n\tEJvELgPwiiFtfj3Vq6OJcuue0B8nuPaPkDzF3SJPULtKDl7QCBQnj3Rne7pCG7u3Zm\n\tGOd+bZCJzONPg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1693580492;\n\tbh=OsMSzhJr2Feh6IYM0vX5jRQDQ74eSJ0ryvRr2HrJTyA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=milbAz24jomymGeU32tQ6rrW9eakXV7lgRkK1bZK8d0a2xn/L5gaSZrhoJp8HQsPf\n\tYGQ5HojDbaoNZUlPZbksv8haR3i3GwYvG6JV2fLOb5VPTQqvrry9NNDTU+VBXk7b11\n\tu/FPjeSjH7PzmhBVnrRRO754zAq5rP0Ht4mj9BZM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"milbAz24\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri,  1 Sep 2023 17:02:15 +0200","Message-Id":"<20230901150215.11585-13-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20230901150215.11585-1-jacopo.mondi@ideasonboard.com>","References":"<20230901150215.11585-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 12/12] py: cam: Add option to set\n\tstream orientation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add a '--orientation|-o' option to the Python version of the cam test\napplication to set an orientation to the image stream.\n\nSupported values are:\n- Rot180: Rotate 180 degrees\n- Flip: vertical flip\n- Mirror: horizontal flip\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/py/cam/cam.py | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)","diff":"diff --git a/src/py/cam/cam.py b/src/py/cam/cam.py\nindex a2a115c164b4..84d8ca1716fd 100755\n--- a/src/py/cam/cam.py\n+++ b/src/py/cam/cam.py\n@@ -23,6 +23,7 @@ class CameraContext:\n     opt_metadata: bool\n     opt_save_frames: bool\n     opt_capture: int\n+    opt_orientation: str\n \n     stream_names: dict[libcam.Stream, str]\n     streams: list[libcam.Stream]\n@@ -146,6 +147,20 @@ class CameraContext:\n             if 'pixelformat' in stream_opts:\n                 stream_config.pixel_format = libcam.PixelFormat(stream_opts['pixelformat'])\n \n+        if self.opt_orientation is not None:\n+            orientation_map = {\n+                'Rot180': libcam.Orientation.Rotate180,\n+                'Mirror': libcam.Orientation.Rotate0Flip,\n+                'Flip': libcam.Orientation.Rotate180Flip,\n+            }\n+\n+            orient = orientation_map.get(self.opt_orientation, None)\n+            if orient is None:\n+                print('Bad orientation: ', self.opt_orientation)\n+                sys.exit(-1)\n+\n+            camconfig.orientation = orient\n+\n         stat = camconfig.validate()\n \n         if stat == libcam.CameraConfiguration.Status.Invalid:\n@@ -385,6 +400,7 @@ def main():\n     parser.add_argument('--metadata', nargs=0, type=bool, action=CustomAction, help='Print the metadata for completed requests')\n     parser.add_argument('--strict-formats', type=bool, nargs=0, action=CustomAction, help='Do not allow requested stream format(s) to be adjusted')\n     parser.add_argument('-s', '--stream', nargs='+', action=CustomAction)\n+    parser.add_argument('-o', '--orientation', help='Desired image orientation (Rot180, Mirror, Flip)')\n     args = parser.parse_args()\n \n     cm = libcam.CameraManager.singleton()\n@@ -408,6 +424,10 @@ def main():\n         ctx.opt_metadata = args.metadata.get(cam_idx, False)\n         ctx.opt_strict_formats = args.strict_formats.get(cam_idx, False)\n         ctx.opt_stream = args.stream.get(cam_idx, ['role=viewfinder'])\n+        if args.orientation is not None:\n+            ctx.opt_orientation = args.orientation\n+        else:\n+            ctx.opt_orientation = None\n         contexts.append(ctx)\n \n     for ctx in contexts:\n","prefixes":["libcamera-devel","v5","12/12"]}