{"id":18974,"url":"https://patchwork.libcamera.org/api/patches/18974/?format=json","web_url":"https://patchwork.libcamera.org/patch/18974/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230901150215.11585-12-jacopo.mondi@ideasonboard.com>","date":"2023-09-01T15:02:14","name":"[libcamera-devel,v5,11/12] apps: cam: Add option to set stream orientation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"33c647861fa433ddfd4530818c16752a8f8e95f2","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18974/mbox/","series":[{"id":4010,"url":"https://patchwork.libcamera.org/api/series/4010/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4010","date":"2023-09-01T15:02:03","name":"libcamera: Replace CameraConfiguration::transform","version":5,"mbox":"https://patchwork.libcamera.org/series/4010/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18974/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18974/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0325DC32B6\n\tfor ;\n\tFri, 1 Sep 2023 15:02:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58B7A628EE;\n\tFri, 1 Sep 2023 17:02:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EC2E628E8\n\tfor ;\n\tFri, 1 Sep 2023 17:02:55 +0200 (CEST)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 224F91ACC;\n\tFri, 1 Sep 2023 17:01:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1693580579;\n\tbh=jTeJz3d++J8zAM5ys7Nfj/HDlO+AoIZ16Lsg0cvM76U=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ARSgpptmTCEDzwNavtXlaKavHE8xXQrcgbA9XyCRwu8xXgbAYf8LyxBNTtSJASMjC\n\toaMjxGUAU2KqjENbF5GzF0DFDlU/K3nR8pY+HrmzjdYJrUQy/7eQJLr2r9d0oTdjZM\n\tRhQtuaj628C4a2GLCjtHU04a24DVywl+nBw6BTX1ON8lYYJavH3XQBC0AQhkcHj74x\n\tOvMOQ+GiXkUdbF8j+GOufjC2WrAGwZU6BhGA8xKseymDY4GudlY2mxtAblycFL1+Xz\n\t/1SQmu15ojioTGHqRmcpg/5GSfQqAJ6quZfEF96wAchGyCeNsGSZJil9xqUBCsKMv/\n\tBDrvQyL0ZE0Bg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1693580491;\n\tbh=jTeJz3d++J8zAM5ys7Nfj/HDlO+AoIZ16Lsg0cvM76U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fRjnRKU9K1+BuoUPgYyU9mFGqgRQMKnETeE2tlGd8v4TQzPfLJam0zee54mHlAA4o\n\tdbapxFU/I1MW35WZLlFVhmSStjCBD2rvD4E0RjP4aYQrckH7WQLsV8ay0va60k4Yzg\n\tx1trwGlqXWW4VjVQdbSfedBWL8sju4oAjTbxD9b4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fRjnRKU9\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 1 Sep 2023 17:02:14 +0200","Message-Id":"<20230901150215.11585-12-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20230901150215.11585-1-jacopo.mondi@ideasonboard.com>","References":"<20230901150215.11585-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 11/12] apps: cam: Add option to set\n\tstream orientation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a '--orientation|-o' option to the cam test application to set\nan orientation to the image stream.\n\nSupported values are the ones obtained by applying flips to the camera\nsensor:\n- rot180: Rotate 180 degrees\n- flip: vertical flip\n- mirror: horizontal flip\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: David Plowman \n---\n src/apps/cam/camera_session.cpp | 17 +++++++++++++++++\n src/apps/cam/main.cpp | 5 +++++\n src/apps/cam/main.h | 1 +\n 3 files changed, 23 insertions(+)","diff":"diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 066e397b5f47..1cf7a245aaa7 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -65,6 +65,23 @@ CameraSession::CameraSession(CameraManager *cm,\n \t\treturn;\n \t}\n \n+\tif (options_.isSet(OptOrientation)) {\n+\t\tstd::string orient = options_[OptOrientation].toString();\n+\t\tif (orient == \"rot180\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::Orientation::rotate180;\n+\t\t} else if (orient == \"mirror\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::Orientation::rotate0Flip;\n+\t\t} else if (orient == \"flip\") {\n+\t\t\tconfig->orientation =\n+\t\t\t\tlibcamera::Orientation::rotate180Flip;\n+\t\t} else {\n+\t\t\tstd::cerr << \"Invalid orientation \" << orient << std::endl;\n+\t\t\treturn;\n+\t\t}\n+\t}\n+\n \t/* Apply configuration if explicitly requested. */\n \tif (StreamKeyValueParser::updateConfiguration(config.get(),\n \t\t\t\t\t\t options_[OptStream])) {\ndiff --git a/src/apps/cam/main.cpp b/src/apps/cam/main.cpp\nindex 5d8a57bc14e5..d68243edac3f 100644\n--- a/src/apps/cam/main.cpp\n+++ b/src/apps/cam/main.cpp\n@@ -133,6 +133,11 @@ int CamApp::parseOptions(int argc, char *argv[])\n \t\t\t \"Capture until interrupted by user or until frames captured\",\n \t\t\t \"capture\", ArgumentOptional, \"count\", false,\n \t\t\t OptCamera);\n+\n+\tparser.addOption(OptOrientation, OptionString,\n+\t\t\t \"Desired image orientation (rot180, mirror, flip)\",\n+\t\t\t \"orientation\", ArgumentRequired, \"orientation\", false,\n+\t\t\t OptCamera);\n #ifdef HAVE_KMS\n \tparser.addOption(OptDisplay, OptionString,\n \t\t\t \"Display viewfinder through DRM/KMS on specified connector\",\ndiff --git a/src/apps/cam/main.h b/src/apps/cam/main.h\nindex 526aecece3f3..4aa959b32e13 100644\n--- a/src/apps/cam/main.h\n+++ b/src/apps/cam/main.h\n@@ -17,6 +17,7 @@ enum {\n \tOptList = 'l',\n \tOptListProperties = 'p',\n \tOptMonitor = 'm',\n+\tOptOrientation = 'o',\n \tOptSDL = 'S',\n \tOptStream = 's',\n \tOptListControls = 256,\n","prefixes":["libcamera-devel","v5","11/12"]}