{"id":1896,"url":"https://patchwork.libcamera.org/api/patches/1896/?format=json","web_url":"https://patchwork.libcamera.org/patch/1896/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190829232653.13214-10-niklas.soderlund@ragnatech.se>","date":"2019-08-29T23:26:48","name":"[libcamera-devel,v2,09/14] libcamera: request: Allow read only access to controls","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ac43642224e7db6f3037284b3108c325e169c6dc","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1896/mbox/","series":[{"id":475,"url":"https://patchwork.libcamera.org/api/series/475/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=475","date":"2019-08-29T23:26:40","name":"libcamera: ipa: Add basic IPA support","version":2,"mbox":"https://patchwork.libcamera.org/series/475/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1896/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1896/checks/","tags":{},"headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D8CDF60E38\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Aug 2019 01:27:34 +0200 (CEST)","from bismarck.berto.se (unknown [79.202.45.17])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 9142ca18-cab4-11e9-837a-0050569116f7;\n\tFri, 30 Aug 2019 01:27:29 +0200 (CEST)"],"X-Halon-ID":"9142ca18-cab4-11e9-837a-0050569116f7","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 30 Aug 2019 01:26:48 +0200","Message-Id":"<20190829232653.13214-10-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.22.1","In-Reply-To":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>","References":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v2 09/14] libcamera: request: Allow read\n\tonly access to controls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 29 Aug 2019 23:27:35 -0000"},"content":"Allow the controls in a Request to be examined from a const\nenvironment.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/request.h | 1 +\n src/libcamera/request.cpp   | 5 +++++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 570924c5ef5e2425..f5de5257bba3f2bb 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -40,6 +40,7 @@ public:\n \t~Request();\n \n \tControlList &controls() { return controls_; }\n+\tconst ControlList &controls() const { return controls_; }\n \tconst std::map<Stream *, Buffer *> &buffers() const { return bufferMap_; }\n \tint addBuffer(std::unique_ptr<Buffer> buffer);\n \tBuffer *findBuffer(Stream *stream) const;\ndiff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex b8b4dfb4b7549163..bdb4f908fb664ccf 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -84,6 +84,11 @@ Request::~Request()\n  * \\return A reference to the ControlList in this request\n  */\n \n+/**\n+ * \\fn Request::controls() const\n+ * \\sa Request::controls()\n+ */\n+\n /**\n  * \\fn Request::buffers()\n  * \\brief Retrieve the request's streams to buffers map\n","prefixes":["libcamera-devel","v2","09/14"]}