{"id":18959,"url":"https://patchwork.libcamera.org/api/patches/18959/?format=json","web_url":"https://patchwork.libcamera.org/patch/18959/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230824131908.12109-1-naush@raspberrypi.com>","date":"2023-08-24T13:19:08","name":"[libcamera-devel] ipa: rpi: imx290: Hide one frame on startup","commit_ref":"26ac1a8e3fc52cb2035ad88b7d22f034a68f50c7","pull_url":null,"state":"accepted","archived":false,"hash":"e71b9c18a8c5067a4aca538946325d50e51003d8","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18959/mbox/","series":[{"id":4008,"url":"https://patchwork.libcamera.org/api/series/4008/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4008","date":"2023-08-24T13:19:08","name":"[libcamera-devel] ipa: rpi: imx290: Hide one frame on startup","version":1,"mbox":"https://patchwork.libcamera.org/series/4008/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18959/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18959/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5576BE080\n\tfor ;\n\tThu, 24 Aug 2023 13:19:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B287F627E0;\n\tThu, 24 Aug 2023 15:19:13 +0200 (CEST)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C82F61E04\n\tfor ;\n\tThu, 24 Aug 2023 15:19:12 +0200 (CEST)","by mail-wr1-x434.google.com with SMTP id\n\tffacd0b85a97d-31c3726cc45so4116631f8f.0\n\tfor ;\n\tThu, 24 Aug 2023 06:19:12 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tl9-20020a5d6749000000b003143867d2ebsm22516262wrw.63.2023.08.24.06.19.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 24 Aug 2023 06:19:11 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1692883153;\n\tbh=0oNSUiuaJalXStkgeSTF+9bLWf3hzD8gNSFvSTaferQ=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=S52f4tPiGf3QYU2W6rAi7kxHnm6GHByl3DmLdaaF4KtKUZAmmjQZnlL4GI8UDr+yq\n\tw15eN63M9i+PpsloGLHVP8IS0dTYSDqOMLuMHHPYrsN9yjDRrRszzJvF6NgFs84a/y\n\tHBRiyC55G6K1OzWEDnqsISeWzTF6ugBvaq950Tw2rEyX5IcPk1K+AlQ5CMXjcbzB9Y\n\th/LOVCk9DEgoKWFstojn+kOSdZ0vjm2ysYvtL7bp4jNYEbKKR1CZfsjxHQtIrb2zHg\n\tvGT8SSIFxcz1E1Il+xLbRwUawojzqDxpj6Z0cqR3sAnS6u4lYB5KLuKiQXRpp0m5du\n\tJ76hyOTwF71LA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1692883151; x=1693487951;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=xFRDW11M9uvShRUmPgrp8KqO7/6ywZaq1zt5zUFAxGo=;\n\tb=mgvTNQKCBby32MgJmzRSUi12QwgtPxJscngFo5gpzQSZq0GlGrW5tQpj4NrJM+a8Wx\n\t+bh66FyeMudC+0RigeN0Z2IS0hPfM4Hn7mwSr5ICDXeWCOz2cWDhECev9kncOFmmS8Ew\n\thhGEQ7QcdE9wTbKiLdREOixcHTU6vJ118EsqS+yp1wJaU4X0ip7nAQFGdWPGgxCNNimi\n\tT6Tz/x6N6YAhQ4QSxlTCTZoDL1GfQRa/+CFcEdSpFKSWq9r2fFiJRsql5CYdoomMSuYv\n\tKSaIB6P7GWWP+WlyAvnLUoHL8MQbV2kLLQaYnzhieyHhb0O8XUiBBaagLrRjxv9zWK9W\n\tu7LA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"mgvTNQKC\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1692883151; x=1693487951;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=xFRDW11M9uvShRUmPgrp8KqO7/6ywZaq1zt5zUFAxGo=;\n\tb=CEvj91iscqSL7wd5ZSKJxjMWRWkEUm7NuI6N3hme2eM7v8Gx4VrayizCV2SxUAyIpV\n\tM4NlUbSgWPbWGqwfEpPa7sVdgTsBl4jYxpMnOvJGMyybK/I4cnSVwQXbK1DYxlai38BD\n\tNJn/OQo5KlFk9KkqtcS8FoWVamTmPtCzlvdvl+gbay0RJjdWbOX/kLulTWtw1hsPlFD5\n\ttkObGU8NUki+/xfhbfIgM70lPnvWghqIUj3otMZWSHkEId5+xQDkem6NcoKQ7A7JqCXh\n\tecF1MgmRsm05yO8Ul2L6fAun8HgEX63MBgRcH7N1NsDvNNdIKfFsw3Dl5VuKHZ+vF8/e\n\tvltA==","X-Gm-Message-State":"AOJu0YywwhagUjozV3+hLW8/bxChy0Jo8kmzg73uopLR65Rz9AspCDv/\n\tHAdxJjh2OCV+MfdTDxY6dNnNKSyA0e1UkUjQ7/s=","X-Google-Smtp-Source":"AGHT+IGzsGIcZnQl29EQNn8t1rsjtHtXfFy0gKo+syUC+/GV6DASlNwpYdjqiIO8j3fSm9DROxLI+Q==","X-Received":"by 2002:adf:e990:0:b0:319:6d8a:75f8 with SMTP id\n\th16-20020adfe990000000b003196d8a75f8mr13142109wrm.44.1692883151376; \n\tThu, 24 Aug 2023 06:19:11 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Aug 2023 14:19:08 +0100","Message-Id":"<20230824131908.12109-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: rpi: imx290: Hide one frame on\n\tstartup","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The imx290 produces a single unusable frame on startup and mode switch.\nThis is signalled to the IPA in the mode switch case, but not the\nstartup case. Fix this.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/rpi/cam_helper/cam_helper_imx290.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\nindex 7d6f5b549a73..d98b51cd56b3 100644\n--- a/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n+++ b/src/ipa/rpi/cam_helper/cam_helper_imx290.cpp\n@@ -19,6 +19,7 @@ public:\n \tdouble gain(uint32_t gainCode) const override;\n \tvoid getDelays(int &exposureDelay, int &gainDelay,\n \t\t int &vblankDelay, int &hblankDelay) const override;\n+\tunsigned int hideFramesStartup() const override;\n \tunsigned int hideFramesModeSwitch() const override;\n \n private:\n@@ -54,6 +55,12 @@ void CamHelperImx290::getDelays(int &exposureDelay, int &gainDelay,\n \thblankDelay = 2;\n }\n \n+unsigned int CamHelperImx290::hideFramesStartup() const\n+{\n+\t/* On startup, we seem to get 1 bad frame. */\n+\treturn 1;\n+}\n+\n unsigned int CamHelperImx290::hideFramesModeSwitch() const\n {\n \t/* After a mode switch, we seem to get 1 bad frame. */\n","prefixes":["libcamera-devel"]}