[{"id":27677,"web_url":"https://patchwork.libcamera.org/comment/27677/","msgid":"","date":"2023-08-21T14:01:29","subject":"Re: [libcamera-devel] [RFC PATCH v2 2/5] libcamera:\n\tMappedFrameBuffer: Use stored plane offset","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"content":"Hello Gabby,\n\nThanks for your patch !\n\nOn Mon, Aug 21, 2023 at 6:40 PM Gabby George wrote:\n>\n> As it is written, the MappedFrameBuffer causes a failure in mmap when\n\ns/As it is written/ /\ns/the/The\n\n> attempting to map UVC metadata planes. UVC metadata (four character\n> code UVCH) does not support exporting buffers as file descriptors, so\n> mmap can be used to give libcamera access to the metadata buffer\n> planes. It is convenient to use the already-existing\n> MappedFrameBuffers class, but the class must be modified to support\n> mapping using file descriptors of the video node itself.\n>\n> To do this, mmap needs information obtained through a call to\n> QUERYBUF, namely, the plane offset for buffer planes. Modify the\n> constructor of a MappedFrameBuffer to use the plane offset directly in\n> the call to mmap, rather than the hard-coded 0 value.\n>\n> The current version does not work when a buffer cannot be exported as\n> a dma buf fd. The fd argument to mmap must be the one obtained on a\n> call to open() for the video node (ie, /dev/videoX). This method of\n> mapping buffer planes requires the arguments to mmap to be exactly the\n> length and offset QUERYBUF provides. Mmap will return a -EINVAL if\n\ns/Mmap/mmap\n\n> this is not the case.\n>\n> Signed-off-by: Gabby George \n> ---\n> .../libcamera/internal/mapped_framebuffer.h | 3 ++-\n> src/libcamera/mapped_framebuffer.cpp | 20 ++++++++++++++-----\n> 2 files changed, 17 insertions(+), 6 deletions(-)\n>\n> diff --git a/include/libcamera/internal/mapped_framebuffer.h b/include/libcamera/internal/mapped_framebuffer.h\n> index fb39adbf..04096d1b 100644\n> --- a/include/libcamera/internal/mapped_framebuffer.h\n> +++ b/include/libcamera/internal/mapped_framebuffer.h\n> @@ -54,7 +54,8 @@ public:\n>\n> using MapFlags = Flags;\n>\n> - MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags);\n> + MappedFrameBuffer(const FrameBuffer *buffer,\n> + MapFlags flags, bool usePlaneOffset = false);\n> };\n>\n> LIBCAMERA_FLAGS_ENABLE_OPERATORS(MappedFrameBuffer::MapFlag)\n> diff --git a/src/libcamera/mapped_framebuffer.cpp b/src/libcamera/mapped_framebuffer.cpp\n> index 6860069b..3d2cc332 100644\n> --- a/src/libcamera/mapped_framebuffer.cpp\n> +++ b/src/libcamera/mapped_framebuffer.cpp\n> @@ -172,12 +172,13 @@ MappedBuffer::~MappedBuffer()\n> * \\brief Map all planes of a FrameBuffer\n> * \\param[in] buffer FrameBuffer to be mapped\n> * \\param[in] flags Protection flags to apply to map\n> + * \\param[in] usePlaneOffset Use offset stored in buffer's plane; default false\n> *\n> * Construct an object to map a frame buffer for CPU access. The mapping can be\n> * made as Read only, Write only or support Read and Write operations by setting\n> * the MapFlag flags accordingly.\n> */\n> -MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> +MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags, bool usePlaneOffset)\n> {\n> ASSERT(!buffer->planes().empty());\n> planes_.reserve(buffer->planes().size());\n> @@ -223,8 +224,14 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> const int fd = plane.fd.get();\n> auto &info = mappedBuffers[fd];\n> if (!info.address) {\n> - void *address = mmap(nullptr, info.mapLength, mmapFlags,\n> - MAP_SHARED, fd, 0);\n> + void *address;\n> + if (usePlaneOffset) {\n> + address = mmap(nullptr, plane.length, mmapFlags,\n> + MAP_SHARED, fd, plane.offset);\n> + } else {\n> + address = mmap(nullptr, info.mapLength, mmapFlags,\n> + MAP_SHARED, fd, 0);\n> + }\n\nYou could make this an oneliner using ternary operators, it would look\nmore compact I believe.\n\nsize_t length = usePlaneOffset ? plane.length : info.mapLength ;\noff_t offset = usePlaneOffset ? plane.offset : 0\nvoid *address = mmap(.., length, ..., offset);\n\n> if (address == MAP_FAILED) {\n> error_ = -errno;\n> LOG(Buffer, Error) << \"Failed to mmap plane: \"\n> @@ -233,10 +240,13 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> }\n>\n> info.address = static_cast(address);\n> - maps_.emplace_back(info.address, info.mapLength);\n> + maps_.emplace_back(info.address, usePlaneOffset ? plane.length :\n> + info.mapLength);\n> }\n>\n> - planes_.emplace_back(info.address + plane.offset, plane.length);\n> + uint8_t *storedAddress = usePlaneOffset ? info.address :\n> + info.address + plane.offset;\n\nI maybe wrong here, but looking at the code, shouldn't the operators\nbe opposite ? something like this ?\n\nuint8_t *storedAddress = usePlaneOffset ? info.address + plane.offset\n: info.address;\n\n> + planes_.emplace_back(storedAddress, plane.length);\n> }\n> }\n>\n> --\n> 2.34.1\n>\n\nRegards,\nVedant Paranjape","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23C78BF415\n\tfor ;\n\tMon, 21 Aug 2023 14:01:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77C4A61EB0;\n\tMon, 21 Aug 2023 16:01:44 +0200 (CEST)","from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com\n\t[IPv6:2607:f8b0:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9A6E61E09\n\tfor ;\n\tMon, 21 Aug 2023 16:01:42 +0200 (CEST)","by mail-ot1-x32f.google.com with SMTP id\n\t46e09a7af769-6bc9254a1baso2639257a34.2\n\tfor ;\n\tMon, 21 Aug 2023 07:01:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1692626504;\n\tbh=hO/dssiN4D264g/Ln4hwVYwy7PMXZxMNdvrS51Wrr0Y=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Sgj+FAW/F/HdPJkdQVmMd6/R71by0auMd3/MFyBHpyRxHGzNlJroBMqE2R/UbmGrY\n\t5Px3bpuOq5RuJSpIZx9rP1nReM1xQoZBWbDExVBD5NCOx5txiiKJvqOAFwQsrOHPzt\n\tilNNGcWdMCSlQnq1ECZh4iF44mvLyct4D9A1U57SgGMAqRKajkLRHvAT8ePxt6E8PR\n\tWpmm6r1DbE+TBDY/cpCnHaYbqv4Xx87lLcY0PzQw7lzvpAwQeLsuBq+U8RcQV8VSA7\n\tOoZpQMg4R86Z9N+vXj2v4l6UoEycFwhYrWPaS17lyAN4UnDaDBRmmv+bqKp4M9aFsk\n\tjuVhe7ghIFu0A==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20221208; t=1692626501; x=1693231301;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=GHxM844rIMNpej2kisBLcJVQQvkRTto+UJJlolzXDRg=;\n\tb=aevIbP+Uf2/Y3RH4B4OJKofpHXRb6vm0Me8B4XLNLvd7PIH4wHCf0NI5FULaTPL3/x\n\t44yg7hagWq6+G6VzwJSXrKZHLU/dJVRIdA4ypXQT2Y3fzp7uN+7xlbaxdnoEk6VmoN3J\n\t1trL9dNwa4UgGpf1HIatf/oW/Ot/l9CVnOzfWgdSvrsLcRl6FlORtV7AHjIh+2Cggg8p\n\tA3FAJLyMcTm5U3gaqQ+kpBWktRDgpHas+VcZiXDhkvRAgIbDptrcenfamI8kCjR4mAcM\n\tqMB071wQIA1FcRvoJkfNxzWdlhYvI75U26oolpEpVjJ1Wv6AeL9sFJqEsmzqWCCi0j8C\n\tiAVQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aevIbP+U\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1692626501; x=1693231301;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=GHxM844rIMNpej2kisBLcJVQQvkRTto+UJJlolzXDRg=;\n\tb=ijbYOxvNgmfHA8bK57mQVr4c7mjtn26Y8cPZDo3UeFBLF08BL0B/1eBHXznK9p0Fs0\n\tqaPNz+vH5h8Mwpwug+S/juzrWZN6tUAUSnDzS8HRcveYFf4m1dh4q4BzGvNqQ0Mk1rgO\n\tU0nDnmfjqmrDLLJO1coN0rqXXxpNZCBSXwa7BrwrMqYrrJdtvd2MjEth0C7co5rB14Mm\n\tDjsHe975w6tg5O/t/Wstjcb5r5pj2P8UzuME+qT2aq5/96I5qfLQDBF93BcG/8Gc+azz\n\tfAmTPBMirNwzXq74B2XyfYR4aK7AHKXTNywoi3P/shbuFIbFlrtXUWiFncwMqpAXHjPe\n\tEl4w==","X-Gm-Message-State":"AOJu0YzE5I+Dx5tvT4YFZw8PaIPZTcSI+5vytRrprfkvZQEtApQDuRit\n\tv4QDmLWHGghrYKrgzJROdLSG2KKdDxsVjwpv4zc0StG597in9Q==","X-Google-Smtp-Source":"AGHT+IFlwcsWiJr/2Z/i/fl8s4cCWDnQzmrQ9IvyMpZnWD2rYR1z4aVrAvh57Cxe8KOauTVUhlXCMAlf2Cqw01OlzdE=","X-Received":"by 2002:a05:6830:1646:b0:6bc:dbbf:47be with SMTP id\n\th6-20020a056830164600b006bcdbbf47bemr9420650otr.26.1692626501340;\n\tMon, 21 Aug 2023 07:01:41 -0700 (PDT)","MIME-Version":"1.0","References":"<20230821131039.127370-1-gabbymg94@gmail.com>\n\t<20230821131039.127370-3-gabbymg94@gmail.com>","In-Reply-To":"<20230821131039.127370-3-gabbymg94@gmail.com>","Date":"Mon, 21 Aug 2023 19:31:29 +0530","Message-ID":"","To":"Gabby George ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [RFC PATCH v2 2/5] libcamera:\n\tMappedFrameBuffer: Use stored plane offset","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Vedant Paranjape via libcamera-devel\n\t","Reply-To":"Vedant Paranjape ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27701,"web_url":"https://patchwork.libcamera.org/comment/27701/","msgid":"<20230828204026.GH17083@pendragon.ideasonboard.com>","date":"2023-08-28T20:40:26","subject":"Re: [libcamera-devel] [RFC PATCH v2 2/5] libcamera:\n\tMappedFrameBuffer: Use stored plane offset","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Mon, Aug 21, 2023 at 07:31:29PM +0530, Vedant Paranjape via libcamera-devel wrote:\n> On Mon, Aug 21, 2023 at 6:40 PM Gabby George wrote:\n> >\n> > As it is written, the MappedFrameBuffer causes a failure in mmap when\n> \n> s/As it is written/ /\n> s/the/The\n> \n> > attempting to map UVC metadata planes. UVC metadata (four character\n> > code UVCH) does not support exporting buffers as file descriptors, so\n\nI think you meant dmabuf file descriptors here. The precision is\nimportant, as file descriptors can be many things.\n\n> > mmap can be used to give libcamera access to the metadata buffer\n> > planes. It is convenient to use the already-existing\n> > MappedFrameBuffers class, but the class must be modified to support\n> > mapping using file descriptors of the video node itself.\n> >\n> > To do this, mmap needs information obtained through a call to\n> > QUERYBUF, namely, the plane offset for buffer planes. Modify the\n> > constructor of a MappedFrameBuffer to use the plane offset directly in\n> > the call to mmap, rather than the hard-coded 0 value.\n\nI don't think I like this :-( It feels a bit of an abuse of this class.\nI'd rather implement the mapping manually in the UVC pipeline handler.\n\n> > The current version does not work when a buffer cannot be exported as\n> > a dma buf fd. The fd argument to mmap must be the one obtained on a\n> > call to open() for the video node (ie, /dev/videoX). This method of\n> > mapping buffer planes requires the arguments to mmap to be exactly the\n> > length and offset QUERYBUF provides. Mmap will return a -EINVAL if\n> \n> s/Mmap/mmap\n> \n> > this is not the case.\n> >\n> > Signed-off-by: Gabby George \n> > ---\n> > .../libcamera/internal/mapped_framebuffer.h | 3 ++-\n> > src/libcamera/mapped_framebuffer.cpp | 20 ++++++++++++++-----\n> > 2 files changed, 17 insertions(+), 6 deletions(-)\n> >\n> > diff --git a/include/libcamera/internal/mapped_framebuffer.h b/include/libcamera/internal/mapped_framebuffer.h\n> > index fb39adbf..04096d1b 100644\n> > --- a/include/libcamera/internal/mapped_framebuffer.h\n> > +++ b/include/libcamera/internal/mapped_framebuffer.h\n> > @@ -54,7 +54,8 @@ public:\n> >\n> > using MapFlags = Flags;\n> >\n> > - MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags);\n> > + MappedFrameBuffer(const FrameBuffer *buffer,\n> > + MapFlags flags, bool usePlaneOffset = false);\n> > };\n> >\n> > LIBCAMERA_FLAGS_ENABLE_OPERATORS(MappedFrameBuffer::MapFlag)\n> > diff --git a/src/libcamera/mapped_framebuffer.cpp b/src/libcamera/mapped_framebuffer.cpp\n> > index 6860069b..3d2cc332 100644\n> > --- a/src/libcamera/mapped_framebuffer.cpp\n> > +++ b/src/libcamera/mapped_framebuffer.cpp\n> > @@ -172,12 +172,13 @@ MappedBuffer::~MappedBuffer()\n> > * \\brief Map all planes of a FrameBuffer\n> > * \\param[in] buffer FrameBuffer to be mapped\n> > * \\param[in] flags Protection flags to apply to map\n> > + * \\param[in] usePlaneOffset Use offset stored in buffer's plane; default false\n> > *\n> > * Construct an object to map a frame buffer for CPU access. The mapping can be\n> > * made as Read only, Write only or support Read and Write operations by setting\n> > * the MapFlag flags accordingly.\n> > */\n> > -MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> > +MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags, bool usePlaneOffset)\n> > {\n> > ASSERT(!buffer->planes().empty());\n> > planes_.reserve(buffer->planes().size());\n> > @@ -223,8 +224,14 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> > const int fd = plane.fd.get();\n> > auto &info = mappedBuffers[fd];\n> > if (!info.address) {\n> > - void *address = mmap(nullptr, info.mapLength, mmapFlags,\n> > - MAP_SHARED, fd, 0);\n> > + void *address;\n> > + if (usePlaneOffset) {\n> > + address = mmap(nullptr, plane.length, mmapFlags,\n> > + MAP_SHARED, fd, plane.offset);\n> > + } else {\n> > + address = mmap(nullptr, info.mapLength, mmapFlags,\n> > + MAP_SHARED, fd, 0);\n> > + }\n> \n> You could make this an oneliner using ternary operators, it would look\n> more compact I believe.\n> \n> size_t length = usePlaneOffset ? plane.length : info.mapLength ;\n> off_t offset = usePlaneOffset ? plane.offset : 0\n> void *address = mmap(.., length, ..., offset);\n> \n> > if (address == MAP_FAILED) {\n> > error_ = -errno;\n> > LOG(Buffer, Error) << \"Failed to mmap plane: \"\n> > @@ -233,10 +240,13 @@ MappedFrameBuffer::MappedFrameBuffer(const FrameBuffer *buffer, MapFlags flags)\n> > }\n> >\n> > info.address = static_cast(address);\n> > - maps_.emplace_back(info.address, info.mapLength);\n> > + maps_.emplace_back(info.address, usePlaneOffset ? plane.length :\n> > + info.mapLength);\n> > }\n> >\n> > - planes_.emplace_back(info.address + plane.offset, plane.length);\n> > + uint8_t *storedAddress = usePlaneOffset ? info.address :\n> > + info.address + plane.offset;\n> \n> I maybe wrong here, but looking at the code, shouldn't the operators\n> be opposite ? something like this ?\n> \n> uint8_t *storedAddress = usePlaneOffset ? info.address + plane.offset\n> : info.address;\n> \n> > + planes_.emplace_back(storedAddress, plane.length);\n> > }\n> > }\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DDFBEC0F1B\n\tfor ;\n\tMon, 28 Aug 2023 20:40:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BE82627E0;\n\tMon, 28 Aug 2023 22:40:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8EEB160375\n\tfor ;\n\tMon, 28 Aug 2023 22:40:17 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22470741;\n\tMon, 28 Aug 2023 22:38:56 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1693255219;\n\tbh=8aIKQv0ihHC8JqR3s56L0dmZ7AaJzBds48GPdR3KknI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=b3bmm8qes7MDbU3lY7874a4vuy3y4b9RphUOHB7/X0X/3RCmMQfalFtZ/K4ZrsUTC\n\tEyQtbBfWOaMYj3CO9kh3RbKgfc0Wrq0V1F4GZt/rVJSCJXn7c0ocVHgSmFemlsRXtU\n\thL7ZglvzfpIG1zbIOZsw/glBNbxG4T7bqCHYPODpKWC2+ROur9ywNb82Q3xJbNVgv3\n\txEpAdrSgZmrbHh4SOSHashptWl8BOz+CXFJqOl530Xasci4i4j+iqeE318xQI/+FXH\n\tQbNI5NsiKNnzE9K0LLmMLhIvlglwm9m1Mb24qF3suyODTbHx5TQnkHtQ/BBhs7aYUB\n\tAlVyrhkcrALQA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1693255136;\n\tbh=8aIKQv0ihHC8JqR3s56L0dmZ7AaJzBds48GPdR3KknI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ilxABjk5SMsZuP+lJywKifn/ni0fITwQ23IaDuNicF4b8+zgJGtWfIRT57i3e2rAY\n\tlJDy0Ir+zf07V0omF6OYsZdhhn8nwEHUUGwwXgCuFoTtB9kglSuKUYYCSL63Pctmiw\n\tCW4nZ/Krg6ln2b2r9ELEgQjZ9PdQWJ4R5JJA/yAc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ilxABjk5\"; dkim-atps=neutral","Date":"Mon, 28 Aug 2023 23:40:26 +0300","To":"Vedant Paranjape ","Message-ID":"<20230828204026.GH17083@pendragon.ideasonboard.com>","References":"<20230821131039.127370-1-gabbymg94@gmail.com>\n\t<20230821131039.127370-3-gabbymg94@gmail.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [RFC PATCH v2 2/5] libcamera:\n\tMappedFrameBuffer: Use stored plane offset","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]