[{"id":2602,"web_url":"https://patchwork.libcamera.org/comment/2602/","msgid":"<20190904181258.GF5433@pendragon.ideasonboard.com>","date":"2019-09-04T18:12:58","subject":"Re: [libcamera-devel] [PATCH v2 06/14] libcamera: controls: Add\n\tAeEnable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Aug 30, 2019 at 01:26:45AM +0200, Niklas Söderlund wrote:\n> Add a control to turn Auto Exposure on or off.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/control_ids.h | 1 +\n> src/libcamera/controls.cpp | 15 +++++++++++++--\n> 2 files changed, 14 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/control_ids.h b/include/libcamera/control_ids.h\n> index 75b6a2d5cafeca72..8cd44e571f705ac5 100644\n> --- a/include/libcamera/control_ids.h\n> +++ b/include/libcamera/control_ids.h\n> @@ -13,6 +13,7 @@\n> namespace libcamera {\n> \n> enum ControlId {\n> +\tAeEnable,\n> \tAwbEnable,\n> \tBrightness,\n> \tContrast,\n> diff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\n> index 727fdbd9450d2f40..35861e27401d5241 100644\n> --- a/src/libcamera/controls.cpp\n> +++ b/src/libcamera/controls.cpp\n> @@ -186,6 +186,13 @@ std::string ControlValue::toString() const\n> * \\brief Numerical control ID\n> */\n> \n> +/**\n> + * \\var AeEnable\n> + * ControlType: Bool\n> + *\n> + * Enables or disables the AE. See also \\a libcamera::ControlId::ManualExposure.\n\ns/Enables or disables/Enable or disable/\ns/AE/auto-exposure algorithm/ or s/the AE/auto-expose/\n\nYou should also use \\sa instead of See also.\n\n * \\sa ControlId::ManualExposure\n\n> + */\n> +\n> /**\n> * \\var AwbEnable\n> * ControlType: Bool\n> @@ -218,14 +225,18 @@ std::string ControlValue::toString() const\n> * \\var ManualExposure\n> * ControlType: Integer\n> *\n> - * Specify a fixed exposure time in milli-seconds\n> + * Specify a fixed exposure time in milli-seconds.\n> + *\n> + * This control is only considered if AeEnable is not enabled.\n\nWhat happens if AE is enabled ? Will the fixed exposure time be recorded\ninternally and applied when AE gets disabled ? Same for the gain below.\n\n> */\n> \n> /**\n> * \\var ManualGain\n> * ControlType: Integer\n> *\n> - * Specify a fixed gain parameter\n> + * Specify a fixed gain parameter.\n> + *\n> + * This control is only considered if AeEnable is not enabled.\n\nShould AE be renamed to auto exposure and gain ? Or should we have an\nAGCEnable control ?\n\n> */\n> \n> /**","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65E1060BB2\n\tfor ;\n\tWed, 4 Sep 2019 20:13:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CB41D440;\n\tWed, 4 Sep 2019 20:13:04 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567620785;\n\tbh=7n9S/+cZiRmaIgeydIlz52PYK+M8Wu/QRMUCbk8/77U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oB7DFbeewaat+swpSIE+2OBkxITi27Mz6z5s/6AJN0Ujhmpq/hW5q9v+xLDbuBUx9\n\ty4EanC8cMcEw7/ZW5jt7zWxmtKx8hy0fxb0NsTwOVeSb/7+8YQhXsQU6VuzL+wEvso\n\tAg1lTiq0jS5rjO5TlOFDgGOXN/lEYUXa2kIN9PIw=","Date":"Wed, 4 Sep 2019 21:12:58 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190904181258.GF5433@pendragon.ideasonboard.com>","References":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>\n\t<20190829232653.13214-7-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190829232653.13214-7-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 06/14] libcamera: controls: Add\n\tAeEnable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 18:13:05 -0000"}}]