[{"id":27640,"web_url":"https://patchwork.libcamera.org/comment/27640/","msgid":"<169087806281.137962.5316236837315253050@Monstersaurus>","date":"2023-08-01T08:21:02","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated\n\tSortIncludes in `.clang-format`","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Harvey,\n\nQuoting Harvey Yang via libcamera-devel (2023-08-01 09:07:04)\n> `SortIncludes: true` was added in both ae05b9f and 0e1ff86, which caused\n> issues to run clang-format.\n> \n\nYikes - this looks like it was my fault! Sorry!\n\nBut thanks for the cleanup / fix...\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>\n> ---\n>  .clang-format | 1 -\n>  1 file changed, 1 deletion(-)\n> \n> diff --git a/.clang-format b/.clang-format\n> index 5b8857da..cac7029f 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -66,7 +66,6 @@ ExperimentalAutoDetectBinPacking: false\n>  FixNamespaceComments: true\n>  ForEachMacros:\n>    - 'udev_list_entry_foreach'\n> -SortIncludes: true\n>  IncludeBlocks: Regroup\n>  IncludeCategories:\n>    # Headers matching the name of the component are matched automatically.\n> -- \n> 2.41.0.585.gd2178a4bd4-goog\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28F1CBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  1 Aug 2023 08:21:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C5DE627E6;\n\tTue,  1 Aug 2023 10:21:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 066B9627E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Aug 2023 10:21:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF5493D5;\n\tTue,  1 Aug 2023 10:20:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690878066;\n\tbh=PlZhefPM+3K1Mk/2tjlhPPgiZzMBk68ALXZU7oWtNgo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SNqKr3PTUXPHfb2PkXyz5/aDo8ZKeUEDEtzfSK8GYB03ayEPK4PXXwj6IWwM/SAMm\n\t28bLNxmVtgvw9TliGOSIJOa3VTdYr/ZS0RZX5hIASwJeAl+PJAftM1vCIcFvWhLUHV\n\tvQo/FW4cbGhfr9SX1tntmM1FE0XR2dJo2tZnshNySO7SN947ch+R1EioGPCmsAki8L\n\tlVNAECfYfAxpg4WfKZVY06HFw3/tWfR0TnikzbrC/8MqSHOjmFlf4ZHib00Sd5fYkK\n\tKBlSPuY/ni9I1yrc6/oHZ9E2qQl+jZ4Z9Y8JE2TN1F5ovBZI9GSz+yCGOf4xjUnfTJ\n\tToYdine8KL++Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690878002;\n\tbh=PlZhefPM+3K1Mk/2tjlhPPgiZzMBk68ALXZU7oWtNgo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=uNeZOeNj1TjQUsOs05eamEjiedJgjNNAk6gFFjp4slcUnSx42WrzqfToD/C2xj//I\n\tEoeM08DbaJMVFovyLXwLAFVtPG31TrGQCXWB1eX70Tcc3AccBvCKjBxJZ8cE58Gzpn\n\tYfksB1GfH/W7zsjwZY52J4NUkLUtgnmCj+GHaDQ8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uNeZOeNj\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230801080920.658638-2-chenghaoyang@google.com>","References":"<20230801080920.658638-1-chenghaoyang@google.com>\n\t<20230801080920.658638-2-chenghaoyang@google.com>","To":"Harvey Yang <chenghaoyang@chromium.org>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 01 Aug 2023 09:21:02 +0100","Message-ID":"<169087806281.137962.5316236837315253050@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated\n\tSortIncludes in `.clang-format`","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Kieran Bingham via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Harvey Yang <chenghaoyang@google.com>,\n\tHarvey Yang <chenghaoyang@chromium.org>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27641,"web_url":"https://patchwork.libcamera.org/comment/27641/","msgid":"<20230801084115.GA26128@pendragon.ideasonboard.com>","date":"2023-08-01T08:41:15","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated\n\tSortIncludes in `.clang-format`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Aug 01, 2023 at 09:21:02AM +0100, Kieran Bingham via libcamera-devel wrote:\n> Hi Harvey,\n> \n> Quoting Harvey Yang via libcamera-devel (2023-08-01 09:07:04)\n> > `SortIncludes: true` was added in both ae05b9f and 0e1ff86, which caused\n> > issues to run clang-format.\n> > \n> \n> Yikes - this looks like it was my fault! Sorry!\n> \n> But thanks for the cleanup / fix...\n> \n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> > Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>\n> > ---\n> >  .clang-format | 1 -\n> >  1 file changed, 1 deletion(-)\n> > \n> > diff --git a/.clang-format b/.clang-format\n> > index 5b8857da..cac7029f 100644\n> > --- a/.clang-format\n> > +++ b/.clang-format\n> > @@ -66,7 +66,6 @@ ExperimentalAutoDetectBinPacking: false\n> >  FixNamespaceComments: true\n> >  ForEachMacros:\n> >    - 'udev_list_entry_foreach'\n> > -SortIncludes: true\n> >  IncludeBlocks: Regroup\n> >  IncludeCategories:\n> >    # Headers matching the name of the component are matched automatically.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5615FBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  1 Aug 2023 08:41:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB974627E6;\n\tTue,  1 Aug 2023 10:41:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF5716037F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Aug 2023 10:41:09 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 854988D;\n\tTue,  1 Aug 2023 10:40:06 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690879271;\n\tbh=sOJz9BEGWjDKU3RARZ9kkTgs4z/XCUgjw4DSNIZM1UE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=A1cOetpwnaM1qAyfMusjd8JEmaz2aEayA5Oiqj9tyP8kKe+MCcAWWSrgK+dkULw+c\n\twbmTeUGtHHoOOGLdnOLIo0ZsNac+t2dhOJYyAbdVBXUL7+Aa9bTKmvf/rU7hdi8Grr\n\tHFlT9JxNhgz8H0Ih8tWENnLONIXrEnvdz3ej398I8qyi0ejGBeDKgE5wLACJ+vDS80\n\ti493hkDIf5M60n+bjFeA2u1UN/d9M8TIftNDeqEco3HOK0Vf609Qjfmf4X41l4rpbx\n\tzhKW0Mq43QbsY1TasDKNn1fquMV6YHQ8qI51Z7tKhIx5pTAp3pkxtUSu0m5Q9aT6AS\n\tgbet8nU2pzkOg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690879206;\n\tbh=sOJz9BEGWjDKU3RARZ9kkTgs4z/XCUgjw4DSNIZM1UE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EIxxWmDJgiRXZeS3qoN8bc8tOm8SxDrPWQj75QKL7KvqMtvqC5dGsqT3r3Iyi2csc\n\t3jmtt0qSvMbEMLsKj+DG0kobTJCUQ/4pkXffaf6Hrbx/k4xS+wV7n8AYUKeEWgbSLj\n\tvcBDKuBxQwD2m1HtaoIwyojV6/s/zFmkyrV44EB8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"EIxxWmDJ\"; dkim-atps=neutral","Date":"Tue, 1 Aug 2023 11:41:15 +0300","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20230801084115.GA26128@pendragon.ideasonboard.com>","References":"<20230801080920.658638-1-chenghaoyang@google.com>\n\t<20230801080920.658638-2-chenghaoyang@google.com>\n\t<169087806281.137962.5316236837315253050@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<169087806281.137962.5316236837315253050@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated\n\tSortIncludes in `.clang-format`","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"Harvey Yang <chenghaoyang@google.com>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27642,"web_url":"https://patchwork.libcamera.org/comment/27642/","msgid":"<CAEB1ahvdxt1unX_B-OtggkWzy_Q_ymC9FqN4gj3XKnHUrWqzYQ@mail.gmail.com>","date":"2023-08-01T08:41:29","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated\n\tSortIncludes in `.clang-format`","submitter":{"id":117,"url":"https://patchwork.libcamera.org/api/people/117/","name":"Cheng-Hao Yang","email":"chenghaoyang@chromium.org"},"content":"Hi Kieran\n\nGlad to help clean up :)\n\n\nOn Tue, Aug 1, 2023 at 4:21 PM Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Hi Harvey,\n>\n> Quoting Harvey Yang via libcamera-devel (2023-08-01 09:07:04)\n> > `SortIncludes: true` was added in both ae05b9f and 0e1ff86, which caused\n> > issues to run clang-format.\n> >\n>\n> Yikes - this looks like it was my fault! Sorry!\n>\n> But thanks for the cleanup / fix...\n>\n>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>\n> > Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>\n> > ---\n> >  .clang-format | 1 -\n> >  1 file changed, 1 deletion(-)\n> >\n> > diff --git a/.clang-format b/.clang-format\n> > index 5b8857da..cac7029f 100644\n> > --- a/.clang-format\n> > +++ b/.clang-format\n> > @@ -66,7 +66,6 @@ ExperimentalAutoDetectBinPacking: false\n> >  FixNamespaceComments: true\n> >  ForEachMacros:\n> >    - 'udev_list_entry_foreach'\n> > -SortIncludes: true\n> >  IncludeBlocks: Regroup\n> >  IncludeCategories:\n> >    # Headers matching the name of the component are matched\n> automatically.\n> > --\n> > 2.41.0.585.gd2178a4bd4-goog\n> >\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 907D5BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  1 Aug 2023 08:41:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4BB5D627E9;\n\tTue,  1 Aug 2023 10:41:42 +0200 (CEST)","from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com\n\t[IPv6:2a00:1450:4864:20::22a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B2F5627E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Aug 2023 10:41:41 +0200 (CEST)","by mail-lj1-x22a.google.com with SMTP id\n\t38308e7fff4ca-2b9cf2b1309so49482611fa.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 01 Aug 2023 01:41:41 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690879302;\n\tbh=CaqjYgr31Vs9c6lqxRMJTeTmKauq1oaeHV4lKxYxuIQ=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HfsJ2mlnagl/4XCuH4acilybRd5PaTpagiHVMvINo0gx1Xq0aIzWszd6sCxZEWeDZ\n\tIbxeKSf57WkdWimzl6V5U7s3rduT7iZJPjQWoOMqPyGhVOhJmXuHjF15p4uMPD+Ie3\n\tRnHSAurPOMomgKVIALmM1ohBFoWUsEStq756QeXix1hxUpHeqEAGojHoBbo6WN2QgO\n\tXecptVMPu0PpzR12/ot3qP7Dw16ZVdZW/qHJI0g4dIDszMDFZtw0r18pXYowNSvHdG\n\t4Wek8Me4ilopZXS/Fl1NgWd0Wbvr8oaLoZUVFHdcPb9C+rSh1AUeyUANg7JhhzP2j5\n\tGe76iN+BoMscw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1690879300; x=1691484100;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=RqY/tzTnDms7UzXt9WQFfX/frgcxVMiVOBbgnhrsDM8=;\n\tb=I8tdjKkMt0XT6MF7bX5gxjGrFrauW51qXqk6yE/uxgnvmEq1SsjrA7gQ+vYUnIP3Eg\n\tQ6/6wMW11j3ts4qLv7pnHVFfqy0DmTAJlNmhDsKxe2xZ6sJKcHB1W/lzOeFtBseVy3Aq\n\t3ZL2+DNsOi+2h396hFWthtUkEUaciWX+pxS7A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"I8tdjKkM\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1690879300; x=1691484100;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=RqY/tzTnDms7UzXt9WQFfX/frgcxVMiVOBbgnhrsDM8=;\n\tb=EhX+lubNteDTOgJ9dmy+ZFphSOe96VaHhtDOE/t0MgyBSjh9WPEs7TvGpHBTOHE4vQ\n\t2IqHCEE8lrPU1RTvx2Eg5TJpdA+cJFLjX4oSleSb+Z3xEO3yhXgpHEbUXY/HY88Y7isJ\n\tgIV/QE7QhdUF0JydguRRRqn6rZ5TrEQ7WyXdzwqb+OvRHVnHR/ppw6LWnew6y1v+3LYQ\n\tMdTPlBVCNVpuqLXx56kUKd+dX+Bl4n129BqOiF8etpySurRilf1Qk7lrrTCA8Iq6pgu/\n\twpT1Z9+mdu/0lMa4R/2evVl2lbxkeQ7qrxRlMszsBI/o1pL+yr1gvAbO2rlqq66oeBdv\n\t/w5A==","X-Gm-Message-State":"ABy/qLbwii9rLixkTRywMuvI6+sd2tgw3OxVYtdQLPB5T+qGnlycMzXv\n\t6itwkG/NO+XGkkPFf6yHnWVlZBAqL/l4BdX9kLe+F6xBNPZ1GfOA","X-Google-Smtp-Source":"APBJJlFGCvTjT49N5DEm2ACIDmRQ+hX84LcI8zjmw7LrzYM7WY1UOmJBQoZSkADc7hmBk0L73YNbl/24w3DhAMinszo=","X-Received":"by 2002:a05:651c:1025:b0:2b8:8642:c00d with SMTP id\n\tw5-20020a05651c102500b002b88642c00dmr874379ljm.17.1690879300145;\n\tTue, 01 Aug 2023 01:41:40 -0700 (PDT)","MIME-Version":"1.0","References":"<20230801080920.658638-1-chenghaoyang@google.com>\n\t<20230801080920.658638-2-chenghaoyang@google.com>\n\t<169087806281.137962.5316236837315253050@Monstersaurus>","In-Reply-To":"<169087806281.137962.5316236837315253050@Monstersaurus>","Date":"Tue, 1 Aug 2023 16:41:29 +0800","Message-ID":"<CAEB1ahvdxt1unX_B-OtggkWzy_Q_ymC9FqN4gj3XKnHUrWqzYQ@mail.gmail.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Content-Type":"multipart/alternative; boundary=\"0000000000000b2a9e0601d8842f\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated\n\tSortIncludes in `.clang-format`","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Cheng-Hao Yang via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Cheng-Hao Yang <chenghaoyang@chromium.org>","Cc":"Harvey Yang <chenghaoyang@google.com>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27649,"web_url":"https://patchwork.libcamera.org/comment/27649/","msgid":"<20230801215135.GG8578@pendragon.ideasonboard.com>","date":"2023-08-01T21:51:35","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated\n\tSortIncludes in `.clang-format`","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Aug 01, 2023 at 11:41:15AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> On Tue, Aug 01, 2023 at 09:21:02AM +0100, Kieran Bingham via libcamera-devel wrote:\n> > Quoting Harvey Yang via libcamera-devel (2023-08-01 09:07:04)\n> > > `SortIncludes: true` was added in both ae05b9f and 0e1ff86, which caused\n> > > issues to run clang-format.\n> > > \n> > \n> > Yikes - this looks like it was my fault! Sorry!\n> > \n> > But thanks for the cleanup / fix...\n> > \n> > \n> > Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nI'll update the commit message to\n\n----\nlibcamera: Remove duplicated SortIncludes in `.clang-format`\n\n`SortIncludes: true` was added in both commit ae05b9f9d082\n(\"clang-format: Enable sorted includes\") and commit 0e1ff86e78ae\n(\"clang-format: Regroup sort orders\"), which caused issues to run\nclang-format.\n\nFixes: 0e1ff86e78ae (\"clang-format: Regroup sort orders\")\n----\n\n(plus the SoB and Rb tags) and push.\n\n> > > Signed-off-by: Harvey Yang <chenghaoyang@chromium.org>\n> > > ---\n> > >  .clang-format | 1 -\n> > >  1 file changed, 1 deletion(-)\n> > > \n> > > diff --git a/.clang-format b/.clang-format\n> > > index 5b8857da..cac7029f 100644\n> > > --- a/.clang-format\n> > > +++ b/.clang-format\n> > > @@ -66,7 +66,6 @@ ExperimentalAutoDetectBinPacking: false\n> > >  FixNamespaceComments: true\n> > >  ForEachMacros:\n> > >    - 'udev_list_entry_foreach'\n> > > -SortIncludes: true\n> > >  IncludeBlocks: Regroup\n> > >  IncludeCategories:\n> > >    # Headers matching the name of the component are matched automatically.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB800BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  1 Aug 2023 21:51:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14D74627EB;\n\tTue,  1 Aug 2023 23:51:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 412B661E1D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Aug 2023 23:51:30 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 88EC08D;\n\tTue,  1 Aug 2023 23:50:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690926692;\n\tbh=tOI3IXIe0xbum+le/y8JZJjkH1vFPXx+bZ/NttRhoe8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=hssoT5GK8ojBMr0y+Js74pSUURTrzqpCGmH0IFyd8S58v2baVRobKe71bP7mgGHVT\n\tgiwXtu5a4G2YbV0y2krFG36ezracKckFcdvSf22rG58Flhduw8cI8WP7T/JCvsGWG5\n\t+VdLskeGg+wdK3JPqI/SqwBmveDLoBv2QRKUA/pRCUZtSpTgjX+O+KmfY7nTXE3tpS\n\tncHhNL4vCAsNVMvSRbrSg5m4dR5gC3qEsQLzQG+1wE7nZkTkmEvbfMTEAsHStvtzN6\n\tW0utaGq7i9msJ0FQL2OTSpfbkWUBllloE/a2mMuUp6qIQZd12V7isg1XP4PQ5nu9FM\n\tc/Br7EXhnWCEw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690926626;\n\tbh=tOI3IXIe0xbum+le/y8JZJjkH1vFPXx+bZ/NttRhoe8=;\n\th=Date:From:To:Subject:References:In-Reply-To:From;\n\tb=gGSbLzrqTjrM8iGBUbYGXhgjDpw0ng84tFb5fSAsNak/1m9Wd0lIiMzJNKNHa/2AF\n\t4fuzP1nw+wb7eAsw6dMkDFmwKTrsNkZdY550xEmyTM/Wu7qwe/+mGnCbPt9TdZhiFp\n\tHZBMceti/NQyrAbzoHNMxVyUgn7Qxla3xz3Pt/UI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gGSbLzrq\"; dkim-atps=neutral","Date":"Wed, 2 Aug 2023 00:51:35 +0300","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tHarvey Yang <chenghaoyang@google.com>,\n\tHarvey Yang <chenghaoyang@chromium.org>,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20230801215135.GG8578@pendragon.ideasonboard.com>","References":"<20230801080920.658638-1-chenghaoyang@google.com>\n\t<20230801080920.658638-2-chenghaoyang@google.com>\n\t<169087806281.137962.5316236837315253050@Monstersaurus>\n\t<20230801084115.GA26128@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230801084115.GA26128@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: Remove duplicated\n\tSortIncludes in `.clang-format`","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]