[{"id":27631,"web_url":"https://patchwork.libcamera.org/comment/27631/","msgid":"<169056233882.277971.2204508794825926941@Monstersaurus>","date":"2023-07-28T16:38:58","subject":"Re: [libcamera-devel] [PATCH] meson: Correctly locate libc++","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2023-07-28 17:15:17)\n> The meson find_library() function takes a library name without the \"lib\"\n> prefix. Its usage to find lic++ is thus not correct, and meson warns\n> about it:\n> \n> WARNING: find_library('libc++') starting in \"lib\" only works by accident and is not portable\n> \n> Fix it by dropping the \"lib\" prefix.\n\nThe 'Only works by accident' is curious!...\n\nHrm ... introduced last year - so I guess we haven't seen this much\nbefore (or when we first added it).\n - https://github.com/mesonbuild/meson/pull/10864\n\n> Signed-off-by: Laurent Pinchart \n\nAnyway, seems reasonable based on the meson developers discussions and\nstatements so:\n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 031e1eda08f0..7959b5386eee 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -109,7 +109,7 @@ if cc.get_id() == 'clang'\n> \n> # Use libc++ by default if available instead of libstdc++ when compiling\n> # with clang.\n> - if cc.find_library('libc++', required : false).found()\n> + if cc.find_library('c++', required : false).found()\n> cpp_arguments += [\n> '-stdlib=libc++',\n> ]\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E922CBDB13\n\tfor ;\n\tFri, 28 Jul 2023 16:39:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4DFAC627EB;\n\tFri, 28 Jul 2023 18:39:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D757627E6\n\tfor ;\n\tFri, 28 Jul 2023 18:39:01 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 003727F3;\n\tFri, 28 Jul 2023 18:38:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690562342;\n\tbh=431b0NAglVxgrgVeknBtEf3eqkTB17/I3feeTa9x48E=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=1olE0PTA1BYWlzD8JjpJFpv0pZw5y3zfwb02cNMsNs4YtQO0M+0xG8AXUFXSzK3wT\n\tRx8K6dsyzXBTyBPZcC2PQvjT+G7aLt3udvmq99QSCVwNzFjFbq4E0/OONYNtquYUWN\n\tRSJUj748l4HVeyEmS5jEr+BNB3pvbUZxlQRSLUwWZqYrTkxbUB8GyVu74RE64VQk/e\n\ts2bO1h1/EcQcBrSCyCjH7Z0WL1u6LrNMOpUTBi77XYdVwIPyaNFFcfLbZsO1rVreuO\n\tB8UBAJE8wunANyfW0mu5RGd3ZAQzR0MzB4ZGq2xvVe7J7hYv+fZhFgCpFv0j1RaR5F\n\tWMq0LZVU9Apvw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690562281;\n\tbh=431b0NAglVxgrgVeknBtEf3eqkTB17/I3feeTa9x48E=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=A4MwYB0LdE+bNoPOubNiX/7BkpJ8SDHzxEE5lrWbdkkx40n+3hWLB9k4V1cdhhrmf\n\tUcrsf9rWDhCpVeK7/FV6jZJ7tIfWunIAVmxG6DWDV2i/9XUorXBSFtJE7Z1O2ZaLnU\n\te2y1QBWa5IH1LmjDj3gmDRGjatyclHQ/mCQBZjdU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"A4MwYB0L\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230728161517.15399-1-laurent.pinchart@ideasonboard.com>","References":"<20230728161517.15399-1-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 28 Jul 2023 17:38:58 +0100","Message-ID":"<169056233882.277971.2204508794825926941@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] meson: Correctly locate libc++","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27632,"web_url":"https://patchwork.libcamera.org/comment/27632/","msgid":"<3a756c0ced9f1fd0bfde02a7d46f38950b065617.camel@ndufresne.ca>","date":"2023-07-28T17:20:43","subject":"Re: [libcamera-devel] [PATCH] meson: Correctly locate libc++","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le vendredi 28 juillet 2023 à 17:38 +0100, Kieran Bingham via libcamera-devel a\nécrit :\n> Quoting Laurent Pinchart via libcamera-devel (2023-07-28 17:15:17)\n> > The meson find_library() function takes a library name without the \"lib\"\n> > prefix. Its usage to find lic++ is thus not correct, and meson warns\n> > about it:\n> > \n> > WARNING: find_library('libc++') starting in \"lib\" only works by accident and is not portable\n> > \n> > Fix it by dropping the \"lib\" prefix.\n> \n> The 'Only works by accident' is curious!...\n\nOn Windows there is no lib prefix, as this is a Linux library, this is unlikely\nan accident that it worked.\n\n> \n> Hrm ... introduced last year - so I guess we haven't seen this much\n> before (or when we first added it).\n> - https://github.com/mesonbuild/meson/pull/10864\n> \n> > Signed-off-by: Laurent Pinchart \n> \n> Anyway, seems reasonable based on the meson developers discussions and\n> statements so:\n> \n> Reviewed-by: Kieran Bingham \n> \n> \n> > ---\n> > meson.build | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/meson.build b/meson.build\n> > index 031e1eda08f0..7959b5386eee 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -109,7 +109,7 @@ if cc.get_id() == 'clang'\n> > \n> > # Use libc++ by default if available instead of libstdc++ when compiling\n> > # with clang.\n> > - if cc.find_library('libc++', required : false).found()\n> > + if cc.find_library('c++', required : false).found()\n> > cpp_arguments += [\n> > '-stdlib=libc++',\n> > ]\n> > -- \n> > Regards,\n> > \n> > Laurent Pinchart\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43FC2BDC71\n\tfor ;\n\tFri, 28 Jul 2023 17:20:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ADF81627E7;\n\tFri, 28 Jul 2023 19:20:47 +0200 (CEST)","from mail-qk1-x732.google.com (mail-qk1-x732.google.com\n\t[IPv6:2607:f8b0:4864:20::732])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C1BD627E6\n\tfor ;\n\tFri, 28 Jul 2023 19:20:45 +0200 (CEST)","by mail-qk1-x732.google.com with SMTP id\n\taf79cd13be357-76714caf466so190996085a.1\n\tfor ;\n\tFri, 28 Jul 2023 10:20:45 -0700 (PDT)","from nicolas-tpx395.localdomain ([2606:6d00:10:2688::7a9])\n\tby smtp.gmail.com with ESMTPSA id\n\tp1-20020a05620a132100b00767d47eb29bsm1261454qkj.119.2023.07.28.10.20.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 28 Jul 2023 10:20:43 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690564847;\n\tbh=VBxW73Nez7gmbXqaWbGTKe9VR/LNNHpmNi6VyamcmcM=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=X5SqlrSmRwTtBTavbC1H5/Z7PRZdO3cycTun41tp9/H5LwQZQQrFgnskfJ08BkAtS\n\tWkryjEnNd0Ckw6PUO3BoufJd4ZyazbO6Wlt7Zzk0tgZoIhzp98snKfqbVBXY1gRZ1i\n\tM0iK7umWi+3VVM7X+FdDtCbREbJNOk3zbPXBQAU8yoE3C8vKNa5odx7pkOmNH/gJni\n\tLh1Ijdh5jDSKtpHZpPcGpQMft79ylF6TvS0pRnO2F3KL4Gm/90VdB7+xX188P5ZGxT\n\tdtbQ1miCWVAC4/yzd5D03lkRrU2i4V7GCD68GrT/Dc9mEU3RceaKn5k5QAFOu1TMbz\n\tJMwJrCeJPOuAw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20221208.gappssmtp.com; s=20221208; t=1690564844;\n\tx=1691169644; \n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=hiuaJknTXW3SKrB3WNajcysn8q6E4YTfZwdldKkdZLI=;\n\tb=Ox4DGRiZmZh1X8OlhUBF2XuJ0H3RHSifV1l7q2S2buWPBd64VOC7VFM5VGORv/2YAo\n\tWxiW2VF6sQX9r61BWOLwEUvUsouGPA9N0Abr4BvXt9zU3YjglSS7O54pj1W8I0LE3CuS\n\tJ9BuYawHWHascmuD3Wu2pPPc3uLcSpSyvWZKWNrMFixHOlUP29NRu1PFC0n2SqvQ7i64\n\t/5Oxi15hYYFmGLW20IHB7MDJ/8/8HvQr1e91NiY/z7KgObjxgS4kX9nqNdFaNliOR8WD\n\tMibBlA6Z50n5HTTAtWTEdcTKeuZ6SwNKGAP2A5J61U3nfhBdhTTkHipf6pVMapKdc/FS\n\tIsTg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=ndufresne-ca.20221208.gappssmtp.com\n\theader.i=@ndufresne-ca.20221208.gappssmtp.com header.b=\"Ox4DGRiZ\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1690564844; x=1691169644;\n\th=mime-version:user-agent:content-transfer-encoding:references\n\t:in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=hiuaJknTXW3SKrB3WNajcysn8q6E4YTfZwdldKkdZLI=;\n\tb=SDHemsb3ksC7t36LNZiCui32Cuh2Uv2fQqxTGlLbCosjGHedFYSKo2vEtlFD+rASbF\n\t0qt+NU5nFDPenNis127bWjV8tXRq0HUALLVRkkMYoLHf3HwkcQIUFrS7HhetuCYBi9Cj\n\t+W76y4xAuFb6T3Epaf6qW+aj93xdC0pm9KtG86sV27atGQUWoY1Yqs+PQMEaIJSyFxRr\n\tJYznPPiMgSPvbA9aDkhnPAXcExTPjNN0h6jJxKXaQgfZZMCmjAKshVM4HsZb/4w9rp/G\n\tQ1jVRk934qSN/4vhwgJmeEClIRFjxZF9KlYw/caip3R6D+OiSCyrSlxiLFamlTb7AdlF\n\tE97g==","X-Gm-Message-State":"ABy/qLZT6upkbkbw8AZX36ZziaPzCSVfMCc9dBJ5jJTpx+jiDMXalHA2\n\tvQtJGIEKGD/K2Eo6gyFIHbqqS8VTmuDo14ofgc2DLw==","X-Google-Smtp-Source":"APBJJlH9k9jLmGkMYAAeKwk8HumCROXGjk+A5QuLdDaqrbTvY92VQN4IVL1uim3fC7BeUSY55lM6nA==","X-Received":"by 2002:a05:620a:25d:b0:76c:9181:ff46 with SMTP id\n\tq29-20020a05620a025d00b0076c9181ff46mr1723087qkn.56.1690564844266; \n\tFri, 28 Jul 2023 10:20:44 -0700 (PDT)","Message-ID":"<3a756c0ced9f1fd0bfde02a7d46f38950b065617.camel@ndufresne.ca>","To":"Kieran Bingham , Laurent Pinchart\n\t, libcamera-devel@lists.libcamera.org","Date":"Fri, 28 Jul 2023 13:20:43 -0400","In-Reply-To":"<169056233882.277971.2204508794825926941@Monstersaurus>","References":"<20230728161517.15399-1-laurent.pinchart@ideasonboard.com>\n\t<169056233882.277971.2204508794825926941@Monstersaurus>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","User-Agent":"Evolution 3.48.4 (3.48.4-1.fc38) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [PATCH] meson: Correctly locate libc++","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nicolas Dufresne via libcamera-devel\n\t","Reply-To":"Nicolas Dufresne ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]