[{"id":27661,"web_url":"https://patchwork.libcamera.org/comment/27661/","msgid":"","date":"2023-08-16T09:59:56","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi everyone\n\nJust a little prod to see if anyone has any thoughts on this?\n\nThanks!\nDavid\n\nOn Fri, 28 Jul 2023 at 13:28, David Plowman\n wrote:\n>\n> We add an HdrMode control (to enable and disable HDR processing)\n> and an HdrChannel, which indicates what kind of HDR frame (short, long\n> medium) has just arrived.\n>\n> Currently the HdrMode supports three values:\n>\n> * Off - no HDR processing at all.\n> * MultiExposure - frames at multiple different exposures are combined\n> to create HDR images.\n> * SingleExposure - multiple frames all at the same exposure are\n> combined to create HDR images.\n>\n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/control_ids.yaml | 47 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 47 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 056886e6..34df7adb 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -701,6 +701,53 @@ controls:\n> Continuous AF is paused. No further state changes or lens movements\n> will occur until the AfPauseResume control is sent.\n>\n> + - HdrMode:\n> + type: int32_t\n> + description: |\n> + Control to set the mode to be used for High Dynamic Range (HDR)\n> + imaging.\n> +\n> + enum:\n> + - name: HdrModeOff\n> + value: 0\n> + description: |\n> + HDR is not enabled.\n> + - name: HdrModeMultiExposure\n> + value: 1\n> + description: |\n> + Multiple exposures will be used to create HDR images.\n> + - name: HdrModeSingleExposure\n> + value: 2\n> + description: |\n> + Multiple frames all at a single exposure will be used to create HDR\n> + images.\n> +\n> + - HdrChannel:\n> + type: int32_t\n> + description: |\n> + This value is reported back to the application so that it can discover\n> + whether this capture corresponds to the short or long exposure image (or\n> + any other image used by the HDR procedure).\n> +\n> + enum:\n> + - name: HdrChannelNone\n> + value: 0\n> + description: |\n> + This image does not correspond to any of the captures used to create\n> + an HDR image.\n> + - name: HdrChannelShort\n> + value: 1\n> + description: |\n> + This is a short exposure image.\n> + - name: HdrChannelMedium\n> + value: 2\n> + description: |\n> + This is a medium exposure image.\n> + - name: HdrChannelLong\n> + value: 3\n> + description: |\n> + This is a long exposure image.\n> +\n> # ----------------------------------------------------------------------------\n> # Draft controls section\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3367EBE08A\n\tfor ;\n\tWed, 16 Aug 2023 10:00:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E26F628D7;\n\tWed, 16 Aug 2023 12:00:11 +0200 (CEST)","from mail-qk1-x733.google.com (mail-qk1-x733.google.com\n\t[IPv6:2607:f8b0:4864:20::733])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 12EC0628D2\n\tfor ;\n\tWed, 16 Aug 2023 12:00:09 +0200 (CEST)","by mail-qk1-x733.google.com with SMTP id\n\taf79cd13be357-76d70d181dfso13324285a.1\n\tfor ;\n\tWed, 16 Aug 2023 03:00:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1692180011;\n\tbh=cAdC09ZiRRzEVe0csWNbX930qGgGF5/toNoKt7LXo8M=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=4ThYrCEZLz6Rc1uEs8rs232xdHSlVRU2fOUTbiFBe1LMT+NPLyd1AI3Q4Yc2Xirbp\n\tSZYI4lUc9UeCVcs7ub8m4Xt7MpHxFffISirOvljzY7o19yLYEkHeBBxByR3ROdJuZ5\n\txFKgKSVD4RTOE8UNYA/aI5yxcmSpzXO8yaINb+6rTM5wRlzqARNjCIF6o8KOcsfQoK\n\tVdvKtZ36CeBlAuLYBttqQNxb6AHLD5MRj0MnkV7/SFFA7BlzchFD2NJHS3xchzcMF4\n\tI19Qypw5P3zqGjV9KnTMdyUd722x77x9KzPUNOfhwmc2GXNHHi20TPcz2gl3lI1MdS\n\tCMHmun3Wt2cZQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1692180007; x=1692784807;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=eo03ECtsFFe4VeYiG0ymRwhbN6z0XkVedr1PU/9R/Z4=;\n\tb=si3TqLShcOPy4ir+68Q/cDtvSMPz6t0Xv76qgOVcNl5V46WZVnfyc8BEh8LLT8oOtU\n\ttVFvTrjn0UOhlXLUrIiZ4Fwwd1iT7Yi5bBGzVja4WJvtNb1fgZOTbz4dyfq0apsDcZeG\n\tNDRHn25j3x/6IJ1yx6Z9Z0APfv8TL1hjS7+TMjdfcZbstCxUFz5tE2OFhjbuBYwIQAX/\n\tKDuDyjmoPEj2cEwNx5gEw7l9Kna+WLX99xIorlMMpZai/sWCXOluVGC5B0yOqHWWwN6T\n\thtA+rYFgofxG4zIGH0ISprvuYXrlaIh+AD75wCV3W5zadkyiwWDpBadGKbrYeBL/F4Za\n\t6SeQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"si3TqLSh\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1692180007; x=1692784807;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=eo03ECtsFFe4VeYiG0ymRwhbN6z0XkVedr1PU/9R/Z4=;\n\tb=CsD7WhL1I8OlGKlwNY+80ROg9qLe+8fYIl0rYNWiC4Lp8c/eVq1HeNtQ4bJr6uHoxx\n\tkBAPYt2kX5YF1I1L0wiu4M/kAYU/GOtE3zioQWNP0YLSuMBwgMy9qN75+LqERe1RDN+2\n\tU+gReyYKJW9mrLRb1lFcujWWHWYUHJM4JxPtie53+NaKB20llVCV+CF6Bl7IuFvpv/RA\n\t+JAgZVajmsPcewtxeT6YuEEYlTaS/uUx+9hLA+K1SMHIzG1v9V3/NqpCNZaJD6EllzVP\n\tLPUtFrBKZTFz1q2MkC9tsVz8xoH15EsTLgRQKk4FeDoPVdDAubDW5nufIHvVheBTO3f4\n\t8g6w==","X-Gm-Message-State":"AOJu0YyXslIZNIflUaGK8monPUQQSh1MpUKmBjFyhk0wpplWxPhoFA9V\n\t7z17+r/Q2XxYsvZ9YfUm4pLMvRbQprYDyo6eN6hUoDrgs2UlxJe7","X-Google-Smtp-Source":"AGHT+IEUyHXaGFGxReHCazka/GioCtmWV5s2EBcOlqb7WQBhPm1gqgYM9qI3rCV3VGAzE0ctRw1W09dTZm9UdEG4hNs=","X-Received":"by 2002:a05:620a:1a14:b0:762:3841:c098 with SMTP id\n\tbk20-20020a05620a1a1400b007623841c098mr5805126qkb.30.1692180007499;\n\tWed, 16 Aug 2023 03:00:07 -0700 (PDT)","MIME-Version":"1.0","References":"<20230728122758.2411-1-david.plowman@raspberrypi.com>\n\t<20230728122758.2411-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20230728122758.2411-2-david.plowman@raspberrypi.com>","Date":"Wed, 16 Aug 2023 10:59:56 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27667,"web_url":"https://patchwork.libcamera.org/comment/27667/","msgid":"","date":"2023-08-21T08:41:28","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your patch.\n\nOn Fri, 28 Jul 2023 at 13:28, David Plowman via libcamera-devel\n wrote:\n>\n> We add an HdrMode control (to enable and disable HDR processing)\n> and an HdrChannel, which indicates what kind of HDR frame (short, long\n> medium) has just arrived.\n>\n> Currently the HdrMode supports three values:\n>\n> * Off - no HDR processing at all.\n> * MultiExposure - frames at multiple different exposures are combined\n> to create HDR images.\n> * SingleExposure - multiple frames all at the same exposure are\n> combined to create HDR images.\n>\n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/control_ids.yaml | 47 ++++++++++++++++++++++++++++++++++\n> 1 file changed, 47 insertions(+)\n>\n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 056886e6..34df7adb 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -701,6 +701,53 @@ controls:\n> Continuous AF is paused. No further state changes or lens movements\n> will occur until the AfPauseResume control is sent.\n>\n> + - HdrMode:\n> + type: int32_t\n> + description: |\n> + Control to set the mode to be used for High Dynamic Range (HDR)\n> + imaging.\n> +\n> + enum:\n> + - name: HdrModeOff\n> + value: 0\n> + description: |\n> + HDR is not enabled.\n> + - name: HdrModeMultiExposure\n> + value: 1\n> + description: |\n> + Multiple exposures will be used to create HDR images.\n> + - name: HdrModeSingleExposure\n> + value: 2\n> + description: |\n> + Multiple frames all at a single exposure will be used to create HDR\n> + images.\n> +\n> + - HdrChannel:\n> + type: int32_t\n> + description: |\n> + This value is reported back to the application so that it can discover\n> + whether this capture corresponds to the short or long exposure image (or\n> + any other image used by the HDR procedure).\n\nOnly a minor comment about this control. Instead of an enum, should we use an\nexplicit integer to determine channel number? Then we are not limited to only\nshort/medium/long channels as below?\n\nI'm not too bothered either way so,\n\nReviewed-by: Naushir Patuck \n\n> + enum:\n> + - name: HdrChannelNone\n> + value: 0\n> + description: |\n> + This image does not correspond to any of the captures used to create\n> + an HDR image.\n> + - name: HdrChannelShort\n> + value: 1\n> + description: |\n> + This is a short exposure image.\n> + - name: HdrChannelMedium\n> + value: 2\n> + description: |\n> + This is a medium exposure image.\n> + - name: HdrChannelLong\n> + value: 3\n> + description: |\n> + This is a long exposure image.\n> +\n> # ----------------------------------------------------------------------------\n> # Draft controls section\n>\n> --\n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E288BDE17\n\tfor ;\n\tMon, 21 Aug 2023 08:41:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C74E3627E0;\n\tMon, 21 Aug 2023 10:41:21 +0200 (CEST)","from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com\n\t[IPv6:2607:f8b0:4864:20::112f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED31F60379\n\tfor ;\n\tMon, 21 Aug 2023 10:41:17 +0200 (CEST)","by mail-yw1-x112f.google.com with SMTP id\n\t00721157ae682-5922b96c5fcso2931947b3.0\n\tfor ;\n\tMon, 21 Aug 2023 01:41:17 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1692607281;\n\tbh=DzYW7vFXjaTvpUmdEkrqYfFUfYkV9Yr/L722NsiPJgI=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gh0j2E0RNP/6bugb5n+T4bdW+umuDjW2uWNWg+0pMx3084r8n0K0Eskk23XuFv/4W\n\tcpvCyobZ5eDVR/uFq3uhoqeE4mDkxgOS7EF/RmHzkQQJnLKNbklhGfSYWmjP3GcoA3\n\tO+t30NsPIPWkHoXDrThOh02w1Kb5hMcAggWcThC4L8NxzFTu/Yxr9qUT1+4h2G3F30\n\trlzMkbPmycSGeqlQ8YfPhaSka/gHL7awR+yiv6I63cMx8xWCLPGMDUAlTkaow03eF8\n\tUN5XxOoYOGMcLvQjnGqt/dHO88MyCDuEXiefYijoM/tEJxxgG5Tbn+btogDX/uvSvm\n\tpOt5mqSCK/CEA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1692607276; x=1693212076;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=1WVR8ht9CFhCpBU+XcHHaLSfJwx+5Dn4MuthqhUF/Ms=;\n\tb=AJkSc9e/GrMauECttepa0cVJq0tzQd1M4sqkFMw5c2pJwF7GEO/42R0ulMVIisjbWZ\n\tPdlJKlS/wbRfHLe7K0gLTtDvDq3WT/vE0UCsFBb/daHp5RNTFW0dJzUImK7VEtcxbRjr\n\tSe/i9oAHXd4y3joUppxi+AgG8wmx1Mzmi8WiXnjUNkYVHvCz7McQ/oDtze8Oo0jvvfvT\n\twt9/2bYb8pSGQtdNrMFmz7OwlMCAA3Y03y582OkpvEZJMsLavPwZaKPRytcsIyaO/K72\n\tIkkdIt1g+QdfgcI2FKccoeJjIl+SSbVrO6qkJMHCV0rYRmjDcoaan8JNF331CEwZcexI\n\tqjOg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"AJkSc9e/\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1692607276; x=1693212076;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=1WVR8ht9CFhCpBU+XcHHaLSfJwx+5Dn4MuthqhUF/Ms=;\n\tb=QqTueQdyS9bSsDC0XpHGhZu1JkCrJDTYO1SERJVAGVt2hQQ1DJc6Rs6QF4RPCv9I48\n\tIl9gm8be7g9Tm6LI+LvSNsHic90y67R2cR0IaMRENKCf3yqnzciofTVsO6Z3V2THrqdu\n\trYBMigO5xkDjEVVcZqkhUlgOs2Yjly5rwCNx8MeU6Eh40GjcoAnDWd/S+z/06tzgCStw\n\tV2MxMjBCN67BwAhbigBMlMQ/gln3ZL4+sL05j4LyKp1EWvZoM4GxHT0rPjcuNkPKstoK\n\tXgCuf3Pgi5K43VWIGr7I8xzr3MNTdFxYfhQubsx/75X1iNxNqhB5JLdtpTsjS0NuDQy/\n\tSnbw==","X-Gm-Message-State":"AOJu0YwgY41xtZjtl99WuGBpH0kYdjU9swYWWC8ycUiuDJQjn60OV2Qr\n\tx5Jl5+nSSmbjnfqGPHBzhyaXnhdbTX5idSyeiFqF/g==","X-Google-Smtp-Source":"AGHT+IHP6umOMPIvYQ2Luea9dOYOXaywyt1kdaD+6fyP+K4UWQ1s68AYjML59uYAEflk+rIszHxdMM2maqWDQq8+KvE=","X-Received":"by 2002:a0d:e6c1:0:b0:583:a856:63ee with SMTP id\n\tp184-20020a0de6c1000000b00583a85663eemr7435849ywe.35.1692607276758;\n\tMon, 21 Aug 2023 01:41:16 -0700 (PDT)","MIME-Version":"1.0","References":"<20230728122758.2411-1-david.plowman@raspberrypi.com>\n\t<20230728122758.2411-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20230728122758.2411-2-david.plowman@raspberrypi.com>","Date":"Mon, 21 Aug 2023 09:41:28 +0100","Message-ID":"","To":"David Plowman ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27670,"web_url":"https://patchwork.libcamera.org/comment/27670/","msgid":"","date":"2023-08-21T09:06:46","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the comments.\n\nOn Mon, 21 Aug 2023 at 09:41, Naushir Patuck wrote:\n>\n> Hi David,\n>\n> Thank you for your patch.\n>\n> On Fri, 28 Jul 2023 at 13:28, David Plowman via libcamera-devel\n> wrote:\n> >\n> > We add an HdrMode control (to enable and disable HDR processing)\n> > and an HdrChannel, which indicates what kind of HDR frame (short, long\n> > medium) has just arrived.\n> >\n> > Currently the HdrMode supports three values:\n> >\n> > * Off - no HDR processing at all.\n> > * MultiExposure - frames at multiple different exposures are combined\n> > to create HDR images.\n> > * SingleExposure - multiple frames all at the same exposure are\n> > combined to create HDR images.\n> >\n> > Signed-off-by: David Plowman \n> > ---\n> > src/libcamera/control_ids.yaml | 47 ++++++++++++++++++++++++++++++++++\n> > 1 file changed, 47 insertions(+)\n> >\n> > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > index 056886e6..34df7adb 100644\n> > --- a/src/libcamera/control_ids.yaml\n> > +++ b/src/libcamera/control_ids.yaml\n> > @@ -701,6 +701,53 @@ controls:\n> > Continuous AF is paused. No further state changes or lens movements\n> > will occur until the AfPauseResume control is sent.\n> >\n> > + - HdrMode:\n> > + type: int32_t\n> > + description: |\n> > + Control to set the mode to be used for High Dynamic Range (HDR)\n> > + imaging.\n> > +\n> > + enum:\n> > + - name: HdrModeOff\n> > + value: 0\n> > + description: |\n> > + HDR is not enabled.\n> > + - name: HdrModeMultiExposure\n> > + value: 1\n> > + description: |\n> > + Multiple exposures will be used to create HDR images.\n> > + - name: HdrModeSingleExposure\n> > + value: 2\n> > + description: |\n> > + Multiple frames all at a single exposure will be used to create HDR\n> > + images.\n> > +\n> > + - HdrChannel:\n> > + type: int32_t\n> > + description: |\n> > + This value is reported back to the application so that it can discover\n> > + whether this capture corresponds to the short or long exposure image (or\n> > + any other image used by the HDR procedure).\n>\n> Only a minor comment about this control. Instead of an enum, should we use an\n> explicit integer to determine channel number? Then we are not limited to only\n> short/medium/long channels as below?\n\nThis slightly gets us into the portable-applications vs.\nplatform-specific-capabilities debate...\n\nI'd quite like to have \"AgcChannel\" metadata that tells you exactly\nthis - namely which AGC channel this frame is from. But other\nplatforms might have no such concept even if they have some kind of\nHDR support.\n\nSo I'm slightly inclined to have a more generic notion of long/short\nframe for HDR, whilst leaving the door open to adding \"AgcChannel\"\nwhen it's needed.\n\nBut I agree that there's no clear answer here, and other people's\nopinions would be interesting.\n\nThanks!\nDavid\n\n>\n> I'm not too bothered either way so,\n>\n> Reviewed-by: Naushir Patuck \n>\n> > + enum:\n> > + - name: HdrChannelNone\n> > + value: 0\n> > + description: |\n> > + This image does not correspond to any of the captures used to create\n> > + an HDR image.\n> > + - name: HdrChannelShort\n> > + value: 1\n> > + description: |\n> > + This is a short exposure image.\n> > + - name: HdrChannelMedium\n> > + value: 2\n> > + description: |\n> > + This is a medium exposure image.\n> > + - name: HdrChannelLong\n> > + value: 3\n> > + description: |\n> > + This is a long exposure image.\n> > +\n> > # ----------------------------------------------------------------------------\n> > # Draft controls section\n> >\n> > --\n> > 2.30.2\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 43CE7BF415\n\tfor ;\n\tMon, 21 Aug 2023 09:07:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A0E3627DF;\n\tMon, 21 Aug 2023 11:07:00 +0200 (CEST)","from mail-qt1-x835.google.com (mail-qt1-x835.google.com\n\t[IPv6:2607:f8b0:4864:20::835])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EA2CB627DA\n\tfor ;\n\tMon, 21 Aug 2023 11:06:58 +0200 (CEST)","by mail-qt1-x835.google.com with SMTP id\n\td75a77b69052e-410904c823bso10290621cf.3\n\tfor ;\n\tMon, 21 Aug 2023 02:06:58 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1692608820;\n\tbh=bTkeZazf8hjCdbEh5xgQXnQsyHVv6zKQ3wNo2TYPln8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gTFCiLJuMlIu97biM+K2JuiUuP4mjfvMVclqgn5OwDfEUGFs26dRLIGArq8qxdmOT\n\tLEjl9jWXGH90kEIvsNGk0zrOfLg5m7ZsSRgWtI0jEsFCqX1ldzvBZmp02NM7AzsA4I\n\tMcQZ/PO1mmKvRuuNtvX6M2RwE+zLxruqbfZITlP94C7ts7QaYO+f+xMyAd7GrsKNfH\n\tcuBi19tqJT3iv9swSYPDxWMoB6ca1rEWqkr0beS9WIX6x5GjVGX4Nfz4/NOQap9rLY\n\tr3W1Q2BkjQcoNCp1nvJNuJaeNlBN8RxhpgopFkXGmCmMA5pBzQki+2d9q3gBfUyfLZ\n\t6t9FtGa9nFPUg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1692608817; x=1693213617;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Tub0MUdyDD8qsGwqipCh5DVfWEFYL5kcTo3WSyShzrY=;\n\tb=Wb2S65mkmCjtkOulnAseWm+vvA2eYs5LEpJUayeiYvzjIzgIPHoprLtP/CIJ5Npeyq\n\taQMIP/SZ2WPxCiE8qWM63e22n0oxRmCdzjkiFKNvuy5iJq3dza0SHDyczLKrCkF4VxTi\n\tXeT3Cfr56lXJ115KS55FCOTwPxILVh5OkMoDIFJ8xAH5oq2q8gub4TZa/g6EzdepZ5k2\n\tNnFZrgDwh7U25ObFBDSwIV8svK49aqLxH8qMm6h8VAvmYfA0+Mste6e6D/NX3LKcUi3f\n\txZkSfi+EOBIpRPDuS/F9yImjmoOx7EmNrTjyEg4jBHFg8ME6L2owDLf4sdCXsyIi4Ctm\n\tzQ2g=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Wb2S65mk\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1692608817; x=1693213617;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=Tub0MUdyDD8qsGwqipCh5DVfWEFYL5kcTo3WSyShzrY=;\n\tb=ehh68nMNC7ZTXqxLBsbIG+Vl/WnQDnXHmAezzS6Mw+7AAppSEDto3Wi4Q1Dwjs9R5T\n\t/3X3lDhLYWUIVROCzOfn0OcEZjcw0uWiSPD4+b4YYEXblpR50XGkVd+a2QX2M77U4dvk\n\t+UyTtvxxmvzmDIfMwRIlympowvCGh8TYpyv//8dzbd1WPFaf2OLY5ZBKJtLPiTj7h0lC\n\tRckFvD836i/WRSrsFo2ilevDMSB5vSOQ4a2hia68jwarIn9MiVRXy84P5yMG1HrVAFA6\n\tWzeiMTEHINz6YPOExnydSwRBrTiq2UhA80s/g+SgxbW1pnrS58EwoDxp9kzIXQXI7W4P\n\t9iMA==","X-Gm-Message-State":"AOJu0YxaqfdgRXSanLEzoVp6aGCiY7S7+ou7htnYiDmCBeWjnbqspQYk\n\tOxfimECcVLT4FcJcBkNX35cSi7bNddLltpY5BgXfIjayuMSlgONO","X-Google-Smtp-Source":"AGHT+IH2RpU3Uves2YTrVXsHvyaiBlqux6mlFt5aY21vTqKIfchQKEmOunHaRPH95no1LUtj3NC8MBrhMp3aivhzdVY=","X-Received":"by 2002:a0c:aa5b:0:b0:64a:157:1d01 with SMTP id\n\te27-20020a0caa5b000000b0064a01571d01mr6489003qvb.4.1692608817696;\n\tMon, 21 Aug 2023 02:06:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20230728122758.2411-1-david.plowman@raspberrypi.com>\n\t<20230728122758.2411-2-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Mon, 21 Aug 2023 10:06:46 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27801,"web_url":"https://patchwork.libcamera.org/comment/27801/","msgid":"<2kgtimjmwrst7frmchngklpw7h5hqevlg5czpllzg62kbtuflq@4ywc4mdsax2g>","date":"2023-09-16T13:11:44","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi David\n\nOn Mon, Aug 21, 2023 at 10:06:46AM +0100, David Plowman via libcamera-devel wrote:\n> Hi Naush\n>\n> Thanks for the comments.\n>\n> On Mon, 21 Aug 2023 at 09:41, Naushir Patuck wrote:\n> >\n> > Hi David,\n> >\n> > Thank you for your patch.\n> >\n> > On Fri, 28 Jul 2023 at 13:28, David Plowman via libcamera-devel\n> > wrote:\n> > >\n> > > We add an HdrMode control (to enable and disable HDR processing)\n> > > and an HdrChannel, which indicates what kind of HDR frame (short, long\n> > > medium) has just arrived.\n> > >\n> > > Currently the HdrMode supports three values:\n> > >\n> > > * Off - no HDR processing at all.\n> > > * MultiExposure - frames at multiple different exposures are combined\n> > > to create HDR images.\n> > > * SingleExposure - multiple frames all at the same exposure are\n> > > combined to create HDR images.\n> > >\n> > > Signed-off-by: David Plowman \n> > > ---\n> > > src/libcamera/control_ids.yaml | 47 ++++++++++++++++++++++++++++++++++\n> > > 1 file changed, 47 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > > index 056886e6..34df7adb 100644\n> > > --- a/src/libcamera/control_ids.yaml\n> > > +++ b/src/libcamera/control_ids.yaml\n> > > @@ -701,6 +701,53 @@ controls:\n> > > Continuous AF is paused. No further state changes or lens movements\n> > > will occur until the AfPauseResume control is sent.\n> > >\n> > > + - HdrMode:\n> > > + type: int32_t\n> > > + description: |\n> > > + Control to set the mode to be used for High Dynamic Range (HDR)\n> > > + imaging.\n> > > +\n> > > + enum:\n> > > + - name: HdrModeOff\n> > > + value: 0\n> > > + description: |\n> > > + HDR is not enabled.\n> > > + - name: HdrModeMultiExposure\n> > > + value: 1\n> > > + description: |\n> > > + Multiple exposures will be used to create HDR images.\n> > > + - name: HdrModeSingleExposure\n> > > + value: 2\n> > > + description: |\n> > > + Multiple frames all at a single exposure will be used to create HDR\n> > > + images.\n> > > +\n> > > + - HdrChannel:\n> > > + type: int32_t\n> > > + description: |\n> > > + This value is reported back to the application so that it can discover\n> > > + whether this capture corresponds to the short or long exposure image (or\n> > > + any other image used by the HDR procedure).\n> >\n> > Only a minor comment about this control. Instead of an enum, should we use an\n> > explicit integer to determine channel number? Then we are not limited to only\n> > short/medium/long channels as below?\n>\n> This slightly gets us into the portable-applications vs.\n> platform-specific-capabilities debate...\n>\n> I'd quite like to have \"AgcChannel\" metadata that tells you exactly\n> this - namely which AGC channel this frame is from. But other\n> platforms might have no such concept even if they have some kind of\n> HDR support.\n>\n> So I'm slightly inclined to have a more generic notion of long/short\n> frame for HDR, whilst leaving the door open to adding \"AgcChannel\"\n> when it's needed.\n\nRelated to the discussion on \"[PATCH v2 2/2] ipa: rpi: vc4: data:\nUpdate tuning files for HDR \", the association between a channel index\n(defined by their declaration order) and the menomic name is done in\nthe config file, using the \"channel_map\" property.\n\nTo know what \"short\" corresponds to, an application has to look at the\nconfig file and reverse the association. Is this fine in your opinion ?\n\n\n>\n> But I agree that there's no clear answer here, and other people's\n> opinions would be interesting.\n>\n> Thanks!\n> David\n>\n> >\n> > I'm not too bothered either way so,\n> >\n> > Reviewed-by: Naushir Patuck \n> >\n> > > + enum:\n> > > + - name: HdrChannelNone\n> > > + value: 0\n> > > + description: |\n> > > + This image does not correspond to any of the captures used to create\n> > > + an HDR image.\n> > > + - name: HdrChannelShort\n> > > + value: 1\n> > > + description: |\n> > > + This is a short exposure image.\n> > > + - name: HdrChannelMedium\n> > > + value: 2\n> > > + description: |\n> > > + This is a medium exposure image.\n> > > + - name: HdrChannelLong\n> > > + value: 3\n> > > + description: |\n> > > + This is a long exposure image.\n> > > +\n> > > # ----------------------------------------------------------------------------\n> > > # Draft controls section\n> > >\n> > > --\n> > > 2.30.2\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4C42BE080\n\tfor ;\n\tSat, 16 Sep 2023 13:11:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C46262919;\n\tSat, 16 Sep 2023 15:11:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9693562905\n\tfor ;\n\tSat, 16 Sep 2023 15:11:47 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 71A3710A0;\n\tSat, 16 Sep 2023 15:10:13 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1694869909;\n\tbh=ZviAhGdMP+BE1Y4eRAf7YRbzisF7e/lmRWCFwRFpYqg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Rsg6eKjIFjTxLk3MJQu5kmk5rOCgQr+Cigz3HgtLJk/2ol+AW7Cu8DtCk1SGI2r7a\n\t6mPmxcTXlVNcttZrmp8ZoSMGNamJs609JejVHUH5n4x1DBadxdiHIR3ux5EcqFx+ag\n\tVZH3exBt7KJN0l+uj5MoBGh0LLsfGfEcXkuQ2z8uNMXStN+p9f8LB6hUPNWZhkxr4D\n\tBiJIjY5DEtBgf4jz1Y51UxLjEih7PqcoaI0clZgZBzDoDaRezBgaFrSORbOtmwHiI4\n\ts3Yd5oo0JLd5EpioamLJ1I3wmbUQkiXVrwmDQus0LR3BqggH9uye8BKg4JLUGgeP1t\n\tgSpB/WgXBlESA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1694869813;\n\tbh=ZviAhGdMP+BE1Y4eRAf7YRbzisF7e/lmRWCFwRFpYqg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cT+J1GS3b58pNpPejrTHJd78T4c06KOUbX+mbxEbwPupg089GsTvZj9qLFIZGEfJb\n\tn2NPOEf/4p33oDhh98UIf+MjYNKuNoMuxNmOgISBPz4WFTONSU3nHWT2dPpIDwOAaf\n\tG21hUD+BKUH0aaXWzEaq1Hk1J384e7NTO+ZLmffg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cT+J1GS3\"; dkim-atps=neutral","Date":"Sat, 16 Sep 2023 15:11:44 +0200","To":"David Plowman ","Message-ID":"<2kgtimjmwrst7frmchngklpw7h5hqevlg5czpllzg62kbtuflq@4ywc4mdsax2g>","References":"<20230728122758.2411-1-david.plowman@raspberrypi.com>\n\t<20230728122758.2411-2-david.plowman@raspberrypi.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27808,"web_url":"https://patchwork.libcamera.org/comment/27808/","msgid":"","date":"2023-09-18T08:45:56","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Jacopo\n\nThanks for the feedback.\n\nOn Sat, 16 Sept 2023 at 14:11, Jacopo Mondi\n wrote:\n>\n> Hi David\n>\n> On Mon, Aug 21, 2023 at 10:06:46AM +0100, David Plowman via libcamera-devel wrote:\n> > Hi Naush\n> >\n> > Thanks for the comments.\n> >\n> > On Mon, 21 Aug 2023 at 09:41, Naushir Patuck wrote:\n> > >\n> > > Hi David,\n> > >\n> > > Thank you for your patch.\n> > >\n> > > On Fri, 28 Jul 2023 at 13:28, David Plowman via libcamera-devel\n> > > wrote:\n> > > >\n> > > > We add an HdrMode control (to enable and disable HDR processing)\n> > > > and an HdrChannel, which indicates what kind of HDR frame (short, long\n> > > > medium) has just arrived.\n> > > >\n> > > > Currently the HdrMode supports three values:\n> > > >\n> > > > * Off - no HDR processing at all.\n> > > > * MultiExposure - frames at multiple different exposures are combined\n> > > > to create HDR images.\n> > > > * SingleExposure - multiple frames all at the same exposure are\n> > > > combined to create HDR images.\n> > > >\n> > > > Signed-off-by: David Plowman \n> > > > ---\n> > > > src/libcamera/control_ids.yaml | 47 ++++++++++++++++++++++++++++++++++\n> > > > 1 file changed, 47 insertions(+)\n> > > >\n> > > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > > > index 056886e6..34df7adb 100644\n> > > > --- a/src/libcamera/control_ids.yaml\n> > > > +++ b/src/libcamera/control_ids.yaml\n> > > > @@ -701,6 +701,53 @@ controls:\n> > > > Continuous AF is paused. No further state changes or lens movements\n> > > > will occur until the AfPauseResume control is sent.\n> > > >\n> > > > + - HdrMode:\n> > > > + type: int32_t\n> > > > + description: |\n> > > > + Control to set the mode to be used for High Dynamic Range (HDR)\n> > > > + imaging.\n> > > > +\n> > > > + enum:\n> > > > + - name: HdrModeOff\n> > > > + value: 0\n> > > > + description: |\n> > > > + HDR is not enabled.\n> > > > + - name: HdrModeMultiExposure\n> > > > + value: 1\n> > > > + description: |\n> > > > + Multiple exposures will be used to create HDR images.\n> > > > + - name: HdrModeSingleExposure\n> > > > + value: 2\n> > > > + description: |\n> > > > + Multiple frames all at a single exposure will be used to create HDR\n> > > > + images.\n> > > > +\n> > > > + - HdrChannel:\n> > > > + type: int32_t\n> > > > + description: |\n> > > > + This value is reported back to the application so that it can discover\n> > > > + whether this capture corresponds to the short or long exposure image (or\n> > > > + any other image used by the HDR procedure).\n> > >\n> > > Only a minor comment about this control. Instead of an enum, should we use an\n> > > explicit integer to determine channel number? Then we are not limited to only\n> > > short/medium/long channels as below?\n> >\n> > This slightly gets us into the portable-applications vs.\n> > platform-specific-capabilities debate...\n> >\n> > I'd quite like to have \"AgcChannel\" metadata that tells you exactly\n> > this - namely which AGC channel this frame is from. But other\n> > platforms might have no such concept even if they have some kind of\n> > HDR support.\n> >\n> > So I'm slightly inclined to have a more generic notion of long/short\n> > frame for HDR, whilst leaving the door open to adding \"AgcChannel\"\n> > when it's needed.\n>\n> Related to the discussion on \"[PATCH v2 2/2] ipa: rpi: vc4: data:\n> Update tuning files for HDR \", the association between a channel index\n> (defined by their declaration order) and the menomic name is done in\n> the config file, using the \"channel_map\" property.\n>\n> To know what \"short\" corresponds to, an application has to look at the\n> config file and reverse the association. Is this fine in your opinion ?\n\nFor the Pi platform, yes that's correct. Other platforms can of course\ndo completely different things.\n\nI think there does need to be some kind of mapping somewhere, because\nwe never pass libcamera control values directly into our algorithms.\nThough we could certainly look again at how the mapping works.\n\nI'll talk more about that in that other patch as I don't think it's\nactually relevant to this HDR control.\n\nThanks!\nDavid\n\n>\n>\n> >\n> > But I agree that there's no clear answer here, and other people's\n> > opinions would be interesting.\n> >\n> > Thanks!\n> > David\n> >\n> > >\n> > > I'm not too bothered either way so,\n> > >\n> > > Reviewed-by: Naushir Patuck \n> > >\n> > > > + enum:\n> > > > + - name: HdrChannelNone\n> > > > + value: 0\n> > > > + description: |\n> > > > + This image does not correspond to any of the captures used to create\n> > > > + an HDR image.\n> > > > + - name: HdrChannelShort\n> > > > + value: 1\n> > > > + description: |\n> > > > + This is a short exposure image.\n> > > > + - name: HdrChannelMedium\n> > > > + value: 2\n> > > > + description: |\n> > > > + This is a medium exposure image.\n> > > > + - name: HdrChannelLong\n> > > > + value: 3\n> > > > + description: |\n> > > > + This is a long exposure image.\n> > > > +\n> > > > # ----------------------------------------------------------------------------\n> > > > # Draft controls section\n> > > >\n> > > > --\n> > > > 2.30.2\n> > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8939BE080\n\tfor ;\n\tMon, 18 Sep 2023 08:46:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 118B66293B;\n\tMon, 18 Sep 2023 10:46:10 +0200 (CEST)","from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com\n\t[IPv6:2607:f8b0:4864:20::f2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0689E61DEC\n\tfor ;\n\tMon, 18 Sep 2023 10:46:09 +0200 (CEST)","by mail-qv1-xf2c.google.com with SMTP id\n\t6a1803df08f44-65636207df5so14002876d6.2\n\tfor ;\n\tMon, 18 Sep 2023 01:46:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695026770;\n\tbh=h45Vz8z7Lnm6Bli5zK3tUrKFhVmNmGlUd8qq+8dreXg=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=OLMU4Zj9IH//JSg7fX+K68uEFWn4d+9FLiDBuErg++z11seDQmYv3h0utWf1SK4PB\n\tnECWMPf7zy/vJeiN9CwJYaCGVKKHpnbx1VfDP0BHK7+bd3b4hMlknq9t+PyUTjKT72\n\t9Da8HkSRVDF70XElT7zZhepxRouZX9z8U6Iv6S+3HHbX3kiZkUQFD17bL9q5d+jEEN\n\tzLIvblC4Nyv3okBSOI1YyqQ2zV6IhofMkcqyxM85rTn1elGhg4hD5H3iLcNuIgJr1b\n\tDtpI0UxGbKJID4gYw2st8HJDwwByne01JhqMdZqaXPfH9Hb3zEN1Jec4qWxi1x9krN\n\t6Gc9OtEqQBI4g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695026767; x=1695631567;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=DFGWjabHzUteHVe4PNMZYEY/+wCiGF2bmhlCOigJhIs=;\n\tb=FSfakkhaSb9cLBK0qZ/ErgiixwoGppnfDGY/U+BXOYGdYd8WFbFl3NpXZd/2BxRNia\n\t2DWZeE4P80mPzmgifjGnOCkS5wl3QDz508o6qGYDoyxlYzWskdh6tNTXSv2YGytkI2nX\n\tkvQHetUjBpou3oaYjyIIx+4MBXA7bKGpTH1ukCUgYVUDPRr3/kWQonbAiRTWxX5nkmFa\n\tXKy8y7fP3+bTDrid3aoN0jSbCwLcabK2g/brbQ2mW86GGPrlpGi50tJVqOGGFmxq6Ydq\n\tH06a33xFskMHM2GhUWuNFu22tJNPV1yi2rw4eiaVo3hivPJ1dFGj7gsfeCw6ZyTsQcos\n\t1I+w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"FSfakkha\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695026767; x=1695631567;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=DFGWjabHzUteHVe4PNMZYEY/+wCiGF2bmhlCOigJhIs=;\n\tb=DZANDJpg9gNV6bh8INRT7mrqEkzmiNnd936oTzIcYp05SIHO1vfXWOMChZfgel4Vph\n\tE3ewyxkP7uC0vgThlkTs0ihmNvvfZ7JoDI1wn2nfB0rOhqOLckzKkStzqdXtMYsmpW/T\n\ttmJ/CM3fKKrMdTIQ3QiNhK2+EuuDrhRHlBQIeSYnXSW2XboLS77EiL34wo9Sa9I1HaEG\n\t647TVUtxvzYEcJXDp7PACzDrF355KDhJ38MU9hvbXffpaRLdFVo0JEBy7vnn0seGzn7r\n\tuqJvAy2iW8myjp7ujdJIQzyHAlg6ryOQRPO3iY+mJMS+Hphxa6Jz1+0VOIl896pLnSDK\n\tW8Tw==","X-Gm-Message-State":"AOJu0Ywpj+Y6gTGOeWoWrwsw6cow4LXDdxnwV52ajyHg+Y4zOFF2kq8C\n\tIFKqmaYTwCTiN+vGmafkksxcmkGyV4ny7MzJFD6vFyBWccxa+XEl","X-Google-Smtp-Source":"AGHT+IE0rS7SH2QQJtFX9LxIdQn1BFcdVBmbclUe2C8nhFNYaj98xMBFN6G6jHXjwHmXh0DbnVm2lUtHxa5E/sPkGWI=","X-Received":"by 2002:a0c:abc6:0:b0:63c:f48c:cbe5 with SMTP id\n\tk6-20020a0cabc6000000b0063cf48ccbe5mr8014484qvb.35.1695026767749;\n\tMon, 18 Sep 2023 01:46:07 -0700 (PDT)","MIME-Version":"1.0","References":"<20230728122758.2411-1-david.plowman@raspberrypi.com>\n\t<20230728122758.2411-2-david.plowman@raspberrypi.com>\n\t\n\t\n\t<2kgtimjmwrst7frmchngklpw7h5hqevlg5czpllzg62kbtuflq@4ywc4mdsax2g>","In-Reply-To":"<2kgtimjmwrst7frmchngklpw7h5hqevlg5czpllzg62kbtuflq@4ywc4mdsax2g>","Date":"Mon, 18 Sep 2023 09:45:56 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27834,"web_url":"https://patchwork.libcamera.org/comment/27834/","msgid":"","date":"2023-09-21T14:00:15","subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi again\n\nActually I'm wondering about adding another option to this list. I\nthink a \"night\" mode might be useful. It might be very similar to some\nof the other HDR modes, but I could imagine placing less emphasis on\nexpanding the dynamic range and rather more on using the image\nstacking to increase the amount of denoise. It's clearly very similar\nto the other HDR techniques, but it would be left to the\nimplementation to decide exactly how to do the \"night\" version (if\nindeed it wants to support that).\n\n Any thoughts? I could submit another version of this patch...\n\nDavid\n\nOn Mon, 18 Sept 2023 at 09:45, David Plowman\n wrote:\n>\n> Hi Jacopo\n>\n> Thanks for the feedback.\n>\n> On Sat, 16 Sept 2023 at 14:11, Jacopo Mondi\n> wrote:\n> >\n> > Hi David\n> >\n> > On Mon, Aug 21, 2023 at 10:06:46AM +0100, David Plowman via libcamera-devel wrote:\n> > > Hi Naush\n> > >\n> > > Thanks for the comments.\n> > >\n> > > On Mon, 21 Aug 2023 at 09:41, Naushir Patuck wrote:\n> > > >\n> > > > Hi David,\n> > > >\n> > > > Thank you for your patch.\n> > > >\n> > > > On Fri, 28 Jul 2023 at 13:28, David Plowman via libcamera-devel\n> > > > wrote:\n> > > > >\n> > > > > We add an HdrMode control (to enable and disable HDR processing)\n> > > > > and an HdrChannel, which indicates what kind of HDR frame (short, long\n> > > > > medium) has just arrived.\n> > > > >\n> > > > > Currently the HdrMode supports three values:\n> > > > >\n> > > > > * Off - no HDR processing at all.\n> > > > > * MultiExposure - frames at multiple different exposures are combined\n> > > > > to create HDR images.\n> > > > > * SingleExposure - multiple frames all at the same exposure are\n> > > > > combined to create HDR images.\n> > > > >\n> > > > > Signed-off-by: David Plowman \n> > > > > ---\n> > > > > src/libcamera/control_ids.yaml | 47 ++++++++++++++++++++++++++++++++++\n> > > > > 1 file changed, 47 insertions(+)\n> > > > >\n> > > > > diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> > > > > index 056886e6..34df7adb 100644\n> > > > > --- a/src/libcamera/control_ids.yaml\n> > > > > +++ b/src/libcamera/control_ids.yaml\n> > > > > @@ -701,6 +701,53 @@ controls:\n> > > > > Continuous AF is paused. No further state changes or lens movements\n> > > > > will occur until the AfPauseResume control is sent.\n> > > > >\n> > > > > + - HdrMode:\n> > > > > + type: int32_t\n> > > > > + description: |\n> > > > > + Control to set the mode to be used for High Dynamic Range (HDR)\n> > > > > + imaging.\n> > > > > +\n> > > > > + enum:\n> > > > > + - name: HdrModeOff\n> > > > > + value: 0\n> > > > > + description: |\n> > > > > + HDR is not enabled.\n> > > > > + - name: HdrModeMultiExposure\n> > > > > + value: 1\n> > > > > + description: |\n> > > > > + Multiple exposures will be used to create HDR images.\n> > > > > + - name: HdrModeSingleExposure\n> > > > > + value: 2\n> > > > > + description: |\n> > > > > + Multiple frames all at a single exposure will be used to create HDR\n> > > > > + images.\n> > > > > +\n> > > > > + - HdrChannel:\n> > > > > + type: int32_t\n> > > > > + description: |\n> > > > > + This value is reported back to the application so that it can discover\n> > > > > + whether this capture corresponds to the short or long exposure image (or\n> > > > > + any other image used by the HDR procedure).\n> > > >\n> > > > Only a minor comment about this control. Instead of an enum, should we use an\n> > > > explicit integer to determine channel number? Then we are not limited to only\n> > > > short/medium/long channels as below?\n> > >\n> > > This slightly gets us into the portable-applications vs.\n> > > platform-specific-capabilities debate...\n> > >\n> > > I'd quite like to have \"AgcChannel\" metadata that tells you exactly\n> > > this - namely which AGC channel this frame is from. But other\n> > > platforms might have no such concept even if they have some kind of\n> > > HDR support.\n> > >\n> > > So I'm slightly inclined to have a more generic notion of long/short\n> > > frame for HDR, whilst leaving the door open to adding \"AgcChannel\"\n> > > when it's needed.\n> >\n> > Related to the discussion on \"[PATCH v2 2/2] ipa: rpi: vc4: data:\n> > Update tuning files for HDR \", the association between a channel index\n> > (defined by their declaration order) and the menomic name is done in\n> > the config file, using the \"channel_map\" property.\n> >\n> > To know what \"short\" corresponds to, an application has to look at the\n> > config file and reverse the association. Is this fine in your opinion ?\n>\n> For the Pi platform, yes that's correct. Other platforms can of course\n> do completely different things.\n>\n> I think there does need to be some kind of mapping somewhere, because\n> we never pass libcamera control values directly into our algorithms.\n> Though we could certainly look again at how the mapping works.\n>\n> I'll talk more about that in that other patch as I don't think it's\n> actually relevant to this HDR control.\n>\n> Thanks!\n> David\n>\n> >\n> >\n> > >\n> > > But I agree that there's no clear answer here, and other people's\n> > > opinions would be interesting.\n> > >\n> > > Thanks!\n> > > David\n> > >\n> > > >\n> > > > I'm not too bothered either way so,\n> > > >\n> > > > Reviewed-by: Naushir Patuck \n> > > >\n> > > > > + enum:\n> > > > > + - name: HdrChannelNone\n> > > > > + value: 0\n> > > > > + description: |\n> > > > > + This image does not correspond to any of the captures used to create\n> > > > > + an HDR image.\n> > > > > + - name: HdrChannelShort\n> > > > > + value: 1\n> > > > > + description: |\n> > > > > + This is a short exposure image.\n> > > > > + - name: HdrChannelMedium\n> > > > > + value: 2\n> > > > > + description: |\n> > > > > + This is a medium exposure image.\n> > > > > + - name: HdrChannelLong\n> > > > > + value: 3\n> > > > > + description: |\n> > > > > + This is a long exposure image.\n> > > > > +\n> > > > > # ----------------------------------------------------------------------------\n> > > > > # Draft controls section\n> > > > >\n> > > > > --\n> > > > > 2.30.2\n> > > > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9CE3BE080\n\tfor ;\n\tThu, 21 Sep 2023 14:00:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E16A62944;\n\tThu, 21 Sep 2023 16:00:29 +0200 (CEST)","from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com\n\t[IPv6:2607:f8b0:4864:20::1136])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8148D628D8\n\tfor ;\n\tThu, 21 Sep 2023 16:00:27 +0200 (CEST)","by mail-yw1-x1136.google.com with SMTP id\n\t00721157ae682-59b5484fbe6so12371967b3.1\n\tfor ;\n\tThu, 21 Sep 2023 07:00:27 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1695304829;\n\tbh=zGsb7pj5oQxKjjawi8+GJAAVTBsD+QTy+oh+tc3hFDc=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=gknule2eCZ82I8hovN1KRI78wgSv6l0lK4/UMx7b6soS5zw6NK7IFzJUzSm3ryjBz\n\tfkxlTDOGzLHthNE3O1IwpjxX4nbQk7iMxSm4IiknriUDRFutICpaOcxE5s1Qfao53q\n\tJv2YdQeSf29N5Ta6bcWgXTm1azGSThlR+8xqdHTVUh6iZJa+xT56TxTPmXK0dOXx9+\n\tiudpP0N+mVKNchJvE02MSutkMseuKQq5HS7g3uw+7WlH6SoMWnD0QfQ5IWU7Nqg5me\n\taf3lKnMclWKJ/q+M/vaM9xPjbJww/Ilnt47H1xmIsbTWkTHBAFZZhjuvLyIN+qXvHj\n\truYGaS3HUHRpA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1695304826; x=1695909626;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=y76anVI9zJ4rgtJOteI13dfXatnkeMNh0PxXjdgNNd4=;\n\tb=o2da7tjNVpu4wmtRWkkEDu1FAOc2bgfnTu4NZAZ4eKpcXy4PJ+73sGsEo6rnLgxvvp\n\tTVdXBiScy94r+YDDphblu9JxmbKy+BoILpk3TjTbCPvIlMZr+09mgL46+zqC9gCeA7EM\n\t0V7BFzC/VeNhmlFPyzr9WKLmEYwCZMTRoC0+gRzA2ThSCTfEQhiADyx/XSeBHpx4cagP\n\tb+4TZOAmw+AJjrtdIXQJPp+rIgpFvlrKNSvEvn0OUD98AxsVvyWSkdb7mvJlTr9Ttt99\n\tR9XqadEnFeWHbwbPzFdTixLTX7eieuHbSSvRDYIAujeDtERqOhxij57zIwSinC5IUXzj\n\tTftA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"o2da7tjN\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1695304826; x=1695909626;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=y76anVI9zJ4rgtJOteI13dfXatnkeMNh0PxXjdgNNd4=;\n\tb=b99gVxJJMJDZtUyGFFxPsLQ7UfHtNKK9443bx9h6o7mA5pStQu/ojYw/3EGg7WMfiv\n\towwIiRw46Ui7+i6m7vPIE00SNShmAsNkrYG3tz4yKmcz3xqev2rj+diPAZUblmq/V9Kj\n\tjQPOoLsMn48PQqGCmAEAOnXFB6w0aK2CcH9MFVuqcwrHd5XJ8/DXSRLxfXVCXw761Nzk\n\tYKBPvBJFSgJ/yKGk2rUVza0VikW8KQB4mgeet0UxxZUwbMTJ9wEXOvbkTnblCH+kdf3/\n\tYF3EAkk0Mk3uZNDXZnnyr5Smxq2gJNtnq82BgPkMlAfdhhhTdqV8Rar0auz+CQbbiQ8m\n\tK7Vg==","X-Gm-Message-State":"AOJu0YyLlG+PBCSrGn1lyMhrn+J3efJQB+AOndxnoHVlSIWvkQ3B5CRK\n\tdMQRfRtF1A8Bc7flGBJgK2eIZbJEyp6qNmKY2BXJNQ==","X-Google-Smtp-Source":"AGHT+IEj0+GowG0HUtNA2OXLRu7uPHdqO2M916llbdeJ7eiGqE6X9dUcBlKIQrL7g/RkMXYXq0nM1iF+ZoAoJVeSDO0=","X-Received":"by 2002:a0d:c341:0:b0:583:307d:41bc with SMTP id\n\tf62-20020a0dc341000000b00583307d41bcmr5374107ywd.27.1695304826062;\n\tThu, 21 Sep 2023 07:00:26 -0700 (PDT)","MIME-Version":"1.0","References":"<20230728122758.2411-1-david.plowman@raspberrypi.com>\n\t<20230728122758.2411-2-david.plowman@raspberrypi.com>\n\t\n\t\n\t<2kgtimjmwrst7frmchngklpw7h5hqevlg5czpllzg62kbtuflq@4ywc4mdsax2g>\n\t","In-Reply-To":"","Date":"Thu, 21 Sep 2023 15:00:15 +0100","Message-ID":"","To":"Jacopo Mondi ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] libcamera: controls: Add controls\n\tfor HDR","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]