[{"id":27623,"web_url":"https://patchwork.libcamera.org/comment/27623/","msgid":"<matrqkttwdbz4skodqspcv3owj5waalj356e5n3skci2di6t5m@kq3vcybhq3p7>","date":"2023-07-27T14:21:40","subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Don't call\n\ttoV4L2DeviceFormat() from validate()","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Thu, Jul 27, 2023 at 02:01:07PM +0100, Naushir Patuck wrote:\n> Don't make an unnecessary call to toV4L2DeviceFormat() from validate()\n> to get a V4L2DeviceFormat. Instead, the conversion can happen directly\n> from the RAW stream PixelFormat.\n>\n> Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> ---\n>  src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 7 ++++---\n>  1 file changed, 4 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> index e0fbeec37fe9..97acafbbb728 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> @@ -226,10 +226,11 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n>  \t/* Further fixups on the RAW streams. */\n>  \tfor (auto &raw : rawStreams) {\n>  \t\tStreamConfiguration &cfg = config_.at(raw.index);\n> -\t\tV4L2DeviceFormat rawFormat;\n>\n> -\t\tBayerFormat::Packing packing = BayerFormat::fromPixelFormat(cfg.pixelFormat).packing;\n> -\t\trawFormat = PipelineHandlerBase::toV4L2DeviceFormat(raw.dev, sensorFormat_, packing);\n\nIs the function still used ?\n\n> +\t\tV4L2DeviceFormat rawFormat;\n> +\t\trawFormat.fourcc = raw.dev->toV4L2PixelFormat(cfg.pixelFormat);\n> +\t\trawFormat.size = cfg.size;\n> +\t\trawFormat.colorSpace = cfg.colorSpace;\n>\n>  \t\tint ret = raw.dev->tryFormat(&rawFormat);\n>  \t\tif (ret)\n> --\n> 2.34.1\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB0ABBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Jul 2023 14:21:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39F3B628BC;\n\tThu, 27 Jul 2023 16:21:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15CAA600F7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Jul 2023 16:21:44 +0200 (CEST)","from ideasonboard.com (mob-5-91-19-250.net.vodafone.it\n\t[5.91.19.250])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F6F02E4;\n\tThu, 27 Jul 2023 16:20:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690467706;\n\tbh=uH6V+/iXuq32a7plPxEVKbVugiGn2DBaYnOV2qey+TU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rBVt/ho8/jJmmqgoEBTZCIiuL7gMjM/2FW3NzO05Ncq25g8hjx2A+wzCYM+6Z1nsx\n\tj33LzSqwJwJgtUxCj9l/9At8mk5TKOUz0Ic4KU4liyb2scQmP0bFUoLjDSVGP1fJLu\n\t9g5hD0EqJL+8Fvvv6O7dawQXPUvkSX1CqAodErOblaFg91oSFEbCiEBtW0Pyym+LsT\n\tv97sNB/hKnwkjJ2ymUBgyBW0SWAPdY61AGiJBnEJYBWqxpPFZEgAUlm5efkVGNxniZ\n\tfqH9X7sJG6U2x49PFLD6sB5EDphanoALiF2zBlwLLY7REzPVglV1dA/yi0VTQd+Ba0\n\tIf5wHXBnB5XVw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690467644;\n\tbh=uH6V+/iXuq32a7plPxEVKbVugiGn2DBaYnOV2qey+TU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ukTr0L3PT1JTcVT3l7iUwXoZTZTM9RUUv/ZZ/cke5mC8h2qqxcn06H3uF6wPOxKqw\n\t894BfViZkMf5tcGfZ9dRs4UGB7yr6FQRc3IrhABkh+B1bi7L3hkdyf7pSA2rZXomUC\n\tzIKE1ZsXW8eobvbnk0piC5LuPAd2fIqdfr3LUg1M="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ukTr0L3P\"; dkim-atps=neutral","Date":"Thu, 27 Jul 2023 16:21:40 +0200","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<matrqkttwdbz4skodqspcv3owj5waalj356e5n3skci2di6t5m@kq3vcybhq3p7>","References":"<20230727130107.20891-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230727130107.20891-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Don't call\n\ttoV4L2DeviceFormat() from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27625,"web_url":"https://patchwork.libcamera.org/comment/27625/","msgid":"<CAEmqJPob094z+yqPfLm-=dht8dnR+QnxRNZHzEWRW=p8P0X0iQ@mail.gmail.com>","date":"2023-07-27T14:32:52","subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Don't call\n\ttoV4L2DeviceFormat() from validate()","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Jacopo,\n\nOn Thu, 27 Jul 2023 at 15:21, Jacopo Mondi\n<jacopo.mondi@ideasonboard.com> wrote:\n>\n> Hi Naush\n>\n> On Thu, Jul 27, 2023 at 02:01:07PM +0100, Naushir Patuck wrote:\n> > Don't make an unnecessary call to toV4L2DeviceFormat() from validate()\n> > to get a V4L2DeviceFormat. Instead, the conversion can happen directly\n> > from the RAW stream PixelFormat.\n> >\n> > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> > ---\n> >  src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 7 ++++---\n> >  1 file changed, 4 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > index e0fbeec37fe9..97acafbbb728 100644\n> > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > @@ -226,10 +226,11 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> >       /* Further fixups on the RAW streams. */\n> >       for (auto &raw : rawStreams) {\n> >               StreamConfiguration &cfg = config_.at(raw.index);\n> > -             V4L2DeviceFormat rawFormat;\n> >\n> > -             BayerFormat::Packing packing = BayerFormat::fromPixelFormat(cfg.pixelFormat).packing;\n> > -             rawFormat = PipelineHandlerBase::toV4L2DeviceFormat(raw.dev, sensorFormat_, packing);\n>\n> Is the function still used ?\n\nYes, it does get used in vc4.cpp.  Essentially it converts from a\nV4L2SubdeviceFormat to V4L2DeviceFormat for any given packing mode.\n\nRegards,\nNaush\n\n>\n> > +             V4L2DeviceFormat rawFormat;\n> > +             rawFormat.fourcc = raw.dev->toV4L2PixelFormat(cfg.pixelFormat);\n> > +             rawFormat.size = cfg.size;\n> > +             rawFormat.colorSpace = cfg.colorSpace;\n> >\n> >               int ret = raw.dev->tryFormat(&rawFormat);\n> >               if (ret)\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4495BBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Jul 2023 14:33:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04D14628BE;\n\tThu, 27 Jul 2023 16:33:09 +0200 (CEST)","from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com\n\t[IPv6:2607:f8b0:4864:20::1129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46A55628BC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Jul 2023 16:33:07 +0200 (CEST)","by mail-yw1-x1129.google.com with SMTP id\n\t00721157ae682-583f837054eso10875037b3.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Jul 2023 07:33:07 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690468389;\n\tbh=0rYKOwscu8ruv4X9rT6oxPMT6jKQQP58dn0eB03lv8A=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=iPmzpxbOF9Pinem/wfl+vLfWHuFDPbglX2xQZxD/V5XhN2pVicHNChylvSek7KAk5\n\tf7WEe3fYoZFB8DnHjP4JT1aPE3nptqX6Sc+M4AU+lGrKb1W+vLHwdXPlYPweCzo0/C\n\t9xuKtu5t9wjdXqVb/E/ToYRKyisXhtIeYPXmH6lccOYqT68PSo/MYyJUcwokLbvbjS\n\tvbc/WpwRQWxD31L1wIOnAYY5mbDmM6lqM3JzWY2pR/MHCyOJcxVfuQRQdSFQsmZ3fL\n\tWQsXW/ydFzSTaeAMOM1jy8o9r9MVMudAY7Aq41n4lZzwz5JhNO+GyBP3Lurz9l1+an\n\tYMzGqtOWDkllw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1690468386; x=1691073186;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=m0Qjv9PQG/7jrnwQZll2w/Pyh2VMQYuOwMIJRiM7OXQ=;\n\tb=B/JdCHaQDzWBXv/tBlXAs4PS0CL/uAu0uY/chw1ORl56TePe2TmoYj4sSiiiP/0TIu\n\tCVO3tSHQi3b+3favxCyJgw/0gyD3jXEmpCEQ5FG3Hcgme07S2zwnVLRljfAfRcNglJUE\n\t58hu0ejfBwlroNHjWKu9CDzg0qVGxAjvLJvrPU9m3abEpTVJRVpGFnyHmApktbZ/55aE\n\tDagZZmhXQO5ScQDN2OHIqbPt446v/9VrqX19rK8azZ8iUihgrivUE9GAjcOhYhrty+qw\n\tYM0nbCm41viSTBfTfQ4kYt8HERs/Tw9KlSSolIQ+jMwNQTQPO9KWvwMztrGTxBrztOsL\n\tTalw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"B/JdCHaQ\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1690468386; x=1691073186;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=m0Qjv9PQG/7jrnwQZll2w/Pyh2VMQYuOwMIJRiM7OXQ=;\n\tb=h2IqTBjSfvTNK2fmHsgEA+0SlpMJmI6Ka+o4Sijut/beneGm5x+SXNSVW/ZdKPQzPi\n\thZi5/YRpkPzD9IvKl+RntCOq0k37xVkpUEFDZIobnKCg4uN65h3yCC3iRT3RvklM+TDw\n\tpaWSKNg9p1ibF56W6+wENSbmF1fgdrMy1dHJK2H80HotVy7h/AQewY3PyGoLByzwafiX\n\tgf6OPziJBHcABs8hEfGYGJg7u9t5eACiWax4p3/4KMDpK5FusuO/UDlgmStP48MkVxUz\n\t/Y7d5rZ5rml+Ty4N0QG5NHt7gttubXvG6T3KLlF7B/SwMe6K4Iyj21FsoVKHEocXk1HS\n\tlDsQ==","X-Gm-Message-State":"ABy/qLZaN6CnD4MK+XsNJdabQnwXLWqOKZ3tAVvVu6XeKnCXUIllQtGX\n\taHt0Lhst5QjuXEweZhit2J2V1Ty3uS8zgJXdYsAGVg==","X-Google-Smtp-Source":"APBJJlGmN9VmXdJik1WUi/EGgTfyE/f3koLKMLjPmSRw6PTM6BojmZsAqnb60jt0rpmr7gr8vPvl+LdWKVpmQAAQeGA=","X-Received":"by 2002:a81:52d1:0:b0:565:c1a7:d197 with SMTP id\n\tg200-20020a8152d1000000b00565c1a7d197mr5278651ywb.39.1690468386154;\n\tThu, 27 Jul 2023 07:33:06 -0700 (PDT)","MIME-Version":"1.0","References":"<20230727130107.20891-1-naush@raspberrypi.com>\n\t<matrqkttwdbz4skodqspcv3owj5waalj356e5n3skci2di6t5m@kq3vcybhq3p7>","In-Reply-To":"<matrqkttwdbz4skodqspcv3owj5waalj356e5n3skci2di6t5m@kq3vcybhq3p7>","Date":"Thu, 27 Jul 2023 15:32:52 +0100","Message-ID":"<CAEmqJPob094z+yqPfLm-=dht8dnR+QnxRNZHzEWRW=p8P0X0iQ@mail.gmail.com>","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Don't call\n\ttoV4L2DeviceFormat() from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":27634,"web_url":"https://patchwork.libcamera.org/comment/27634/","msgid":"<wsv4do4akza576unw2enr35ez4siba3nksettafiysybeoyak5@ep4rxkmfxmvo>","date":"2023-07-31T08:25:18","subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Don't call\n\ttoV4L2DeviceFormat() from validate()","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Thu, Jul 27, 2023 at 03:32:52PM +0100, Naushir Patuck wrote:\n> Hi Jacopo,\n>\n> On Thu, 27 Jul 2023 at 15:21, Jacopo Mondi\n> <jacopo.mondi@ideasonboard.com> wrote:\n> >\n> > Hi Naush\n> >\n> > On Thu, Jul 27, 2023 at 02:01:07PM +0100, Naushir Patuck wrote:\n> > > Don't make an unnecessary call to toV4L2DeviceFormat() from validate()\n> > > to get a V4L2DeviceFormat. Instead, the conversion can happen directly\n> > > from the RAW stream PixelFormat.\n> > >\n> > > Signed-off-by: Naushir Patuck <naush@raspberrypi.com>\n> > > ---\n> > >  src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 7 ++++---\n> > >  1 file changed, 4 insertions(+), 3 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > index e0fbeec37fe9..97acafbbb728 100644\n> > > --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> > > @@ -226,10 +226,11 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> > >       /* Further fixups on the RAW streams. */\n> > >       for (auto &raw : rawStreams) {\n> > >               StreamConfiguration &cfg = config_.at(raw.index);\n> > > -             V4L2DeviceFormat rawFormat;\n> > >\n> > > -             BayerFormat::Packing packing = BayerFormat::fromPixelFormat(cfg.pixelFormat).packing;\n> > > -             rawFormat = PipelineHandlerBase::toV4L2DeviceFormat(raw.dev, sensorFormat_, packing);\n> >\n> > Is the function still used ?\n>\n> Yes, it does get used in vc4.cpp.  Essentially it converts from a\n> V4L2SubdeviceFormat to V4L2DeviceFormat for any given packing mode.\n>\n\nAh sorry, I did a wrong `git grep` indeed :/\n\nI guess there is no way we can get rid of this during ::platfomConfigure() as\nwe cannot bet on having a RAW PixelFormat as we do in this loop.\n\nBut anyway, the simplification here is good\n\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThanks\n  j\n\n> Regards,\n> Naush\n>\n> >\n> > > +             V4L2DeviceFormat rawFormat;\n> > > +             rawFormat.fourcc = raw.dev->toV4L2PixelFormat(cfg.pixelFormat);\n> > > +             rawFormat.size = cfg.size;\n> > > +             rawFormat.colorSpace = cfg.colorSpace;\n> > >\n> > >               int ret = raw.dev->tryFormat(&rawFormat);\n> > >               if (ret)\n> > > --\n> > > 2.34.1\n> > >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E9CBABDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 31 Jul 2023 08:25:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 477B0627EB;\n\tMon, 31 Jul 2023 10:25:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E83B6037D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Jul 2023 10:25:23 +0200 (CEST)","from ideasonboard.com (mob-5-90-53-43.net.vodafone.it [5.90.53.43])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E7482E4;\n\tMon, 31 Jul 2023 10:24:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690791924;\n\tbh=rzHDpqXrYbfh+0whe8w2A8cGbBkgK7MW1z4D8BdN6tQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=aKFZl0l4Y8IhcgII+pJUGXMjE1P7VrSmgT6tzUzjw1IkeIqlMis8GtAp2eHmgNtsw\n\ty7KRaXto/rB3lKgwCHwYaPhdezGEc3tywtdaN8ZSZU1ZPJg+dpTRKrxs7VsonsDClx\n\tycw0OSsZKiS1b5WSpcSRoDTWlhrJmyXw+zamNG+Z76YJcmqGl7S+zBhA3o44wayBiI\n\tDw1kzNfT51VDMkGg84mlwtpDa68l27DINf+9wF+OCx6iE8AMjmXUZ+NIWtM+EDv+zR\n\tObQxjrrJiVL6wu5U+SFXM3pORkihTfAXlro+ncoI/rzJHWthr9qQbK/cntqV4pCjSs\n\tfeD8St2w+2J8Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690791860;\n\tbh=rzHDpqXrYbfh+0whe8w2A8cGbBkgK7MW1z4D8BdN6tQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IiK7DkzCgL466//BKqfBaHOlosKxK1lGFzcBJCC8hnvPRGOP0LIYNEAKk4D91BYEK\n\t8tqVZwKB1HsCsSC41TDuf348sArfrO039SQP7bvoqPl4tl+aW46N9lkyw2wJVFtwzA\n\t8vqq/nW9Tjq8cecggj4sx+aFhAj+4wHB8Whq8r4A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"IiK7DkzC\"; dkim-atps=neutral","Date":"Mon, 31 Jul 2023 10:25:18 +0200","To":"Naushir Patuck <naush@raspberrypi.com>","Message-ID":"<wsv4do4akza576unw2enr35ez4siba3nksettafiysybeoyak5@ep4rxkmfxmvo>","References":"<20230727130107.20891-1-naush@raspberrypi.com>\n\t<matrqkttwdbz4skodqspcv3owj5waalj356e5n3skci2di6t5m@kq3vcybhq3p7>\n\t<CAEmqJPob094z+yqPfLm-=dht8dnR+QnxRNZHzEWRW=p8P0X0iQ@mail.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<CAEmqJPob094z+yqPfLm-=dht8dnR+QnxRNZHzEWRW=p8P0X0iQ@mail.gmail.com>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: rpi: Don't call\n\ttoV4L2DeviceFormat() from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]