[{"id":2562,"web_url":"https://patchwork.libcamera.org/comment/2562/","msgid":"<2f88436a-a3d1-7f42-b722-9b2269fd6016@ideasonboard.com>","date":"2019-08-30T09:14:06","subject":"Re: [libcamera-devel] [PATCH v2 01/14] libcamera: ipa: Remove\n\tIPAInterface::init()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\n\nOn 30/08/2019 00:26, Niklas Söderlund wrote:\n> The function performs no useful task and will not be needed when we\n> extend the IPA interface to process parameter and statistic buffers.\n\nThis is probably a neater way to remove this call :D\n\nI assume we're not relying on these messages as the only way to know the\ndummy-IPA tests have loaded ...\n\nSo..\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/ipa/ipa_interface.h | 2 --\n> src/ipa/ipa_dummy.cpp | 8 --------\n> src/ipa/ipa_dummy_isolate.cpp | 8 --------\n> src/libcamera/ipa_interface.cpp | 5 -----\n> src/libcamera/pipeline/vimc.cpp | 2 --\n> 5 files changed, 25 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 2c5eb1fd524311cb..9bbc4cf58ec66420 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -13,8 +13,6 @@ class IPAInterface\n> {\n> public:\n> \tvirtual ~IPAInterface() {}\n> -\n> -\tvirtual int init() = 0;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\n> index 4c8b6657689d0c9f..2fe232295c676941 100644\n> --- a/src/ipa/ipa_dummy.cpp\n> +++ b/src/ipa/ipa_dummy.cpp\n> @@ -14,16 +14,8 @@ namespace libcamera {\n> \n> class IPADummy : public IPAInterface\n> {\n> -public:\n> -\tint init();\n> };\n> \n> -int IPADummy::init()\n> -{\n> -\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n> -\treturn 0;\n> -}\n> -\n> /*\n> * External IPA module interface\n> */\n> diff --git a/src/ipa/ipa_dummy_isolate.cpp b/src/ipa/ipa_dummy_isolate.cpp\n> index 24434e85d31809e2..fa50be5309eba3c4 100644\n> --- a/src/ipa/ipa_dummy_isolate.cpp\n> +++ b/src/ipa/ipa_dummy_isolate.cpp\n> @@ -15,16 +15,8 @@ namespace libcamera {\n> \n> class IPADummyIsolate : public IPAInterface\n> {\n> -public:\n> -\tint init();\n> };\n> \n> -int IPADummyIsolate::init()\n> -{\n> -\tstd::cout << \"initializing isolated dummy IPA!\" << std::endl;\n> -\treturn 0;\n> -}\n> -\n> /*\n> * External IPA module interface\n> */\n> diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> index 9d30da29228fabb7..273477a5272677b7 100644\n> --- a/src/libcamera/ipa_interface.cpp\n> +++ b/src/libcamera/ipa_interface.cpp\n> @@ -19,9 +19,4 @@ namespace libcamera {\n> * \\brief Interface for IPA implementation\n> */\n> \n> -/**\n> - * \\fn IPAInterface::init()\n> - * \\brief Initialise the IPAInterface\n> - */\n> -\n> } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index f8f91d6219b1aee4..55d5bff287c3366d 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -364,8 +364,6 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> \tipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n> \tif (ipa_ == nullptr)\n> \t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n> -\telse\n> -\t\tipa_->init();\n> \n> \tstd::unique_ptr data = utils::make_unique(this);\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3A2A60BB2\n\tfor ;\n\tFri, 30 Aug 2019 11:14:09 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 324B454B;\n\tFri, 30 Aug 2019 11:14:09 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567156449;\n\tbh=hqhWvE93EbdE7lIcWbM7xvy2L9H3VCENEP1FuXHSKXo=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ixpJphfkdaPoWQz8AhbNE+M43829ocptUGsRWjD+gxjIOkpBZIohXAx6dBlyDuxlb\n\tgryXhBYZzNMVC5pqcBW83lDGBWEnuUFjIliYsqqnI4YcF9xwHxDrHrvWY8dRSPPCUl\n\t870BLyzw9EHETdG05/ErLwMVEqjHQFaFf1GgT4sE=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>\n\t<20190829232653.13214-2-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCJQQYAQoADwIbDAUCWcOUawUJ\n\tB4D+AgAKCRChHkZyEKRh/XJhEACr5iidt/0MZ0rWRMCbZFMWD7D2g6nZeOp+F2zY8CEUW+sd\n\tCDVd9BH9QX9KN5SZo6YtJzMzSzpcx45VwTvtQW0n/6Eujg9EUqblfU9xqvqDmbjEapr5d/OL\n\t21GTALb0owKhA5qDUGEcKGCphpQffKhTNo/BP99jvmJUj7IPSKH97qPypi8/ym8bAxB+uY31\n\tgHTMHf1jMJJ1pRo2tYYPeIIHGDqXBI4sp5GHHF+JcIhgR/e/A6w/dgzHYmQPl2ix5eZYEZbV\n\tTRP+gkX4NV8oHqa/lR+xPOlWElGB57viOSOoWriqxQbFy8XbG1GR8cWlkNtGBGVWaJaSoORP\n\tiowD7irXL91bCyFIqL+7BVk3Jy4uzP744PzE80KwxOp5SQAp9sPzFbgsJrLev90PZySjFHG0\n\twP144DK7nBjOj/J0g9OHVASP1JjK+nw7SDoKnETDIdRC0XmiHXk7TXzPdkvO0UkpHdEPjZUp\n\tWyuc0MqehjR/hTTPt4m/Y14XzEcy6JREIjOrFfUZVho2QpOdv9CNryGdieRTNjUtz463CIaZ\n\tdPBiw9mOMBoNffkn9FIoCjLnAaj9gUAnEHWBZOEviQ5NuyqpeP0YtzI4iaRbSUkYZHej99X3\n\tVmHrdLlMqd/ZgYYbPGSL4AN3FVACb5CxuxEHwo029VcE5U3CSjzqtCoX12tm7A==","Organization":"Ideas on Board","Message-ID":"<2f88436a-a3d1-7f42-b722-9b2269fd6016@ideasonboard.com>","Date":"Fri, 30 Aug 2019 10:14:06 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20190829232653.13214-2-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 01/14] libcamera: ipa: Remove\n\tIPAInterface::init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 30 Aug 2019 09:14:10 -0000"}},{"id":2592,"web_url":"https://patchwork.libcamera.org/comment/2592/","msgid":"<20190904141159.GI4811@pendragon.ideasonboard.com>","date":"2019-09-04T14:11:59","subject":"Re: [libcamera-devel] [PATCH v2 01/14] libcamera: ipa: Remove\n\tIPAInterface::init()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Aug 30, 2019 at 01:26:40AM +0200, Niklas Söderlund wrote:\n> The function performs no useful task and will not be needed when we\n> extend the IPA interface to process parameter and statistic buffers.\n> \n> Signed-off-by: Niklas Söderlund \n\nI haven't checked the rest of the series yet, but assuming we indeed\nwill have no use for an init method,\n\nReviewed-by: Laurent Pinchart \n\nIf this question isn't answered by other patches in the series, how will\nIPAs perform one-time initialisation ?\n\n> ---\n> include/libcamera/ipa/ipa_interface.h | 2 --\n> src/ipa/ipa_dummy.cpp | 8 --------\n> src/ipa/ipa_dummy_isolate.cpp | 8 --------\n> src/libcamera/ipa_interface.cpp | 5 -----\n> src/libcamera/pipeline/vimc.cpp | 2 --\n> 5 files changed, 25 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 2c5eb1fd524311cb..9bbc4cf58ec66420 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -13,8 +13,6 @@ class IPAInterface\n> {\n> public:\n> \tvirtual ~IPAInterface() {}\n> -\n> -\tvirtual int init() = 0;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/ipa/ipa_dummy.cpp b/src/ipa/ipa_dummy.cpp\n> index 4c8b6657689d0c9f..2fe232295c676941 100644\n> --- a/src/ipa/ipa_dummy.cpp\n> +++ b/src/ipa/ipa_dummy.cpp\n> @@ -14,16 +14,8 @@ namespace libcamera {\n> \n> class IPADummy : public IPAInterface\n> {\n> -public:\n> -\tint init();\n> };\n> \n> -int IPADummy::init()\n> -{\n> -\tstd::cout << \"initializing dummy IPA!\" << std::endl;\n> -\treturn 0;\n> -}\n> -\n> /*\n> * External IPA module interface\n> */\n> diff --git a/src/ipa/ipa_dummy_isolate.cpp b/src/ipa/ipa_dummy_isolate.cpp\n> index 24434e85d31809e2..fa50be5309eba3c4 100644\n> --- a/src/ipa/ipa_dummy_isolate.cpp\n> +++ b/src/ipa/ipa_dummy_isolate.cpp\n> @@ -15,16 +15,8 @@ namespace libcamera {\n> \n> class IPADummyIsolate : public IPAInterface\n> {\n> -public:\n> -\tint init();\n> };\n> \n> -int IPADummyIsolate::init()\n> -{\n> -\tstd::cout << \"initializing isolated dummy IPA!\" << std::endl;\n> -\treturn 0;\n> -}\n> -\n> /*\n> * External IPA module interface\n> */\n> diff --git a/src/libcamera/ipa_interface.cpp b/src/libcamera/ipa_interface.cpp\n> index 9d30da29228fabb7..273477a5272677b7 100644\n> --- a/src/libcamera/ipa_interface.cpp\n> +++ b/src/libcamera/ipa_interface.cpp\n> @@ -19,9 +19,4 @@ namespace libcamera {\n> * \\brief Interface for IPA implementation\n> */\n> \n> -/**\n> - * \\fn IPAInterface::init()\n> - * \\brief Initialise the IPAInterface\n> - */\n> -\n> } /* namespace libcamera */\n> diff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\n> index f8f91d6219b1aee4..55d5bff287c3366d 100644\n> --- a/src/libcamera/pipeline/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc.cpp\n> @@ -364,8 +364,6 @@ bool PipelineHandlerVimc::match(DeviceEnumerator *enumerator)\n> \tipa_ = IPAManager::instance()->createIPA(this, 0, 0);\n> \tif (ipa_ == nullptr)\n> \t\tLOG(VIMC, Warning) << \"no matching IPA found\";\n> -\telse\n> -\t\tipa_->init();\n> \n> \tstd::unique_ptr data = utils::make_unique(this);\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87E3D60BB2\n\tfor ;\n\tWed, 4 Sep 2019 16:12:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(mobile-access-bceeb5-228.dhcp.inet.fi [188.238.181.228])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0FE8440;\n\tWed, 4 Sep 2019 16:12:05 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567606326;\n\tbh=i8sQXDnmK+0H2/XKv+FFS+a/Gy2XFaZMpf+KZfbtc/Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wa54rZrfwI3JsoqlZlc2OIvy+wKhDUZZpfYzCwYLeq9G7a6UVG/xBQovBAoMHoNbM\n\t8Bg8gUIP9mvcU3oU/Ay3R2qlM2B0h7aINSLh9aOhfOjY9diJI61Kue4Pd0+gndA7qL\n\tzcnqyLXcFcou+IkwamAjE3+xOKbL9I+iMOwHV3gk=","Date":"Wed, 4 Sep 2019 17:11:59 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190904141159.GI4811@pendragon.ideasonboard.com>","References":"<20190829232653.13214-1-niklas.soderlund@ragnatech.se>\n\t<20190829232653.13214-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190829232653.13214-2-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 01/14] libcamera: ipa: Remove\n\tIPAInterface::init()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 04 Sep 2019 14:12:06 -0000"}}]