{"id":18866,"url":"https://patchwork.libcamera.org/api/patches/18866/?format=json","web_url":"https://patchwork.libcamera.org/patch/18866/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230724071101.5256-5-jacopo.mondi@ideasonboard.com>","date":"2023-07-24T07:10:55","name":"[libcamera-devel,v4,04/10] libcamera: properties: Make 'Rotation' the mounting rotation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5a6b72d0f853d0d1abb0ddff88c46d929a0fc426","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18866/mbox/","series":[{"id":3981,"url":"https://patchwork.libcamera.org/api/series/3981/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3981","date":"2023-07-24T07:10:51","name":"libcamera: Replace CameraConfiguration::transform","version":4,"mbox":"https://patchwork.libcamera.org/series/3981/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18866/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18866/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 331CCC32AA\n\tfor ;\n\tMon, 24 Jul 2023 07:11:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA61E628D4;\n\tMon, 24 Jul 2023 09:11:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CB5A628CB\n\tfor ;\n\tMon, 24 Jul 2023 09:11:23 +0200 (CEST)","from uno.localdomain (mob-5-91-20-233.net.vodafone.it\n\t[5.91.20.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 97BB84AD;\n\tMon, 24 Jul 2023 09:10:25 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690182686;\n\tbh=xDK91yoWnPn+8AhlpzdW8lSc0qCCbfllNaIxij+HUQg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=17mpc9u3OTXDX61fc4Ixw3V9/elpfc9+ae8zQ27On5HeUKCofpv6lRHcfWBaltxey\n\tEzUjs4cersxS2TqSd0NJWuEWNUuXID+w73zG1HqXnPQaNOUdJrAMOO1n+QI3gxv4Yz\n\tChtm8xwc/+JqEPISFWJo+gSgFm+C2cf/K+tgGnW3hiR/EYrFpw0zkoztN8FnppZrmK\n\t5MK+RhrsBF/UpheVAsi4dHqP9+0fuCYocyULITiOBMi8sTrgSw/JzP4Rp7tfFcAJGx\n\trJMBH/5uRH1pkJlxHGFkJ/ofVEUAAqvo3lJ/gotxkmnPoKZERz6xz5N0tASZB6aLmS\n\tOfTGS5qUiCndQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690182626;\n\tbh=xDK91yoWnPn+8AhlpzdW8lSc0qCCbfllNaIxij+HUQg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Cov2X0JP7XP/wHSucBCibrOUlUrCJj5WRey1Yo3HIffbJoTyF1s9Azy6ezHyf6GNb\n\tc4d8WwkOI2eKfJVH1Rv2rcvQ3eiZp96R2IqA4VbDXNgfIYVsHuJF68zJHYrqcJDd0n\n\tHCc8az/3KO3iuHE5lMZqsmXJcCN7A4So63kmHGgA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Cov2X0JP\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 24 Jul 2023 09:10:55 +0200","Message-Id":"<20230724071101.5256-5-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20230724071101.5256-1-jacopo.mondi@ideasonboard.com>","References":"<20230724071101.5256-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 04/10] libcamera: properties: Make\n\t'Rotation' the mounting rotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Specify in the documentation that properties::Rotation specifies the\nmounting rotation of the camera module. This avoids confusion with the\nimage orientation which is instead expressed by\nCameraConfiguration::orientation.\n\nFor this reason, do not compensate the Rotation property when\ninitializing the CameraSensor class but report the value of\nV4L2_CID_CAMERA_SENSOR_ROTATION or 0 if the control is not available.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: David Plowman \n---\n src/libcamera/camera_sensor.cpp | 11 +----------\n src/libcamera/property_ids.yaml | 8 ++++----\n 2 files changed, 5 insertions(+), 14 deletions(-)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 9a033459742f..3ba364c44a40 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -476,20 +476,11 @@ int CameraSensor::initProperties()\n \t\t\trotationTransform_ = Transform::Identity;\n \t\t}\n \n-\t\t/*\n-\t\t * Adjust property::Rotation as validateTransform() compensates\n-\t\t * for the mounting rotation. However, as a camera sensor can\n-\t\t * only compensate rotations by applying H/VFlips, only rotation\n-\t\t * of 180 degrees are automatically compensated. The other valid\n-\t\t * rotations (Rot90 and Rot270) require transposition, which the\n-\t\t * camera sensor cannot perform, so leave them untouched.\n-\t\t */\n-\t\tif (propertyValue == 180 && supportFlips_)\n-\t\t\tpropertyValue = 0;\n \t\tproperties_.set(properties::Rotation, propertyValue);\n \t} else {\n \t\tLOG(CameraSensor, Warning)\n \t\t\t<< \"Rotation control not available, default to 0 degrees\";\n+\t\tproperties_.set(properties::Rotation, propertyValue);\n \t\trotationTransform_ = Transform::Identity;\n \t}\n \ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 5bddafc29364..fb53081c1bd2 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -29,10 +29,10 @@ controls:\n - Rotation:\n type: int32_t\n description: |\n- The camera rotation is expressed as the angular difference in degrees\n- between two reference systems, one relative to the camera module, and\n- one defined on the external world scene to be captured when projected\n- on the image sensor pixel array.\n+ The camera physical mounting rotation, expressed as the angular\n+ difference in degrees between two reference systems, one relative to the\n+ camera module, and one defined on the external world scene to be\n+ captured when projected on the image sensor pixel array.\n \n A camera sensor has a 2-dimensional reference system 'Rc' defined by\n its pixel array read-out order. The origin is set to the first pixel\n","prefixes":["libcamera-devel","v4","04/10"]}