{"id":18863,"url":"https://patchwork.libcamera.org/api/patches/18863/?format=json","web_url":"https://patchwork.libcamera.org/patch/18863/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230724071101.5256-2-jacopo.mondi@ideasonboard.com>","date":"2023-07-24T07:10:52","name":"[libcamera-devel,v4,01/10] libcamera: camera_sensor: Cache rotationTransform_","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"da06f4fafdad4cf4b74b0d6d69fd7bf52cd0bff4","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18863/mbox/","series":[{"id":3981,"url":"https://patchwork.libcamera.org/api/series/3981/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3981","date":"2023-07-24T07:10:51","name":"libcamera: Replace CameraConfiguration::transform","version":4,"mbox":"https://patchwork.libcamera.org/series/3981/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18863/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18863/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FCB9C324E\n\tfor ;\n\tMon, 24 Jul 2023 07:11:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C99FF628C7;\n\tMon, 24 Jul 2023 09:11:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 27EF161E25\n\tfor ;\n\tMon, 24 Jul 2023 09:11:20 +0200 (CEST)","from uno.localdomain (mob-5-91-20-233.net.vodafone.it\n\t[5.91.20.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AC774AD;\n\tMon, 24 Jul 2023 09:10:21 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690182681;\n\tbh=5sPxj+3er3deOD8JJ1ckeFkzP2xyjqOLP3WMPssZpK4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=HR+nZe2/0c3/bDLNsi47xoetDfFzMI5SFJDJ92b6gEl3p7Majky5vtaU5+vaqCfDl\n\tgr7h/UGazOyQcaE6n7au9PqbebO8KQHT5Gw95exh2oXRayvkX3Vs873DeaMpr2IaiN\n\tfsp1Zj16iGOTo4sADwmkIaC/idir3IPMFErGObAuZ4BkOT7qYAy5mfCghETnYRldr+\n\tKCPeWya9zFrVEPHmZr/FRfXX32xCU+/6hUlup+tbNNitnlHG9mbtRel1sXJMC4aH+7\n\th65PBX/WIVDF/JhY5kAgToIp6796dTGUIsV/XyMGQ7C0CKf/UHZgUhldx18DT+Kwgk\n\tvYQW+CM6tsn8A==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690182622;\n\tbh=5sPxj+3er3deOD8JJ1ckeFkzP2xyjqOLP3WMPssZpK4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=evRgTWMkUcGt0g+I56NIU9YmhCHBozcGH+ReculRLU3gcfYe0JO4/Nngn4hgs2oZ+\n\taSVI0nOcV6dBgAoagja1VyFj22HK8X7aKf+OSsSbvZv7DsI9aI2KNbXPGZkUrfx7CF\n\tvOqJNyTip5r5/9rpoImUFxQ8kKa46G3vgHAqYe2A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"evRgTWMk\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 24 Jul 2023 09:10:52 +0200","Message-Id":"<20230724071101.5256-2-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20230724071101.5256-1-jacopo.mondi@ideasonboard.com>","References":"<20230724071101.5256-1-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v4 01/10] libcamera: camera_sensor: Cache\n\trotationTransform_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Jacopo Mondi ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The rotationTransform_ depends on a V4L2 control whose value does not\nchange for the whole lifetime of the camera.\n\nInstead of re-calculating it everytime the camera is configured, cache\nit at properties initialization time.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Umang Jain \nReviewed-by: Laurent Pinchart \nReviewed-by: David Plowman \n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/camera_sensor.cpp | 54 +++++++++++++---------\n 2 files changed, 32 insertions(+), 23 deletions(-)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 02c77ab037da..02b4b4d25e6d 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -107,6 +107,7 @@ private:\n \tRectangle activeArea_;\n \tconst BayerFormat *bayerFormat_;\n \tbool supportFlips_;\n+\tTransform rotationTransform_;\n \n \tControlList properties_;\n \ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex f3a5aa37149f..9a033459742f 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -461,18 +461,36 @@ int CameraSensor::initProperties()\n \n \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n \tif (rotationControl != controls.end()) {\n+\t\tpropertyValue = rotationControl->second.def().get();\n+\n \t\t/*\n-\t\t * validateTransform() compensates for the mounting rotation.\n-\t\t * However, as a camera sensor can only compensate rotations\n-\t\t * by applying H/VFlips, only rotation of 180 degrees are\n-\t\t * automatically compensated. The other valid rotations (Rot90\n-\t\t * and Rot270) require transposition, which the camera sensor\n-\t\t * cannot perform, so leave them untouched.\n+\t\t * Cache the Transform associated with the camera mounting\n+\t\t * rotation for later use in validateTransform().\n+\t\t */\n+\t\tbool success;\n+\t\trotationTransform_ = transformFromRotation(propertyValue, &success);\n+\t\tif (!success) {\n+\t\t\tLOG(CameraSensor, Warning)\n+\t\t\t\t<< \"Invalid rotation of \" << propertyValue\n+\t\t\t\t<< \" degrees - ignoring\";\n+\t\t\trotationTransform_ = Transform::Identity;\n+\t\t}\n+\n+\t\t/*\n+\t\t * Adjust property::Rotation as validateTransform() compensates\n+\t\t * for the mounting rotation. However, as a camera sensor can\n+\t\t * only compensate rotations by applying H/VFlips, only rotation\n+\t\t * of 180 degrees are automatically compensated. The other valid\n+\t\t * rotations (Rot90 and Rot270) require transposition, which the\n+\t\t * camera sensor cannot perform, so leave them untouched.\n \t\t */\n-\t\tpropertyValue = rotationControl->second.def().get();\n \t\tif (propertyValue == 180 && supportFlips_)\n \t\t\tpropertyValue = 0;\n \t\tproperties_.set(properties::Rotation, propertyValue);\n+\t} else {\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"Rotation control not available, default to 0 degrees\";\n+\t\trotationTransform_ = Transform::Identity;\n \t}\n \n \tproperties_.set(properties::PixelArraySize, pixelArraySize_);\n@@ -1038,21 +1056,11 @@ void CameraSensor::updateControlInfo()\n */\n Transform CameraSensor::validateTransform(Transform *transform) const\n {\n-\t/* Adjust the requested transform to compensate the sensor mounting rotation. */\n-\tconst ControlInfoMap &controls = subdev_->controls();\n-\tint rotation = 0;\n-\n-\tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n-\tif (rotationControl != controls.end())\n-\t\trotation = rotationControl->second.def().get();\n-\n-\tbool success;\n-\tTransform rotationTransform = transformFromRotation(rotation, &success);\n-\tif (!success)\n-\t\tLOG(CameraSensor, Warning) << \"Invalid rotation of \" << rotation\n-\t\t\t\t\t << \" degrees - ignoring\";\n-\n-\tTransform combined = *transform * rotationTransform;\n+\t/*\n+\t * Combine the requested transform to compensate the sensor mounting\n+\t * rotation.\n+\t */\n+\tTransform combined = *transform * rotationTransform_;\n \n \t/*\n \t * We combine the platform and user transform, but must \"adjust away\"\n@@ -1083,7 +1091,7 @@ Transform CameraSensor::validateTransform(Transform *transform) const\n \t\t * rise to this is the inverse of the rotation. (Recall that\n \t\t * combined = transform * rotationTransform.)\n \t\t */\n-\t\t*transform = -rotationTransform;\n+\t\t*transform = -rotationTransform_;\n \t\tcombined = Transform::Identity;\n \t}\n \n","prefixes":["libcamera-devel","v4","01/10"]}