[{"id":27600,"web_url":"https://patchwork.libcamera.org/comment/27600/","msgid":"","date":"2023-07-24T07:41:17","subject":"Re: [libcamera-devel] [PATCH v1 3/4] pipeline: rpi: Rename\n\tRPi::Stream::setExternalBuffer()","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Fri, Jul 21, 2023 at 10:37:58AM +0100, Naushir Patuck via libcamera-devel wrote:\n> Since we don't distinguish between externally and internally allocated\n> dma bufs, rename this function to setExportedBuffer() to clearer on its\n> function.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 2 +-\n> src/libcamera/pipeline/rpi/common/rpi_stream.cpp | 2 +-\n> src/libcamera/pipeline/rpi/common/rpi_stream.h | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> index f244edc68a85..fc0c0ec3c53c 100644\n> --- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n> @@ -764,7 +764,7 @@ int PipelineHandlerBase::queueRequestDevice(Camera *camera, Request *request)\n> \t\t\t * outside the v4l2 device. Store it in the stream buffer list\n> \t\t\t * so we can track it.\n> \t\t\t */\n> -\t\t\tstream->setExternalBuffer(buffer);\n> +\t\t\tstream->setExportedBuffer(buffer);\n> \t\t}\n>\n> \t\t/*\n> diff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n> index 07b8de6875fe..e24531e171c8 100644\n> --- a/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n> +++ b/src/libcamera/pipeline/rpi/common/rpi_stream.cpp\n> @@ -76,7 +76,7 @@ unsigned int Stream::getBufferId(FrameBuffer *buffer) const\n> \treturn it->first;\n> }\n>\n> -void Stream::setExternalBuffer(FrameBuffer *buffer)\n> +void Stream::setExportedBuffer(FrameBuffer *buffer)\n> {\n> \tbufferMap_.emplace(id_.get(), buffer);\n> }\n> diff --git a/src/libcamera/pipeline/rpi/common/rpi_stream.h b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n> index ca591f99cc45..d1289c4679b9 100644\n> --- a/src/libcamera/pipeline/rpi/common/rpi_stream.h\n> +++ b/src/libcamera/pipeline/rpi/common/rpi_stream.h\n> @@ -76,7 +76,7 @@ public:\n> \tconst BufferMap &getBuffers() const;\n> \tunsigned int getBufferId(FrameBuffer *buffer) const;\n>\n> -\tvoid setExternalBuffer(FrameBuffer *buffer);\n> +\tvoid setExportedBuffer(FrameBuffer *buffer);\n>\n> \tint prepareBuffers(unsigned int count);\n> \tint queueBuffer(FrameBuffer *buffer);\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C8AABDB13\n\tfor ;\n\tMon, 24 Jul 2023 07:41:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98419628C1;\n\tMon, 24 Jul 2023 09:41:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8A99D61E25\n\tfor ;\n\tMon, 24 Jul 2023 09:41:21 +0200 (CEST)","from ideasonboard.com (mob-5-91-20-233.net.vodafone.it\n\t[5.91.20.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 16792735;\n\tMon, 24 Jul 2023 09:40:23 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690184482;\n\tbh=8W1apcAnyl4Y8FT1aHG3+iJksigKtkzIGV1EZYfmy68=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2E1VZWkMs99UEiAKN76jK1HPzERRXlOcIjQuuM8ois/ISB4M/Pm0wKA86+/ibTA4R\n\tTnP2gR2FDl8eWE250mMTjoyeku3uiVk3CObrBxK00uCpEbU0Dx5KZzmIbZyeSq9VQl\n\t6lWrPeNNIacJ6TlaXgzcB/dCZjPmATtyBcF4uHC42XqsnY54numVg15u/FUIb+FExu\n\t2pgTcAeBTxCDXTGNch3Bp342K7bfcXIIlzNJaPhFDlB+FzvgxTYttX730G/dpY/MTo\n\tpXYZY/wR+CIxjuOWvAYjFaFqW5FV8T8AKDcTKh4M5oF01yIV8fvRQIytkjhG/iXYTR\n\tJdaS9LXpv/XJw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690184424;\n\tbh=8W1apcAnyl4Y8FT1aHG3+iJksigKtkzIGV1EZYfmy68=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=f8LJPOSJlZt9HHOYDGm0sQEE89knTaJaPfZdO+FZj8xfKxvS/Mrz7ALCBW/KgVNKv\n\t64dhYxdYYhBOuIzjqnx8afZ6YFUXeRwknNoVk6NfqcxUCs3t9qWpgggHZJ/Aa9cM9T\n\tEzE3eT5ERZSDg2BA1HtkXGQbQYNtx3bGXWlI/50g="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"f8LJPOSJ\"; dkim-atps=neutral","Date":"Mon, 24 Jul 2023 09:41:17 +0200","To":"Naushir Patuck ","Message-ID":"","References":"<20230721093759.27700-1-naush@raspberrypi.com>\n\t<20230721093759.27700-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230721093759.27700-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v1 3/4] pipeline: rpi: Rename\n\tRPi::Stream::setExternalBuffer()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]