[{"id":27608,"web_url":"https://patchwork.libcamera.org/comment/27608/","msgid":"<20230725114326.GF31069@pendragon.ideasonboard.com>","date":"2023-07-25T11:43:26","subject":"Re: [libcamera-devel] [PATCH] README.rst: Report py dependencies","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Jul 21, 2023 at 07:20:56AM +0100, Kieran Bingham via libcamera-devel wrote:\n> The python bindings were supported by a subproject when they were first\n\ns/python/Python/\n\n> contributed to be able to directly make use of the smart pointers\n> branch.\n> \n> This requirement has now been removed to prefer using released versions\n> of pybind11 directly, however the README.rst was not updated to\n> reference and reflect this.\n> \n> Update the README.rst to report the pybind11 package which needs to be\n> installed to make use of the optional python bindings component.\n\nDitto.\n\n> Signed-off-by: Kieran Bingham \n> ---\n> README.rst | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/README.rst b/README.rst\n> index df2818e1f598..18946e4f5ca2 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -101,6 +101,9 @@ for tracing with lttng: [optional]\n> for android: [optional]\n> libexif-dev libjpeg-dev\n> \n> +for python bindings: [optional]\n\nAnd here too.\n\nReviewed-by: Laurent Pinchart \n\n> + pybind11-dev\n> +\n> for lc-compliance: [optional]\n> libevent-dev\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38328BDB13\n\tfor ;\n\tTue, 25 Jul 2023 11:43:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A4B6628C0;\n\tTue, 25 Jul 2023 13:43:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1500B61E26\n\tfor ;\n\tTue, 25 Jul 2023 13:43:19 +0200 (CEST)","from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi\n\t[213.243.189.158])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 85132558;\n\tTue, 25 Jul 2023 13:42:20 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1690285401;\n\tbh=yDbzfqHXaPl/tAby9GXN51J8SRJIJIlIFktiayiC2qU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WpR4o1mE7ReUWrgE+6ORFycJxHzpDaKxaqd24Q8wK5IIHETFsttiLQjiWhNxt5iZV\n\ticTRG2AIuqng1vTcuJ4B3eShqDiC0LsvGl72dUPhokhr7xaWQ7NP5IdPCyTRL8fVty\n\tUAGE2GYk/lIoTIOnMHeqblN8EVzFZd2bvXznNdzDQu/aSJRalOMsXBkjW8RAomqQyi\n\tOWSlzkrpXzb7XPchl9zVmmTJl6KITjOuzXN3t38GDY2tb7KK5YehXQ/6iwp8p4QmTN\n\tWMHTwDiPobkc4O4L4KalD1dQ7HMt7ESoO04E2ViXLRfSmvvS7Z3vHMPkVH3QEJjmQg\n\teztpTTp3pUPpg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1690285340;\n\tbh=yDbzfqHXaPl/tAby9GXN51J8SRJIJIlIFktiayiC2qU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=a3cYAfYlbSUZlXzLlNU28qG5tOfMCT7QW4RegB/NtIuGIkttVmO3jozgPy49OZHyb\n\tlpmYxoxMsoP7aKuu9pTFV5X8raw1PjIDKsWNXV7DwMfgQmkaAmIL8u7KadnioGTcB4\n\tHIz9aNBlQPRxznKIsRNmjqUEE2T3/Uyv+Rqz+H2s="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"a3cYAfYl\"; dkim-atps=neutral","Date":"Tue, 25 Jul 2023 14:43:26 +0300","To":"Kieran Bingham ","Message-ID":"<20230725114326.GF31069@pendragon.ideasonboard.com>","References":"<20230721062056.2915581-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230721062056.2915581-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] README.rst: Report py dependencies","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]