[{"id":27572,"web_url":"https://patchwork.libcamera.org/comment/27572/","msgid":"","date":"2023-07-18T07:26:20","subject":"Re: [libcamera-devel] [libcamera-devel, v2,\n\t1/1] pipeline: simple: Add support for MediaTek MT8365 platforms","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hello Suhrid\n\nOn Mon, Jul 17, 2023 at 04:23:28PM -0700, Suhrid Subramaniam via libcamera-devel wrote:\n> The camera pipeline for MediaTek MT8365 consists of the following:\n> Raw sensor (+ external ISP) --> SENINF --> CAMSV30 --> DRAM\n>\n> SENINF (SENsor INterFace) is a CSI-2 receiver.\n> CAMSV30 (Camera Simple Version) is a DMA Engine which bypasses\n> ISP3.0 and writes directly to DRAM.\n> Both SENINF and CAMSV30 are supported by V4L2 drivers.\n>\n> MT8365 platform consists of a hardware converter called MDP which\n> supports up to three streams.\n\nI presume this is the driver that lives in\ndrivers/media/platform/mediatek/mdp/\n\nwhich is different than the one that lives in\ndrivers/media/platform/mediatek/mdp3/\n\nwhose driver is named in facts \"mtk-mdp3\" ?\n\n>\n> Signed-off-by: Suhrid Subramaniam \n\nThis seems fine to me!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n\n\n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 2 files changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 2a4d1d99..a5fc979b 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -445,6 +445,7 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n> }\n>\n> static std::initializer_list compatibles = {\n> +\t\"mtk-mdp\",\n> \t\"pxp\",\n> };\n>\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 05ba76bc..24835d50 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -193,6 +193,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"dcmipp\", {} },\n> \t{ \"imx7-csi\", { { \"pxp\", 1 } } },\n> \t{ \"j721e-csi2rx\", {} },\n> +\t{ \"mtk-seninf\", { { \"mtk-mdp\", 3 } } },\n> \t{ \"mxc-isi\", {} },\n> \t{ \"qcom-camss\", {} },\n> \t{ \"sun6i-csi\", {} },\n> --\n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C811BDB1C\n\tfor ;\n\tTue, 18 Jul 2023 07:26:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2BD161E2A;\n\tTue, 18 Jul 2023 09:26:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51C3461E2A\n\tfor ;\n\tTue, 18 Jul 2023 09:26:24 +0200 (CEST)","from ideasonboard.com (mob-5-90-54-150.net.vodafone.it\n\t[5.90.54.150])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B20CC2C6;\n\tTue, 18 Jul 2023 09:25:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689665185;\n\tbh=SFci/3jHjy/58H32IMkLHrwxSRdpYbyrr3XrsSX663M=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ar4k8orSMHxzbn21you25JwZ1ysFyo3WObsWlXfzUqLF8H5+GdHYL7G8UFocqRYUW\n\tXZ4EaLENvpagLYA0QWrsH+w4NISAhIt5NJ43Hij6lA7K83nTRFdoowyzIZuDd4sBet\n\t3IH10qwfB5aMxWnKb9Xek785ALh/zBQsMZloSq3PKEBh8+e7rORId0OVE/Wy4IjkQh\n\tc35rrrP0tVfTYeUSgJpZ0/gnFmSjr5gN0Fjmu6QQ39ElUCH2T7d/Td4DC2F1ha5Wm4\n\tkd0CqtidV5+PeI8at9fSBr1dzkdAzf4IsMft/GyjbAJqZDUuPOKC0ztL5MvSHkerFN\n\tQ5hksHf2mmAbg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689665130;\n\tbh=SFci/3jHjy/58H32IMkLHrwxSRdpYbyrr3XrsSX663M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=P9zNlFYlgW5oxZ/mk/5fBwHrqn+Ji4JR8T8P11hXPjKiA7nHYLMasOeXiKjsZ4Y8I\n\truTx+YqGUEaldEwcbIYvGQ4WfU0E+oh6xTTFzQNAttM8aA/jEbKp7jFXCjM/qpPa/d\n\t5tyZs7NRxXWFQKDChnbFI/5W3H5v+62KVcSvd8wo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"P9zNlFYl\"; dkim-atps=neutral","Date":"Tue, 18 Jul 2023 09:26:20 +0200","To":"Suhrid Subramaniam ","Message-ID":"","References":"<20230717232328.98247-1-suhrid.subramaniam@mediatek.com>\n\t<20230717232328.98247-2-suhrid.subramaniam@mediatek.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230717232328.98247-2-suhrid.subramaniam@mediatek.com>","Subject":"Re: [libcamera-devel] [libcamera-devel, v2,\n\t1/1] pipeline: simple: Add support for MediaTek MT8365 platforms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Suhrid Subramaniam ,\n\tlibcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27577,"web_url":"https://patchwork.libcamera.org/comment/27577/","msgid":"<168967044855.265056.3418349665953960805@Monstersaurus>","date":"2023-07-18T08:54:08","subject":"Re: [libcamera-devel] [libcamera-devel, v2,\n\t1/1] pipeline: simple: Add support for MediaTek MT8365 platforms","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Suhrid Subramaniam via libcamera-devel (2023-07-18 00:23:28)\n> The camera pipeline for MediaTek MT8365 consists of the following:\n> Raw sensor (+ external ISP) --> SENINF --> CAMSV30 --> DRAM\n> \n> SENINF (SENsor INterFace) is a CSI-2 receiver.\n> CAMSV30 (Camera Simple Version) is a DMA Engine which bypasses\n> ISP3.0 and writes directly to DRAM.\n> Both SENINF and CAMSV30 are supported by V4L2 drivers.\n> \n> MT8365 platform consists of a hardware converter called MDP which\n> supports up to three streams.\n> \n> Signed-off-by: Suhrid Subramaniam \n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 2 files changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 2a4d1d99..a5fc979b 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -445,6 +445,7 @@ int V4L2M2MConverter::queueBuffers(FrameBuffer *input,\n> }\n> \n> static std::initializer_list compatibles = {\n> + \"mtk-mdp\",\n\nThis addresses my comment from the previous version so:\n\nReviewed-by: Kieran Bingham \n\nAnd I believe this is still fine to go in, but I'm weary about testing.\n\nHave you been able to run cam or another libcamera application and make\nuse of the convertor for multiple streams?\n\nWhat testing have you performed on the platform with the simple pipeline\nhandler?\n\n--\nKieran\n\n\n> \"pxp\",\n> };\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 05ba76bc..24835d50 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -193,6 +193,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n> { \"dcmipp\", {} },\n> { \"imx7-csi\", { { \"pxp\", 1 } } },\n> { \"j721e-csi2rx\", {} },\n> + { \"mtk-seninf\", { { \"mtk-mdp\", 3 } } },\n> { \"mxc-isi\", {} },\n> { \"qcom-camss\", {} },\n> { \"sun6i-csi\", {} },\n> -- \n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BA39BDB1C\n\tfor ;\n\tTue, 18 Jul 2023 08:54:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B407D628BC;\n\tTue, 18 Jul 2023 10:54:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21DE661E2A\n\tfor ;\n\tTue, 18 Jul 2023 10:54:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 85014838;\n\tTue, 18 Jul 2023 10:53:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689670452;\n\tbh=K/yWzfymzIZbPAb2Hu4KroxZ1Fvjlv7LTV0nHHKZ12w=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=t031cRefY260HdZrhlG1QsIjhZ1ilIKSQZpDf3385L4wk9mQYpiV3OUVhtGQPDe1Y\n\t1rHfCvAEF5nOdDTNbL4o3IRtv0Scvp7pEcC1npItOPE9FivxMDLaJhG39a+0c5d+bF\n\tFwpzVHYES0TuRHt9H/+gm9K6/0EywnysfmkMcatZhy79AraSrP8qkBjuP8W7baJwoS\n\tI6zsccpnAhQGBUZ7m9HJ3YFjbjpwNlPjcpcqnavflCpwyO3ExI+tRk3Hqx6pn3/KC4\n\tnWhGHmhP74wObVSjJcSgDV8PXLUDUWfEQlK/tw3TRa1irhFI06jhkqTUG2Spjl7pdv\n\tYqYb160RJ7smg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689670397;\n\tbh=K/yWzfymzIZbPAb2Hu4KroxZ1Fvjlv7LTV0nHHKZ12w=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=OQdCARPhKyHPYFo/IZSl3g5Y/qQbzn0LxIYJDjQgksRfB+e470Pc39pyr3RMl454N\n\tRohw6U4ki/aClPsjOg9e6ebYP3T6CjuFq+lU/S6GsQIBGND074ueFp+lyIuA0knQ9g\n\tAJQOvcreMddj/suspUraRCVsJCGU+Hclsvze/HAs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"OQdCARPh\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20230717232328.98247-2-suhrid.subramaniam@mediatek.com>","References":"<20230717232328.98247-1-suhrid.subramaniam@mediatek.com>\n\t<20230717232328.98247-2-suhrid.subramaniam@mediatek.com>","To":"Suhrid Subramaniam ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 18 Jul 2023 09:54:08 +0100","Message-ID":"<168967044855.265056.3418349665953960805@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [libcamera-devel, v2,\n\t1/1] pipeline: simple: Add support for MediaTek MT8365 platforms","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Suhrid Subramaniam ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]