[{"id":2564,"web_url":"https://patchwork.libcamera.org/comment/2564/","msgid":"<20190830121720.GN8479@bigcity.dyn.berto.se>","date":"2019-08-30T12:17:20","subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: camera_device: Use\n\tcorrect sizes for static metadata","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2019-08-29 18:53:09 +0200, Jacopo Mondi wrote:\n> Use more opportune sizes for the static metadata pack, and for the\n> dynamic metadata sizes which where wrongly set to use the ones defined\n> for the static pack.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.cpp | 20 ++++++++++----------\n> 1 file changed, 10 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 02bb6fc5d042..bc8ffed92c61 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -128,11 +128,11 @@ camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t * more.\n> \t */\n> \n> -\t/* \\todo Use correct sizes */\n> -\t#define STATIC_ENTRY_CAP 256\n> -\t#define STATIC_DATA_CAP 6688\n> -\tstaticMetadata_ = allocate_camera_metadata(STATIC_ENTRY_CAP,\n> -\t\t\t\t\t\t STATIC_DATA_CAP);\n> +\t/*\n> +\t * \\todo Keep this in sync with the actual number of entries.\n> +\t * Currently: 46 entries, 390 bytes\n> +\t */\n> +\tstaticMetadata_ = allocate_camera_metadata(50, 500);\n\nWhere do the values 50 and 500 come from, is it simply 50 > 46 and 500 > \n390 ?\n\n> \n> \t/* Color correction static metadata. */\n> \tstd::vector aberrationModes = {\n> @@ -966,11 +966,11 @@ camera_metadata_t *CameraDevice::getResultMetadata(int frame_number,\n> {\n> \tint ret;\n> \n> -\t/* \\todo Use correct sizes */\n> -\t#define RESULT_ENTRY_CAP 256\n> -\t#define RESULT_DATA_CAP 6688\n> -\tcamera_metadata_t *resultMetadata =\n> -\t\tallocate_camera_metadata(STATIC_ENTRY_CAP, STATIC_DATA_CAP);\n> +\t/*\n> +\t * \\todo Keep this in sync with the actual number of entries.\n> +\t * Currently: 13 entries, 36 bytes\n> +\t */\n> +\tcamera_metadata_t *resultMetadata = allocate_camera_metadata(15, 50);\n> \n> \tconst uint8_t ae_state = ANDROID_CONTROL_AE_STATE_CONVERGED;\n> \tret = add_camera_metadata_entry(resultMetadata, ANDROID_CONTROL_AE_STATE,\n> -- \n> 2.23.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 000A360BCF\n\tfor ;\n\tFri, 30 Aug 2019 14:17:21 +0200 (CEST)","by mail-lf1-x143.google.com with SMTP id z21so5218237lfe.1\n\tfor ;\n\tFri, 30 Aug 2019 05:17:21 -0700 (PDT)","from localhost (h-177-236.A463.priv.bahnhof.se. [217.31.177.236])\n\tby smtp.gmail.com with ESMTPSA id\n\tz18sm943177ljc.45.2019.08.30.05.17.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 30 Aug 2019 05:17:20 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=YP1dimNnswlOUVAkSzufpeyd+0yvb8ZKW40FZgBjGYg=;\n\tb=WzN/99jOB5ch2G2iYzclhL5igjuQqbNWzcYGsTI/jeLzw6p6e49h75Elbbzje/QC3z\n\tsL9Aiu2RqSuvLmjfAcQIPnqO3EmsvytxoHEb55JIPl4nX3poZ9e+2qKAYcT9HJHOH3Hs\n\tDljifa95oIHV6KKWed9HtjLQQXBA9guRYC0KZfxB5scHU8iCkkXXWIg9z1ef0BACwpil\n\t8LKhN2Ibu28qQxytVxrgzU+UYximHQ7WyZ1rIWIlzkqevQUqXZ6+44F6y0vnyfT4mjaO\n\taK+o+3l+ciAgzx20aDkg5aT3gpzvMFvtiJkrsVPQ/LyAr+IDaPqHDS1tNxnp6oVlZcGE\n\tFi0A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=YP1dimNnswlOUVAkSzufpeyd+0yvb8ZKW40FZgBjGYg=;\n\tb=kfDX14rSv0tjFf34Q2wdaMHenRqmQGsgoMmi75bJ7p2I9IsSl4fHswf4FuaW6ROkpB\n\tw0nd3Tj848YdLeKxCgPL3BF7xwSOWzuqViHSmBX43kQZUJ0nC0GLGU6z+P9nP3Peyfx1\n\t1E0Ypfts5A4/gsh14p9Bm8oj+a5maoejACkW1cL4SoYUS/FQNCpoaP6f1/uyNWkR1iPF\n\thEKCKfHbJaLTePFIzeh2Q7BMuJm378jBfWkYuqRGdqxQkNPwja6clBJep7L48dlG008p\n\tTQKhOzgV3QREJrU2CgypMC6cR4j3P4ZIiFRwtlXQfiTAcCsueeWb9pNuJ8zFb4dXoFzk\n\tjopg==","X-Gm-Message-State":"APjAAAXihs/yqczouMpcY2YUKHkmyfbOmXdOQdrjTaqNoLsY4TOovLa1\n\tiwY6uolSnq64YqrWcd01cOPBelDrV5k=","X-Google-Smtp-Source":"APXvYqxoF8oLyJh38af8ioL7oR3EU2COoxq6gaDu2rTi81T3MRPyN20tqL8QI+8rvgRXTb1cjMGgHw==","X-Received":"by 2002:ac2:51b0:: with SMTP id\n\tf16mr9358906lfk.103.1567167441255; \n\tFri, 30 Aug 2019 05:17:21 -0700 (PDT)","Date":"Fri, 30 Aug 2019 14:17:20 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190830121720.GN8479@bigcity.dyn.berto.se>","References":"<20190829165311.29196-1-jacopo@jmondi.org>\n\t<20190829165311.29196-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190829165311.29196-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: camera_device: Use\n\tcorrect sizes for static metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 30 Aug 2019 12:17:22 -0000"}},{"id":2566,"web_url":"https://patchwork.libcamera.org/comment/2566/","msgid":"<20190830131000.qxe5bdyezquj4rhu@uno.localdomain>","date":"2019-08-30T13:10:00","subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: camera_device: Use\n\tcorrect sizes for static metadata","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Aug 30, 2019 at 02:17:20PM +0200, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2019-08-29 18:53:09 +0200, Jacopo Mondi wrote:\n> > Use more opportune sizes for the static metadata pack, and for the\n> > dynamic metadata sizes which where wrongly set to use the ones defined\n> > for the static pack.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera_device.cpp | 20 ++++++++++----------\n> > 1 file changed, 10 insertions(+), 10 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 02bb6fc5d042..bc8ffed92c61 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -128,11 +128,11 @@ camera_metadata_t *CameraDevice::getStaticMetadata()\n> > \t * more.\n> > \t */\n> >\n> > -\t/* \\todo Use correct sizes */\n> > -\t#define STATIC_ENTRY_CAP 256\n> > -\t#define STATIC_DATA_CAP 6688\n> > -\tstaticMetadata_ = allocate_camera_metadata(STATIC_ENTRY_CAP,\n> > -\t\t\t\t\t\t STATIC_DATA_CAP);\n> > +\t/*\n> > +\t * \\todo Keep this in sync with the actual number of entries.\n> > +\t * Currently: 46 entries, 390 bytes\n> > +\t */\n> > +\tstaticMetadata_ = allocate_camera_metadata(50, 500);\n>\n> Where do the values 50 and 500 come from, is it simply 50 > 46 and 500 >\n> 390 ?\n>\n\nYes, I calculated the metadata pack occupation by hand, and I\nconsidered staying a bit larger a safety measure against my\nmis-calculations :)\n\n> >\n> > \t/* Color correction static metadata. */\n> > \tstd::vector aberrationModes = {\n> > @@ -966,11 +966,11 @@ camera_metadata_t *CameraDevice::getResultMetadata(int frame_number,\n> > {\n> > \tint ret;\n> >\n> > -\t/* \\todo Use correct sizes */\n> > -\t#define RESULT_ENTRY_CAP 256\n> > -\t#define RESULT_DATA_CAP 6688\n> > -\tcamera_metadata_t *resultMetadata =\n> > -\t\tallocate_camera_metadata(STATIC_ENTRY_CAP, STATIC_DATA_CAP);\n> > +\t/*\n> > +\t * \\todo Keep this in sync with the actual number of entries.\n> > +\t * Currently: 13 entries, 36 bytes\n> > +\t */\n> > +\tcamera_metadata_t *resultMetadata = allocate_camera_metadata(15, 50);\n> >\n> > \tconst uint8_t ae_state = ANDROID_CONTROL_AE_STATE_CONVERGED;\n> > \tret = add_camera_metadata_entry(resultMetadata, ANDROID_CONTROL_AE_STATE,\n> > --\n> > 2.23.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","Received":["from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3127360BCF\n\tfor ;\n\tFri, 30 Aug 2019 15:08:34 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 4B8DD1BF209;\n\tFri, 30 Aug 2019 13:08:33 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 30 Aug 2019 15:10:00 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190830131000.qxe5bdyezquj4rhu@uno.localdomain>","References":"<20190829165311.29196-1-jacopo@jmondi.org>\n\t<20190829165311.29196-3-jacopo@jmondi.org>\n\t<20190830121720.GN8479@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"7csusvaeiunqbtfa\"","Content-Disposition":"inline","In-Reply-To":"<20190830121720.GN8479@bigcity.dyn.berto.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: camera_device: Use\n\tcorrect sizes for static metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 30 Aug 2019 13:08:34 -0000"}},{"id":2579,"web_url":"https://patchwork.libcamera.org/comment/2579/","msgid":"<20190903202533.GH4788@pendragon.ideasonboard.com>","date":"2019-09-03T20:25:33","subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: camera_device: Use\n\tcorrect sizes for static metadata","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Aug 29, 2019 at 06:53:09PM +0200, Jacopo Mondi wrote:\n> Use more opportune sizes for the static metadata pack, and for the\n> dynamic metadata sizes which where wrongly set to use the ones defined\n> for the static pack.\n> \n> Signed-off-by: Jacopo Mondi \n\nAcked-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 20 ++++++++++----------\n> 1 file changed, 10 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 02bb6fc5d042..bc8ffed92c61 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -128,11 +128,11 @@ camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t * more.\n> \t */\n> \n> -\t/* \\todo Use correct sizes */\n> -\t#define STATIC_ENTRY_CAP 256\n> -\t#define STATIC_DATA_CAP 6688\n> -\tstaticMetadata_ = allocate_camera_metadata(STATIC_ENTRY_CAP,\n> -\t\t\t\t\t\t STATIC_DATA_CAP);\n> +\t/*\n> +\t * \\todo Keep this in sync with the actual number of entries.\n> +\t * Currently: 46 entries, 390 bytes\n> +\t */\n> +\tstaticMetadata_ = allocate_camera_metadata(50, 500);\n> \n> \t/* Color correction static metadata. */\n> \tstd::vector aberrationModes = {\n> @@ -966,11 +966,11 @@ camera_metadata_t *CameraDevice::getResultMetadata(int frame_number,\n> {\n> \tint ret;\n> \n> -\t/* \\todo Use correct sizes */\n> -\t#define RESULT_ENTRY_CAP 256\n> -\t#define RESULT_DATA_CAP 6688\n> -\tcamera_metadata_t *resultMetadata =\n> -\t\tallocate_camera_metadata(STATIC_ENTRY_CAP, STATIC_DATA_CAP);\n> +\t/*\n> +\t * \\todo Keep this in sync with the actual number of entries.\n> +\t * Currently: 13 entries, 36 bytes\n> +\t */\n> +\tcamera_metadata_t *resultMetadata = allocate_camera_metadata(15, 50);\n> \n> \tconst uint8_t ae_state = ANDROID_CONTROL_AE_STATE_CONVERGED;\n> \tret = add_camera_metadata_entry(resultMetadata, ANDROID_CONTROL_AE_STATE,","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3529460BCF\n\tfor ;\n\tTue, 3 Sep 2019 22:25:45 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-18-41-nat.elisa-mobile.fi\n\t[85.76.18.41])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB894542;\n\tTue, 3 Sep 2019 22:25:41 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567542344;\n\tbh=K6X3GaW5qA3F0uzt1wEzcY5VjJyAj8FKe5FNM/vlAxY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NAgj/Iswd3CM1X3o1/8RauHX71iWZEQXcVibYFcqmAbBR7Kt8/qDuYHf/ExrbN8oU\n\tSFGBfHX34LROt7RYa+OVMIHHRULI0M2uK+mwMpt4vZbbSG0U1xII1uJcDdSrEVL56H\n\toLYSsuyPEyT6sFrXbx0xiiUWXjAkhHbQqa4RGbL4=","Date":"Tue, 3 Sep 2019 23:25:33 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, jcliang@google.com, wtlee@google.com","Message-ID":"<20190903202533.GH4788@pendragon.ideasonboard.com>","References":"<20190829165311.29196-1-jacopo@jmondi.org>\n\t<20190829165311.29196-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190829165311.29196-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v2 2/4] android: camera_device: Use\n\tcorrect sizes for static metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 03 Sep 2019 20:25:45 -0000"}}]