[{"id":2536,"web_url":"https://patchwork.libcamera.org/comment/2536/","msgid":"<20190829090856.grhwsyssv3fsjpwc@uno.localdomain>","date":"2019-08-29T09:08:56","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Fix error\n\tmessages in setControls()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n ups, thanks for fixing this\n\nOn Thu, Aug 29, 2019 at 10:09:19AM +0200, Niklas Söderlund wrote:\n> The error messages looks copied from getControls() without being updated\n> for the set controls case, fix this.\n>\n> Signed-off-by: Niklas Söderlund \n\nAcked-by: Jacopo Mondi \n\nThanks\n j\n> ---\n> src/libcamera/v4l2_device.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index f89546610ac69ba0..349bf2d2970418e4 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -287,13 +287,13 @@ int V4L2Device::setControls(V4L2ControlList *ctrls)\n>\n> \t\t/* Generic validation error. */\n> \t\tif (errorIdx == 0 || errorIdx >= count) {\n> -\t\t\tLOG(V4L2, Error) << \"Unable to read controls: \"\n> +\t\t\tLOG(V4L2, Error) << \"Unable to set controls: \"\n> \t\t\t\t\t << strerror(ret);\n> \t\t\treturn -EINVAL;\n> \t\t}\n>\n> \t\t/* A specific control failed. */\n> -\t\tLOG(V4L2, Error) << \"Unable to read control \" << errorIdx\n> +\t\tLOG(V4L2, Error) << \"Unable to set control \" << errorIdx\n> \t\t\t\t << \": \" << strerror(ret);\n> \t\tcount = errorIdx - 1;\n> \t\tret = errorIdx;\n> --\n> 2.22.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D3AD60BCF\n\tfor ;\n\tThu, 29 Aug 2019 11:07:24 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id CE81320002;\n\tThu, 29 Aug 2019 09:07:23 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Thu, 29 Aug 2019 11:08:56 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190829090856.grhwsyssv3fsjpwc@uno.localdomain>","References":"<20190829080919.16396-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"guvgbj3h3yv54p2g\"","Content-Disposition":"inline","In-Reply-To":"<20190829080919.16396-1-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Fix error\n\tmessages in setControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 09:07:24 -0000"}},{"id":2540,"web_url":"https://patchwork.libcamera.org/comment/2540/","msgid":"","date":"2019-08-29T09:48:07","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Fix error\n\tmessages in setControls()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 29/08/2019 09:09, Niklas Söderlund wrote:\n> The error messages looks copied from getControls() without being updated\n> for the set controls case, fix this.\n\nIndeed, I'd even say they /are/ copied :-D\n\n> \n> Signed-off-by: Niklas Söderlund \n\nThanks for the fix.\n\nPerhaps a:\n\nFixes: eb068f4e67ee (\"libcamera: v4l2_device: Implement get and set\ncontrols\")\n\nbut that's not essential.\n\nReviewed-by: Kieran Bingham \n\n\n> ---\n> src/libcamera/v4l2_device.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index f89546610ac69ba0..349bf2d2970418e4 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -287,13 +287,13 @@ int V4L2Device::setControls(V4L2ControlList *ctrls)\n> \n> \t\t/* Generic validation error. */\n> \t\tif (errorIdx == 0 || errorIdx >= count) {\n> -\t\t\tLOG(V4L2, Error) << \"Unable to read controls: \"\n> +\t\t\tLOG(V4L2, Error) << \"Unable to set controls: \"\n> \t\t\t\t\t << strerror(ret);\n> \t\t\treturn -EINVAL;\n> \t\t}\n> \n> \t\t/* A specific control failed. */\n> -\t\tLOG(V4L2, Error) << \"Unable to read control \" << errorIdx\n> +\t\tLOG(V4L2, Error) << \"Unable to set control \" << errorIdx\n> \t\t\t\t << \": \" << strerror(ret);\n> \t\tcount = errorIdx - 1;\n> \t\tret = errorIdx;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2299B60BCF\n\tfor ;\n\tThu, 29 Aug 2019 11:48:11 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 890382E5;\n\tThu, 29 Aug 2019 11:48:10 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1567072090;\n\tbh=vGaWzRRRFurHs2cPQzp9gnMia9WxCcMVqwq/UVOveIs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=nmS6feiILAG+rMalf2Z3HxrP2PBLkkIaFKErFaUBm1rUgrpTINdjxAbjU2T/gUXot\n\tq68ayQaHRfNTqruXxTyDvcPGEC6G0s0oheQHg3WMaGfU+7CVgdkjl+eUauYExD7lKJ\n\tf+l1xIU0YMbbqyf/QhzhWxXM6M2x1P4gpmokNBfA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20190829080919.16396-1-niklas.soderlund@ragnatech.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCJQQYAQoADwIbDAUCWcOUawUJ\n\tB4D+AgAKCRChHkZyEKRh/XJhEACr5iidt/0MZ0rWRMCbZFMWD7D2g6nZeOp+F2zY8CEUW+sd\n\tCDVd9BH9QX9KN5SZo6YtJzMzSzpcx45VwTvtQW0n/6Eujg9EUqblfU9xqvqDmbjEapr5d/OL\n\t21GTALb0owKhA5qDUGEcKGCphpQffKhTNo/BP99jvmJUj7IPSKH97qPypi8/ym8bAxB+uY31\n\tgHTMHf1jMJJ1pRo2tYYPeIIHGDqXBI4sp5GHHF+JcIhgR/e/A6w/dgzHYmQPl2ix5eZYEZbV\n\tTRP+gkX4NV8oHqa/lR+xPOlWElGB57viOSOoWriqxQbFy8XbG1GR8cWlkNtGBGVWaJaSoORP\n\tiowD7irXL91bCyFIqL+7BVk3Jy4uzP744PzE80KwxOp5SQAp9sPzFbgsJrLev90PZySjFHG0\n\twP144DK7nBjOj/J0g9OHVASP1JjK+nw7SDoKnETDIdRC0XmiHXk7TXzPdkvO0UkpHdEPjZUp\n\tWyuc0MqehjR/hTTPt4m/Y14XzEcy6JREIjOrFfUZVho2QpOdv9CNryGdieRTNjUtz463CIaZ\n\tdPBiw9mOMBoNffkn9FIoCjLnAaj9gUAnEHWBZOEviQ5NuyqpeP0YtzI4iaRbSUkYZHej99X3\n\tVmHrdLlMqd/ZgYYbPGSL4AN3FVACb5CxuxEHwo029VcE5U3CSjzqtCoX12tm7A==","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 29 Aug 2019 10:48:07 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20190829080919.16396-1-niklas.soderlund@ragnatech.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Fix error\n\tmessages in setControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 09:48:11 -0000"}},{"id":2549,"web_url":"https://patchwork.libcamera.org/comment/2549/","msgid":"<20190829151949.GB28351@bigcity.dyn.berto.se>","date":"2019-08-29T15:19:49","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Fix error\n\tmessages in setControls()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nI have now pushed this patch with Jacopo's and Kieran's tags.\n\nOn 2019-08-29 10:09:19 +0200, Niklas Söderlund wrote:\n> The error messages looks copied from getControls() without being updated\n> for the set controls case, fix this.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/v4l2_device.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index f89546610ac69ba0..349bf2d2970418e4 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -287,13 +287,13 @@ int V4L2Device::setControls(V4L2ControlList *ctrls)\n> \n> \t\t/* Generic validation error. */\n> \t\tif (errorIdx == 0 || errorIdx >= count) {\n> -\t\t\tLOG(V4L2, Error) << \"Unable to read controls: \"\n> +\t\t\tLOG(V4L2, Error) << \"Unable to set controls: \"\n> \t\t\t\t\t << strerror(ret);\n> \t\t\treturn -EINVAL;\n> \t\t}\n> \n> \t\t/* A specific control failed. */\n> -\t\tLOG(V4L2, Error) << \"Unable to read control \" << errorIdx\n> +\t\tLOG(V4L2, Error) << \"Unable to set control \" << errorIdx\n> \t\t\t\t << \": \" << strerror(ret);\n> \t\tcount = errorIdx - 1;\n> \t\tret = errorIdx;\n> -- \n> 2.22.1\n>","headers":{"Return-Path":"","Received":["from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E70A60BE5\n\tfor ;\n\tThu, 29 Aug 2019 17:19:51 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id l1so3391774lji.12\n\tfor ;\n\tThu, 29 Aug 2019 08:19:51 -0700 (PDT)","from localhost (h-177-236.A463.priv.bahnhof.se. [217.31.177.236])\n\tby smtp.gmail.com with ESMTPSA id\n\ty8sm393985ljn.65.2019.08.29.08.19.49\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 29 Aug 2019 08:19:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=QeoqXIpjN8q2Xzo4H2utauksnTdeEOOVM4u8UY79HGQ=;\n\tb=cnVGMEydw26N6+bicG6/r17kDZTes9/4yT3dvNOGVX8NNLHIAKwlB9Af767IhYpzTW\n\tOK4AoCbFPjy1BkKwDDdRL0SKzU1Bisu33ZSf8DXCdsNV5ieuXuQx84O6Zh2lsrndZmkS\n\tP0BHoDyBu5EQ2yVWjwzM9BmxBMgZow2k0U0/WVzk3npLY/Jsd6wa4AdQiZGIsW2zS8MH\n\tsxJL8mQ3RToqGEwVU+L29Hqq1EW9DfS9tNMMS3zISIPVOJgEbpUTI/YqEE35diVpB2Ki\n\tidPdtamyCdgpW9k1lBkSgJhhgnJqYcL+jzoKtPCscJmhfBJAFQsGN6wZP+kDguCNcpYC\n\tcVGA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=QeoqXIpjN8q2Xzo4H2utauksnTdeEOOVM4u8UY79HGQ=;\n\tb=UM8UD0WMCjVGbTwfCz1SGzUJ47NkEdVbzTRp9qfkYNRyHejPDSfgwQ5tepNXPFyqdg\n\tgNAYkLJWLuxG8IsorH6hDQOd45yc0NhlNKO7HTlu6O1LnWBdbciBVozk5u6dDtdzOphc\n\tWUNs/c9rFsYx50oPWC5CjWhwRrVpSDXo58x5RXWd/7SF7HtKtma0YkNb8/sKjf9/aV44\n\t6qkEYwOA40kFdw3J8VPh4vRTlbgu++TqAljDb15q6fRnjpOy1ODEJ+o0RFmE42cT4oNb\n\tkd2caU827VFtAW2CLw+x0aR9Gkw7QgWNKki+PSwYyB76JK7/Po2tcbm1j/FPUkhMaUvz\n\tJ6Mw==","X-Gm-Message-State":"APjAAAWHCMx18REpeWclcDGBPXC4XXapmhZXXrMxLXNjpU+Dya9sa86B\n\tAAmtCarrzLF711MYLhXOyzVBnrlPAb8=","X-Google-Smtp-Source":"APXvYqwLxXCwodwSFGaCQvQncc4BT/S15b2oeBo/cV7OML/JGIYrZHW6A7b3Nv10tYRW0ptMSqz6Dg==","X-Received":"by 2002:a2e:988c:: with SMTP id b12mr437295ljj.212.1567091990565;\n\tThu, 29 Aug 2019 08:19:50 -0700 (PDT)","Date":"Thu, 29 Aug 2019 17:19:49 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190829151949.GB28351@bigcity.dyn.berto.se>","References":"<20190829080919.16396-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190829080919.16396-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Fix error\n\tmessages in setControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 29 Aug 2019 15:19:51 -0000"}}]