[{"id":27536,"web_url":"https://patchwork.libcamera.org/comment/27536/","msgid":"","date":"2023-07-11T13:49:00","subject":"Re: [libcamera-devel] [PATCH 2/4] utils: checkstyle.py: Initialise\n\tstaged trailers","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Kieran\n\nThank you  for the patch.\n\nOn 7/11/23 7:09 PM, Kieran Bingham via libcamera-devel wrote:\n> There are no possible Trailers for staged changes as the commit message\n> has not yet been written.\n>\n> Initialise the empty trailers when the commit object is initialised.\n>\n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Umang Jain \n\n> ---\n> utils/checkstyle.py | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 5a1268064d31..2ba3165b8ecd 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -253,6 +253,9 @@ class StagedChanges(Commit):\n> def __init__(self):\n> Commit.__init__(self, '')\n> \n> + # There are no trailers to parse on a Staged Change.\n> + self._trailers = []\n> +\n> def _parse(self):\n> ret = subprocess.run(['git', 'diff', '--staged', '--name-status'],\n> stdout=subprocess.PIPE).stdout.decode('utf-8')","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12B52BDC71\n\tfor ;\n\tTue, 11 Jul 2023 13:49:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3BD6628C0;\n\tTue, 11 Jul 2023 15:49:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 415E460570\n\tfor ;\n\tTue, 11 Jul 2023 15:49:04 +0200 (CEST)","from [192.168.1.108] (unknown [103.251.226.37])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23F388CC;\n\tTue, 11 Jul 2023 15:48:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689083345;\n\tbh=+d3MRJXnRmaW/bkO64Boo0KYMGKDeO53waN0Qg2eeis=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=4ZLtUeHI4YUfKDhG0KqU47DOT1j2y8AAIFw9ntuh/MreWq7C84zy2vVDee6cDdOgb\n\tjWeWWbaMG2d/prFhJp8uyxPt+ksQgn6B4OD+Eo4ZIvkH+wAUBx6pswg0lprgjM2mMQ\n\tzaK7G17PejEeYss6oSL9kVxB3RmuNBB30Hr+K3Nn2Zc08Clbz9wWvtG9cCYw5ibmZa\n\tvqnnwJvnjOY3Owpq7ZcOz8KygvsGb9AaQwb9lnLFibHer4giiDqlzLLAdyJH2ulSVn\n\tVE9T0HH/elTBfWIlFjJAhVFskU0DmUK4JLSO7xnETBLzcI9fzxVrZ9p83aGV+wfpK1\n\t4NyuNsKWxV2lQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689083295;\n\tbh=+d3MRJXnRmaW/bkO64Boo0KYMGKDeO53waN0Qg2eeis=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=NhKCc19N0fV3Z913e4E+0XTRC4MSz5GedDcH69ItrH+P327Kwjz1GTTsbZsQxdmAT\n\tx/lCiAhAg5ecoCjSKWx+rYeApXK55cOiLeKPIeGn2CtbAVpkQ0t+V95gLCZocIOLnX\n\t9ZwM7DiIOZ9w618MBYbe7wGVnrziY/WxhXerK6qE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"NhKCc19N\"; dkim-atps=neutral","Message-ID":"","Date":"Tue, 11 Jul 2023 19:19:00 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.7.1","Content-Language":"en-US","To":"Kieran Bingham ,\n\tlibcamera devel ","References":"<20230711133915.650485-1-kieran.bingham@ideasonboard.com>\n\t<20230711133915.650485-3-kieran.bingham@ideasonboard.com>","In-Reply-To":"<20230711133915.650485-3-kieran.bingham@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH 2/4] utils: checkstyle.py: Initialise\n\tstaged trailers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]