[{"id":27517,"web_url":"https://patchwork.libcamera.org/comment/27517/","msgid":"<168899508298.3585053.9651925006212798297@Monstersaurus>","date":"2023-07-10T13:18:02","subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2023-07-10 14:13:56)\n> The following changes since commit 7802471a3badb561f1e017c3ecdafc95a0a43d61:\n> \n> pipeline: rpi: Account for Bayer packing when validating format\n> (2023-07-07 11:39:34 +0300)\n> \n> are available in the Git repository at:\n> \n> https://github.com/naushir/libcamera.git\n> \n> for you to fetch changes up to e3ecd71894399b26e80d26b29078c82e6bfc5c63:\n> \n> ipa: rpi: imx296_mono: Disable all colour shading (2023-07-10 14:10:11 +0100)\n> \n> ----------------------------------------------------------------\n> Naushir Patuck (2):\n> ipa: rpi: imx708: Fix mode switch drop frame count\n\nclang++-11 -Isrc/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p -Isrc/ipa/rpi/cam_helper -I../../../src/libcamera/src/ipa/rpi/cam_helper -Isrc/ipa/rpi -I../../../src/libcamera/src/ipa/rpi -Iinclude -I../../../src/libcamera/include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -MF src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o.d -o src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -c ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp:62:15: error: 'hideFramesStartup' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]\n unsigned int hideFramesStartup() const;\n ^\n../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper.h:98:23: note: overridden virtual function is here\n virtual unsigned int hideFramesStartup() const;\n ^\n1 error generated.\n\nMeans I can't do a direct git pull on this.\n\nI'll fix up and merge.\n\n--\nRegards\n\nKieran\n\n\n> ipa: rpi: imx296_mono: Disable all colour shading\n> \n> src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 25 ++++++++++++++++++++++++-\n> src/ipa/rpi/vc4/data/imx296_mono.json | 48\n> ++++++++++++++++++++++++------------------------\n> 2 files changed, 48 insertions(+), 25 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD681BDC71\n\tfor ;\n\tMon, 10 Jul 2023 13:18:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E725628C1;\n\tMon, 10 Jul 2023 15:18:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1089C60384\n\tfor ;\n\tMon, 10 Jul 2023 15:18:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C16F1BEB;\n\tMon, 10 Jul 2023 15:17:17 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688995087;\n\tbh=WhQUkpllW5UHw1IURFnOelA7HhqSzWU3+kqkf0ifNQg=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=mYf42n3/94FxTuBCUuoqdtarZIXSLEQv/oSo86Li7u1C+vAkFCsQXhW2NIsLOPBq2\n\tmUhvGCa8WW8fg6uC5KEjg5925ZNpX6KqQc6A5GbkO4sFR85HezsqIxOgcEjQ2OUcaY\n\tatTVMEFzSTEMraUlFx5sUvFT2Zf8kKN61HwFLhhNGoW6yyJURnJoQ7ojcWflEw5Kzw\n\tkYhTIIElxeTglxqsHUOBJkRwOE+jlv9GniOZ2SP90snrLowg4SN9twDXfPaw8cTcQ+\n\tkVGo86dc7+8H35223PTbIUWPH3VYzdU1X1/qX/D29KlMn+MLYWhRpES47YtcP/696m\n\tJR95To6IQL1Ig==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688995037;\n\tbh=WhQUkpllW5UHw1IURFnOelA7HhqSzWU3+kqkf0ifNQg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=gN8Bdi9H2xco/Cu65DKUBSXD05DxIAVXqnaUbUtjlsHhVv8Qgcxc7rEwL/B7a+xNl\n\tDcSIl47kTUXTwFw5iwRtBC+XMUQqFpV4+/ru9brDoWk4/50BNsFtT5TgSd0GIxSzwE\n\t+hHaxhvmJ65mBmDyf2OTbVegNpJx0L9WOEk2toZ4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gN8Bdi9H\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"","To":"Naushir Patuck ,\n\tlibcamera devel ","Date":"Mon, 10 Jul 2023 14:18:02 +0100","Message-ID":"<168899508298.3585053.9651925006212798297@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27518,"web_url":"https://patchwork.libcamera.org/comment/27518/","msgid":"","date":"2023-07-10T13:19:04","subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Mon, 10 Jul 2023 at 14:18, Kieran Bingham\n wrote:\n>\n> Quoting Naushir Patuck (2023-07-10 14:13:56)\n> > The following changes since commit 7802471a3badb561f1e017c3ecdafc95a0a43d61:\n> >\n> > pipeline: rpi: Account for Bayer packing when validating format\n> > (2023-07-07 11:39:34 +0300)\n> >\n> > are available in the Git repository at:\n> >\n> > https://github.com/naushir/libcamera.git\n> >\n> > for you to fetch changes up to e3ecd71894399b26e80d26b29078c82e6bfc5c63:\n> >\n> > ipa: rpi: imx296_mono: Disable all colour shading (2023-07-10 14:10:11 +0100)\n> >\n> > ----------------------------------------------------------------\n> > Naushir Patuck (2):\n> > ipa: rpi: imx708: Fix mode switch drop frame count\n>\n> clang++-11 -Isrc/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p -Isrc/ipa/rpi/cam_helper -I../../../src/libcamera/src/ipa/rpi/cam_helper -Isrc/ipa/rpi -I../../../src/libcamera/src/ipa/rpi -Iinclude -I../../../src/libcamera/include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -MF src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o.d -o src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -c ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp:62:15: error: 'hideFramesStartup' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]\n> unsigned int hideFramesStartup() const;\n> ^\n> ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper.h:98:23: note: overridden virtual function is here\n> virtual unsigned int hideFramesStartup() const;\n> ^\n> 1 error generated.\n>\n> Means I can't do a direct git pull on this.\n>\n> I'll fix up and merge.\n\nArgh, you did warn me about this as well :(\nThanks for fixing it!\n\nNaush\n\n\n>\n> --\n> Regards\n>\n> Kieran\n>\n>\n> > ipa: rpi: imx296_mono: Disable all colour shading\n> >\n> > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 25 ++++++++++++++++++++++++-\n> > src/ipa/rpi/vc4/data/imx296_mono.json | 48\n> > ++++++++++++++++++++++++------------------------\n> > 2 files changed, 48 insertions(+), 25 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D348BDC71\n\tfor ;\n\tMon, 10 Jul 2023 13:19:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D40EE628C1;\n\tMon, 10 Jul 2023 15:19:22 +0200 (CEST)","from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com\n\t[IPv6:2607:f8b0:4864:20::112d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C353C60384\n\tfor ;\n\tMon, 10 Jul 2023 15:19:21 +0200 (CEST)","by mail-yw1-x112d.google.com with SMTP id\n\t00721157ae682-57045429f76so53815517b3.0\n\tfor ;\n\tMon, 10 Jul 2023 06:19:21 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688995162;\n\tbh=m1dwfHytNFnco2miBqUhl2KGNTKj24RnYqrbcgVLyV8=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZNHCHSntKCqRHFeAUEpyhikEuBya1VZ1QBmu6SDcSKZnznxnZHVq/73sLUafsmMuy\n\tebuze+LQ7ZGBEOK4NwW4OtWNazfT6n4mHnKdunhZV6w3GCUkbE9Bi4C5Z9GWRrVZw+\n\tfFeY38I2w9JhaX3BwkZnMw+qnXegiQqOVVJQq04IIJ2fHrWfzqrEbRWk6t5BQEpDfZ\n\tD1nq9kM9+BhT6JTyNfbtnYcBX0ACcp5cVdhXBy78cGwi0l9eA51CbQEoiUD8qWC1Pt\n\t9BHPC+tuSKNfIQ2qf9QvrM6Ui7PW2vxInKuCs6/1YoJ3izi/gqbylZZaMxO+Vj6klz\n\tU7A/S1lki1sfg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1688995160; x=1691587160;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=vfPJkbYsp6+9sruwniUl61V8RSQcaNKV5ePizm5gmas=;\n\tb=FUKJChZIXjocvCvovIQOQABpr86xTgTkUpVOysjxLCD7bt6Ecqgy/snHA1j3G3ppX+\n\tskU9bENHRM4LE1maD0FUIruh0tksJrr64YTFpEr3dvTvAk0XhORnmnKie22eCVI+/wnO\n\tTPE9vH2euG6cLvVcE5p8ZVMgZ5eAk+aPztlYkM1n33DzocSwCIlnMEksgdqdfaVkdDmU\n\t4fhAamyeefJdyksiDWA1ceC8Db/xJzBzrxZ4yLvkYq0YpQHUAsE1nSeBLPIARJ4SjxTw\n\tv5Qt2/HEof0NF9Ov4ltW1ZpQupCkxrgxETnVerG9HAmeZ0xmMeVNZ4ftT+bYCLwwkAJF\n\tHyLw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"FUKJChZI\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1688995160; x=1691587160;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=vfPJkbYsp6+9sruwniUl61V8RSQcaNKV5ePizm5gmas=;\n\tb=a3Ur+TNURFCyMKbaOeyw6qjrpy5uL95hO/izE92jPlbY8fgcWw9bF20CCvFWN5NGmu\n\tFQih/Uzu4uTIjpRWfgY/Fb4XbON2BYGc7brdVrsQLhxuqOYAmO0E6nJT29As4v1GX3jd\n\tArjmJT3Olc6A5mR6yktM6poKQReV5MQoNZY26n0vaFeL5mTSjet4nWHC7NjuVZluIo0D\n\tgzvaTVI0Mna2OqkztSgrG3/GaQZcFHRW29ORAT0OIBQz0NYOsOyRjuCID7ZLs4rqpP5F\n\txhnB67r2aoxzXmrMeuVWKe98K6ukTxqcTf4OOdEgxPkgjEdDAwBE6psMTt3Er0veCXzH\n\tC2pQ==","X-Gm-Message-State":"ABy/qLY6vuhvQlNbrzKafa6uIwFOyYsx5fIxHL6AWZ/tyGLVw9jnjGrY\n\t7CWThdabGkZ/YHBmu8UcFluwSEODlEajV/FnvDdzybjAzYdrqrG4ADM=","X-Google-Smtp-Source":"APBJJlEomfgZ9zHQ0UIJEikwuIYIgECs5IrH/GVK2Wd2jVBLrUsUfIdSMpFjY9KofwYoKnoJ87wJKeVvrXyGFrb4kmY=","X-Received":"by 2002:a0d:eb42:0:b0:562:1850:bbf0 with SMTP id\n\tu63-20020a0deb42000000b005621850bbf0mr12377378ywe.21.1688995160550;\n\tMon, 10 Jul 2023 06:19:20 -0700 (PDT)","MIME-Version":"1.0","References":"\n\t<168899508298.3585053.9651925006212798297@Monstersaurus>","In-Reply-To":"<168899508298.3585053.9651925006212798297@Monstersaurus>","Date":"Mon, 10 Jul 2023 14:19:04 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27519,"web_url":"https://patchwork.libcamera.org/comment/27519/","msgid":"<168899543091.3585053.9524041388461940593@Monstersaurus>","date":"2023-07-10T13:23:50","subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2023-07-10 14:19:04)\n> On Mon, 10 Jul 2023 at 14:18, Kieran Bingham\n> wrote:\n> >\n> > Quoting Naushir Patuck (2023-07-10 14:13:56)\n> > > The following changes since commit 7802471a3badb561f1e017c3ecdafc95a0a43d61:\n> > >\n> > > pipeline: rpi: Account for Bayer packing when validating format\n> > > (2023-07-07 11:39:34 +0300)\n> > >\n> > > are available in the Git repository at:\n> > >\n> > > https://github.com/naushir/libcamera.git\n> > >\n> > > for you to fetch changes up to e3ecd71894399b26e80d26b29078c82e6bfc5c63:\n> > >\n> > > ipa: rpi: imx296_mono: Disable all colour shading (2023-07-10 14:10:11 +0100)\n> > >\n> > > ----------------------------------------------------------------\n> > > Naushir Patuck (2):\n> > > ipa: rpi: imx708: Fix mode switch drop frame count\n> >\n> > clang++-11 -Isrc/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p -Isrc/ipa/rpi/cam_helper -I../../../src/libcamera/src/ipa/rpi/cam_helper -Isrc/ipa/rpi -I../../../src/libcamera/src/ipa/rpi -Iinclude -I../../../src/libcamera/include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -MF src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o.d -o src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -c ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> > ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp:62:15: error: 'hideFramesStartup' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]\n> > unsigned int hideFramesStartup() const;\n> > ^\n> > ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper.h:98:23: note: overridden virtual function is here\n> > virtual unsigned int hideFramesStartup() const;\n> > ^\n> > 1 error generated.\n> >\n> > Means I can't do a direct git pull on this.\n> >\n> > I'll fix up and merge.\n> \n> Argh, you did warn me about this as well :(\n> Thanks for fixing it!\n\nNo worries. Merged!\n\n--\nKieran\n\n\n> \n> Naush\n> \n> \n> >\n> > --\n> > Regards\n> >\n> > Kieran\n> >\n> >\n> > > ipa: rpi: imx296_mono: Disable all colour shading\n> > >\n> > > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 25 ++++++++++++++++++++++++-\n> > > src/ipa/rpi/vc4/data/imx296_mono.json | 48\n> > > ++++++++++++++++++++++++------------------------\n> > > 2 files changed, 48 insertions(+), 25 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6AD16C323E\n\tfor ;\n\tMon, 10 Jul 2023 13:23:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC7F8628C1;\n\tMon, 10 Jul 2023 15:23:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91D5960384\n\tfor ;\n\tMon, 10 Jul 2023 15:23:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 215E0BEB;\n\tMon, 10 Jul 2023 15:23:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688995434;\n\tbh=yJAG0xwWyVEbdG3ClfcX986X8Bz302YVKksScUz5PyI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ATtCJqMwnamRTbz1e+18/0gi2xI9/OZJkv8JhIqwvrd0E6hGWJxyCVabklWEF/M9a\n\tDUKcmRzf7eiYXJSHiPIIZAiwCHwL0oAOPDAHMSF1ku7sNQOaDoOXeLmpmQO/GwHeyJ\n\t4CTv/6aqhZzMZNT8nYp/aDy3w1sWgQkP9VL3AbHKuVoLX8ZRTIgDQXv9eDO+fu5BSI\n\tzXmHjk+XDcqLtzSlwQWuZ9RzIFPYuEhx5TJC5NumO3Rg6ukqI673dYOGOX0iHePUaJ\n\tclJEsb3YvChZX0A0jD3CGO4WczOoqwR7jp+Oq1CKGoo5dWg1HTe/V3dG8Y2DABhHdT\n\tiDnOO0UxCL8fA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688995385;\n\tbh=yJAG0xwWyVEbdG3ClfcX986X8Bz302YVKksScUz5PyI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=VicIP9ovzKs1EaM2NsuM1DWBiuQ6EjsHwyMM5L4R/8a3ICSRnHv9kSx5eJoFxBlnr\n\tc84Wb8guq2kycaa3HGpDsFu7/6PR1yYhinTw6BA7+XdmsmTFEw0NjpTnKPuYWWHUoG\n\taTiThuMXvaVUhlc2DW2J0XJ/EhJ3c9eimPbJKZoA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"VicIP9ov\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"","References":"\n\t<168899508298.3585053.9651925006212798297@Monstersaurus>\n\t","To":"Naushir Patuck ","Date":"Mon, 10 Jul 2023 14:23:50 +0100","Message-ID":"<168899543091.3585053.9524041388461940593@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27520,"web_url":"https://patchwork.libcamera.org/comment/27520/","msgid":"","date":"2023-07-10T13:25:09","subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Mon, 10 Jul 2023 at 14:23, Kieran Bingham\n wrote:\n>\n> Quoting Naushir Patuck (2023-07-10 14:19:04)\n> > On Mon, 10 Jul 2023 at 14:18, Kieran Bingham\n> > wrote:\n> > >\n> > > Quoting Naushir Patuck (2023-07-10 14:13:56)\n> > > > The following changes since commit 7802471a3badb561f1e017c3ecdafc95a0a43d61:\n> > > >\n> > > > pipeline: rpi: Account for Bayer packing when validating format\n> > > > (2023-07-07 11:39:34 +0300)\n> > > >\n> > > > are available in the Git repository at:\n> > > >\n> > > > https://github.com/naushir/libcamera.git\n> > > >\n> > > > for you to fetch changes up to e3ecd71894399b26e80d26b29078c82e6bfc5c63:\n> > > >\n> > > > ipa: rpi: imx296_mono: Disable all colour shading (2023-07-10 14:10:11 +0100)\n> > > >\n> > > > ----------------------------------------------------------------\n> > > > Naushir Patuck (2):\n> > > > ipa: rpi: imx708: Fix mode switch drop frame count\n> > >\n> > > clang++-11 -Isrc/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p -Isrc/ipa/rpi/cam_helper -I../../../src/libcamera/src/ipa/rpi/cam_helper -Isrc/ipa/rpi -I../../../src/libcamera/src/ipa/rpi -Iinclude -I../../../src/libcamera/include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -MF src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o.d -o src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -c ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> > > ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp:62:15: error: 'hideFramesStartup' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]\n> > > unsigned int hideFramesStartup() const;\n> > > ^\n> > > ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper.h:98:23: note: overridden virtual function is here\n> > > virtual unsigned int hideFramesStartup() const;\n> > > ^\n> > > 1 error generated.\n> > >\n> > > Means I can't do a direct git pull on this.\n> > >\n> > > I'll fix up and merge.\n> >\n> > Argh, you did warn me about this as well :(\n> > Thanks for fixing it!\n>\n> No worries. Merged!\n\nYou'll be happy to learn that I've now switched to clang as my default compiler\nso this will never happen again ;-)\n\n>\n> --\n> Kieran\n>\n>\n> >\n> > Naush\n> >\n> >\n> > >\n> > > --\n> > > Regards\n> > >\n> > > Kieran\n> > >\n> > >\n> > > > ipa: rpi: imx296_mono: Disable all colour shading\n> > > >\n> > > > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 25 ++++++++++++++++++++++++-\n> > > > src/ipa/rpi/vc4/data/imx296_mono.json | 48\n> > > > ++++++++++++++++++++++++------------------------\n> > > > 2 files changed, 48 insertions(+), 25 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB408C323E\n\tfor ;\n\tMon, 10 Jul 2023 13:25:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 931E7628BC;\n\tMon, 10 Jul 2023 15:25:27 +0200 (CEST)","from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com\n\t[IPv6:2607:f8b0:4864:20::1135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB2A160384\n\tfor ;\n\tMon, 10 Jul 2023 15:25:25 +0200 (CEST)","by mail-yw1-x1135.google.com with SMTP id\n\t00721157ae682-5701e8f2b79so56587057b3.0\n\tfor ;\n\tMon, 10 Jul 2023 06:25:25 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688995527;\n\tbh=PFwwYjX7TmBDHufJhSIDfV8s/uQmGcR6RemUp3eDxbA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0Ecz1Pq0SurAeA+nJfbDKbG7d1tJlJ0b3mH3g4sNKDHqY7z2jgfVhtKTbGaveZh4o\n\ttV9dhHQ+DweL6Mfqqg35zME6Aw07Rd0AURFoKP6gmXjPfMPj/eSplD3RbyJJoLyouQ\n\t2ILOHtJH0jiiwyFq6MttbqEVsy0S1IeuhJfRZTdqqZIKmoFfnaxlpCeusw80JsR9bz\n\tyFDgEiZxE57x7xGfGASWCWkIpZNfTteO3zh0y5213gcKVksDkiN3WEvZluOOovLtL+\n\tZeumyKqOVxS8eXDkN2ke2LzDaqMqFBOcwxYVwCmngO9/QF0SFmiQ6OaUCjReZ1tvWZ\n\tVSUyZ3EZwQzfg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1688995525; x=1691587525;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=oytrLWGYne3X0yUXlixvoDICxA+RXb/Ihmrjh41MPsg=;\n\tb=etvd87WILJenLVahQnimawRuARYAKNClq7ciYdBWUhXmhPEWPztUwHhfaFcaBzeKxa\n\toEWBWQVC4p2DhyvtYw6SRs+qDV2SX4CYWpgA/YMBfyv/m4OK8FF6mUXTjlOf4gDiFNsp\n\tv4U1ju3pRPgFKhoFLxhXV2n7Z03KhWfXcLzGBEhdf48muasNQyxMJeVDbBcuMu+BLMBe\n\tiKmhup7Tze6Z9MFnPr9UUWmUYFG6CHKoLghNk/Ki9xIJS6fF5bGs07yblsGKDFy/SAC8\n\tY8r6j/vZib8NCFs498wUO4DAIEDN8kA7yAWqtnfm3lfh2N8XsV+tQHpkYz5QBtBT+RZV\n\tlD8w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"etvd87WI\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1688995525; x=1691587525;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=oytrLWGYne3X0yUXlixvoDICxA+RXb/Ihmrjh41MPsg=;\n\tb=V7BbzJlSxAvYqUjhI/NqYZaMnsdx24m5WuS58OB820AVdzVx+mizceGszHsI4M2MAi\n\tpem4VLEDXFrZDFvZyXbUMoCK58ikKMOCpb5XvELgUC9v/0oaXkImd28k37Gq5EFJW7kO\n\tPqcxj6z9BQSVQzzvoVxcNT+sZLHJww8Y/LIKrPeEwcO9zzu+wLXRPbSBlukpKtcHpTkp\n\tVWC7IJBaOO2EI9d8f4Qme9XRtHJc5VUi8tmDIfP88vbFNLWkQztfRcPmVxdasoWMpLmV\n\tS8Ph07JSAOlCpGaVjGxgxnT2mGxfxCBZKtYJ1ET0iHfIA6pRXMpXBd8qOtY/xf3mA+fg\n\thhwg==","X-Gm-Message-State":"ABy/qLYnqCTO5UrDEGFlzodouGQ2EIDi77Ilt2+dlXQBsDmQrUYJoxgg\n\t0tZ8IRu7EQ9041LQZ7Ef0kTATTLV/4OlcyhdjAmuTs1YBTc5mvNh5b4SRw==","X-Google-Smtp-Source":"APBJJlFfIA+jDrQ/rDckBSsg0IGq56oO13BAvfjEdO+NMX7sFNWzE8XbAS8vepnnSXkjt22REIW7wLnB9HjIOa19jp8=","X-Received":"by 2002:a81:8497:0:b0:577:3bf2:860b with SMTP id\n\tu145-20020a818497000000b005773bf2860bmr11689935ywf.5.1688995524751;\n\tMon, 10 Jul 2023 06:25:24 -0700 (PDT)","MIME-Version":"1.0","References":"\n\t<168899508298.3585053.9651925006212798297@Monstersaurus>\n\t\n\t<168899543091.3585053.9524041388461940593@Monstersaurus>","In-Reply-To":"<168899543091.3585053.9524041388461940593@Monstersaurus>","Date":"Mon, 10 Jul 2023 14:25:09 +0100","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27549,"web_url":"https://patchwork.libcamera.org/comment/27549/","msgid":"<20230712212935.GA15876@pendragon.ideasonboard.com>","date":"2023-07-12T21:29:35","subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Jul 10, 2023 at 02:25:09PM +0100, Naushir Patuck via libcamera-devel wrote:\n> On Mon, 10 Jul 2023 at 14:23, Kieran Bingham wrote:\n> > Quoting Naushir Patuck (2023-07-10 14:19:04)\n> > > On Mon, 10 Jul 2023 at 14:18, Kieran Bingham wrote:\n> > > > Quoting Naushir Patuck (2023-07-10 14:13:56)\n> > > > > The following changes since commit 7802471a3badb561f1e017c3ecdafc95a0a43d61:\n> > > > >\n> > > > > pipeline: rpi: Account for Bayer packing when validating format\n> > > > > (2023-07-07 11:39:34 +0300)\n> > > > >\n> > > > > are available in the Git repository at:\n> > > > >\n> > > > > https://github.com/naushir/libcamera.git\n> > > > >\n> > > > > for you to fetch changes up to e3ecd71894399b26e80d26b29078c82e6bfc5c63:\n> > > > >\n> > > > > ipa: rpi: imx296_mono: Disable all colour shading (2023-07-10 14:10:11 +0100)\n> > > > >\n> > > > > ----------------------------------------------------------------\n> > > > > Naushir Patuck (2):\n> > > > > ipa: rpi: imx708: Fix mode switch drop frame count\n> > > >\n> > > > clang++-11 -Isrc/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p -Isrc/ipa/rpi/cam_helper -I../../../src/libcamera/src/ipa/rpi/cam_helper -Isrc/ipa/rpi -I../../../src/libcamera/src/ipa/rpi -Iinclude -I../../../src/libcamera/include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -MF src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o.d -o src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -c ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> > > > ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp:62:15: error: 'hideFramesStartup' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]\n> > > > unsigned int hideFramesStartup() const;\n> > > > ^\n> > > > ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper.h:98:23: note: overridden virtual function is here\n> > > > virtual unsigned int hideFramesStartup() const;\n> > > > ^\n> > > > 1 error generated.\n> > > >\n> > > > Means I can't do a direct git pull on this.\n> > > >\n> > > > I'll fix up and merge.\n> > >\n> > > Argh, you did warn me about this as well :(\n> > > Thanks for fixing it!\n> >\n> > No worries. Merged!\n> \n> You'll be happy to learn that I've now switched to clang as my default compiler\n> so this will never happen again ;-)\n\nBut you may then not notice gcc-specific issues :-) Would you be able to\ncompile-test with both compilers before sending patches ?\n\n> > > > > ipa: rpi: imx296_mono: Disable all colour shading\n> > > > >\n> > > > > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 25 ++++++++++++++++++++++++-\n> > > > > src/ipa/rpi/vc4/data/imx296_mono.json | 48 ++++++++++++++++++++++++------------------------\n> > > > > 2 files changed, 48 insertions(+), 25 deletions(-)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2BA8FBEFBE\n\tfor ;\n\tWed, 12 Jul 2023 21:29:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B0D5628BC;\n\tWed, 12 Jul 2023 23:29:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C650628BB\n\tfor ;\n\tWed, 12 Jul 2023 23:29:34 +0200 (CEST)","from pendragon.ideasonboard.com (unknown [188.20.72.2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 81BF157E;\n\tWed, 12 Jul 2023 23:28:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689197376;\n\tbh=D8Ph5s7zC8mrRMRvubour+ILmZA879Xb+olnvicU8Xc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SjojvqJzqr1H0kbUtCx1M9goL6WA8YbOx67/ThKdk01ojMk8SglnQXbOC4uPMyHsW\n\tk0CyZMymPaHPrMFsZ8po/AJvH3SaiBM3BbgUm4xCgsoPz1cec8GM0CVa7vwkyY1WfE\n\tn/CJ8e9OeWCiqjfFEWk9ACxW17+ABquon/uMKc+/BeF2qKs+mJs4MADvdbR3G7AXjT\n\tBVY6TxUwM8t55kCB+V/upgCff0p4v7su6O5DkXmW0qYvLWuqlYvtirGW8SbjufDfbR\n\tvo2jO3ooB4Y9bGv7BEF1Xeq8xvllulJUdJ2xi5OEY5V+bOEIWQEcUCWKh5GZ0hg8PW\n\tjvqSo45I5ocHA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689197324;\n\tbh=D8Ph5s7zC8mrRMRvubour+ILmZA879Xb+olnvicU8Xc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BMvAa68H+ym1K4qtrEoc3vy/wpNfGpVAA99Ak3oe2aTqMdbVIISjMyZesKfS338eS\n\tC2hsko6BmKlk5x3X0CVy/jeW6TMag9FsIGKT08ml05OOCTCiu9aqH+DAXajTd801tq\n\trT/35k+aGcrUscmooSsBWyPWQxc36ZvsHgsWrhq4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BMvAa68H\"; dkim-atps=neutral","Date":"Thu, 13 Jul 2023 00:29:35 +0300","To":"Naushir Patuck ","Message-ID":"<20230712212935.GA15876@pendragon.ideasonboard.com>","References":"\n\t<168899508298.3585053.9651925006212798297@Monstersaurus>\n\t\n\t<168899543091.3585053.9524041388461940593@Monstersaurus>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27550,"web_url":"https://patchwork.libcamera.org/comment/27550/","msgid":"","date":"2023-07-13T07:02:30","subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Wed, 12 Jul 2023 at 22:29, Laurent Pinchart\n wrote:\n>\n> On Mon, Jul 10, 2023 at 02:25:09PM +0100, Naushir Patuck via libcamera-devel wrote:\n> > On Mon, 10 Jul 2023 at 14:23, Kieran Bingham wrote:\n> > > Quoting Naushir Patuck (2023-07-10 14:19:04)\n> > > > On Mon, 10 Jul 2023 at 14:18, Kieran Bingham wrote:\n> > > > > Quoting Naushir Patuck (2023-07-10 14:13:56)\n> > > > > > The following changes since commit 7802471a3badb561f1e017c3ecdafc95a0a43d61:\n> > > > > >\n> > > > > > pipeline: rpi: Account for Bayer packing when validating format\n> > > > > > (2023-07-07 11:39:34 +0300)\n> > > > > >\n> > > > > > are available in the Git repository at:\n> > > > > >\n> > > > > > https://github.com/naushir/libcamera.git\n> > > > > >\n> > > > > > for you to fetch changes up to e3ecd71894399b26e80d26b29078c82e6bfc5c63:\n> > > > > >\n> > > > > > ipa: rpi: imx296_mono: Disable all colour shading (2023-07-10 14:10:11 +0100)\n> > > > > >\n> > > > > > ----------------------------------------------------------------\n> > > > > > Naushir Patuck (2):\n> > > > > > ipa: rpi: imx708: Fix mode switch drop frame count\n> > > > >\n> > > > > clang++-11 -Isrc/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p -Isrc/ipa/rpi/cam_helper -I../../../src/libcamera/src/ipa/rpi/cam_helper -Isrc/ipa/rpi -I../../../src/libcamera/src/ipa/rpi -Iinclude -I../../../src/libcamera/include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -std=c++17 -O0 -g -Wextra-semi -Wthread-safety -Wshadow -include /home/kbingham/iob/libcamera/ci/integrator/builds/build-matrix/clang-11/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -MF src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o.d -o src/ipa/rpi/cam_helper/librpi_ipa_cam_helper.a.p/cam_helper_imx708.cpp.o -c ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp\n> > > > > ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper_imx708.cpp:62:15: error: 'hideFramesStartup' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]\n> > > > > unsigned int hideFramesStartup() const;\n> > > > > ^\n> > > > > ../../../src/libcamera/src/ipa/rpi/cam_helper/cam_helper.h:98:23: note: overridden virtual function is here\n> > > > > virtual unsigned int hideFramesStartup() const;\n> > > > > ^\n> > > > > 1 error generated.\n> > > > >\n> > > > > Means I can't do a direct git pull on this.\n> > > > >\n> > > > > I'll fix up and merge.\n> > > >\n> > > > Argh, you did warn me about this as well :(\n> > > > Thanks for fixing it!\n> > >\n> > > No worries. Merged!\n> >\n> > You'll be happy to learn that I've now switched to clang as my default compiler\n> > so this will never happen again ;-)\n>\n> But you may then not notice gcc-specific issues :-) Would you be able to\n> compile-test with both compilers before sending patches ?\n\nYes, I'll keep gcc as a compile test step.\nIt seems like clang is so much more picky compared to gcc on compiler warnings,\nit seems sensible to use it as the default.\n\nRegards,\nNaush\n\n\n>\n> > > > > > ipa: rpi: imx296_mono: Disable all colour shading\n> > > > > >\n> > > > > > src/ipa/rpi/cam_helper/cam_helper_imx708.cpp | 25 ++++++++++++++++++++++++-\n> > > > > > src/ipa/rpi/vc4/data/imx296_mono.json | 48 ++++++++++++++++++++++++------------------------\n> > > > > > 2 files changed, 48 insertions(+), 25 deletions(-)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C3EABDC71\n\tfor ;\n\tThu, 13 Jul 2023 07:02:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37AF5628C0;\n\tThu, 13 Jul 2023 09:02:41 +0200 (CEST)","from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com\n\t[IPv6:2607:f8b0:4864:20::1129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1E7F61E30\n\tfor ;\n\tThu, 13 Jul 2023 09:02:38 +0200 (CEST)","by mail-yw1-x1129.google.com with SMTP id\n\t00721157ae682-5776312eaddso2853087b3.3\n\tfor ;\n\tThu, 13 Jul 2023 00:02:38 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689231761;\n\tbh=VbiDfaOUD0dpK0NBG26Zs/gWZv3mykaWLBb6rtSYfCM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=aIxGgoFzTVnbegE+grEugh62LTUCSloni/NpflXcHHYGVsIHXhTWEEvmGrRjBArg7\n\t9J3pcOZT5bxVqzw1aHe8WUyAoKLnKlikQG+mw/mSKtG0xskvAiqTPRGA4qGhU3Z6Ij\n\t4Ddb7nK/2uRxR83dQEPUx2WIJqmgRR6pjwqgNa6QiIalH8crIQmiSCqt5f6TkH2hgc\n\tercUE2hLNjwnyjHvJGKn7ciRFujIOnkmLDqnJaMuke9MckYNM8Dw4P3J5XNmJuWlDw\n\tor7kHz8GXE62x13m56O3W7SkDPzZEqFZS12FwKB4Tf7pld3WPnBSJKrkuzUtO+gl+r\n\tbbSrF53lGNhug==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1689231757; x=1691823757;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=1o165r1lwVWeo9l0+gHEcDN2Hg7XdbhWsuoQ7ZTcgx8=;\n\tb=MmfLPG5pBZmJ9bulUWxEwj4JTbS6FDtPTZhayr/Ko/nUFm2GtcvFJXtw1MHIOYldim\n\tpGIK5oOrT5Ren1nSM52BTKwolBm5n+m5RMXgHWFApu1NY+z/wbKvF6rmcZMENug8kqf5\n\tTN2/ZJyTqC+oBs6gynjvKLFDSYMdYwnjEFhwja09Ahmo9XougyTti/9+L0okHj99Dxn/\n\tOYT7zC2Q8Y49N/uBMdcM3iDJaqbAWnxPi89gCmyWKDpKI6Pppu8ytSv+FicZpCOoM02l\n\tYrAOy/9hJYh2mNq+r/DOCeuDU4c7vDJzHu77qig3cjc23AwogCSM+NyESrCS4qRiGV5S\n\tP09w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"MmfLPG5p\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1689231757; x=1691823757;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=1o165r1lwVWeo9l0+gHEcDN2Hg7XdbhWsuoQ7ZTcgx8=;\n\tb=khpF/RpGYJInUT96MOLv94COiOCSUXIh6jFJ3J+KfAvMxpiCLBJ6qwyi5JJ5t6xANb\n\tMDZutu+7RZOm+rhZ1sEDi51EzXiEy22LU5jccbPKfRT1qslg9k4sFAkBTkce7bI6P3u7\n\tsbu5eDg4GnQPIgBw61uFem4r263Qg+ide4claj/kGJaI4W16F3JipSMg7c92TvVUMISj\n\t7ZzZOkPe+Y0TD13Pad5aYh2DMh6tA+5IgS1fQN9u40GvEH5kZPPx0pr50mLDE8gSDXwP\n\tlBNkhKjuWyxscXU7NDZ2smtSLBk1qOZfdEGuood1etoyaCZZg3uEBg1EB6yziM3jwjNv\n\tuaEQ==","X-Gm-Message-State":"ABy/qLb/ooW4MwT+5/69Sedgbb8RpGQsRU4jSzldiqQ+5gakXdTAowFi\n\tPJN7Yhh2TpZEJLyO+pjTs9FvNnOg59S/tkmNscFszmnxP9y7F6KW0jii5w==","X-Google-Smtp-Source":"APBJJlEJqHgjf2Qb8XFM4eNMJmQ1cYbN0q2Q1N6bqTPhTa/yVlb+wqA2uyFLeqQt0rfHbs/rX2au/WBKKfM2PcMoNj0=","X-Received":"by 2002:a81:6fc4:0:b0:561:d25b:672a with SMTP id\n\tk187-20020a816fc4000000b00561d25b672amr951501ywc.21.1689231757420;\n\tThu, 13 Jul 2023 00:02:37 -0700 (PDT)","MIME-Version":"1.0","References":"\n\t<168899508298.3585053.9651925006212798297@Monstersaurus>\n\t\n\t<168899543091.3585053.9524041388461940593@Monstersaurus>\n\t\n\t<20230712212935.GA15876@pendragon.ideasonboard.com>","In-Reply-To":"<20230712212935.GA15876@pendragon.ideasonboard.com>","Date":"Thu, 13 Jul 2023 08:02:30 +0100","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Subject":"Re: [libcamera-devel] [GIT PULL] : Raspberry Pi: IMX296 mono fixes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]