[{"id":27513,"web_url":"https://patchwork.libcamera.org/comment/27513/","msgid":"","date":"2023-07-10T10:03:48","subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: rpi: vc4: data: Updated\n\tcolor matrices for RPi Cameras","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Ben\n\nThanks for these changes.\n\nOn Fri, 7 Jul 2023 at 14:41, Ben Benson via libcamera-devel\n wrote:\n>\n> Altered the color matrices for the tuning files for various\n> cameras in order to make them more color accurate.\n>\n> Signed-off-by Ben Benson \n\ns/by/by:/\n\nOne thing to note is that we've shortened the range of the colour\ntemperatures covered by the matrices (for example, imx219 starts at\n2860 and not 2498). I'm not really sure why the ranges were so large\npreviously, I don't know where those illuminants came from. But I\nthink the arrangement now is fine - the colour matrices will just be\nclamped to the most extreme values that are available (and they're\nprobably still better than what we had before). So with that:\n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> ---\n> src/ipa/rpi/vc4/data/imx219.json | 66 ++++-------\n> src/ipa/rpi/vc4/data/imx296.json | 160 +++++---------------------\n> src/ipa/rpi/vc4/data/imx477.json | 93 ++++-----------\n> src/ipa/rpi/vc4/data/imx708.json | 139 ++++------------------\n> src/ipa/rpi/vc4/data/imx708_wide.json | 49 ++++----\n> src/ipa/rpi/vc4/data/ov5647.json | 66 ++++-------\n> 6 files changed, 147 insertions(+), 426 deletions(-)\n>\n> diff --git a/src/ipa/rpi/vc4/data/imx219.json b/src/ipa/rpi/vc4/data/imx219.json\n> index efe7210a..e8fce164 100644\n> --- a/src/ipa/rpi/vc4/data/imx219.json\n> +++ b/src/ipa/rpi/vc4/data/imx219.json\n> @@ -405,75 +405,57 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2498,\n> + \"ct\": 2860,\n> \"ccm\":\n> [\n> - 1.58731, -0.18011, -0.40721,\n> - -0.60639, 2.03422, -0.42782,\n> - -0.19612, -1.69203, 2.88815\n> + 2.12089, -0.52461, -0.59629,\n> + -0.85342, 2.80445, -0.95103,\n> + -0.26897, -1.14788, 2.41685\n> ]\n> },\n> {\n> - \"ct\": 2811,\n> + \"ct\": 2960,\n> \"ccm\":\n> [\n> - 1.61593, -0.33164, -0.28429,\n> - -0.55048, 1.97779, -0.42731,\n> - -0.12042, -1.42847, 2.54889\n> + 2.26962, -0.54174, -0.72789,\n> + -0.77008, 2.60271, -0.83262,\n> + -0.26036, -1.51254, 2.77289\n> ]\n> },\n> {\n> - \"ct\": 2911,\n> + \"ct\": 3603,\n> \"ccm\":\n> [\n> - 1.62771, -0.41282, -0.21489,\n> - -0.57991, 2.04176, -0.46186,\n> - -0.07613, -1.13359, 2.20972\n> + 2.18644, -0.66148, -0.52496,\n> + -0.77828, 2.69474, -0.91645,\n> + -0.25239, -0.83059, 2.08298\n> ]\n> },\n> {\n> - \"ct\": 2919,\n> + \"ct\": 4650,\n> \"ccm\":\n> [\n> - 1.62661, -0.37736, -0.24925,\n> - -0.52519, 1.95233, -0.42714,\n> - -0.10842, -1.34929, 2.45771\n> + 2.18174, -0.70887, -0.47287,\n> + -0.70196, 2.76426, -1.06231,\n> + -0.25157, -0.71978, 1.97135\n> ]\n> },\n> {\n> - \"ct\": 3627,\n> + \"ct\": 5858,\n> \"ccm\":\n> [\n> - 1.70385, -0.57231, -0.13154,\n> - -0.47763, 1.85998, -0.38235,\n> - -0.07467, -0.82678, 1.90145\n> + 2.32392, -0.88421, -0.43971,\n> + -0.63821, 2.58348, -0.94527,\n> + -0.28541, -0.54112, 1.82653\n> ]\n> },\n> {\n> - \"ct\": 4600,\n> + \"ct\": 7580,\n> \"ccm\":\n> [\n> - 1.68486, -0.61085, -0.07402,\n> - -0.41927, 2.04016, -0.62089,\n> - -0.08633, -0.67672, 1.76305\n> - ]\n> - },\n> - {\n> - \"ct\": 5716,\n> - \"ccm\":\n> - [\n> - 1.80439, -0.73699, -0.06739,\n> - -0.36073, 1.83327, -0.47255,\n> - -0.08378, -0.56403, 1.64781\n> - ]\n> - },\n> - {\n> - \"ct\": 8575,\n> - \"ccm\":\n> - [\n> - 1.89357, -0.76427, -0.12931,\n> - -0.27399, 2.15605, -0.88206,\n> - -0.12035, -0.68256, 1.80292\n> + 2.21175, -0.53242, -0.67933,\n> + -0.57875, 3.07922, -1.50047,\n> + -0.27709, -0.73338, 2.01048\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/imx296.json b/src/ipa/rpi/vc4/data/imx296.json\n> index 9330d0a9..7621f759 100644\n> --- a/src/ipa/rpi/vc4/data/imx296.json\n> +++ b/src/ipa/rpi/vc4/data/imx296.json\n> @@ -357,174 +357,66 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2000,\n> + \"ct\": 2500,\n> \"ccm\":\n> [\n> - 1.48716, -0.1877, -0.35079,\n> - -0.48577, 1.55088, -0.03387,\n> - 0.24919, -1.4583, 2.12083\n> - ]\n> - },\n> - {\n> - \"ct\": 2200,\n> - \"ccm\":\n> - [\n> - 1.53439, -0.28852, -0.29392,\n> - -0.44748, 1.56295, -0.08907,\n> - 0.23529, -1.30488, 1.99784\n> - ]\n> - },\n> - {\n> - \"ct\": 2400,\n> - \"ccm\":\n> - [\n> - 1.57619, -0.36904, -0.25181,\n> - -0.41654, 1.57046, -0.13192,\n> - 0.21678, -1.18352, 1.90786\n> - ]\n> - },\n> - {\n> - \"ct\": 2600,\n> - \"ccm\":\n> - [\n> - 1.61348, -0.43497, -0.2198,\n> - -0.39075, 1.5753, -0.1665,\n> - 0.19789, -1.08592, 1.83942\n> + 1.95054, -0.57435, -0.37619,\n> + -0.46945, 1.86661, -0.39716,\n> + 0.07977, -1.14072, 2.06095\n> ]\n> },\n> {\n> \"ct\": 2800,\n> \"ccm\":\n> [\n> - 1.64717, -0.49009, -0.1951,\n> - -0.36881, 1.57852, -0.1952,\n> - 0.18016, -1.00609, 1.78575\n> - ]\n> - },\n> - {\n> - \"ct\": 3000,\n> - \"ccm\":\n> - [\n> - 1.67798, -0.53693, -0.17591,\n> - -0.34986, 1.58074, -0.21955,\n> - 0.16406, -0.9398, 1.74261\n> - ]\n> - },\n> - {\n> - \"ct\": 3200,\n> - \"ccm\":\n> - [\n> - 1.70647, -0.5773, -0.161,\n> - -0.33332, 1.58235, -0.24056,\n> - 0.14961, -0.88398, 1.70721\n> - ]\n> - },\n> - {\n> - \"ct\": 3400,\n> - \"ccm\":\n> - [\n> - 1.73305, -0.61248, -0.14951,\n> - -0.31875, 1.58355, -0.25894,\n> - 0.13671, -0.83642, 1.67769\n> + 1.94104, -0.60261, -0.33844,\n> + -0.43162, 1.85422, -0.42261,\n> + 0.03799, -0.95022, 1.91222\n> ]\n> },\n> {\n> - \"ct\": 3600,\n> + \"ct\": 2900,\n> \"ccm\":\n> [\n> - 1.75802, -0.64343, -0.14077,\n> - -0.30581, 1.5845, -0.27518,\n> - 0.12518, -0.79546, 1.65271\n> + 1.91828, -0.59569, -0.32258,\n> + -0.51902, 2.09091, -0.57189,\n> + -0.03324, -0.73462, 1.76785\n> ]\n> },\n> {\n> - \"ct\": 4100,\n> + \"ct\": 3620,\n> \"ccm\":\n> [\n> - 1.78116, -0.67459, -0.13048,\n> - -0.26859, 1.58692, -0.31929,\n> - 0.11915, -0.77931, 1.64012\n> + 1.97199, -0.66403, -0.30797,\n> + -0.46411, 2.02612, -0.56201,\n> + -0.07764, -0.61178, 1.68942\n> ]\n> },\n> {\n> - \"ct\": 4600,\n> + \"ct\": 4560,\n> \"ccm\":\n> [\n> - 1.83867, -0.73605, -0.12044,\n> - -0.24947, 1.58699, -0.34207,\n> - 0.09949, -0.71041, 1.59842\n> - ]\n> - },\n> - {\n> - \"ct\": 5100,\n> - \"ccm\":\n> - [\n> - 1.88967, -0.78455, -0.11744,\n> - -0.23398, 1.58806, -0.36172,\n> - 0.08362, -0.6574, 1.56728\n> + 2.15256, -0.84787, -0.30469,\n> + -0.48422, 2.28962, -0.80541,\n> + -0.15113, -0.53014, 1.68127\n> ]\n> },\n> {\n> \"ct\": 5600,\n> \"ccm\":\n> [\n> - 1.93485, -0.82318, -0.1191,\n> - -0.22108, 1.58973, -0.37892,\n> - 0.07074, -0.61609, 1.54362\n> - ]\n> - },\n> - {\n> - \"ct\": 6100,\n> - \"ccm\":\n> - [\n> - 1.97481, -0.85423, -0.12371,\n> - -0.21015, 1.59169, -0.39406,\n> - 0.06021, -0.58353, 1.52536\n> - ]\n> - },\n> - {\n> - \"ct\": 6600,\n> - \"ccm\":\n> - [\n> - 2.01029, -0.87946, -0.13017,\n> - -0.20074, 1.59378, -0.4075,\n> - 0.05146, -0.55732, 1.51096\n> - ]\n> - },\n> - {\n> - \"ct\": 7100,\n> - \"ccm\":\n> - [\n> - 2.04183, -0.9002, -0.13765,\n> - -0.19255, 1.59586, -0.41944,\n> - 0.04414, -0.53603, 1.49947\n> - ]\n> - },\n> - {\n> - \"ct\": 7600,\n> - \"ccm\":\n> - [\n> - 2.07001, -0.91744, -0.14566,\n> - -0.18534, 1.59788, -0.43013,\n> - 0.03791, -0.51841, 1.49013\n> - ]\n> - },\n> - {\n> - \"ct\": 8100,\n> - \"ccm\":\n> - [\n> - 2.09534, -0.93195, -0.15388,\n> - -0.17893, 1.59981, -0.43974,\n> - 0.03256, -0.50364, 1.48243\n> + 2.04576, -0.74771, -0.29805,\n> + -0.36332, 1.98993, -0.62662,\n> + -0.09328, -0.46543, 1.55871\n> ]\n> },\n> {\n> - \"ct\": 8600,\n> + \"ct\": 7400,\n> \"ccm\":\n> [\n> - 2.11799, -0.94416, -0.16203,\n> - -0.17324, 1.60161, -0.44836,\n> - 0.02795, -0.4912, 1.47604\n> + 2.37532, -0.83069, -0.54462,\n> + -0.48279, 2.84309, -1.36031,\n> + -0.21178, -0.66532, 1.87709\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/imx477.json b/src/ipa/rpi/vc4/data/imx477.json\n> index daffc268..0e39d419 100644\n> --- a/src/ipa/rpi/vc4/data/imx477.json\n> +++ b/src/ipa/rpi/vc4/data/imx477.json\n> @@ -410,102 +410,57 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2360,\n> + \"ct\": 2850,\n> \"ccm\":\n> [\n> - 1.66078, -0.23588, -0.42491,\n> - -0.47456, 1.82763, -0.35307,\n> - -0.00545, -1.44729, 2.45273\n> + 1.97469, -0.71439, -0.26031,\n> + -0.43521, 2.09769, -0.66248,\n> + -0.04826, -0.84642, 1.89468\n> ]\n> },\n> {\n> - \"ct\": 2870,\n> - \"ccm\":\n> - [\n> - 1.78373, -0.55344, -0.23029,\n> - -0.39951, 1.69701, -0.29751,\n> - 0.01986, -1.06525, 2.04539\n> - ]\n> - },\n> - {\n> - \"ct\": 2970,\n> - \"ccm\":\n> - [\n> - 1.73511, -0.56973, -0.16537,\n> - -0.36338, 1.69878, -0.33539,\n> - -0.02354, -0.76813, 1.79168\n> - ]\n> - },\n> - {\n> - \"ct\": 3000,\n> - \"ccm\":\n> - [\n> - 2.06374, -0.92218, -0.14156,\n> - -0.41721, 1.69289, -0.27568,\n> - -0.00554, -0.92741, 1.93295\n> - ]\n> - },\n> - {\n> - \"ct\": 3700,\n> - \"ccm\":\n> - [\n> - 2.13792, -1.08136, -0.05655,\n> - -0.34739, 1.58989, -0.24249,\n> - -0.00349, -0.76789, 1.77138\n> - ]\n> - },\n> - {\n> - \"ct\": 3870,\n> - \"ccm\":\n> - [\n> - 1.83834, -0.70528, -0.13307,\n> - -0.30499, 1.60523, -0.30024,\n> - -0.05701, -0.58313, 1.64014\n> - ]\n> - },\n> - {\n> - \"ct\": 4000,\n> + \"ct\": 2960,\n> \"ccm\":\n> [\n> - 2.15741, -1.10295, -0.05447,\n> - -0.34631, 1.61158, -0.26528,\n> - -0.02723, -0.70288, 1.73011\n> + 2.12952, -0.91185, -0.21768,\n> + -0.38018, 1.90789, -0.52771,\n> + 0.03988, -1.10079, 2.06092\n> ]\n> },\n> {\n> - \"ct\": 4400,\n> + \"ct\": 3580,\n> \"ccm\":\n> [\n> - 2.05729, -0.95007, -0.10723,\n> - -0.41712, 1.78606, -0.36894,\n> - -0.11899, -0.55727, 1.67626\n> + 2.03422, -0.80048, -0.23374,\n> + -0.39089, 1.97221, -0.58132,\n> + -0.08969, -0.61439, 1.70408\n> ]\n> },\n> {\n> - \"ct\": 4715,\n> + \"ct\": 4559,\n> \"ccm\":\n> [\n> - 1.90255, -0.77478, -0.12777,\n> - -0.31338, 1.88197, -0.56858,\n> - -0.06001, -0.61785, 1.67786\n> + 2.15423, -0.98143, -0.17279,\n> + -0.38131, 2.14763, -0.76632,\n> + -0.10069, -0.54383, 1.64452\n> ]\n> },\n> {\n> - \"ct\": 5920,\n> + \"ct\": 5881,\n> \"ccm\":\n> [\n> - 1.98691, -0.84671, -0.14019,\n> - -0.26581, 1.70615, -0.44035,\n> - -0.09532, -0.47332, 1.56864\n> + 2.18464, -0.95493, -0.22971,\n> + -0.36826, 2.00298, -0.63471,\n> + -0.15219, -0.38055, 1.53274\n> ]\n> },\n> {\n> - \"ct\": 9050,\n> + \"ct\": 7600,\n> \"ccm\":\n> [\n> - 2.09255, -0.76541, -0.32714,\n> - -0.28973, 2.27462, -0.98489,\n> - -0.17299, -0.61275, 1.78574\n> + 2.30687, -0.97295, -0.33392,\n> + -0.30872, 2.32779, -1.01908,\n> + -0.17761, -0.55891, 1.73651\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/imx708.json b/src/ipa/rpi/vc4/data/imx708.json\n> index 6b26d0a1..c40a5994 100644\n> --- a/src/ipa/rpi/vc4/data/imx708.json\n> +++ b/src/ipa/rpi/vc4/data/imx708.json\n> @@ -368,147 +368,48 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2498,\n> + \"ct\": 2964,\n> \"ccm\":\n> [\n> - 1.14912, 0.28638, -0.43551,\n> - -0.49691, 1.60391, -0.10701,\n> - -0.10513, -1.09534, 2.20047\n> + 1.72129, -0.45961, -0.26169,\n> + -0.30042, 1.56924, -0.26882,\n> + 0.15133, -1.13293, 1.98161\n> ]\n> },\n> {\n> - \"ct\": 2821,\n> + \"ct\": 3610,\n> \"ccm\":\n> [\n> - 1.18251, 0.15501, -0.33752,\n> - -0.44304, 1.58495, -0.14191,\n> - -0.05077, -0.96422, 2.01498\n> + 1.54474, -0.35082, -0.19391,\n> + -0.36989, 1.67926, -0.30936,\n> + -0.00524, -0.55197, 1.55722\n> ]\n> },\n> {\n> - \"ct\": 2925,\n> + \"ct\": 4640,\n> \"ccm\":\n> [\n> - 1.18668, 0.00195, -0.18864,\n> - -0.41617, 1.50514, -0.08897,\n> - -0.02675, -0.91143, 1.93818\n> + 1.52972, -0.35168, -0.17804,\n> + -0.28309, 1.67098, -0.38788,\n> + 0.01695, -0.57209, 1.55515\n> ]\n> },\n> {\n> - \"ct\": 2926,\n> + \"ct\": 5910,\n> \"ccm\":\n> [\n> - 1.50948, -0.44421, -0.06527,\n> - -0.37241, 1.41726, -0.04486,\n> - 0.07098, -0.84694, 1.77596\n> + 1.56879, -0.42159, -0.14719,\n> + -0.27275, 1.59354, -0.32079,\n> + -0.02862, -0.40662, 1.43525\n> ]\n> },\n> {\n> - \"ct\": 2951,\n> + \"ct\": 7590,\n> \"ccm\":\n> [\n> - 1.52743, -0.47333, -0.05411,\n> - -0.36485, 1.40764, -0.04279,\n> - 0.08672, -0.90479, 1.81807\n> - ]\n> - },\n> - {\n> - \"ct\": 2954,\n> - \"ccm\":\n> - [\n> - 1.51683, -0.46841, -0.04841,\n> - -0.36288, 1.39914, -0.03625,\n> - 0.06421, -0.82034, 1.75613\n> - ]\n> - },\n> - {\n> - \"ct\": 3578,\n> - \"ccm\":\n> - [\n> - 1.59888, -0.59105, -0.00784,\n> - -0.29366, 1.32037, -0.02671,\n> - 0.06627, -0.76465, 1.69838\n> - ]\n> - },\n> - {\n> - \"ct\": 3717,\n> - \"ccm\":\n> - [\n> - 1.59063, -0.58059, -0.01003,\n> - -0.29583, 1.32715, -0.03132,\n> - 0.03613, -0.67431, 1.63817\n> - ]\n> - },\n> - {\n> - \"ct\": 3784,\n> - \"ccm\":\n> - [\n> - 1.59379, -0.58861, -0.00517,\n> - -0.29178, 1.33292, -0.04115,\n> - 0.03541, -0.66162, 1.62622\n> - ]\n> - },\n> - {\n> - \"ct\": 4485,\n> - \"ccm\":\n> - [\n> - 1.40761, -0.34561, -0.06201,\n> - -0.32388, 1.57221, -0.24832,\n> - -0.01014, -0.63427, 1.64441\n> - ]\n> - },\n> - {\n> - \"ct\": 4615,\n> - \"ccm\":\n> - [\n> - 1.41537, -0.35832, -0.05705,\n> - -0.31429, 1.56019, -0.24591,\n> - -0.01761, -0.61859, 1.63621\n> - ]\n> - },\n> - {\n> - \"ct\": 4671,\n> - \"ccm\":\n> - [\n> - 1.42941, -0.38178, -0.04764,\n> - -0.31421, 1.55925, -0.24504,\n> - -0.01141, -0.62987, 1.64129\n> - ]\n> - },\n> - {\n> - \"ct\": 5753,\n> - \"ccm\":\n> - [\n> - 1.64549, -0.63329, -0.01221,\n> - -0.22431, 1.36423, -0.13992,\n> - -0.00831, -0.55373, 1.56204\n> - ]\n> - },\n> - {\n> - \"ct\": 5773,\n> - \"ccm\":\n> - [\n> - 1.63668, -0.63557, -0.00111,\n> - -0.21919, 1.36234, -0.14315,\n> - -0.00399, -0.57428, 1.57827\n> - ]\n> - },\n> - {\n> - \"ct\": 7433,\n> - \"ccm\":\n> - [\n> - 1.36007, -0.09277, -0.26729,\n> - -0.36886, 2.09249, -0.72363,\n> - -0.12573, -0.76761, 1.89334\n> - ]\n> - },\n> - {\n> - \"ct\": 55792,\n> - \"ccm\":\n> - [\n> - 1.65091, -0.63689, -0.01401,\n> - -0.22277, 1.35752, -0.13475,\n> - -0.00943, -0.55091, 1.56033\n> + 1.41424, -0.21092, -0.20332,\n> + -0.17646, 1.71734, -0.54087,\n> + 0.01297, -0.63111, 1.61814\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/imx708_wide.json b/src/ipa/rpi/vc4/data/imx708_wide.json\n> index 14bc918e..65543628 100644\n> --- a/src/ipa/rpi/vc4/data/imx708_wide.json\n> +++ b/src/ipa/rpi/vc4/data/imx708_wide.json\n> @@ -358,48 +358,57 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2750,\n> + \"ct\": 2868,\n> \"ccm\":\n> [\n> - 1.13004, 0.36392, -0.49396,\n> - -0.45885, 1.68171, -0.22286,\n> - -0.06473, -0.86962, 1.93435\n> + 1.58923, -0.36649, -0.22273,\n> + -0.43591, 1.84858, -0.41268,\n> + 0.02948, -0.77666, 1.74718\n> ]\n> },\n> {\n> - \"ct\": 2940,\n> + \"ct\": 2965,\n> \"ccm\":\n> [\n> - 1.29876, 0.09627, -0.39503,\n> - -0.43085, 1.60258, -0.17172,\n> - -0.02638, -0.92581, 1.95218\n> + 1.73397, -0.42794, -0.30603,\n> + -0.36504, 1.72431, -0.35926,\n> + 0.12765, -1.10933, 1.98168\n> ]\n> },\n> {\n> - \"ct\": 3650,\n> + \"ct\": 3603,\n> \"ccm\":\n> [\n> - 1.57729, -0.29734, -0.27995,\n> - -0.42965, 1.66231, -0.23265,\n> - -0.02183, -0.62331, 1.64514\n> + 1.61787, -0.42704, -0.19084,\n> + -0.37819, 1.74588, -0.36769,\n> + 0.00961, -0.59807, 1.58847\n> ]\n> },\n> {\n> - \"ct\": 4625,\n> + \"ct\": 4620,\n> \"ccm\":\n> [\n> - 1.52145, -0.22382, -0.29763,\n> - -0.40445, 1.82186, -0.41742,\n> - -0.05732, -0.56222, 1.61954\n> + 1.55581, -0.35422, -0.20158,\n> + -0.31805, 1.79309, -0.47505,\n> + -0.01256, -0.54489, 1.55746\n> ]\n> },\n> {\n> - \"ct\": 5715,\n> + \"ct\": 5901,\n> \"ccm\":\n> [\n> - 1.67851, -0.39193, -0.28658,\n> - -0.37169, 1.72949, -0.35781,\n> - -0.09556, -0.41951, 1.51508\n> + 1.64439, -0.48855, -0.15585,\n> + -0.29149, 1.67122, -0.37972,\n> + -0.03111, -0.44052, 1.47163\n> + ]\n> + },\n> + {\n> + \"ct\": 7610,\n> + \"ccm\":\n> + [\n> + 1.48667, -0.26072, -0.22595,\n> + -0.21815, 1.86724, -0.64909,\n> + -0.00985, -0.64485, 1.65471\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/ov5647.json b/src/ipa/rpi/vc4/data/ov5647.json\n> index d770e44f..a1b42a18 100644\n> --- a/src/ipa/rpi/vc4/data/ov5647.json\n> +++ b/src/ipa/rpi/vc4/data/ov5647.json\n> @@ -406,75 +406,57 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2500,\n> + \"ct\": 2873,\n> \"ccm\":\n> [\n> - 1.70741, -0.05307, -0.65433,\n> - -0.62822, 1.68836, -0.06014,\n> - -0.04452, -1.87628, 2.92079\n> + 1.88195, -0.26249, -0.61946,\n> + -0.63842, 2.11535, -0.47693,\n> + -0.13531, -0.99739, 2.13271\n> ]\n> },\n> {\n> - \"ct\": 2803,\n> + \"ct\": 2965,\n> \"ccm\":\n> [\n> - 1.74383, -0.18731, -0.55652,\n> - -0.56491, 1.67772, -0.11281,\n> - -0.01522, -1.60635, 2.62157\n> + 2.15048, -0.51859, -0.63189,\n> + -0.53572, 1.92585, -0.39013,\n> + 0.01831, -1.48576, 2.46744\n> ]\n> },\n> {\n> - \"ct\": 2912,\n> + \"ct\": 3606,\n> \"ccm\":\n> [\n> - 1.75215, -0.22221, -0.52995,\n> - -0.54568, 1.63522, -0.08954,\n> - 0.02633, -1.56997, 2.54364\n> + 1.97522, -0.43847, -0.53675,\n> + -0.56151, 1.99765, -0.43614,\n> + -0.12438, -0.77056, 1.89493\n> ]\n> },\n> {\n> - \"ct\": 2914,\n> + \"ct\": 4700,\n> \"ccm\":\n> [\n> - 1.72423, -0.28939, -0.43484,\n> - -0.55188, 1.62925, -0.07737,\n> - 0.01959, -1.28661, 2.26702\n> + 2.00971, -0.51461, -0.49511,\n> + -0.52109, 2.01003, -0.48894,\n> + -0.09527, -0.67318, 1.76845\n> ]\n> },\n> {\n> - \"ct\": 3605,\n> + \"ct\": 5890,\n> \"ccm\":\n> [\n> - 1.80381, -0.43646, -0.36735,\n> - -0.46505, 1.56814, -0.10309,\n> - 0.00929, -1.00424, 1.99495\n> + 2.13616, -0.65283, -0.48333,\n> + -0.48364, 1.93115, -0.44751,\n> + -0.13465, -0.54831, 1.68295\n> ]\n> },\n> {\n> - \"ct\": 4540,\n> + \"ct\": 7600,\n> \"ccm\":\n> [\n> - 1.85263, -0.46545, -0.38719,\n> - -0.44136, 1.68443, -0.24307,\n> - 0.04108, -0.85599, 1.81491\n> - ]\n> - },\n> - {\n> - \"ct\": 5699,\n> - \"ccm\":\n> - [\n> - 1.98595, -0.63542, -0.35054,\n> - -0.34623, 1.54146, -0.19522,\n> - 0.00411, -0.70936, 1.70525\n> - ]\n> - },\n> - {\n> - \"ct\": 8625,\n> - \"ccm\":\n> - [\n> - 2.21637, -0.56663, -0.64974,\n> - -0.41133, 1.96625, -0.55492,\n> - -0.02307, -0.83529, 1.85837\n> + 2.06599, -0.39161, -0.67439,\n> + -0.50883, 2.27467, -0.76583,\n> + -0.13961, -0.66121, 1.80081\n> ]\n> }\n> ]\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 620F4BDC71\n\tfor ;\n\tMon, 10 Jul 2023 10:04:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3C0D628C1;\n\tMon, 10 Jul 2023 12:04:02 +0200 (CEST)","from mail-ua1-x935.google.com (mail-ua1-x935.google.com\n\t[IPv6:2607:f8b0:4864:20::935])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C415761E31\n\tfor ;\n\tMon, 10 Jul 2023 12:04:00 +0200 (CEST)","by mail-ua1-x935.google.com with SMTP id\n\ta1e0cc1a2514c-79470b88d88so1227992241.0\n\tfor ;\n\tMon, 10 Jul 2023 03:04:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688983442;\n\tbh=HFnCuaiIeX8qi9yOD3PFZgV3lzADo5605iJGlniW7SU=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ISVp7KKhGrUI7Y6N7RGTq0B7X3uZaeBkWobF7XqT0iuVJbSte2ivDlVc5yIZdN51K\n\tJpfWbIsyIvIrLyw4ffgFTA+o0vgRimdltQuBR6RPd8t+wklscA4iXzYNqpq12Pci0D\n\tdmdB6DW45sgvx8MkLvfjguWVr7OBQOwXfPMxHZBdEBk7m7ZeZSsyxeOztROQ0hbfRc\n\tcsXVX/4HHsoMycwh2kP1kIjSmEYcPpmx8Zp4Ff4NnuGY5GnDKV+pA3yocWGzb3E9tg\n\tWsQi2FHvI38MwBxTMYJUZnAY2jw7vTcju4aCfmXg4aIK5QjcaODJzaY1PMGx6pBW4S\n\t3BK0tbZT90OqQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1688983439; x=1691575439;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=LFUBuEkywGldyVPCXKjbZhMRsThi9B3t5b/kAEL83fA=;\n\tb=Cqk1iQ0lIq6UuLI6h2XNpPk/iFj6/0sF4F9bTNwvgoxUVsAuC2Xw8BZMafEEEriK5X\n\tsGSdEnChjQ9qqFYmcUhUBxKDqIEGhe8RJLR5N1aF8zIcZn9bd3tKdZzODW8k7ZzAB45p\n\teWBV385gfpL5yPLrGU9ZtTGyOUPZFGMINHNJdeu5Ysv8gxf+2W6lbMgbtlhQkFBK4BB+\n\tbMBHyvEo8JP1yJ4OePSyUVFDoaM0nUHoCxgm7RvfpKuzH50lPYJ5iUzeYc1iPc3CqJ21\n\t1k+RoiWj9aC2M3e5s/Gm3FaLZ5DVtRWJS7TP7qJD0ZsnKfvDjuTxkMjEE/PMqAaZjq3c\n\tEnYQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Cqk1iQ0l\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1688983439; x=1691575439;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=LFUBuEkywGldyVPCXKjbZhMRsThi9B3t5b/kAEL83fA=;\n\tb=gFMQgG7fDN4HSyOuNYT76wo+SoGlD4NWgCBgGQ5YIjjS9dWva2CqR6Nijk1viEZbGA\n\tEnDlszDwFLuetMQ+CNOkrD0olNXrr2QY5t/Ou8gKzmHnpFX4QEH+WKvXMs35XKt2koaA\n\tVS7c4jC8LXZ/USTXXGgYZvP1FtdKOQyPjyulnatng560761LeYsY7zrgD9eSDN93LoU1\n\t3R2v5yqeQ051FxenIDTp4K/bbJ6JdpRQ+85ZOXWiXpVf7PK2zBn+6UC1fy8NBuTRV1jZ\n\tw+GeEBX97pFxVSMejwEVejhORyCvbKj25cgtP4VS/0O08FBdaVVIEkRkNkgzE02FvSYZ\n\tdjWQ==","X-Gm-Message-State":"ABy/qLb5MNl6EJZ/LxTJooQjQmpPNZQ49duBx5fAeK2h2Wjo3S2iVZhH\n\ttW5iw2oONYaAO8sgSmhJnYvV+vi7x3hGs9hkmJAkWX/P/CtTHffi","X-Google-Smtp-Source":"APBJJlEyHcxuvupVUP/I/8CQFnz5WXz4yFC75y7euVmbw1XJpsv0AWEuvrPdwo5w7FEE4Yi3nvL/Z+6OX5kp52USns4=","X-Received":"by 2002:a1f:ddc1:0:b0:476:4267:178c with SMTP id\n\tu184-20020a1fddc1000000b004764267178cmr4697903vkg.13.1688983439142;\n\tMon, 10 Jul 2023 03:03:59 -0700 (PDT)","MIME-Version":"1.0","References":"<20230706013926.218131-1-ben.benson@raspberrypi.com>\n\t<20230706013926.218131-3-ben.benson@raspberrypi.com>","In-Reply-To":"<20230706013926.218131-3-ben.benson@raspberrypi.com>","Date":"Mon, 10 Jul 2023 11:03:48 +0100","Message-ID":"","To":"Ben Benson ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: rpi: vc4: data: Updated\n\tcolor matrices for RPi Cameras","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27546,"web_url":"https://patchwork.libcamera.org/comment/27546/","msgid":"","date":"2023-07-12T12:12:02","subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: rpi: vc4: data: Updated\n\tcolor matrices for RPi Cameras","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Ben,\n\nThank you for your work.\n\nOn Fri, 7 Jul 2023 at 14:41, Ben Benson via libcamera-devel\n wrote:\n>\n> Altered the color matrices for the tuning files for various\n> cameras in order to make them more color accurate.\n>\n> Signed-off-by Ben Benson \n\nReviewed-by: Naushir Patuck \n\n> ---\n> src/ipa/rpi/vc4/data/imx219.json | 66 ++++-------\n> src/ipa/rpi/vc4/data/imx296.json | 160 +++++---------------------\n> src/ipa/rpi/vc4/data/imx477.json | 93 ++++-----------\n> src/ipa/rpi/vc4/data/imx708.json | 139 ++++------------------\n> src/ipa/rpi/vc4/data/imx708_wide.json | 49 ++++----\n> src/ipa/rpi/vc4/data/ov5647.json | 66 ++++-------\n> 6 files changed, 147 insertions(+), 426 deletions(-)\n>\n> diff --git a/src/ipa/rpi/vc4/data/imx219.json b/src/ipa/rpi/vc4/data/imx219.json\n> index efe7210a..e8fce164 100644\n> --- a/src/ipa/rpi/vc4/data/imx219.json\n> +++ b/src/ipa/rpi/vc4/data/imx219.json\n> @@ -405,75 +405,57 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2498,\n> + \"ct\": 2860,\n> \"ccm\":\n> [\n> - 1.58731, -0.18011, -0.40721,\n> - -0.60639, 2.03422, -0.42782,\n> - -0.19612, -1.69203, 2.88815\n> + 2.12089, -0.52461, -0.59629,\n> + -0.85342, 2.80445, -0.95103,\n> + -0.26897, -1.14788, 2.41685\n> ]\n> },\n> {\n> - \"ct\": 2811,\n> + \"ct\": 2960,\n> \"ccm\":\n> [\n> - 1.61593, -0.33164, -0.28429,\n> - -0.55048, 1.97779, -0.42731,\n> - -0.12042, -1.42847, 2.54889\n> + 2.26962, -0.54174, -0.72789,\n> + -0.77008, 2.60271, -0.83262,\n> + -0.26036, -1.51254, 2.77289\n> ]\n> },\n> {\n> - \"ct\": 2911,\n> + \"ct\": 3603,\n> \"ccm\":\n> [\n> - 1.62771, -0.41282, -0.21489,\n> - -0.57991, 2.04176, -0.46186,\n> - -0.07613, -1.13359, 2.20972\n> + 2.18644, -0.66148, -0.52496,\n> + -0.77828, 2.69474, -0.91645,\n> + -0.25239, -0.83059, 2.08298\n> ]\n> },\n> {\n> - \"ct\": 2919,\n> + \"ct\": 4650,\n> \"ccm\":\n> [\n> - 1.62661, -0.37736, -0.24925,\n> - -0.52519, 1.95233, -0.42714,\n> - -0.10842, -1.34929, 2.45771\n> + 2.18174, -0.70887, -0.47287,\n> + -0.70196, 2.76426, -1.06231,\n> + -0.25157, -0.71978, 1.97135\n> ]\n> },\n> {\n> - \"ct\": 3627,\n> + \"ct\": 5858,\n> \"ccm\":\n> [\n> - 1.70385, -0.57231, -0.13154,\n> - -0.47763, 1.85998, -0.38235,\n> - -0.07467, -0.82678, 1.90145\n> + 2.32392, -0.88421, -0.43971,\n> + -0.63821, 2.58348, -0.94527,\n> + -0.28541, -0.54112, 1.82653\n> ]\n> },\n> {\n> - \"ct\": 4600,\n> + \"ct\": 7580,\n> \"ccm\":\n> [\n> - 1.68486, -0.61085, -0.07402,\n> - -0.41927, 2.04016, -0.62089,\n> - -0.08633, -0.67672, 1.76305\n> - ]\n> - },\n> - {\n> - \"ct\": 5716,\n> - \"ccm\":\n> - [\n> - 1.80439, -0.73699, -0.06739,\n> - -0.36073, 1.83327, -0.47255,\n> - -0.08378, -0.56403, 1.64781\n> - ]\n> - },\n> - {\n> - \"ct\": 8575,\n> - \"ccm\":\n> - [\n> - 1.89357, -0.76427, -0.12931,\n> - -0.27399, 2.15605, -0.88206,\n> - -0.12035, -0.68256, 1.80292\n> + 2.21175, -0.53242, -0.67933,\n> + -0.57875, 3.07922, -1.50047,\n> + -0.27709, -0.73338, 2.01048\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/imx296.json b/src/ipa/rpi/vc4/data/imx296.json\n> index 9330d0a9..7621f759 100644\n> --- a/src/ipa/rpi/vc4/data/imx296.json\n> +++ b/src/ipa/rpi/vc4/data/imx296.json\n> @@ -357,174 +357,66 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2000,\n> + \"ct\": 2500,\n> \"ccm\":\n> [\n> - 1.48716, -0.1877, -0.35079,\n> - -0.48577, 1.55088, -0.03387,\n> - 0.24919, -1.4583, 2.12083\n> - ]\n> - },\n> - {\n> - \"ct\": 2200,\n> - \"ccm\":\n> - [\n> - 1.53439, -0.28852, -0.29392,\n> - -0.44748, 1.56295, -0.08907,\n> - 0.23529, -1.30488, 1.99784\n> - ]\n> - },\n> - {\n> - \"ct\": 2400,\n> - \"ccm\":\n> - [\n> - 1.57619, -0.36904, -0.25181,\n> - -0.41654, 1.57046, -0.13192,\n> - 0.21678, -1.18352, 1.90786\n> - ]\n> - },\n> - {\n> - \"ct\": 2600,\n> - \"ccm\":\n> - [\n> - 1.61348, -0.43497, -0.2198,\n> - -0.39075, 1.5753, -0.1665,\n> - 0.19789, -1.08592, 1.83942\n> + 1.95054, -0.57435, -0.37619,\n> + -0.46945, 1.86661, -0.39716,\n> + 0.07977, -1.14072, 2.06095\n> ]\n> },\n> {\n> \"ct\": 2800,\n> \"ccm\":\n> [\n> - 1.64717, -0.49009, -0.1951,\n> - -0.36881, 1.57852, -0.1952,\n> - 0.18016, -1.00609, 1.78575\n> - ]\n> - },\n> - {\n> - \"ct\": 3000,\n> - \"ccm\":\n> - [\n> - 1.67798, -0.53693, -0.17591,\n> - -0.34986, 1.58074, -0.21955,\n> - 0.16406, -0.9398, 1.74261\n> - ]\n> - },\n> - {\n> - \"ct\": 3200,\n> - \"ccm\":\n> - [\n> - 1.70647, -0.5773, -0.161,\n> - -0.33332, 1.58235, -0.24056,\n> - 0.14961, -0.88398, 1.70721\n> - ]\n> - },\n> - {\n> - \"ct\": 3400,\n> - \"ccm\":\n> - [\n> - 1.73305, -0.61248, -0.14951,\n> - -0.31875, 1.58355, -0.25894,\n> - 0.13671, -0.83642, 1.67769\n> + 1.94104, -0.60261, -0.33844,\n> + -0.43162, 1.85422, -0.42261,\n> + 0.03799, -0.95022, 1.91222\n> ]\n> },\n> {\n> - \"ct\": 3600,\n> + \"ct\": 2900,\n> \"ccm\":\n> [\n> - 1.75802, -0.64343, -0.14077,\n> - -0.30581, 1.5845, -0.27518,\n> - 0.12518, -0.79546, 1.65271\n> + 1.91828, -0.59569, -0.32258,\n> + -0.51902, 2.09091, -0.57189,\n> + -0.03324, -0.73462, 1.76785\n> ]\n> },\n> {\n> - \"ct\": 4100,\n> + \"ct\": 3620,\n> \"ccm\":\n> [\n> - 1.78116, -0.67459, -0.13048,\n> - -0.26859, 1.58692, -0.31929,\n> - 0.11915, -0.77931, 1.64012\n> + 1.97199, -0.66403, -0.30797,\n> + -0.46411, 2.02612, -0.56201,\n> + -0.07764, -0.61178, 1.68942\n> ]\n> },\n> {\n> - \"ct\": 4600,\n> + \"ct\": 4560,\n> \"ccm\":\n> [\n> - 1.83867, -0.73605, -0.12044,\n> - -0.24947, 1.58699, -0.34207,\n> - 0.09949, -0.71041, 1.59842\n> - ]\n> - },\n> - {\n> - \"ct\": 5100,\n> - \"ccm\":\n> - [\n> - 1.88967, -0.78455, -0.11744,\n> - -0.23398, 1.58806, -0.36172,\n> - 0.08362, -0.6574, 1.56728\n> + 2.15256, -0.84787, -0.30469,\n> + -0.48422, 2.28962, -0.80541,\n> + -0.15113, -0.53014, 1.68127\n> ]\n> },\n> {\n> \"ct\": 5600,\n> \"ccm\":\n> [\n> - 1.93485, -0.82318, -0.1191,\n> - -0.22108, 1.58973, -0.37892,\n> - 0.07074, -0.61609, 1.54362\n> - ]\n> - },\n> - {\n> - \"ct\": 6100,\n> - \"ccm\":\n> - [\n> - 1.97481, -0.85423, -0.12371,\n> - -0.21015, 1.59169, -0.39406,\n> - 0.06021, -0.58353, 1.52536\n> - ]\n> - },\n> - {\n> - \"ct\": 6600,\n> - \"ccm\":\n> - [\n> - 2.01029, -0.87946, -0.13017,\n> - -0.20074, 1.59378, -0.4075,\n> - 0.05146, -0.55732, 1.51096\n> - ]\n> - },\n> - {\n> - \"ct\": 7100,\n> - \"ccm\":\n> - [\n> - 2.04183, -0.9002, -0.13765,\n> - -0.19255, 1.59586, -0.41944,\n> - 0.04414, -0.53603, 1.49947\n> - ]\n> - },\n> - {\n> - \"ct\": 7600,\n> - \"ccm\":\n> - [\n> - 2.07001, -0.91744, -0.14566,\n> - -0.18534, 1.59788, -0.43013,\n> - 0.03791, -0.51841, 1.49013\n> - ]\n> - },\n> - {\n> - \"ct\": 8100,\n> - \"ccm\":\n> - [\n> - 2.09534, -0.93195, -0.15388,\n> - -0.17893, 1.59981, -0.43974,\n> - 0.03256, -0.50364, 1.48243\n> + 2.04576, -0.74771, -0.29805,\n> + -0.36332, 1.98993, -0.62662,\n> + -0.09328, -0.46543, 1.55871\n> ]\n> },\n> {\n> - \"ct\": 8600,\n> + \"ct\": 7400,\n> \"ccm\":\n> [\n> - 2.11799, -0.94416, -0.16203,\n> - -0.17324, 1.60161, -0.44836,\n> - 0.02795, -0.4912, 1.47604\n> + 2.37532, -0.83069, -0.54462,\n> + -0.48279, 2.84309, -1.36031,\n> + -0.21178, -0.66532, 1.87709\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/imx477.json b/src/ipa/rpi/vc4/data/imx477.json\n> index daffc268..0e39d419 100644\n> --- a/src/ipa/rpi/vc4/data/imx477.json\n> +++ b/src/ipa/rpi/vc4/data/imx477.json\n> @@ -410,102 +410,57 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2360,\n> + \"ct\": 2850,\n> \"ccm\":\n> [\n> - 1.66078, -0.23588, -0.42491,\n> - -0.47456, 1.82763, -0.35307,\n> - -0.00545, -1.44729, 2.45273\n> + 1.97469, -0.71439, -0.26031,\n> + -0.43521, 2.09769, -0.66248,\n> + -0.04826, -0.84642, 1.89468\n> ]\n> },\n> {\n> - \"ct\": 2870,\n> - \"ccm\":\n> - [\n> - 1.78373, -0.55344, -0.23029,\n> - -0.39951, 1.69701, -0.29751,\n> - 0.01986, -1.06525, 2.04539\n> - ]\n> - },\n> - {\n> - \"ct\": 2970,\n> - \"ccm\":\n> - [\n> - 1.73511, -0.56973, -0.16537,\n> - -0.36338, 1.69878, -0.33539,\n> - -0.02354, -0.76813, 1.79168\n> - ]\n> - },\n> - {\n> - \"ct\": 3000,\n> - \"ccm\":\n> - [\n> - 2.06374, -0.92218, -0.14156,\n> - -0.41721, 1.69289, -0.27568,\n> - -0.00554, -0.92741, 1.93295\n> - ]\n> - },\n> - {\n> - \"ct\": 3700,\n> - \"ccm\":\n> - [\n> - 2.13792, -1.08136, -0.05655,\n> - -0.34739, 1.58989, -0.24249,\n> - -0.00349, -0.76789, 1.77138\n> - ]\n> - },\n> - {\n> - \"ct\": 3870,\n> - \"ccm\":\n> - [\n> - 1.83834, -0.70528, -0.13307,\n> - -0.30499, 1.60523, -0.30024,\n> - -0.05701, -0.58313, 1.64014\n> - ]\n> - },\n> - {\n> - \"ct\": 4000,\n> + \"ct\": 2960,\n> \"ccm\":\n> [\n> - 2.15741, -1.10295, -0.05447,\n> - -0.34631, 1.61158, -0.26528,\n> - -0.02723, -0.70288, 1.73011\n> + 2.12952, -0.91185, -0.21768,\n> + -0.38018, 1.90789, -0.52771,\n> + 0.03988, -1.10079, 2.06092\n> ]\n> },\n> {\n> - \"ct\": 4400,\n> + \"ct\": 3580,\n> \"ccm\":\n> [\n> - 2.05729, -0.95007, -0.10723,\n> - -0.41712, 1.78606, -0.36894,\n> - -0.11899, -0.55727, 1.67626\n> + 2.03422, -0.80048, -0.23374,\n> + -0.39089, 1.97221, -0.58132,\n> + -0.08969, -0.61439, 1.70408\n> ]\n> },\n> {\n> - \"ct\": 4715,\n> + \"ct\": 4559,\n> \"ccm\":\n> [\n> - 1.90255, -0.77478, -0.12777,\n> - -0.31338, 1.88197, -0.56858,\n> - -0.06001, -0.61785, 1.67786\n> + 2.15423, -0.98143, -0.17279,\n> + -0.38131, 2.14763, -0.76632,\n> + -0.10069, -0.54383, 1.64452\n> ]\n> },\n> {\n> - \"ct\": 5920,\n> + \"ct\": 5881,\n> \"ccm\":\n> [\n> - 1.98691, -0.84671, -0.14019,\n> - -0.26581, 1.70615, -0.44035,\n> - -0.09532, -0.47332, 1.56864\n> + 2.18464, -0.95493, -0.22971,\n> + -0.36826, 2.00298, -0.63471,\n> + -0.15219, -0.38055, 1.53274\n> ]\n> },\n> {\n> - \"ct\": 9050,\n> + \"ct\": 7600,\n> \"ccm\":\n> [\n> - 2.09255, -0.76541, -0.32714,\n> - -0.28973, 2.27462, -0.98489,\n> - -0.17299, -0.61275, 1.78574\n> + 2.30687, -0.97295, -0.33392,\n> + -0.30872, 2.32779, -1.01908,\n> + -0.17761, -0.55891, 1.73651\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/imx708.json b/src/ipa/rpi/vc4/data/imx708.json\n> index 6b26d0a1..c40a5994 100644\n> --- a/src/ipa/rpi/vc4/data/imx708.json\n> +++ b/src/ipa/rpi/vc4/data/imx708.json\n> @@ -368,147 +368,48 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2498,\n> + \"ct\": 2964,\n> \"ccm\":\n> [\n> - 1.14912, 0.28638, -0.43551,\n> - -0.49691, 1.60391, -0.10701,\n> - -0.10513, -1.09534, 2.20047\n> + 1.72129, -0.45961, -0.26169,\n> + -0.30042, 1.56924, -0.26882,\n> + 0.15133, -1.13293, 1.98161\n> ]\n> },\n> {\n> - \"ct\": 2821,\n> + \"ct\": 3610,\n> \"ccm\":\n> [\n> - 1.18251, 0.15501, -0.33752,\n> - -0.44304, 1.58495, -0.14191,\n> - -0.05077, -0.96422, 2.01498\n> + 1.54474, -0.35082, -0.19391,\n> + -0.36989, 1.67926, -0.30936,\n> + -0.00524, -0.55197, 1.55722\n> ]\n> },\n> {\n> - \"ct\": 2925,\n> + \"ct\": 4640,\n> \"ccm\":\n> [\n> - 1.18668, 0.00195, -0.18864,\n> - -0.41617, 1.50514, -0.08897,\n> - -0.02675, -0.91143, 1.93818\n> + 1.52972, -0.35168, -0.17804,\n> + -0.28309, 1.67098, -0.38788,\n> + 0.01695, -0.57209, 1.55515\n> ]\n> },\n> {\n> - \"ct\": 2926,\n> + \"ct\": 5910,\n> \"ccm\":\n> [\n> - 1.50948, -0.44421, -0.06527,\n> - -0.37241, 1.41726, -0.04486,\n> - 0.07098, -0.84694, 1.77596\n> + 1.56879, -0.42159, -0.14719,\n> + -0.27275, 1.59354, -0.32079,\n> + -0.02862, -0.40662, 1.43525\n> ]\n> },\n> {\n> - \"ct\": 2951,\n> + \"ct\": 7590,\n> \"ccm\":\n> [\n> - 1.52743, -0.47333, -0.05411,\n> - -0.36485, 1.40764, -0.04279,\n> - 0.08672, -0.90479, 1.81807\n> - ]\n> - },\n> - {\n> - \"ct\": 2954,\n> - \"ccm\":\n> - [\n> - 1.51683, -0.46841, -0.04841,\n> - -0.36288, 1.39914, -0.03625,\n> - 0.06421, -0.82034, 1.75613\n> - ]\n> - },\n> - {\n> - \"ct\": 3578,\n> - \"ccm\":\n> - [\n> - 1.59888, -0.59105, -0.00784,\n> - -0.29366, 1.32037, -0.02671,\n> - 0.06627, -0.76465, 1.69838\n> - ]\n> - },\n> - {\n> - \"ct\": 3717,\n> - \"ccm\":\n> - [\n> - 1.59063, -0.58059, -0.01003,\n> - -0.29583, 1.32715, -0.03132,\n> - 0.03613, -0.67431, 1.63817\n> - ]\n> - },\n> - {\n> - \"ct\": 3784,\n> - \"ccm\":\n> - [\n> - 1.59379, -0.58861, -0.00517,\n> - -0.29178, 1.33292, -0.04115,\n> - 0.03541, -0.66162, 1.62622\n> - ]\n> - },\n> - {\n> - \"ct\": 4485,\n> - \"ccm\":\n> - [\n> - 1.40761, -0.34561, -0.06201,\n> - -0.32388, 1.57221, -0.24832,\n> - -0.01014, -0.63427, 1.64441\n> - ]\n> - },\n> - {\n> - \"ct\": 4615,\n> - \"ccm\":\n> - [\n> - 1.41537, -0.35832, -0.05705,\n> - -0.31429, 1.56019, -0.24591,\n> - -0.01761, -0.61859, 1.63621\n> - ]\n> - },\n> - {\n> - \"ct\": 4671,\n> - \"ccm\":\n> - [\n> - 1.42941, -0.38178, -0.04764,\n> - -0.31421, 1.55925, -0.24504,\n> - -0.01141, -0.62987, 1.64129\n> - ]\n> - },\n> - {\n> - \"ct\": 5753,\n> - \"ccm\":\n> - [\n> - 1.64549, -0.63329, -0.01221,\n> - -0.22431, 1.36423, -0.13992,\n> - -0.00831, -0.55373, 1.56204\n> - ]\n> - },\n> - {\n> - \"ct\": 5773,\n> - \"ccm\":\n> - [\n> - 1.63668, -0.63557, -0.00111,\n> - -0.21919, 1.36234, -0.14315,\n> - -0.00399, -0.57428, 1.57827\n> - ]\n> - },\n> - {\n> - \"ct\": 7433,\n> - \"ccm\":\n> - [\n> - 1.36007, -0.09277, -0.26729,\n> - -0.36886, 2.09249, -0.72363,\n> - -0.12573, -0.76761, 1.89334\n> - ]\n> - },\n> - {\n> - \"ct\": 55792,\n> - \"ccm\":\n> - [\n> - 1.65091, -0.63689, -0.01401,\n> - -0.22277, 1.35752, -0.13475,\n> - -0.00943, -0.55091, 1.56033\n> + 1.41424, -0.21092, -0.20332,\n> + -0.17646, 1.71734, -0.54087,\n> + 0.01297, -0.63111, 1.61814\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/imx708_wide.json b/src/ipa/rpi/vc4/data/imx708_wide.json\n> index 14bc918e..65543628 100644\n> --- a/src/ipa/rpi/vc4/data/imx708_wide.json\n> +++ b/src/ipa/rpi/vc4/data/imx708_wide.json\n> @@ -358,48 +358,57 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2750,\n> + \"ct\": 2868,\n> \"ccm\":\n> [\n> - 1.13004, 0.36392, -0.49396,\n> - -0.45885, 1.68171, -0.22286,\n> - -0.06473, -0.86962, 1.93435\n> + 1.58923, -0.36649, -0.22273,\n> + -0.43591, 1.84858, -0.41268,\n> + 0.02948, -0.77666, 1.74718\n> ]\n> },\n> {\n> - \"ct\": 2940,\n> + \"ct\": 2965,\n> \"ccm\":\n> [\n> - 1.29876, 0.09627, -0.39503,\n> - -0.43085, 1.60258, -0.17172,\n> - -0.02638, -0.92581, 1.95218\n> + 1.73397, -0.42794, -0.30603,\n> + -0.36504, 1.72431, -0.35926,\n> + 0.12765, -1.10933, 1.98168\n> ]\n> },\n> {\n> - \"ct\": 3650,\n> + \"ct\": 3603,\n> \"ccm\":\n> [\n> - 1.57729, -0.29734, -0.27995,\n> - -0.42965, 1.66231, -0.23265,\n> - -0.02183, -0.62331, 1.64514\n> + 1.61787, -0.42704, -0.19084,\n> + -0.37819, 1.74588, -0.36769,\n> + 0.00961, -0.59807, 1.58847\n> ]\n> },\n> {\n> - \"ct\": 4625,\n> + \"ct\": 4620,\n> \"ccm\":\n> [\n> - 1.52145, -0.22382, -0.29763,\n> - -0.40445, 1.82186, -0.41742,\n> - -0.05732, -0.56222, 1.61954\n> + 1.55581, -0.35422, -0.20158,\n> + -0.31805, 1.79309, -0.47505,\n> + -0.01256, -0.54489, 1.55746\n> ]\n> },\n> {\n> - \"ct\": 5715,\n> + \"ct\": 5901,\n> \"ccm\":\n> [\n> - 1.67851, -0.39193, -0.28658,\n> - -0.37169, 1.72949, -0.35781,\n> - -0.09556, -0.41951, 1.51508\n> + 1.64439, -0.48855, -0.15585,\n> + -0.29149, 1.67122, -0.37972,\n> + -0.03111, -0.44052, 1.47163\n> + ]\n> + },\n> + {\n> + \"ct\": 7610,\n> + \"ccm\":\n> + [\n> + 1.48667, -0.26072, -0.22595,\n> + -0.21815, 1.86724, -0.64909,\n> + -0.00985, -0.64485, 1.65471\n> ]\n> }\n> ]\n> diff --git a/src/ipa/rpi/vc4/data/ov5647.json b/src/ipa/rpi/vc4/data/ov5647.json\n> index d770e44f..a1b42a18 100644\n> --- a/src/ipa/rpi/vc4/data/ov5647.json\n> +++ b/src/ipa/rpi/vc4/data/ov5647.json\n> @@ -406,75 +406,57 @@\n> {\n> \"ccms\": [\n> {\n> - \"ct\": 2500,\n> + \"ct\": 2873,\n> \"ccm\":\n> [\n> - 1.70741, -0.05307, -0.65433,\n> - -0.62822, 1.68836, -0.06014,\n> - -0.04452, -1.87628, 2.92079\n> + 1.88195, -0.26249, -0.61946,\n> + -0.63842, 2.11535, -0.47693,\n> + -0.13531, -0.99739, 2.13271\n> ]\n> },\n> {\n> - \"ct\": 2803,\n> + \"ct\": 2965,\n> \"ccm\":\n> [\n> - 1.74383, -0.18731, -0.55652,\n> - -0.56491, 1.67772, -0.11281,\n> - -0.01522, -1.60635, 2.62157\n> + 2.15048, -0.51859, -0.63189,\n> + -0.53572, 1.92585, -0.39013,\n> + 0.01831, -1.48576, 2.46744\n> ]\n> },\n> {\n> - \"ct\": 2912,\n> + \"ct\": 3606,\n> \"ccm\":\n> [\n> - 1.75215, -0.22221, -0.52995,\n> - -0.54568, 1.63522, -0.08954,\n> - 0.02633, -1.56997, 2.54364\n> + 1.97522, -0.43847, -0.53675,\n> + -0.56151, 1.99765, -0.43614,\n> + -0.12438, -0.77056, 1.89493\n> ]\n> },\n> {\n> - \"ct\": 2914,\n> + \"ct\": 4700,\n> \"ccm\":\n> [\n> - 1.72423, -0.28939, -0.43484,\n> - -0.55188, 1.62925, -0.07737,\n> - 0.01959, -1.28661, 2.26702\n> + 2.00971, -0.51461, -0.49511,\n> + -0.52109, 2.01003, -0.48894,\n> + -0.09527, -0.67318, 1.76845\n> ]\n> },\n> {\n> - \"ct\": 3605,\n> + \"ct\": 5890,\n> \"ccm\":\n> [\n> - 1.80381, -0.43646, -0.36735,\n> - -0.46505, 1.56814, -0.10309,\n> - 0.00929, -1.00424, 1.99495\n> + 2.13616, -0.65283, -0.48333,\n> + -0.48364, 1.93115, -0.44751,\n> + -0.13465, -0.54831, 1.68295\n> ]\n> },\n> {\n> - \"ct\": 4540,\n> + \"ct\": 7600,\n> \"ccm\":\n> [\n> - 1.85263, -0.46545, -0.38719,\n> - -0.44136, 1.68443, -0.24307,\n> - 0.04108, -0.85599, 1.81491\n> - ]\n> - },\n> - {\n> - \"ct\": 5699,\n> - \"ccm\":\n> - [\n> - 1.98595, -0.63542, -0.35054,\n> - -0.34623, 1.54146, -0.19522,\n> - 0.00411, -0.70936, 1.70525\n> - ]\n> - },\n> - {\n> - \"ct\": 8625,\n> - \"ccm\":\n> - [\n> - 2.21637, -0.56663, -0.64974,\n> - -0.41133, 1.96625, -0.55492,\n> - -0.02307, -0.83529, 1.85837\n> + 2.06599, -0.39161, -0.67439,\n> + -0.50883, 2.27467, -0.76583,\n> + -0.13961, -0.66121, 1.80081\n> ]\n> }\n> ]\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C74F9BDC71\n\tfor ;\n\tWed, 12 Jul 2023 12:12:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F32D9628C0;\n\tWed, 12 Jul 2023 14:12:20 +0200 (CEST)","from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com\n\t[IPv6:2607:f8b0:4864:20::1129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C68D4628BB\n\tfor ;\n\tWed, 12 Jul 2023 14:12:18 +0200 (CEST)","by mail-yw1-x1129.google.com with SMTP id\n\t00721157ae682-579de633419so74155107b3.3\n\tfor ;\n\tWed, 12 Jul 2023 05:12:18 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689163941;\n\tbh=sRXJuWn2Y5yiYtWhn0GodOH15bWnwyWRwT8XeIvxZaE=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZtNLRfaAVX71/QdI+Dkrz9tSP9aZix1zTCEkGJgEiIHCLc9JYTN/DInsAPWIp1tse\n\twp+RnY4KgYzegh7mfj/m+fqlfOzTWnBCrSQlHmuTLFA5mM9ag3Y9kCs6HVXytQ+pTO\n\tkF4kXtJ4rq/qZ5/nMJ9dzrN+XO6fcfCZ1CEAXZrB5RqTb187eVb+DtJz2HnG/rP/VX\n\tgyLD4hq1a+cnqknzStDXX0CYRJ9jTB/Vi+vpK1z34qlYPzCd35OVJ3ie0VVixwpdML\n\tmWe9xc2Vyx/bzElsof+2+/+gOcGouYQw3SGX7NTTwwPiKoCfAF+K0/RxMPLECslrZc\n\t9jrVH6hGzuCKQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1689163937; x=1691755937;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ooDhlPR0qd9quMxa5x6wujuTSWwZ5FJLXQK6iq1DjaE=;\n\tb=hAb0QDlFxMj15Dzq13UWujpyO8YKyswOjTctBA1TrjuB3kDdZzxcV1CWhKit2uSuK8\n\tK6HW09uWVur7nVE1JxlYmFSKmeEfUBPUFKe/UE8NQ2/GM8Q4uSB0V7VM0l1MV1VJc/Do\n\tSHlFN9UgK06f2bC56qWV9X2pJj7I5gyzzNKBAxfwHKGFAWqLo8ANwDZrM8Vqk78nm+eD\n\t1z47iUJ3JC1dyakQNTmtoBoFvFjKwZxxw54BWzQ1FCySx/tf3IrQVGLMdEPD3r09143m\n\tNaTrnnhbztmyzHHPwdWo2W2njaj1btTgVqwT8xJDb2dbr55HXu5lta27A7mcaYWnBBxp\n\tbBtg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"hAb0QDlF\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1689163937; x=1691755937;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=ooDhlPR0qd9quMxa5x6wujuTSWwZ5FJLXQK6iq1DjaE=;\n\tb=Ny20CqpxLcKJJdl9UqrU0YPwQ+t1dGZ0Uxl/UveQF8Q4xJ0AKe9BkPOu/VSU6u/D0D\n\t0D/t5E1E+jMUv83VejamK0mMysyHCKl1d4JsPgL+36fyl6ArpmTdrljgz+mvZHLTfKS3\n\tjJJMfw3cbbhSCl9TOgxFr9n66OJuGoLkCvHFFo4WhRGO9frfT6A+l151/Oa3bNaLucqN\n\thFqvTmCFmaEkeO4LFrhWJdJWMVe7w7++n9ePWmfy5b1Fsx6huum/I/V40t3fbFZO/rWH\n\tm0lKgFOkLK3E253YCniz3+uAQnyBziehk+FD5HKXW4IMcR4uIfn/OLTMHcDZX4nYdOb4\n\tLmbQ==","X-Gm-Message-State":"ABy/qLZYjs6ZDX1iRhnvRQ4yiFBx86AIjAm4HCQFc5NoDkM4TC2yn2ww\n\tdA4NTEjbn54feFMzanTMzc0jdK/rqO96NgsxrdqJL/7F/UJfwkrc0ew=","X-Google-Smtp-Source":"APBJJlGY8c5wm5j3Kc2/DEh8KJ4A81H3S/OvrmcVp/jFiYczFz37VDSsn7TUFPU5miRLIRqhpwH0bMnx26MZciEhxA4=","X-Received":"by 2002:a81:7d8b:0:b0:55a:574f:327c with SMTP id\n\ty133-20020a817d8b000000b0055a574f327cmr17067946ywc.13.1689163937397;\n\tWed, 12 Jul 2023 05:12:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20230706013926.218131-1-ben.benson@raspberrypi.com>\n\t<20230706013926.218131-3-ben.benson@raspberrypi.com>","In-Reply-To":"<20230706013926.218131-3-ben.benson@raspberrypi.com>","Date":"Wed, 12 Jul 2023 13:12:02 +0100","Message-ID":"","To":"Ben Benson ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 2/3] ipa: rpi: vc4: data: Updated\n\tcolor matrices for RPi Cameras","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]