[{"id":27508,"web_url":"https://patchwork.libcamera.org/comment/27508/","msgid":"","date":"2023-07-07T10:49:06","subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: imx296_mono: Disable all\n\tcolour shading","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for the patch!\n\nOn Fri, 7 Jul 2023 at 11:37, Naushir Patuck wrote:\n>\n> Colour shading should be turned off for the mono variant of the IMX296\n> sensor. To do this, set all the colour gain coefficients to 1.\n>\n> Signed-off-by: Naushir Patuck \n\nYes, I'm sure this is the right answer.\n\nReviewed-by: David Plowman \n\nThanks\nDavid\n\n> ---\n> src/ipa/rpi/vc4/data/imx296_mono.json | 48 +++++++++++++--------------\n> 1 file changed, 24 insertions(+), 24 deletions(-)\n>\n> diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\n> index 955af43cccff..d4140c81bf0d 100644\n> --- a/src/ipa/rpi/vc4/data/imx296_mono.json\n> +++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n> @@ -123,18 +123,18 @@\n> \"ct\": 4000,\n> \"table\":\n> [\n> - 2.554, 2.554, 2.541, 2.534, 2.495, 2.506, 2.516, 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n> - 2.522, 2.534, 2.539, 2.531, 2.531, 2.506, 2.506, 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n> - 2.509, 2.517, 2.534, 2.529, 2.531, 2.521, 2.517, 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n> - 2.507, 2.508, 2.517, 2.516, 2.495, 2.487, 2.519, 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n> - 2.509, 2.517, 2.507, 2.501, 2.494, 2.519, 2.539, 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n> - 2.521, 2.522, 2.476, 2.501, 2.501, 2.539, 2.546, 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n> - 2.516, 2.519, 2.469, 2.499, 2.499, 2.543, 2.543, 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n> - 2.509, 2.515, 2.465, 2.487, 2.487, 2.539, 2.543, 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n> - 2.499, 2.499, 2.475, 2.482, 2.471, 2.509, 2.539, 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n> - 2.499, 2.488, 2.488, 2.488, 2.471, 2.462, 2.509, 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n> - 2.483, 2.484, 2.488, 2.488, 2.502, 2.496, 2.508, 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n> - 2.483, 2.487, 2.478, 2.478, 2.507, 2.509, 2.514, 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> ]\n> }\n> ],\n> @@ -143,18 +143,18 @@\n> \"ct\": 4000,\n> \"table\":\n> [\n> - 2.619, 2.603, 2.599, 2.597, 2.595, 2.594, 2.589, 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n> - 2.619, 2.615, 2.603, 2.601, 2.596, 2.595, 2.591, 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n> - 2.617, 2.617, 2.612, 2.611, 2.604, 2.598, 2.593, 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n> - 2.624, 2.619, 2.615, 2.612, 2.605, 2.602, 2.597, 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n> - 2.629, 2.627, 2.627, 2.617, 2.609, 2.598, 2.612, 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n> - 2.629, 2.632, 2.637, 2.627, 2.612, 2.612, 2.629, 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n> - 2.635, 2.636, 2.642, 2.628, 2.623, 2.623, 2.636, 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n> - 2.641, 2.639, 2.646, 2.632, 2.627, 2.625, 2.632, 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n> - 2.643, 2.644, 2.651, 2.649, 2.629, 2.617, 2.624, 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n> - 2.645, 2.646, 2.649, 2.649, 2.638, 2.624, 2.616, 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n> - 2.641, 2.643, 2.649, 2.647, 2.638, 2.618, 2.615, 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n> - 2.638, 2.637, 2.647, 2.634, 2.634, 2.618, 2.621, 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> ]\n> }\n> ],\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B54B2BDC71\n\tfor ;\n\tFri, 7 Jul 2023 10:49:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F06DB628C0;\n\tFri, 7 Jul 2023 12:49:19 +0200 (CEST)","from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com\n\t[IPv6:2607:f8b0:4864:20::f2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAC1F61E34\n\tfor ;\n\tFri, 7 Jul 2023 12:49:18 +0200 (CEST)","by mail-qv1-xf2d.google.com with SMTP id\n\t6a1803df08f44-6378cec43ddso11486036d6.2\n\tfor ;\n\tFri, 07 Jul 2023 03:49:18 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688726960;\n\tbh=kbJNwjPL0vhoy9HWKcZXyqPLuK7/gtbeXw3vBSLuYWI=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xGhCCl340558hil/bHaGp8OQcvIRMO1Yyse84xz2SZ5AL7Ly0Pnid5OauNb0J1JuQ\n\tWTxHu4zYar4lqyQYlMQpmHLFmBZAFY145GiABvzf06SG9ZzCnFMvaOZwjs5uRvb4ku\n\tCIp6p/LuQ+mCO+UUtuLcfGvp30QVgIH21QCfZVNGHECsBu61T81Z/NFgdfXx94BEW4\n\t/sCiitp6pP5EUfmvgAk1C+E0DYh9DImCX0qU1aEKYgMz9Bpi/vTYCh5TNiplVd8X/+\n\tLpyIMEV9cSasfIpaXAuRuRX/UrH77Ex6V7pS5nUvWKinqAehCSeD4hip1CuRaRdjAs\n\tcFtupC8H0OtRw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1688726957; x=1691318957;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=0Xkw8NLYrnRbR55r7KDqenMvJuwQUZgkx/NUG4sL36s=;\n\tb=hvKT1ShuGaKZQaER2zyZCq+HUitJqaGezTL1o+x21AuXs9Ich6hVb3a3xn0jwESxTZ\n\tzUgoAQP4Kb3JG76r5/dgpQdBYOpksCqGJLG8hNMXP1+5Bnm5W3Ib2MqV8o7MKQlL0ehH\n\t8KC5MCOEbhvgjeRbSnBc5ctXcS8X9rMumBeBA+fYuk+WzfomT6LgZERuYGCA2B7s5DEd\n\tsz92CXAhCM9zH+hYTfcZ7Trzit4f5Qsbtnia6LUDFbBNcJPYAWAqXG27d1xrNkLesgpq\n\tkbQw75dwa08bvrw5kIGbevIEVMgCrQ5hncw0jwIKxJ0Hn62lhsAz1JInBNwyjWl3OWc2\n\t6wPg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"hvKT1Shu\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1688726957; x=1691318957;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=0Xkw8NLYrnRbR55r7KDqenMvJuwQUZgkx/NUG4sL36s=;\n\tb=CGV04DUsQnZu8ggU0/z0h8ftMXyfey4w3+RJcbm364DI02TNFQZincO/qIOjdUR4Qr\n\td8oIHmhBNvP9yVEJjMDvLdUtr36gZn/HtdYiBoOc89eUL0LMKMgECKvP1v/IqKiw0cU9\n\tKa0uTo7Z/Y0V3fQpeVCZEMbY1yXbavE2rTGStXuJjMclzFi2jNfeFt7fSvfS5fvnco/E\n\t4zH5hAYshEZqjS4rjNWvwEULLity71hOpLs0aJCyjFAq1s/7/9dv5hrtZbZwmrQGx/V1\n\tkU0NcwCKhdPoWlDyeTW23aHWYEzpY9yfW3o9HEOQ30XS65TRzHYuK+vn9VbXiFA1Np3f\n\tyu4w==","X-Gm-Message-State":"ABy/qLYrhBIp56C+y0QThinreVFb7GjijUjb9RAlCmnq/DyAqcHe79Rh\n\t0BD93UADfpkM6+DkAjEJBhVJhIiyCHvy1jP5uQi9rgiH4J7jPUvxTKTBJA==","X-Google-Smtp-Source":"APBJJlGo0D6NbD1DYl79rlciQVgMkZZHePvjGY4RVN6EnK2SyRB3Tp/QW8qXV8//iNrnZgAZuKvIogI1tMddQohS3Z4=","X-Received":"by 2002:a0c:8ccc:0:b0:631:f210:85dc with SMTP id\n\tq12-20020a0c8ccc000000b00631f21085dcmr3524818qvb.64.1688726957452;\n\tFri, 07 Jul 2023 03:49:17 -0700 (PDT)","MIME-Version":"1.0","References":"<20230707103727.17578-1-naush@raspberrypi.com>","In-Reply-To":"<20230707103727.17578-1-naush@raspberrypi.com>","Date":"Fri, 7 Jul 2023 11:49:06 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: imx296_mono: Disable all\n\tcolour shading","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27509,"web_url":"https://patchwork.libcamera.org/comment/27509/","msgid":"","date":"2023-07-07T11:03:31","subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: imx296_mono: Disable all\n\tcolour shading","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Adding Nick for a review as well.\n\nOn Fri, 7 Jul 2023 at 11:37, Naushir Patuck wrote:\n>\n> Colour shading should be turned off for the mono variant of the IMX296\n> sensor. To do this, set all the colour gain coefficients to 1.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/rpi/vc4/data/imx296_mono.json | 48 +++++++++++++--------------\n> 1 file changed, 24 insertions(+), 24 deletions(-)\n>\n> diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\n> index 955af43cccff..d4140c81bf0d 100644\n> --- a/src/ipa/rpi/vc4/data/imx296_mono.json\n> +++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n> @@ -123,18 +123,18 @@\n> \"ct\": 4000,\n> \"table\":\n> [\n> - 2.554, 2.554, 2.541, 2.534, 2.495, 2.506, 2.516, 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n> - 2.522, 2.534, 2.539, 2.531, 2.531, 2.506, 2.506, 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n> - 2.509, 2.517, 2.534, 2.529, 2.531, 2.521, 2.517, 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n> - 2.507, 2.508, 2.517, 2.516, 2.495, 2.487, 2.519, 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n> - 2.509, 2.517, 2.507, 2.501, 2.494, 2.519, 2.539, 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n> - 2.521, 2.522, 2.476, 2.501, 2.501, 2.539, 2.546, 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n> - 2.516, 2.519, 2.469, 2.499, 2.499, 2.543, 2.543, 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n> - 2.509, 2.515, 2.465, 2.487, 2.487, 2.539, 2.543, 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n> - 2.499, 2.499, 2.475, 2.482, 2.471, 2.509, 2.539, 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n> - 2.499, 2.488, 2.488, 2.488, 2.471, 2.462, 2.509, 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n> - 2.483, 2.484, 2.488, 2.488, 2.502, 2.496, 2.508, 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n> - 2.483, 2.487, 2.478, 2.478, 2.507, 2.509, 2.514, 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> ]\n> }\n> ],\n> @@ -143,18 +143,18 @@\n> \"ct\": 4000,\n> \"table\":\n> [\n> - 2.619, 2.603, 2.599, 2.597, 2.595, 2.594, 2.589, 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n> - 2.619, 2.615, 2.603, 2.601, 2.596, 2.595, 2.591, 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n> - 2.617, 2.617, 2.612, 2.611, 2.604, 2.598, 2.593, 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n> - 2.624, 2.619, 2.615, 2.612, 2.605, 2.602, 2.597, 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n> - 2.629, 2.627, 2.627, 2.617, 2.609, 2.598, 2.612, 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n> - 2.629, 2.632, 2.637, 2.627, 2.612, 2.612, 2.629, 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n> - 2.635, 2.636, 2.642, 2.628, 2.623, 2.623, 2.636, 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n> - 2.641, 2.639, 2.646, 2.632, 2.627, 2.625, 2.632, 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n> - 2.643, 2.644, 2.651, 2.649, 2.629, 2.617, 2.624, 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n> - 2.645, 2.646, 2.649, 2.649, 2.638, 2.624, 2.616, 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n> - 2.641, 2.643, 2.649, 2.647, 2.638, 2.618, 2.615, 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n> - 2.638, 2.637, 2.647, 2.634, 2.634, 2.618, 2.621, 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n> + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n> ]\n> }\n> ],\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3CC13C323E\n\tfor ;\n\tFri, 7 Jul 2023 11:03:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90C2D628BC;\n\tFri, 7 Jul 2023 13:03:51 +0200 (CEST)","from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com\n\t[IPv6:2607:f8b0:4864:20::112f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 776AB61E34\n\tfor ;\n\tFri, 7 Jul 2023 13:03:49 +0200 (CEST)","by mail-yw1-x112f.google.com with SMTP id\n\t00721157ae682-57023c9be80so21078077b3.3\n\tfor ;\n\tFri, 07 Jul 2023 04:03:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688727831;\n\tbh=O1syrKD9EyNKrFH9NSWDsf4q6f92OHKZ0dw0vaCSBs0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=WKVEdUS79exu58RXTBeykUKrR+13lIKE2mOXP6nB6cte/2Zgd6TxC7qByL9VtKX3C\n\tEyfcwAZAukgicwlLtMH8Vg7MlPKl8VY8SgEfwnJIjmc3FFT+Hqdspwsh639JeXINWT\n\tvy4lWyd6BBOUPu0maE5xw9j/UYa0lCu0aw9Z7SgTwHox6cneZ7uHGIXkV3ejAEYoVH\n\t4g93XbQvs/AtGghkfMSbAyH/ZXwL3Y4vPeoSyoctc40TWo+TiXSxpr1zAQkW4vR9uk\n\t7oyIjkC40J9lfEBcF1kNNxHQCBa4zaWdMNdWhPTjtY7huM53Ckad+rlQ5M/G9EkKXi\n\tKG/6o8JGsqfsQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1688727828; x=1691319828;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=kiR1wY117XL3PzHYdKqM5yWGYsgKyZWBYo7zjiB4KgQ=;\n\tb=m+cO8JAS3y4/7KIe8gvsAqbykMHxlJR9Lp78dPFVCxMYYkIhDfjRNyL/cjLSuNqmO2\n\tVcFUyPK4M5WusNOI5LutgI3a/SquwDstkzgazS/v1DLgIDUlAvQqxf6GysmeEpZq5DZF\n\tHzTaCb6xRKp75i/Slt2iU4cuBSiVU+hhPCvtSU8l6NvN20fQr3t8zwCFvnj1fVo0+KIQ\n\tOSENfkXdvsx2kl02dAvRHcOmRzcW0y/diSYwEIkjdMP+dsAZR8wM6RhIQEZ6ijtiy0x7\n\tkQTp07z378TGp2aqAjbUA/kFIJehZytNm4pUpbhFzzSQ96G78NhJ1ChoYfFd3X7ARJPS\n\t1bgA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"m+cO8JAS\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1688727828; x=1691319828;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=kiR1wY117XL3PzHYdKqM5yWGYsgKyZWBYo7zjiB4KgQ=;\n\tb=cxbEDal3s66FOQB4JTtOUa7tN1jaW4aGuEs6WD3l9O5H4UIBxRqH1y8mCcYyP/9A1S\n\tCgKmL01fN1CkI81uU14dwQb8cGHCEdWfKKkgtHJ3aVMF5OQUCa729aaJPlwB7wtBDvrT\n\tbWzLwopLjn5Hu8YJPu4oMUQnb+r5pQzBsm36Buw/ETtuxLt/sbId7HyOlc6QEKzESLTt\n\tucdT0Ht4TDL+Xx7IS0UbfqWrnc2AT84yD4K2W1PfkgEjqjfGcMJ5KcsCK3ZSa/SA22RT\n\tn6Me/Wzsa32Wp3+yx9bblHAYLVhe24O8DYnLytup7GVLSaJ4BfXavwuQ+iehD/xjZ8iV\n\tlWQw==","X-Gm-Message-State":"ABy/qLbMpPH89KRgppnBWRehObX+yKhPihq9g/gVN1dhaN8Ingz3Cn3w\n\t5+QKq1Dy6NJ2SAmgBAEqJNL0dINe6IGGBxhNDksW/eGj+PKf/L8VRjxB3w==","X-Google-Smtp-Source":"APBJJlEmiARtrYVBDm87KFR/oLP9jXfhwgtjOrI6DllGEgN0wuEaCqGZuQbcwDaetPIp7Hslv2+zFyLkaEQ6ZoXRmA8=","X-Received":"by 2002:a0d:eb42:0:b0:562:1850:bbf0 with SMTP id\n\tu63-20020a0deb42000000b005621850bbf0mr5080791ywe.21.1688727827925;\n\tFri, 07 Jul 2023 04:03:47 -0700 (PDT)","MIME-Version":"1.0","References":"<20230707103727.17578-1-naush@raspberrypi.com>","In-Reply-To":"<20230707103727.17578-1-naush@raspberrypi.com>","Date":"Fri, 7 Jul 2023 12:03:31 +0100","Message-ID":"","To":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: imx296_mono: Disable all\n\tcolour shading","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"Nick Hollinghurst ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27511,"web_url":"https://patchwork.libcamera.org/comment/27511/","msgid":"","date":"2023-07-07T12:21:54","subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: imx296_mono: Disable all\n\tcolour shading","submitter":{"id":130,"url":"https://patchwork.libcamera.org/api/people/130/","name":"Nick Hollinghurst","email":"nick.hollinghurst@raspberrypi.com"},"content":"Thanks, Naush\n\nThis is clearly the right thing to do for a mono sensor, to avoid scaling\nit as Bayer, which previously introduced checkerboard artifacts.\n(The error was small, because the smallest value for each component gets\nnormalized to 1.0 and the variation was not large, but was still quite\nvisible in JPEGs.)\n\nReviewed-by: Nick Hollinghurst \n\n Nick\n\nOn Fri, 7 Jul 2023 at 12:03, Naushir Patuck wrote:\n>\n> Adding Nick for a review as well.\n>\n> On Fri, 7 Jul 2023 at 11:37, Naushir Patuck wrote:\n> >\n> > Colour shading should be turned off for the mono variant of the IMX296\n> > sensor. To do this, set all the colour gain coefficients to 1.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/rpi/vc4/data/imx296_mono.json | 48 +++++++++++++--------------\n> > 1 file changed, 24 insertions(+), 24 deletions(-)\n> >\n> > diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json\nb/src/ipa/rpi/vc4/data/imx296_mono.json\n> > index 955af43cccff..d4140c81bf0d 100644\n> > --- a/src/ipa/rpi/vc4/data/imx296_mono.json\n> > +++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n> > @@ -123,18 +123,18 @@\n> > \"ct\": 4000,\n> > \"table\":\n> > [\n> > - 2.554, 2.554, 2.541, 2.534, 2.495, 2.506,\n2.516, 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n> > - 2.522, 2.534, 2.539, 2.531, 2.531, 2.506,\n2.506, 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n> > - 2.509, 2.517, 2.534, 2.529, 2.531, 2.521,\n2.517, 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n> > - 2.507, 2.508, 2.517, 2.516, 2.495, 2.487,\n2.519, 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n> > - 2.509, 2.517, 2.507, 2.501, 2.494, 2.519,\n2.539, 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n> > - 2.521, 2.522, 2.476, 2.501, 2.501, 2.539,\n2.546, 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n> > - 2.516, 2.519, 2.469, 2.499, 2.499, 2.543,\n2.543, 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n> > - 2.509, 2.515, 2.465, 2.487, 2.487, 2.539,\n2.543, 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n> > - 2.499, 2.499, 2.475, 2.482, 2.471, 2.509,\n2.539, 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n> > - 2.499, 2.488, 2.488, 2.488, 2.471, 2.462,\n2.509, 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n> > - 2.483, 2.484, 2.488, 2.488, 2.502, 2.496,\n2.508, 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n> > - 2.483, 2.487, 2.478, 2.478, 2.507, 2.509,\n2.514, 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1\n> > ]\n> > }\n> > ],\n> > @@ -143,18 +143,18 @@\n> > \"ct\": 4000,\n> > \"table\":\n> > [\n> > - 2.619, 2.603, 2.599, 2.597, 2.595, 2.594,\n2.589, 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n> > - 2.619, 2.615, 2.603, 2.601, 2.596, 2.595,\n2.591, 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n> > - 2.617, 2.617, 2.612, 2.611, 2.604, 2.598,\n2.593, 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n> > - 2.624, 2.619, 2.615, 2.612, 2.605, 2.602,\n2.597, 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n> > - 2.629, 2.627, 2.627, 2.617, 2.609, 2.598,\n2.612, 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n> > - 2.629, 2.632, 2.637, 2.627, 2.612, 2.612,\n2.629, 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n> > - 2.635, 2.636, 2.642, 2.628, 2.623, 2.623,\n2.636, 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n> > - 2.641, 2.639, 2.646, 2.632, 2.627, 2.625,\n2.632, 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n> > - 2.643, 2.644, 2.651, 2.649, 2.629, 2.617,\n2.624, 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n> > - 2.645, 2.646, 2.649, 2.649, 2.638, 2.624,\n2.616, 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n> > - 2.641, 2.643, 2.649, 2.647, 2.638, 2.618,\n2.615, 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n> > - 2.638, 2.637, 2.647, 2.634, 2.634, 2.618,\n2.621, 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1,\n> > + 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n1, 1\n> > ]\n> > }\n> > ],\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 371AAC323E\n\tfor ;\n\tFri, 7 Jul 2023 12:22:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97E6A628C0;\n\tFri, 7 Jul 2023 14:22:07 +0200 (CEST)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n\t[IPv6:2a00:1450:4864:20::633])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FF55628BD\n\tfor ;\n\tFri, 7 Jul 2023 14:22:05 +0200 (CEST)","by mail-ej1-x633.google.com with SMTP id\n\ta640c23a62f3a-9923833737eso209418266b.3\n\tfor ;\n\tFri, 07 Jul 2023 05:22:05 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688732527;\n\tbh=mHaNmFO3N0sfz8T3H7KHEUr8ZA15DXVLu987H3gsJn0=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=v3kJQA9FTCjAu0IefIvoN5TSv0p922LrKOk2U50qAVArsgKUsaHMk04PUj3tILn46\n\tXRyj+8ai7grfPIr+m3aPwBCkGJKekLxYuDNxjjazQR6EWlKZLC+PL8ZN1kyRaUFtQM\n\ts4X0Zrgx8LV/rbNwWQsj0ARb/W7Zm1NbHKID1/DRVCJ+QToTdv9FHQnJf4BgAPvi5R\n\t2wkZcKXZ0Q/obG7LzavVU9KoEKS1had9wJa1OQLdGr33QX9f/89dHuhFXq3ru+apd8\n\tV85XC4WlLwDAk3AG/CkuWBYTLzyWy54po/6uMbpvqgX3k1+PABuNz+cFtEwc88HZhr\n\tSXaDxjrWRUe6g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1688732525; x=1691324525;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=y+BkUjDG1UdN+nfM9lCgXWwxq1MshHEsMJkKIVUYGTo=;\n\tb=eZFyZxhn0qbV7Ped/PXbgeg5hUGanyLbZFBoC//As5e6wkMGfXnabs8Im/qC238fpR\n\tZUHXmPpk6kOtdYqpU1EoOmsTNfADD0zCYrcQKBnLybNbnML+b9z2t+PJbyn61Ng8AQHx\n\tmKbOVn2+qv3ZPf9Kh3MMKzIAS4G5aQjtFC7WbxNykC9qPhf0ph53AsvUQC/Fcjkf34pf\n\t5AzjNcrvzgZfvKGgr2145t7+59zNxLXjyVRq9SaW3P0m9ZEf1ovMp1w6Q0sj1UJzg8Ms\n\ttiErLvccDdkTAftmNlqDHl0CUJf/9g4MmUwdyKADaR43caYky8236E4W3Wlyeu2AnVsb\n\tL7Og=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"eZFyZxhn\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1688732525; x=1691324525;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=y+BkUjDG1UdN+nfM9lCgXWwxq1MshHEsMJkKIVUYGTo=;\n\tb=O7SHTIOcqh/1VGFSHaiFjVxdFgHiWpMx0ExS6+whPB/ltGC7gHN8AlY98o5/fS8m0t\n\tZxZxzcKlLJkj8kDXYsOlpw/2yclhttVexV+T4b0xKe8MMz5NDa0qwVTR1x7PuyOwOfD4\n\tuF/qhQJCyindBC/HJV7M7keaPkERRhEOXarSjwzlshRx47nmpDFZWtXZdQJQqc1P1xRU\n\tC2Max/nCAG06JqDHpaRu+ThPaMyC46RK4GQEsB3Z5dBlnGEGL6Yckmknys3z3XzOUbeg\n\tRe3TIT/2AOU9a5f7R6znKThw4i6Qg8EGmt/nvR0RkrFp6WMk9ji8BSlm8KLMrZki4xcD\n\t9f4Q==","X-Gm-Message-State":"ABy/qLYEQafILXVvjUdzWXkRbCidjNchI1BvM/zzGUy2xsCPIGeqGpFO\n\tNbi9ul/BznTTjckN3Ud3oHIhvUUCPXR2cTjmzBBriA==","X-Google-Smtp-Source":"APBJJlGcyAgzI270SP3X/DjmJJuG0X3kKwV6ijkQ1IjkcqwayrKWIoZQpYQsdQtt3dMTL/r9hRsJFCQzd4Yrfd34Jog=","X-Received":"by 2002:a17:907:900f:b0:989:34a0:45b0 with SMTP id\n\tay15-20020a170907900f00b0098934a045b0mr4358182ejc.49.1688732525121;\n\tFri, 07 Jul 2023 05:22:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20230707103727.17578-1-naush@raspberrypi.com>\n\t","In-Reply-To":"","Date":"Fri, 7 Jul 2023 13:21:54 +0100","Message-ID":"","To":"Naushir Patuck ","Content-Type":"multipart/alternative; boundary=\"00000000000047fbf905ffe4ae7a\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: rpi: imx296_mono: Disable all\n\tcolour shading","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Nick Hollinghurst via libcamera-devel\n\t","Reply-To":"Nick Hollinghurst ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]