{"id":18798,"url":"https://patchwork.libcamera.org/api/patches/18798/?format=json","web_url":"https://patchwork.libcamera.org/patch/18798/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20230707103727.17578-1-naush@raspberrypi.com>","date":"2023-07-07T10:37:27","name":"[libcamera-devel] ipa: rpi: imx296_mono: Disable all colour shading","commit_ref":"22cc8bc25dae4b1457c852a7fb633526672d7032","pull_url":null,"state":"accepted","archived":false,"hash":"5c2162ab067cfbc829f19a2fc728fadb6e7e4788","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/18798/mbox/","series":[{"id":3962,"url":"https://patchwork.libcamera.org/api/series/3962/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3962","date":"2023-07-07T10:37:27","name":"[libcamera-devel] ipa: rpi: imx296_mono: Disable all colour shading","version":1,"mbox":"https://patchwork.libcamera.org/series/3962/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/18798/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/18798/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1404C323E\n\tfor ;\n\tFri, 7 Jul 2023 10:37:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25B83628BD;\n\tFri, 7 Jul 2023 12:37:48 +0200 (CEST)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0616C628BC\n\tfor ;\n\tFri, 7 Jul 2023 12:37:47 +0200 (CEST)","by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-3fbc0981755so18712665e9.1\n\tfor ;\n\tFri, 07 Jul 2023 03:37:46 -0700 (PDT)","from localhost.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tw22-20020a1cf616000000b003faef96ee78sm2048958wmc.33.2023.07.07.03.37.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 07 Jul 2023 03:37:45 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688726268;\n\tbh=hvqQYJlnQSDjXrnd5xnHqib5aEJlBOl73kQ743QlBEE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=tptTiJzUh86/CuwaB998WoSRDFOe65TPQxCgBppRXr8oqhCVrqBTYfPNXclB0kHoE\n\tRxcjj59zWNidAahcIZV5zEgvcRDxTX7DecCqHVDjC/ga2M/HwtGkpIt0F21ZlEk6i1\n\tNU/Yc5W8jFjWmp/8SfVCup7k2+E6fkX2cv4YTCu16jgRppIoG59vFnDEHCZ6YFqo0l\n\tqvS+RA2S85HRuOhRUwimFZ2dRFLcjGhAa0Juvb020mEP1u8Gz9Qq4n9Pxca7ARW6P+\n\tStsv7PWMZboH0jJIu6vIemWQnky5WzS0L5LH2D4A7cliqjtaFGk8trg3n+oScYgKfg\n\tl/iDHOSpq5n4g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1688726266; x=1691318266;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=vUn1c69QAlK1Dcrp8NyNy/mHh74n58hCFFIJXtPNqxg=;\n\tb=XzWW+Zftl/yARtChCmFdgczjj24hJxQLihcFdOvBxyLqbRr/WpSgRKnVnYmp8A9FSs\n\tSZPGf7aDklKIRJmWd2Vy29PQDY/+qidXlnF1sewFYfDhh+EhhI6O5qV7I1TyVY8QWL29\n\tQzOeaiHXYC9SfhKiH3CSM5F9qrFOtJXK/4wYrW/kH6lQZSKQmNHCSIY0ZeC69cU7K8IO\n\toaO2Z+Tqnr6monOdNskOjGB9MBG40G1ab+5rubQVzYOE+9IDlabzQx1+o1s9q+B8tPoC\n\tI7TXcnA6W9Qqm3GZoPsZ1qBkvv5/kRmRz0dBo1JcDVr35kIsmurTBaBgWzNZmnBLzCpV\n\tsPVQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"XzWW+Zft\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1688726266; x=1691318266;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=vUn1c69QAlK1Dcrp8NyNy/mHh74n58hCFFIJXtPNqxg=;\n\tb=gQXAn6Ym55JpTMuWhrmBb8KcSkiJTpOIXuDA+Zr7Eq3MAsbR86ralU21d9CWt1qhwg\n\tqSs9YRb1HR239MGfNPnFD8e1DPF5jmfLCdCcdJ4XHbZCbjmfgg4WmPzSekTInGGGUBQK\n\tmpVYJO1zAzjWGDU145fgh90xlzrnZzyulut84rYQfqgQhpI+rW36H7F+z/9o9hxm1ksf\n\tVlUB9Xt+iypa5A6iPLS/Jw3QxA7Ai8tXzSp5LNWf1sIAMOdPV9wmYKC7WtdRgEgnyk30\n\tU5NcdfZ4zexFL/MBJ8CNgyRL5GWCpIOTUBGl4znzC6c+dIZHhlQtx76sBIwd+QI/3C9n\n\tn+Bg==","X-Gm-Message-State":"ABy/qLZA93wuxAK9eKddcm4Nl1Ps2S5eShkB/Tb/Ghhx2EIY2ji/Hyeo\n\tjv3okPItp+qbaKw5SiiZ02tii2SfHaa2niicPgm4tfAO","X-Google-Smtp-Source":"APBJJlHw3ACznfhMkZbNwxtX/2fs02iYDzI3+e+46lvJJsvDsanWW6PVRmF0vKrswToQPJlS613e/w==","X-Received":"by 2002:a7b:c44b:0:b0:3fb:fef3:53f8 with SMTP id\n\tl11-20020a7bc44b000000b003fbfef353f8mr1257830wmi.25.1688726266340; \n\tFri, 07 Jul 2023 03:37:46 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 7 Jul 2023 11:37:27 +0100","Message-Id":"<20230707103727.17578-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] ipa: rpi: imx296_mono: Disable all colour\n\tshading","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Colour shading should be turned off for the mono variant of the IMX296\nsensor. To do this, set all the colour gain coefficients to 1.\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/rpi/vc4/data/imx296_mono.json | 48 +++++++++++++--------------\n 1 file changed, 24 insertions(+), 24 deletions(-)","diff":"diff --git a/src/ipa/rpi/vc4/data/imx296_mono.json b/src/ipa/rpi/vc4/data/imx296_mono.json\nindex 955af43cccff..d4140c81bf0d 100644\n--- a/src/ipa/rpi/vc4/data/imx296_mono.json\n+++ b/src/ipa/rpi/vc4/data/imx296_mono.json\n@@ -123,18 +123,18 @@\n \"ct\": 4000,\n \"table\":\n [\n- 2.554, 2.554, 2.541, 2.534, 2.495, 2.506, 2.516, 2.517, 2.518, 2.515, 2.513, 2.495, 2.481, 2.533, 2.533, 2.521,\n- 2.522, 2.534, 2.539, 2.531, 2.531, 2.506, 2.506, 2.513, 2.513, 2.509, 2.498, 2.496, 2.508, 2.517, 2.521, 2.521,\n- 2.509, 2.517, 2.534, 2.529, 2.531, 2.521, 2.517, 2.517, 2.515, 2.514, 2.506, 2.499, 2.508, 2.508, 2.521, 2.537,\n- 2.507, 2.508, 2.517, 2.516, 2.495, 2.487, 2.519, 2.534, 2.535, 2.531, 2.499, 2.494, 2.501, 2.511, 2.526, 2.526,\n- 2.509, 2.517, 2.507, 2.501, 2.494, 2.519, 2.539, 2.539, 2.537, 2.537, 2.533, 2.499, 2.503, 2.511, 2.529, 2.525,\n- 2.521, 2.522, 2.476, 2.501, 2.501, 2.539, 2.546, 2.538, 2.531, 2.538, 2.541, 2.531, 2.529, 2.526, 2.529, 2.525,\n- 2.516, 2.519, 2.469, 2.499, 2.499, 2.543, 2.543, 2.531, 2.528, 2.534, 2.541, 2.535, 2.531, 2.526, 2.531, 2.528,\n- 2.509, 2.515, 2.465, 2.487, 2.487, 2.539, 2.543, 2.539, 2.533, 2.549, 2.542, 2.531, 2.529, 2.524, 2.532, 2.533,\n- 2.499, 2.499, 2.475, 2.482, 2.471, 2.509, 2.539, 2.544, 2.543, 2.545, 2.533, 2.498, 2.521, 2.521, 2.537, 2.536,\n- 2.499, 2.488, 2.488, 2.488, 2.471, 2.462, 2.509, 2.539, 2.539, 2.532, 2.498, 2.498, 2.518, 2.518, 2.539, 2.539,\n- 2.483, 2.484, 2.488, 2.488, 2.502, 2.496, 2.508, 2.514, 2.518, 2.517, 2.521, 2.518, 2.518, 2.518, 2.525, 2.539,\n- 2.483, 2.487, 2.478, 2.478, 2.507, 2.509, 2.514, 2.513, 2.514, 2.517, 2.536, 2.559, 2.501, 2.501, 2.503, 2.525\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n ]\n }\n ],\n@@ -143,18 +143,18 @@\n \"ct\": 4000,\n \"table\":\n [\n- 2.619, 2.603, 2.599, 2.597, 2.595, 2.594, 2.589, 2.587, 2.586, 2.589, 2.592, 2.597, 2.601, 2.608, 2.621, 2.621,\n- 2.619, 2.615, 2.603, 2.601, 2.596, 2.595, 2.591, 2.589, 2.589, 2.592, 2.599, 2.593, 2.601, 2.613, 2.622, 2.631,\n- 2.617, 2.617, 2.612, 2.611, 2.604, 2.598, 2.593, 2.591, 2.592, 2.591, 2.593, 2.595, 2.599, 2.614, 2.623, 2.631,\n- 2.624, 2.619, 2.615, 2.612, 2.605, 2.602, 2.597, 2.596, 2.592, 2.592, 2.595, 2.599, 2.602, 2.606, 2.619, 2.624,\n- 2.629, 2.627, 2.627, 2.617, 2.609, 2.598, 2.612, 2.623, 2.615, 2.604, 2.589, 2.595, 2.599, 2.608, 2.611, 2.614,\n- 2.629, 2.632, 2.637, 2.627, 2.612, 2.612, 2.629, 2.631, 2.628, 2.621, 2.604, 2.597, 2.598, 2.604, 2.609, 2.609,\n- 2.635, 2.636, 2.642, 2.628, 2.623, 2.623, 2.636, 2.636, 2.634, 2.628, 2.616, 2.599, 2.597, 2.601, 2.603, 2.601,\n- 2.641, 2.639, 2.646, 2.632, 2.627, 2.625, 2.632, 2.635, 2.634, 2.627, 2.614, 2.596, 2.595, 2.599, 2.599, 2.598,\n- 2.643, 2.644, 2.651, 2.649, 2.629, 2.617, 2.624, 2.629, 2.625, 2.614, 2.586, 2.599, 2.595, 2.597, 2.592, 2.595,\n- 2.645, 2.646, 2.649, 2.649, 2.638, 2.624, 2.616, 2.617, 2.609, 2.604, 2.603, 2.603, 2.595, 2.589, 2.587, 2.592,\n- 2.641, 2.643, 2.649, 2.647, 2.638, 2.618, 2.615, 2.608, 2.602, 2.595, 2.596, 2.595, 2.593, 2.584, 2.581, 2.583,\n- 2.638, 2.637, 2.647, 2.634, 2.634, 2.618, 2.621, 2.621, 2.611, 2.602, 2.596, 2.583, 2.581, 2.581, 2.576, 2.574\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,\n+ 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1\n ]\n }\n ],\n","prefixes":["libcamera-devel"]}