[{"id":27505,"web_url":"https://patchwork.libcamera.org/comment/27505/","msgid":"<20230706191122.GA3489@pendragon.ideasonboard.com>","date":"2023-07-06T19:11:22","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jai,\n\nThank you for the patch.\n\nOn Thu, Jul 06, 2023 at 11:44:47PM +0530, Jai Luthra wrote:\n> New TI SoCs from J7 and AM62 family have a camera pipeline that receives\n> data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing \"shim\"\n> IP routes this incoming stream of data to the DMA subsystem, to finally\n> store the frame data in memory.\n> \n> The driver for this is not merged in mainline yet, but v7 was posted [1]\n> on linux-media list a few months ago.\n> \n> With some minor fixes, the work-in-progress v8 series [2] works with the\n> simple pipeline handler, so we enable support for this device.\n> \n> Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1]\n> Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2]\n> Signed-off-by: Jai Luthra \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> I am planning to post the v8 series for review upstream in the coming few \n> weeks.\n> \n> Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt\n> \n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 7495587c..05ba76bc 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -192,6 +192,7 @@ namespace {\n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"dcmipp\", {} },\n> \t{ \"imx7-csi\", { { \"pxp\", 1 } } },\n> +\t{ \"j721e-csi2rx\", {} },\n> \t{ \"mxc-isi\", {} },\n> \t{ \"qcom-camss\", {} },\n> \t{ \"sun6i-csi\", {} },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A349BDC71\n\tfor ;\n\tThu, 6 Jul 2023 19:11:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9E2A628C0;\n\tThu, 6 Jul 2023 21:11:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F79161E36\n\tfor ;\n\tThu, 6 Jul 2023 21:11:25 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-150-194-nat.elisa-mobile.fi\n\t[85.76.150.194])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 01CF28C1;\n\tThu, 6 Jul 2023 21:10:38 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688670686;\n\tbh=N6KPw/XHgRWZaSsyd5n4y7NwsdahAGtYh3HQ88RQjyU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=0qt8wy642VDwgQE3djVFbD+RMJNrVLor5/+XfpXENliieoUggac2dIyhMK1Pscn6X\n\tmIAr6xd6erqrtv0bKBE8EV3ra06l8bZ+wA0NEtc1ujJSIav4raJymFxQnNnIcaJ2Qi\n\tB/FAKBk9e24iRCsmXGtNUGulpC26zrCvR0GD7GwXzy/4p9pTfZBOhxIQsQhmI6aLpo\n\tUYNfhbExhuFsfphvoS2e3/KrlaT+V2rpnuOR6KolZK4FGieSrcyb1JUkfcjvTVbzY2\n\to8xbVbsHMkXONS5Wep9m2xKX2wv+5/iv3VpAEKnvAJD+H0K+kDEd52gHGrY3ho2sv1\n\tls9ZVXenQ+94w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688670639;\n\tbh=N6KPw/XHgRWZaSsyd5n4y7NwsdahAGtYh3HQ88RQjyU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nl42knSX2lj/mhxFp0Rw1qUwG/+1+6wrvz1p5udj2aE6TgGLJTjz6VEZX2QDUvPyC\n\tF/UPKuWqK/hu6oGnkJFx0RIvuIgFdkNcszn0bFMYfVw1QufKnr9vBvqaS5qKjCBoN9\n\tDj+aXXS1Mb59r9+VFkXTN1HX/14Fj1VOIXKCRUIw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"nl42knSX\"; dkim-atps=neutral","Date":"Thu, 6 Jul 2023 22:11:22 +0300","To":"Jai Luthra ","Message-ID":"<20230706191122.GA3489@pendragon.ideasonboard.com>","References":"<20230706181447.2698499-1-j-luthra@ti.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230706181447.2698499-1-j-luthra@ti.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"Vaishnav Achath , libcamera-devel@lists.libcamera.org,\n\tDevarsh Thakkar ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27506,"web_url":"https://patchwork.libcamera.org/comment/27506/","msgid":"","date":"2023-07-06T19:38:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Nice\nReviewed-by: Jacopo Mondi \n\nOn Thu, Jul 06, 2023 at 11:44:47PM +0530, Jai Luthra via libcamera-devel wrote:\n> New TI SoCs from J7 and AM62 family have a camera pipeline that receives\n> data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing \"shim\"\n> IP routes this incoming stream of data to the DMA subsystem, to finally\n> store the frame data in memory.\n>\n> The driver for this is not merged in mainline yet, but v7 was posted [1]\n> on linux-media list a few months ago.\n>\n> With some minor fixes, the work-in-progress v8 series [2] works with the\n> simple pipeline handler, so we enable support for this device.\n>\n> Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1]\n> Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2]\n> Signed-off-by: Jai Luthra \n> ---\n> I am planning to post the v8 series for review upstream in the coming few\n> weeks.\n>\n> Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt\n>\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 7495587c..05ba76bc 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -192,6 +192,7 @@ namespace {\n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"dcmipp\", {} },\n> \t{ \"imx7-csi\", { { \"pxp\", 1 } } },\n> +\t{ \"j721e-csi2rx\", {} },\n> \t{ \"mxc-isi\", {} },\n> \t{ \"qcom-camss\", {} },\n> \t{ \"sun6i-csi\", {} },\n> --\n> 2.41.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BF56C323E\n\tfor ;\n\tThu, 6 Jul 2023 19:38:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 496A3628C0;\n\tThu, 6 Jul 2023 21:38:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90D2361E36\n\tfor ;\n\tThu, 6 Jul 2023 21:38:32 +0200 (CEST)","from ideasonboard.com (85-160-48-60.reb.o2.cz [85.160.48.60])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9C968C1;\n\tThu, 6 Jul 2023 21:37:46 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1688672314;\n\tbh=L2vPhliQApZsoRVfyx/yHGZALykWzDytzx+Lyr2kvYM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=R6U2RuSCoK1Dp7FS0FKrsthefQ3CDkk4+8VNvXqpjhbfEcyo7LmpilkggaBOhJcda\n\t+nACawxabKP6KgQVnrksIW6Pbw1oTCBu3hRZVqOF4sqS+vcVSIq8/8Gj6vMkIgvaZs\n\t1/Anwwnl2Wr/+gUdmYpmnrqFln6cPI7PVr1JZHy+xVUnnNux9ZVGqysV5vdMCe24bO\n\tajfGc0VeXOVAika5VxWS3pKFzJTVHeZSQjprEUH7u4SCdU+8Mt5cFZn5IOZEZEAS5k\n\t9rhjAhl5qzS7wYx2vlA6EOlbnflTXF6+VWj2pSGoQ0kt2z3udIY+29DO/IO4REtmTI\n\tkNr7GYWLzrybA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1688672266;\n\tbh=L2vPhliQApZsoRVfyx/yHGZALykWzDytzx+Lyr2kvYM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dFJjbCNSAnGtmhT9KEXJWU7Af5GxirQ6WOUX62fgln4v0hvyFSfF9DrbHaAaKuQh7\n\t3MMZdc+IC76e8Voj4AorJe1ojBqF75tExGqs/brFZ8TYLH7LgeNqDsnFw0aRJXE/A1\n\tb3886Y72tFdkmjgDztj+ySzDv0eCJY1fCGJPAj+Y="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dFJjbCNS\"; dkim-atps=neutral","Date":"Thu, 6 Jul 2023 21:38:28 +0200","To":"Jai Luthra ","Message-ID":"","References":"<20230706181447.2698499-1-j-luthra@ti.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20230706181447.2698499-1-j-luthra@ti.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"Vaishnav Achath , libcamera-devel@lists.libcamera.org,\n\tDevarsh Thakkar ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27521,"web_url":"https://patchwork.libcamera.org/comment/27521/","msgid":"<87sf9vkci2.fsf@baylibre.com>","date":"2023-07-10T15:33:09","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","submitter":{"id":153,"url":"https://patchwork.libcamera.org/api/people/153/","name":"Mattijs Korpershoek","email":"mkorpershoek@baylibre.com"},"content":"Hi Jai,\n\nThank you for posting this.\n\nOn jeu., juil. 06, 2023 at 23:44, Jai Luthra via libcamera-devel wrote:\n\n> New TI SoCs from J7 and AM62 family have a camera pipeline that receives\n> data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing \"shim\"\n> IP routes this incoming stream of data to the DMA subsystem, to finally\n> store the frame data in memory.\n>\n> The driver for this is not merged in mainline yet, but v7 was posted [1]\n> on linux-media list a few months ago.\n>\n> With some minor fixes, the work-in-progress v8 series [2] works with the\n> simple pipeline handler, so we enable support for this device.\n>\n> Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1]\n> Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2]\n> Signed-off-by: Jai Luthra \n\nI've been running a similar change on my own fork for AM62x SK EVM with\nAndroid I confirm this works fine.\n\nTested-by: Mattijs Korpershoek # on am62 sk evm\n\n> ---\n> I am planning to post the v8 series for review upstream in the coming few \n> weeks.\n>\n> Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt\n>\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 7495587c..05ba76bc 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -192,6 +192,7 @@ namespace {\n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"dcmipp\", {} },\n> \t{ \"imx7-csi\", { { \"pxp\", 1 } } },\n> +\t{ \"j721e-csi2rx\", {} },\n> \t{ \"mxc-isi\", {} },\n> \t{ \"qcom-camss\", {} },\n> \t{ \"sun6i-csi\", {} },\n> -- \n> 2.41.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1B56BDC71\n\tfor ;\n\tMon, 10 Jul 2023 15:33:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 56CF1628BF;\n\tMon, 10 Jul 2023 17:33:12 +0200 (CEST)","from mail-wr1-x430.google.com (mail-wr1-x430.google.com\n\t[IPv6:2a00:1450:4864:20::430])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E841060384\n\tfor ;\n\tMon, 10 Jul 2023 17:33:10 +0200 (CEST)","by mail-wr1-x430.google.com with SMTP id\n\tffacd0b85a97d-3142a9ff6d8so5020704f8f.3\n\tfor ;\n\tMon, 10 Jul 2023 08:33:10 -0700 (PDT)","from localhost ([2a01:cb19:85e6:1900:2bf7:7388:731d:c4e1])\n\tby smtp.gmail.com with ESMTPSA id\n\tj23-20020a5d4537000000b003141e629cb6sm11964758wra.101.2023.07.10.08.33.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 10 Jul 2023 08:33:10 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689003192;\n\tbh=mY7oG/Hb2OuE64cPOyCNX5G29Dxfw5UGgTc19Bc/vzc=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1m7kPzbl0b74ZJcsBnkHZL2xLTUTBY9wlFWNXHhTW//YAUD1OLmPJSfgbtutUwokO\n\tQ65Y0STbPlRUiZOii20ZL/qZfUGVSKdEqMyXsnUUMhDR2nTMUi2Ix+j+FZDZYfgFrk\n\tys6mbq+cDrsrUwq6A0Jv++GIep4sKeem8WdttDhCc4PG2LhJ7BZvghwjSHnl9GmEOz\n\t34nFROOl1pJjdQCASlEXSPviiMeOY6Kd9KouezqSjDINQzGP3t0Prf6AgIIdQtoqm5\n\t0x6ZOTLkwT+Lq41VdF5YUBvkC+OQxhVBwAIWv89ea6tfVvXGp9vSXFZt3v58NoqPmX\n\tsmgHuoYhCCVFw==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1689003190;\n\tx=1691595190; \n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=qQvb2TWBm1O1u+WTQ8iclzHwEcUDQVGvA1UfcS5OhDY=;\n\tb=kRyidnkukqkKhfCC1+0rTiWVBQl64g1EIGxxJjo2mrBdFSlndKUWXpNDvZeV88KIyx\n\tP0sjn0VUS2gj02QTLVuI9V9P54m69sQMabwlE7BmMM+3/SYbAxoNW4bR3z7ycLg6JXPD\n\tukFsArFs0Un2U9DEoW2eT9SkR6l5aM3opjHhKx5ObKDkx9XPFr+tt+ltJkIcT+bxX6I6\n\t20VgOzKEjLZ3KH/CW0EpLzCaqG/lDmPctO/LP4wvoYbvyA3StEmACxdbqpklNmneusTw\n\tq7bXEnmjLblxpSgz2g06BuxUkhwVlMFeytaujRyCcS5CWedSRPuUiZzgFOI+0Ci0W60X\n\tUfew=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20221208.gappssmtp.com\n\theader.i=@baylibre-com.20221208.gappssmtp.com header.b=\"kRyidnku\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1689003190; x=1691595190;\n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; \n\tbh=qQvb2TWBm1O1u+WTQ8iclzHwEcUDQVGvA1UfcS5OhDY=;\n\tb=HZ73dU6gnhq3J+rLejPUy3sBUihktttodA8LiiHoYeuOYM71rpuJJTWkQuaZ/3D0iN\n\taydlexwd3qDv0raChREkLOlCZVGfSuYlque7Spm8933Ilrdn7PMq9X2F5v5vWQU4JfDr\n\tPBi6wXIuiPYh9Fb55nT/C2zVh1ETCi2Eb6XA35Zj5LxuzLQ4EkwCGW2iCbcUdUT7+8Gg\n\tMNMwzEzHBX8zBhw13WI/ZDjjVepl0bUEIrUC+8TiamguobeV4nbr1lvXKoBNbBLilYAc\n\tRoAFmqmXl+7aJ/vmi3iUdaxdbjyqCgUUSlVORQ4E1/2GK2Ia0AlMcicPvktMwnxF8nFk\n\tgAZw==","X-Gm-Message-State":"ABy/qLY2gxH9lCmd8VkWFQMnk75igHoxty3l/eWyAyGNoqBnFpjNTKnO\n\tvBOa7cgWh87ptRhv+GRXqGs2IQ==","X-Google-Smtp-Source":"APBJJlG6qj4mMkA9W+GmJoV/rQu+856+UVmXyY+L97EQvvHtJkGrNjMdKWMGnJgLsknWGGFMz61cZA==","X-Received":"by 2002:a5d:63c9:0:b0:314:367e:92a1 with SMTP id\n\tc9-20020a5d63c9000000b00314367e92a1mr12294584wrw.18.1689003190455; \n\tMon, 10 Jul 2023 08:33:10 -0700 (PDT)","To":"Jai Luthra , libcamera-devel@lists.libcamera.org","In-Reply-To":"<20230706181447.2698499-1-j-luthra@ti.com>","References":"<20230706181447.2698499-1-j-luthra@ti.com>","Date":"Mon, 10 Jul 2023 17:33:09 +0200","Message-ID":"<87sf9vkci2.fsf@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mattijs Korpershoek via libcamera-devel\n\t","Reply-To":"Mattijs Korpershoek ","Cc":"Vaishnav Achath , Devarsh Thakkar ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27522,"web_url":"https://patchwork.libcamera.org/comment/27522/","msgid":"<168900354843.3585053.5973990212704360064@Monstersaurus>","date":"2023-07-10T15:39:08","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Mattijs,\n\nQuoting Mattijs Korpershoek via libcamera-devel (2023-07-10 16:33:09)\n> Hi Jai,\n> \n> Thank you for posting this.\n> \n> On jeu., juil. 06, 2023 at 23:44, Jai Luthra via libcamera-devel wrote:\n> \n> > New TI SoCs from J7 and AM62 family have a camera pipeline that receives\n> > data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing \"shim\"\n> > IP routes this incoming stream of data to the DMA subsystem, to finally\n> > store the frame data in memory.\n> >\n> > The driver for this is not merged in mainline yet, but v7 was posted [1]\n> > on linux-media list a few months ago.\n> >\n> > With some minor fixes, the work-in-progress v8 series [2] works with the\n> > simple pipeline handler, so we enable support for this device.\n> >\n> > Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1]\n> > Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2]\n> > Signed-off-by: Jai Luthra \n> \n> I've been running a similar change on my own fork for AM62x SK EVM with\n> Android I confirm this works fine.\n> \n> Tested-by: Mattijs Korpershoek # on am62 sk evm\n\nThank you for the Tested-by: tag - that's always very welcome.\n\nI can't add it here though on this occasion I'm afraid as this patch has\nalready been merged.\n\nhttps://git.libcamera.org/libcamera/libcamera.git/commit/?id=954ba8a803c078784dfaa6674e687847f49a1dfb\n\nRegards\n--\nKieran\n\n\n> \n> > ---\n> > I am planning to post the v8 series for review upstream in the coming few \n> > weeks.\n> >\n> > Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt\n> >\n> > src/libcamera/pipeline/simple/simple.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 7495587c..05ba76bc 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -192,6 +192,7 @@ namespace {\n> > static const SimplePipelineInfo supportedDevices[] = {\n> > { \"dcmipp\", {} },\n> > { \"imx7-csi\", { { \"pxp\", 1 } } },\n> > + { \"j721e-csi2rx\", {} },\n> > { \"mxc-isi\", {} },\n> > { \"qcom-camss\", {} },\n> > { \"sun6i-csi\", {} },\n> > -- \n> > 2.41.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CDF9C323E\n\tfor ;\n\tMon, 10 Jul 2023 15:39:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69D3061E31;\n\tMon, 10 Jul 2023 17:39:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A73660384\n\tfor ;\n\tMon, 10 Jul 2023 17:39:12 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net\n\t[82.37.23.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDE5CBEB;\n\tMon, 10 Jul 2023 17:38:23 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689003553;\n\tbh=QuP6GGTXNPEvkmEgglOp36TgLHCGm+K68921gKWXiYo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Xo85r1AlBptVvPE6WRBg+I8SDS5WGXl7kipjzPW0rT11Lno7UF5aqJ6lQbwyJom7k\n\tC1zezmcOWSEMHhRs+md4tx/tDtqvmmjAsYuMhaVjYn/FSu3lV35Qo9UaYzhJuaou/1\n\tJczNuA9TOxFJUW7WkIqzTWQWcW73yBmRUIFKguvmlz4KzgnQTDLUfityolVZRiORl6\n\tN5EULYBXahfRrnkAoUxTFqTJqkiXDD4iTxGEQWuLYCXX0/L0mK+XoSSx2D/nh3Jcfr\n\tK4jLTV4G4jjAv2RBdtQYWM2v1R7Wy2Ja8W/CfinMFIg94tW/EC7OeY5yzL2Db7gdyz\n\tkyaIL6YrqGIuA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1689003503;\n\tbh=QuP6GGTXNPEvkmEgglOp36TgLHCGm+K68921gKWXiYo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=j0oStjpNFn5f0iIutH7ekMngd2bFrQKfgK3BMmAl0QDIcYReg78FN8H1no/leJx9D\n\tgylfLMzaGeILEhuzsDa3zh1w0ti/aDjCGqxBm5D/1hG7vp/LmjU50RUsqYUPDSMtf2\n\tw7ZmLqVgDo57piWVWgamjpVJGb5q89+YRj9W5rUc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"j0oStjpN\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87sf9vkci2.fsf@baylibre.com>","References":"<20230706181447.2698499-1-j-luthra@ti.com>\n\t<87sf9vkci2.fsf@baylibre.com>","To":"Jai Luthra ,\n\tMattijs Korpershoek ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 10 Jul 2023 16:39:08 +0100","Message-ID":"<168900354843.3585053.5973990212704360064@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"Vaishnav Achath , Devarsh Thakkar ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":27524,"web_url":"https://patchwork.libcamera.org/comment/27524/","msgid":"<87v8eqncbo.fsf@baylibre.com>","date":"2023-07-11T07:20:59","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","submitter":{"id":153,"url":"https://patchwork.libcamera.org/api/people/153/","name":"Mattijs Korpershoek","email":"mkorpershoek@baylibre.com"},"content":"Hi Kieran,\n\nOn lun., juil. 10, 2023 at 16:39, Kieran Bingham wrote:\n\n> Hi Mattijs,\n>\n> Quoting Mattijs Korpershoek via libcamera-devel (2023-07-10 16:33:09)\n>> Hi Jai,\n>> \n>> Thank you for posting this.\n>> \n>> On jeu., juil. 06, 2023 at 23:44, Jai Luthra via libcamera-devel wrote:\n>> \n>> > New TI SoCs from J7 and AM62 family have a camera pipeline that receives\n>> > data using Cadence's DPHY-RX and CSI-RX bridge. A pixel-grabbing \"shim\"\n>> > IP routes this incoming stream of data to the DMA subsystem, to finally\n>> > store the frame data in memory.\n>> >\n>> > The driver for this is not merged in mainline yet, but v7 was posted [1]\n>> > on linux-media list a few months ago.\n>> >\n>> > With some minor fixes, the work-in-progress v8 series [2] works with the\n>> > simple pipeline handler, so we enable support for this device.\n>> >\n>> > Link: https://lore.kernel.org/all/20230314115516.667-1-vaishnav.a@ti.com/ [1]\n>> > Link: https://github.com/jailuthra/linux/commits/6ff226ca13f34 [2]\n>> > Signed-off-by: Jai Luthra \n>> \n>> I've been running a similar change on my own fork for AM62x SK EVM with\n>> Android I confirm this works fine.\n>> \n>> Tested-by: Mattijs Korpershoek # on am62 sk evm\n>\n> Thank you for the Tested-by: tag - that's always very welcome.\n>\n> I can't add it here though on this occasion I'm afraid as this patch has\n> already been merged.\n\nI did not check that it was already merged, sorry for the noise.\n\nI understand that it can't be added, no worries.\n\n>\n> https://git.libcamera.org/libcamera/libcamera.git/commit/?id=954ba8a803c078784dfaa6674e687847f49a1dfb\n>\n> Regards\n> --\n> Kieran\n>\n>\n>> \n>> > ---\n>> > I am planning to post the v8 series for review upstream in the coming few \n>> > weeks.\n>> >\n>> > Tested with IMX219 on SK-AM62A (logs): http://0x0.st/H14X.txt\n>> >\n>> > src/libcamera/pipeline/simple/simple.cpp | 1 +\n>> > 1 file changed, 1 insertion(+)\n>> >\n>> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> > index 7495587c..05ba76bc 100644\n>> > --- a/src/libcamera/pipeline/simple/simple.cpp\n>> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> > @@ -192,6 +192,7 @@ namespace {\n>> > static const SimplePipelineInfo supportedDevices[] = {\n>> > { \"dcmipp\", {} },\n>> > { \"imx7-csi\", { { \"pxp\", 1 } } },\n>> > + { \"j721e-csi2rx\", {} },\n>> > { \"mxc-isi\", {} },\n>> > { \"qcom-camss\", {} },\n>> > { \"sun6i-csi\", {} },\n>> > -- \n>> > 2.41.0","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB251BDC71\n\tfor ;\n\tTue, 11 Jul 2023 07:21:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F085D628BF;\n\tTue, 11 Jul 2023 09:21:03 +0200 (CEST)","from mail-lj1-x233.google.com (mail-lj1-x233.google.com\n\t[IPv6:2a00:1450:4864:20::233])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D568161E37\n\tfor ;\n\tTue, 11 Jul 2023 09:21:01 +0200 (CEST)","by mail-lj1-x233.google.com with SMTP id\n\t38308e7fff4ca-2b6b98ac328so81086111fa.0\n\tfor ;\n\tTue, 11 Jul 2023 00:21:01 -0700 (PDT)","from localhost ([82.66.159.240]) by smtp.gmail.com with ESMTPSA id\n\tn13-20020a7bc5cd000000b003fbc30825fbsm1685551wmk.39.2023.07.11.00.21.00\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 11 Jul 2023 00:21:00 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1689060064;\n\tbh=Gv1kmsDZX48Zy9KoDgSGNtXLJZnfqBwyAd5nmpBb3RE=;\n\th=To:In-Reply-To:References:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uo/mTXbfLEJ4FYNcfyT6+pRL1rKdoKztdsuCpa1+4UERmOezGewBxQQN4Sm8i6gyZ\n\t/hOLCot+po/Pd0ysJL1aariUrkuJvO7PRXjmyYxZwVx7OUwj7d75+fNA3o4VeaMSyA\n\tA7VCVsLnllA4MZZztqEpQxM19XU2kvHLOyieEbs7jvFVNNUOXvnXHSl54owizLQId0\n\tIpJJ02gD5vBUybSUYfq4YpJKD50Ol3FitQPF+c87HznyHWvBtsUEPvgl67Jy70vDyH\n\tfLw35EsnkKYuDj0qZvycHOs868YWYFROFSvqFOP9feP4jX6FADEaTaczjHCxjuPRcl\n\tnvko/vUb+lY9g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1689060061;\n\tx=1691652061; \n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=USrntHGmx3+I6QdnO+YkVtKoMh8YKnDfW1ydvQRc/5c=;\n\tb=Z1hOsZkMt4uLLAGeBkhF4X0MnGAINg63+LCzv5Ks8oAFJoVEeSHm2ykbvrdmZsPXDl\n\tVzB3wPgZFL3H4A7eGImBKoOIohJ0rt96fIwXqBVcbR59RWn46IEHySyUAxchsG4UnssT\n\tKoFioYTDi2IKtDs71tau7SzYhAqgb0PQty/4mr26uunSxQsQ+VBpvQjLPzwD5ysQlhFY\n\tEv0raEdLq7wVCU2wS0NDEGSj+GRTd+NCuAQiGdeCigIFv8JxkxfHlpuKe/LSpa3iXc2a\n\taQ8A+h8BE16YzYTqF7MVlgfsXGXL3RUX7W57vvF8orEnhOLawLwmMDqrSQoe0V+4zGIF\n\tVjgA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20221208.gappssmtp.com\n\theader.i=@baylibre-com.20221208.gappssmtp.com header.b=\"Z1hOsZkM\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20221208; t=1689060061; x=1691652061;\n\th=mime-version:message-id:date:references:in-reply-to:subject:cc:to\n\t:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; \n\tbh=USrntHGmx3+I6QdnO+YkVtKoMh8YKnDfW1ydvQRc/5c=;\n\tb=fRra7wPf/gGDVIi3m5B3omL/PJHPweoKSDOFxlYNG+dHR28hDPnZzlUoBpd9x1aJJf\n\tv8tFsCo9Mw3Lp069YF/NUWXZ9dpVkeT2wMu0XjIWg+Q8O4XP+CdWF0vJMu84nYB8hkcp\n\tNz7YzPsaHFjnb8DVvaYtavc1uRjsIsBsiU3nP7hMk+NC6F4tO14WGERNXIGU1JTPzc8U\n\tbIfseqOjoqxkVFmnvA+b+yAJdsYJljJGx/245LX2yHavE+SLNvzS+IMmTjaOd7v2uRBa\n\t3I6HeavrUR7NAAyk8KRBLuMc1U4wTQEZQFtvJdmuxgEIgE66wl516wFrNRJsHJLYwFUR\n\tql4w==","X-Gm-Message-State":"ABy/qLb2QNGBJPCjTw4A8KZQobJ5ecIjGLDOpkpJdubeBaWa/8XndUXO\n\tj/nL4BdzuXBIsMQLIkKGIjv9ng==","X-Google-Smtp-Source":"APBJJlHNyG9W+9gPVUXUwHlTJ7bfHjU+U8+5EiiqujCGS0Wj0/gwwoSJ+TpRfXbXwj75F+ZjZVjbrw==","X-Received":"by 2002:a2e:9658:0:b0:2b5:68ad:291f with SMTP id\n\tz24-20020a2e9658000000b002b568ad291fmr11707867ljh.19.1689060060763; \n\tTue, 11 Jul 2023 00:21:00 -0700 (PDT)","To":"Kieran Bingham , Jai Luthra\n\t, libcamera-devel@lists.libcamera.org","In-Reply-To":"<168900354843.3585053.5973990212704360064@Monstersaurus>","References":"<20230706181447.2698499-1-j-luthra@ti.com>\n\t<87sf9vkci2.fsf@baylibre.com>\n\t<168900354843.3585053.5973990212704360064@Monstersaurus>","Date":"Tue, 11 Jul 2023 09:20:59 +0200","Message-ID":"<87v8eqncbo.fsf@baylibre.com>","MIME-Version":"1.0","Content-Type":"text/plain","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Support\n\tTI CSI-RX","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Mattijs Korpershoek via libcamera-devel\n\t","Reply-To":"Mattijs Korpershoek ","Cc":"Vaishnav Achath , Devarsh Thakkar ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]